I still see confusion around patch failures.  This should clearify things.

BUG=

Review-Url: https://codereview.chromium.org/2231953002

BUG=600945

Recipe-Tryjob-Bypass-Reason: expectation changes expected and wanted
Review-Url: https://codereview.chromium.org/2234873002

Also default to latest patchset if no other one is specified locally.

BUG=600945

Review-Url: https://codereview.chromium.org/2230883002

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/6a4b2e47ebde45f546588ed9d733969fbc0634e7 Fixes for autoroll when repo_type=GITILES is used (phajdan.jr@chromium.org)

R=phajdan.jr@chromium.org
BUG=chromium:459840

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2234713002

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/87823726a3c8ef0016780ac1b752a758f2191a55 Require internal recipe tryjob (martiniss@chromium.org)

R=martiniss@chromium.org
BUG=628801

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2229163002

BUG=628801

Review-Url: https://codereview.chromium.org/2187073004

BUG=612417

Change-Id: I695bb93afd5ccde2c34b0dfc78989248e9b923e9

When doing a 'git cl archive' if there are no branches other then master the
command will crash with a 'ValueError: Number of processes must be at least 1'
when attempting to create the thread pool.

This Cl modifies the code to use the maximum of the changes and 1 as the number
of threads to create so we have at least one thread to work with.

Review-Url: https://codereview.chromium.org/2228723003

if when execute command "git rev-parse --show-toplevel" in a directory
that is not a subdirectory of a git repo, CheckCallAndFilter will not
throw exception, so the top_dir may be updated with a invalid path.

BUG=633971
Signed-off-by: hanpfei <hanpfei@gmail.com>
Review-Url: https://codereview.chromium.org/2200193003

"gn format" changed to remove the --in-place argument. This updates the
instructions for formatting and fixes existing usage.

git cl format --diff never worked, it just printed the full formatted output
unconditionally. This change improves things slightly by indicating there's a
diff for a file. A proper diff can be hooked up in a later stage if somebody
so desires.

Review-Url: https://codereview.chromium.org/2220123002

It's now based on bot_update logic.

BUG=630601

Review-Url: https://codereview.chromium.org/2209383002

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/28882da017c8638118faba38890c54d2507fabc0 Regenerate vendored items (martiniss@chromium.org)

R=martiniss@chromium.org
BUG=

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2204373003

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/0e4cf8f18b3062e8bd3eac0c09c2bfcb094f2e24 Improve verbose logging (martiniss@chromium.org)

R=martiniss@chromium.org
BUG=

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2213833003

Parse URL in the form of:
https://domain/<number>/#ps<patchset>

Review-Url: https://codereview.chromium.org/2215433004

It might be the case for some repositories that there is no merge base
between the current git HEAD and origin/master, which causes git
merge-base to exit with a non-zero code and cause calls to gclient
status/diff/pack to fail, as well as gclient sync if the repository in
question has been removed from DEPS.

This is true for the external/webrtc/trunk/talk repository, for example.
Its recent release branches (branch-heads/45 all the way to /53 at
least) have no ancestry shared with its master branch, so gclient
sync'ing from a Chromium M51 checkout to an M52 one (where it's no
longer in DEPS) fails because of the failed git merge-base calls.

We now ignore failures and just don't specify a merge base when calling
"git diff".

BUG=633962
R=iannucci@chromium.org,agable@chromium.org,maruel@chromium.org

Review-Url: https://codereview.chromium.org/2215673002

R=agable@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2204423002

BUG=
TBR=hinoka

Review-Url: https://codereview.chromium.org/2181413004

"git retry" assumes that depot_tools is in PATH; in some cases it isn't,
and there's currently no way to add it.

BUG=

Recipe-Tryjob-Bypass-Reason: Expectations known to change
Review-Url: https://codereview.chromium.org/2192163002

the luci entry point is swarmbucket now

R=hinoka@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2196843002

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/a32538a0b1f13b77635f059d8438c8b10c3ac57a Refactor rolling, allow project filtering. (martiniss@chromium.org)
  https://crrev.com/36d9d216129000237e6c2d30e4d15db161a5b30f cq.cfg: switch to luci builders (nodir@chromium.org)

R=nodir@chromium.org,martiniss@chromium.org
BUG=629676

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2191753002

R=estaab@chromium.org
BUG=629676

Review-Url: https://codereview.chromium.org/2184253003

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/61ead7b5857f1ccb18d35403d66a43fe0d9422da expect_tests: cherry pick fca8c5f (nodir@chromium.org)

R=iannucci@chromium.org,nodir@chromium.org,martiniss@chromium.org
BUG=629676

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2190713003

If dry-run was active, git cl set-commit didn't actually trigger a
full CQ run, but was just a no-op.

TBR=machenbach@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2184643004

BUG=631575

Review-Url: https://codereview.chromium.org/2183393002

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/7f3ae3a4fae4e71019d3434f8c1aa786bccb0e06 cq.cfg: add swarming builders (nodir@chromium.org)

R=estaab@chromium.org,nodir@chromium.org,martiniss@chromium.org
BUG=629676

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2181413003

R=mmoss@chromium.org
BUG=609893

Review-Url: https://codereview.chromium.org/2188493004

This is a workaround for the fact that 'gclient revert' calls
'gclient update' with the same `options` object, despite not
actually having the same set of command line options.

R=iannucci@chromium.org, kevcheng@chromium.org
BUG=631220

Review-Url: https://codereview.chromium.org/2184493002

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/c5e569d259d3d408b4189baa912d0aebb6805302 raw_io: do not call os.path.exists on testdata (nodir@chromium.org)

R=iannucci@chromium.org,nodir@chromium.org,martiniss@chromium.org
BUG=

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2184523002

BUG=628801

Review-Url: https://codereview.chromium.org/2157503003

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/dc09456c693ea913133396141d8d2ad384254ae9 Validate previous step result before attempting to access (martiniss@chromium.org)

R=martiniss@chromium.org
BUG=

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2175393002

Instead of long stacktrace, explain what went wrong.

R=sergiyb@chromium.org,andybons@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2175343002

If an exception occurs during a try block which prevents a step from actually executing, then the finally block's attempt to access step.active_result will fail, and the original exception will be hidden behind a new exception from the recipe engine. This CL changes this behavior so that the original exception will always fire.

Review-Url: https://codereview.chromium.org/2175103002

R=estaab@chromium.org, vadimsh@chromium.org
TBR=tandrii@chromium.org
BUG=629676

Review URL: https://codereview.chromium.org/2177713002 .

add infra_swarmbucket config for infra_paths module to override
git_cache. The value of path_config property value will be specified by
kitchen.

This will still delete cache every time. The goal of this change is to
fix build.git swarmbucket builds.

TBR=dnj@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2176913002

Revert of bot_update: fix git dir check (patchset #1 id:1 of https://codereview.chromium.org/2174923002/ )

Reason for revert:
this is wrong. if directory is not empty, git clone fails

Original issue's description:
> bot_update: fix git dir check
>
> existance of a dir does not mean it is a git repo. Check .git dir
> presence instead.
>
> This is the reason why swarmbucket build.git builds fail.
>
> TBR=hinoka@chromium.org
> BUG=
>
> Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/cdac80c9fb4768bdc5bc42734e852e1f216224c9

TBR=hinoka@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review-Url: https://codereview.chromium.org/2173683003

Since different projects can have different configurations for what
the maximum value of the "Code-Review" label is in Gerrit, this teaches
presubmit_support to inspect the maximum configured value and see who
has granted it (the same behavior as the Submit button in Gerrit itself).

R=andybons@chromium.org, martiniss@chromium.org, tandrii@chromium.org
BUG=630738

Review-Url: https://codereview.chromium.org/2178673002

existance of a dir does not mean it is a git repo. Check .git dir
presence instead.

This is the reason why swarmbucket build.git builds fail.

TBR=hinoka@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2174923002

BUG=

Review-Url: https://codereview.chromium.org/2165643002

R=iannucci@chromium.org
BUG=630312

Review-Url: https://codereview.chromium.org/2170623003

BUG=630601
R=phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2173823002