- 11 May, 2018 3 commits
-
-
John Budorick authored
Bug: 842235 Change-Id: Ie1a00b19a7ebb99dbac4a86562d4eb31493c216d Reviewed-on: https://chromium-review.googlesource.com/1055683 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Michael Moss <mmoss@chromium.org> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/2ee036b744812ca2e9b30fae453ebe3e4dd83f5e api.py: Check if to_leak directory exists before deleting it (charliea@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I2e7c7ebf89bffdf0a4bdc072b9346f276dfa0ca5 Reviewed-on: https://chromium-review.googlesource.com/1054479Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
-
Edward Lemur authored
This is a reland of e877b177 Original change's description: > gclient: Get rid of parsed_url. > > There is no reason I can see to set parsed_url so late. > Also, the tests are misleading, since relative URLs don't behave the way > the tests led you to believe. > > Bug: 839925 > Change-Id: I08d92b7b7847bdc406f003d4a4139d968cc662b1 > Reviewed-on: https://chromium-review.googlesource.com/1047797 > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> > Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> TBR=agable@chromium.org Bug: 839925 Change-Id: I9200ec5fbe7289022e9754f0c78676dc931fcaeb Reviewed-on: https://chromium-review.googlesource.com/1054567 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org>
-
- 10 May, 2018 5 commits
-
-
Edward Lemur authored
It fails when both the revision and the url are None. Bug: 841936 Change-Id: Idef45a015624a92226d4ccd38ed5b978bf786993 Reviewed-on: https://chromium-review.googlesource.com/1053996 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by: Ryan Tseng <hinoka@chromium.org>
-
John Budorick authored
Suspected of breaking the world. This reverts commit e877b177. TBR=ehmaldonado@chromium.org,tandrii@chromium.org Bug: 841936 Change-Id: Iad2b55a2235d8d0b1a3d7681cbd577f795cb89dd Reviewed-on: https://chromium-review.googlesource.com/1054440Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org>
-
Edward Lemur authored
Bug: 840445 Change-Id: I9c9a13914bb2da0d07ed32f71453cbb0f30b59e0 Reviewed-on: https://chromium-review.googlesource.com/1053185 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
-
Takuto Ikuta authored
GIT_TRACE_PERFORMANCE shows invocation time of each subcommands. https://git-scm.com/book/en/v2/Git-Internals-Environment-Variables This is tested on https://ci.chromium.org/swarming/task/3d605b8aab1a5a10?server=chromium-swarm.appspot.com bot_update ran successfully. Bug: 840592 Change-Id: I65ef733d1473f9f0f7e0109b0f727595766021b6 Reviewed-on: https://chromium-review.googlesource.com/1053028 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
-
Takuto Ikuta authored
This CL is tested on https://ci.chromium.org/swarming/task/3d5fde091e610010?server=chromium-swarm.appspot.com api.py change is for auto roller Bug: 840592 Change-Id: Ib6195dc1f4539c8f02fe0696dc140b4cf0973baf Reviewed-on: https://chromium-review.googlesource.com/1049987 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
-
- 09 May, 2018 3 commits
-
-
Edward Lemur authored
This is a reland of 3806b7fb Original change's description: > bot_update: Fetch references to be synced. > > If a solution is to be synced to a reference, such as > refs/branch-heads/#### fetch it so that it can later be > checked out. > > I tried this change on a LUCI task that runs chromium_presubmit > for crrev.com/c/1048868. The bot_update works as expected: > https://ci.chromium.org/swarming/task/3d5b294cff467710?server=chromium-swarm.appspot.com > > > Bug: 840445 > > Change-Id: I6444c0feb679ca89b2f4065215de915494e5082a > Recipe-Nontrivial-Roll: infra > Recipe-Nontrivial-Roll: build > Recipe-Nontrivial-Roll: build_limited > Recipe-Nontrivial-Roll: build_limited_scripts_slave > Reviewed-on: https://chromium-review.googlesource.com/1049007 > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> > Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Bug: 840445 Recipe-Nontrivial-Roll: infra Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: build_limited_scripts_slave Change-Id: I64a97aafe5fab9a26c478262e9ca104dc59e61f5 Reviewed-on: https://chromium-review.googlesource.com/1052387 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Michael Moss <mmoss@chromium.org>
-
agrieve authored
This reverts commit 3806b7fb. Reason for revert: Broke downstream tot bots Original change's description: > bot_update: Fetch references to be synced. > > If a solution is to be synced to a reference, such as > refs/branch-heads/#### fetch it so that it can later be > checked out. > > I tried this change on a LUCI task that runs chromium_presubmit > for crrev.com/c/1048868. The bot_update works as expected: > https://ci.chromium.org/swarming/task/3d5b294cff467710?server=chromium-swarm.appspot.com > > > Bug: 840445 > > Change-Id: I6444c0feb679ca89b2f4065215de915494e5082a > Recipe-Nontrivial-Roll: infra > Recipe-Nontrivial-Roll: build > Recipe-Nontrivial-Roll: build_limited > Recipe-Nontrivial-Roll: build_limited_scripts_slave > Reviewed-on: https://chromium-review.googlesource.com/1049007 > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> > Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> TBR=mmoss@chromium.org,machenbach@chromium.org,tandrii@chromium.org,ehmaldonado@chromium.org Change-Id: If94df8684e634504d8a0c11b2aa5862a458ba19f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 840445, 841306 Reviewed-on: https://chromium-review.googlesource.com/1052187Reviewed-by: agrieve <agrieve@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org>
-
Edward Lemur authored
If a solution is to be synced to a reference, such as refs/branch-heads/#### fetch it so that it can later be checked out. I tried this change on a LUCI task that runs chromium_presubmit for crrev.com/c/1048868. The bot_update works as expected: https://ci.chromium.org/swarming/task/3d5b294cff467710?server=chromium-swarm.appspot.com Bug: 840445 Change-Id: I6444c0feb679ca89b2f4065215de915494e5082a Recipe-Nontrivial-Roll: infra Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: build_limited Recipe-Nontrivial-Roll: build_limited_scripts_slave Reviewed-on: https://chromium-review.googlesource.com/1049007 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
-
- 07 May, 2018 1 commit
-
-
Andrii Shyshkalov authored
R=jchinlee@chromium.org Bug: 811681 Change-Id: Ic09fe7c90690a26f35e71f6313d17097de7553e9 Reviewed-on: https://chromium-review.googlesource.com/1044661 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>
-
- 05 May, 2018 1 commit
-
-
Andrii Shyshkalov authored
Motivation: see https://crbug.com/822437#c6 tl;dr apparently, auotpacking still happens, this CL tries to stop prevent it harder than before. R=vadimsh@chromium.org Bug: 822437 Change-Id: Idda384bdebd96c10ac79c48b0622f84550060362 Reviewed-on: https://chromium-review.googlesource.com/1045491Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
- 04 May, 2018 1 commit
-
-
Edward Lemur authored
Otherwise, the origin URLs for the checkout and the patch won't match and applying the patch on gclient will fail. Bug: 643346 Change-Id: If005bb10e579b3d50f9b6d0ff39440bb9a300cbd Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: build_limited Recipe-Nontrivial-Roll: build_limited_scripts_slave Reviewed-on: https://chromium-review.googlesource.com/1043254 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by: Aaron Gable <agable@chromium.org>
-
- 03 May, 2018 3 commits
-
-
Michael Moss authored
Previously, 'gclient sync' would process "gn_args" settings in any recursed DEPS files, potentially producing multiple output files or conflicting output files, but 'gclient flatten' would only ever include one set of "gn_args" settings in the flattened output, and only if they occurred in the top-level DEPS file. This makes 'gclient sync' and 'gclient flatten' more consistent by restricting them both to a single instance of those setting, and requiring those setting to be defined either in the top-level DEPS file, or in a recursedeps file specificed by the new 'gclient_gn_args_from' setting. R=dpranke@google.com, ehmaldonado@google.com Bug: 825063 Change-Id: If90d952e47367c50b36daade16a26b29aec0c9db Reviewed-on: https://chromium-review.googlesource.com/1039870Reviewed-by: Michael Moss <mmoss@chromium.org> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Michael Moss <mmoss@chromium.org>
-
Stephen Martinis authored
This reverts commit 8f20428b. Reason for revert: Probably broke bot update on catapult bots: https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Linux%20Tryserver/builds/11225 Original change's description: > Reland "bot_update: Patch on gclient by default." > > This is a reland of e38cf570 > > The issue with win CQ bots was fixed in https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1036309 > It was due to misconfigured git user.{name,email} > > Original change's description: > > bot_update: Patch on gclient by default. > > > > See [4] for the design doc for this change. > > > > We're moving the patching logic from bot_update to gclient. > > This way we can test patches of dependencies that modify their DEPS > > files as well, for example when ANGLE uploads a patch that modifies > > DEPS files to be tested by a Chromium trybot. > > > > Chromium Linux CQ and Angle trybots are already running this way > > (see [1] and [2]) and a PSA has already been sent [3] > > > > [1] https://chromium.googlesource.com/chromium/src/+/master/infra/config/global/cr-buildbucket.cfg#214 > > [2] https://chromium.googlesource.com/angle/angle/+/infra/config/cr-buildbucket.cfg#105 > > [3] https://groups.google.com/a/google.com/forum/#!topic/chrome-infra/FVHN2kdUX4I > > [4] https://docs.google.com/document/d/1GSTw4ysm5AYjNR6vMA7NJUxLK2VN9IpOEp_v0u-wyOE/edit?ts=5ad78165# > > > > Bug: 643346 > > Change-Id: Ic9a9dcfae86aca730d35fbb26c26b21135e05bf3 > > Recipe-Nontrivial-Roll: skia > > Recipe-Nontrivial-Roll: infra > > Recipe-Nontrivial-Roll: build_limited_scripts_slave > > Recipe-Nontrivial-Roll: skiabuildbot > > Recipe-Nontrivial-Roll: build > > Recipe-Nontrivial-Roll: release_scripts > > Reviewed-on: https://chromium-review.googlesource.com/1014356 > > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> > > Reviewed-by: Aaron Gable <agable@chromium.org> > > Bug: 643346 > Change-Id: I4f4edd8e815cb12a4cbc3ab690eaf588bc2accc1 > Reviewed-on: https://chromium-review.googlesource.com/1039966 > Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> TBR=agable@chromium.org,tandrii@chromium.org,ehmaldonado@chromium.org Change-Id: Ia8a5779cde3c31812121cffdd806476d4536f35e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 643346 Reviewed-on: https://chromium-review.googlesource.com/1043167Reviewed-by: Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org>
-
Edward Lesmes authored
This is a reland of e38cf570 The issue with win CQ bots was fixed in https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1036309 It was due to misconfigured git user.{name,email} Original change's description: > bot_update: Patch on gclient by default. > > See [4] for the design doc for this change. > > We're moving the patching logic from bot_update to gclient. > This way we can test patches of dependencies that modify their DEPS > files as well, for example when ANGLE uploads a patch that modifies > DEPS files to be tested by a Chromium trybot. > > Chromium Linux CQ and Angle trybots are already running this way > (see [1] and [2]) and a PSA has already been sent [3] > > [1] https://chromium.googlesource.com/chromium/src/+/master/infra/config/global/cr-buildbucket.cfg#214 > [2] https://chromium.googlesource.com/angle/angle/+/infra/config/cr-buildbucket.cfg#105 > [3] https://groups.google.com/a/google.com/forum/#!topic/chrome-infra/FVHN2kdUX4I > [4] https://docs.google.com/document/d/1GSTw4ysm5AYjNR6vMA7NJUxLK2VN9IpOEp_v0u-wyOE/edit?ts=5ad78165# > > Bug: 643346 > Change-Id: Ic9a9dcfae86aca730d35fbb26c26b21135e05bf3 > Recipe-Nontrivial-Roll: skia > Recipe-Nontrivial-Roll: infra > Recipe-Nontrivial-Roll: build_limited_scripts_slave > Recipe-Nontrivial-Roll: skiabuildbot > Recipe-Nontrivial-Roll: build > Recipe-Nontrivial-Roll: release_scripts > Reviewed-on: https://chromium-review.googlesource.com/1014356 > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> > Reviewed-by: Aaron Gable <agable@chromium.org> Bug: 643346 Change-Id: I4f4edd8e815cb12a4cbc3ab690eaf588bc2accc1 Reviewed-on: https://chromium-review.googlesource.com/1039966Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
- 02 May, 2018 1 commit
-
-
Edward Lemur authored
This is a reland of e86fe982 Original change's description: > bot_update: Set user.{name,email} when applying patch refs. > > git rebase complains when user name/email has not been configured, as was > the case for the Chromium trybot. > > Bug: 643346 > Change-Id: Iab7dac0a98608e09b63a53d5bacb98925701fbfd > Reviewed-on: https://chromium-review.googlesource.com/1031524 > Reviewed-by: Aaron Gable <agable@chromium.org> > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Bug: 643346 Change-Id: I4b4d07675222d39d704560ed84f9c221e87aba8b Reviewed-on: https://chromium-review.googlesource.com/1036309Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
- 01 May, 2018 1 commit
-
-
Michael Moss authored
This is needed for release builders to checkout the release tags that will be created when the buildspec branch/release info is migrated out to the regular repos. BUG=825063 R=jbudorick@google.com Change-Id: I5f0e4cdd94de11c59f9b4a5c11aabea129e81523 Reviewed-on: https://chromium-review.googlesource.com/1036526Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Michael Moss <mmoss@chromium.org>
-
- 30 Apr, 2018 3 commits
-
-
Stephen Martinis authored
This reverts commit e86fe982. Reason for revert: Probably causing outages on win7_chromium_rel_ng. Original change's description: > bot_update: Set user.{name,email} when applying patch refs. > > git rebase complains when user name/email has not been configured, as was > the case for the Chromium trybot. > > Bug: 643346 > Change-Id: Iab7dac0a98608e09b63a53d5bacb98925701fbfd > Reviewed-on: https://chromium-review.googlesource.com/1031524 > Reviewed-by: Aaron Gable <agable@chromium.org> > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> TBR=agable@chromium.org,ehmaldonado@chromium.org Change-Id: Ic57398323476fccef34f766270d760c3975630a6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 643346 Reviewed-on: https://chromium-review.googlesource.com/1036308Reviewed-by: Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org>
-
Edward Lesmes authored
git rebase complains when user name/email has not been configured, as was the case for the Chromium trybot. Bug: 643346 Change-Id: Iab7dac0a98608e09b63a53d5bacb98925701fbfd Reviewed-on: https://chromium-review.googlesource.com/1031524Reviewed-by: Aaron Gable <agable@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Andrii Shyshkalov authored
Previously, anything not equal to HEAD meant pinned revision. This backfired on values like "origin/master" which are meant as equivalent to HEAD, but which bot_update tried to ensure exist in checkout, which was refreshed several times under assumption that this is eventual consistency of git servers. Instead, this CL treats repo as pinned if and only if the treeish of the repo is matching sha1 regex. R=hinoka@chromium.org Bug: 838292 Change-Id: I9cb46535f46b2898cf54900ede7960ba08770d77 Post-Scriptum: git bisect + Led is awesome, took only 8 manual steps. Reviewed-on: https://chromium-review.googlesource.com/1035793Reviewed-by: Ryan Tseng <hinoka@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
- 27 Apr, 2018 2 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/c17eef1bc11c5f44462101e8ceaa0f76c9e872bf file: method for creating temporary files (phosek@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I57510027cd29def52eb094fa2b39f1c98ebf7b35 Reviewed-on: https://chromium-review.googlesource.com/1033425Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/8bb8a8eddc83b7110083f1fef2aaafaf7bd25d90 Handle long paths on Windows part 2 (martiniss@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I87be481519bf3e4cd5d36429e528767c50cece7f Reviewed-on: https://chromium-review.googlesource.com/1033417Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
-
- 26 Apr, 2018 8 commits
-
-
Edward Lesmes authored
So we know why did git fail on the Chromium Windows trybots. R=agable@chromium.org Bug: 643346 Change-Id: Iac0abd9202fb56fbed6f3edf382b755e96fed3bf Reviewed-on: https://chromium-review.googlesource.com/1031128Reviewed-by: Aaron Gable <agable@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Ben Pastene authored
This reverts commit e38cf570. Reason for revert: likely broke bot_update on win CQ bots: https://ci.chromium.org/buildbot/tryserver.chromium.win/win7_chromium_rel_ng/154654 https://bugs.chromium.org/p/chromium/issues/detail?id=837321 Original change's description: > Reland "bot_update: Patch on gclient by default." > > This is a reland of 355b11a3 > > Original change's description: > > bot_update: Patch on gclient by default. > > > > See [4] for the design doc for this change. > > > > We're moving the patching logic from bot_update to gclient. > > This way we can test patches of dependencies that modify their DEPS > > files as well, for example when ANGLE uploads a patch that modifies > > DEPS files to be tested by a Chromium trybot. > > > > Chromium Linux CQ and Angle trybots are already running this way > > (see [1] and [2]) and a PSA has already been sent [3] > > > > [1] https://chromium.googlesource.com/chromium/src/+/master/infra/config/global/cr-buildbucket.cfg#214 > > [2] https://chromium.googlesource.com/angle/angle/+/infra/config/cr-buildbucket.cfg#105 > > [3] https://groups.google.com/a/google.com/forum/#!topic/chrome-infra/FVHN2kdUX4I > > [4] https://docs.google.com/document/d/1GSTw4ysm5AYjNR6vMA7NJUxLK2VN9IpOEp_v0u-wyOE/edit?ts=5ad78165# > > > > Bug: 643346 > > Change-Id: Ic9a9dcfae86aca730d35fbb26c26b21135e05bf3 > > Recipe-Nontrivial-Roll: skia > > Recipe-Nontrivial-Roll: infra > > Recipe-Nontrivial-Roll: build_limited_scripts_slave > > Recipe-Nontrivial-Roll: skiabuildbot > > Recipe-Nontrivial-Roll: build > > Recipe-Nontrivial-Roll: release_scripts > > Reviewed-on: https://chromium-review.googlesource.com/1014356 > > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> > > Reviewed-by: Aaron Gable <agable@chromium.org> > > Bug: 643346 > Change-Id: I2da17456f24d1e9fcc3f48f9242b4db05cadbf6d > Reviewed-on: https://chromium-review.googlesource.com/1029073 > Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> TBR=agable@chromium.org,tandrii@chromium.org,ehmaldonado@chromium.org Change-Id: I33e4bf7b5f416f6356dbd0b50a276cd36dd4e9b3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 643346 Reviewed-on: https://chromium-review.googlesource.com/1030718Reviewed-by: Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org>
-
Edward Lesmes authored
Accept cases when the origin in --patch-ref ends in .git but the URL in .gclient or DEPS doesn't. R=agable@chromium.org Bug: 643346 Change-Id: I25e6fd8400b09c7e249578cfbd7e9485bab9ea85 Reviewed-on: https://chromium-review.googlesource.com/1030893 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by: Aaron Gable <agable@chromium.org>
-
Edward Lesmes authored
This is a reland of 355b11a3 Original change's description: > bot_update: Patch on gclient by default. > > See [4] for the design doc for this change. > > We're moving the patching logic from bot_update to gclient. > This way we can test patches of dependencies that modify their DEPS > files as well, for example when ANGLE uploads a patch that modifies > DEPS files to be tested by a Chromium trybot. > > Chromium Linux CQ and Angle trybots are already running this way > (see [1] and [2]) and a PSA has already been sent [3] > > [1] https://chromium.googlesource.com/chromium/src/+/master/infra/config/global/cr-buildbucket.cfg#214 > [2] https://chromium.googlesource.com/angle/angle/+/infra/config/cr-buildbucket.cfg#105 > [3] https://groups.google.com/a/google.com/forum/#!topic/chrome-infra/FVHN2kdUX4I > [4] https://docs.google.com/document/d/1GSTw4ysm5AYjNR6vMA7NJUxLK2VN9IpOEp_v0u-wyOE/edit?ts=5ad78165# > > Bug: 643346 > Change-Id: Ic9a9dcfae86aca730d35fbb26c26b21135e05bf3 > Recipe-Nontrivial-Roll: skia > Recipe-Nontrivial-Roll: infra > Recipe-Nontrivial-Roll: build_limited_scripts_slave > Recipe-Nontrivial-Roll: skiabuildbot > Recipe-Nontrivial-Roll: build > Recipe-Nontrivial-Roll: release_scripts > Reviewed-on: https://chromium-review.googlesource.com/1014356 > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> > Reviewed-by: Aaron Gable <agable@chromium.org> Bug: 643346 Change-Id: I2da17456f24d1e9fcc3f48f9242b4db05cadbf6d Reviewed-on: https://chromium-review.googlesource.com/1029073Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Andrii Shyshkalov authored
It doesn't change after change is created. R=jchinlee@chromium.org Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: infra Recipe-Nontrivial-Roll: build_limited_scripts_slave Change-Id: I4c4758085f6cfa7c2ef5267c6c71c9b324263f95 Reviewed-on: https://chromium-review.googlesource.com/1029227 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/c93ee0e7a9941356e1a7489af1abc2dca43f2c97 Add OWNERS to LUCI recipe modules. (tandrii@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ia24c51fe6c80a2582bb2a7c9765117e365b6ca16 Reviewed-on: https://chromium-review.googlesource.com/1029672 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/0a82af179bce717e9be1240286497312309487d0 service_account: remove ability to vary lifetime and set it to 180s. (tandrii@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ie83d17b1b0ac1a689d2c59046736f28dc2f41535 Reviewed-on: https://chromium-review.googlesource.com/1029734 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
-
Edward Lesmes authored
This reverts commit 355b11a3. Reason for revert: Easier to do this another way that doesn't cause expectation changes, so it doesn't require non-trivial rolls. Original change's description: > bot_update: Patch on gclient by default. > > See [4] for the design doc for this change. > > We're moving the patching logic from bot_update to gclient. > This way we can test patches of dependencies that modify their DEPS > files as well, for example when ANGLE uploads a patch that modifies > DEPS files to be tested by a Chromium trybot. > > Chromium Linux CQ and Angle trybots are already running this way > (see [1] and [2]) and a PSA has already been sent [3] > > [1] https://chromium.googlesource.com/chromium/src/+/master/infra/config/global/cr-buildbucket.cfg#214 > [2] https://chromium.googlesource.com/angle/angle/+/infra/config/cr-buildbucket.cfg#105 > [3] https://groups.google.com/a/google.com/forum/#!topic/chrome-infra/FVHN2kdUX4I > [4] https://docs.google.com/document/d/1GSTw4ysm5AYjNR6vMA7NJUxLK2VN9IpOEp_v0u-wyOE/edit?ts=5ad78165# > > Bug: 643346 > Change-Id: Ic9a9dcfae86aca730d35fbb26c26b21135e05bf3 > Recipe-Nontrivial-Roll: skia > Recipe-Nontrivial-Roll: infra > Recipe-Nontrivial-Roll: build_limited_scripts_slave > Recipe-Nontrivial-Roll: skiabuildbot > Recipe-Nontrivial-Roll: build > Recipe-Nontrivial-Roll: release_scripts > Reviewed-on: https://chromium-review.googlesource.com/1014356 > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> > Reviewed-by: Aaron Gable <agable@chromium.org> TBR=agable@chromium.org,ehmaldonado@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 643346 Change-Id: I0e694b0e398770b8bd2e5a3170e158a7e54c5a61 Reviewed-on: https://chromium-review.googlesource.com/1029310Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
- 25 Apr, 2018 1 commit
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/e315ab3c7742e21b293911eb61e0c0a2e877acab cq: switch to 100% LUCI. (tandrii@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I571d840178dfd2e9b737abaf59b01648c1062fac Reviewed-on: https://chromium-review.googlesource.com/1027150 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
-
- 24 Apr, 2018 2 commits
-
-
Edward Lesmes authored
See [4] for the design doc for this change. We're moving the patching logic from bot_update to gclient. This way we can test patches of dependencies that modify their DEPS files as well, for example when ANGLE uploads a patch that modifies DEPS files to be tested by a Chromium trybot. Chromium Linux CQ and Angle trybots are already running this way (see [1] and [2]) and a PSA has already been sent [3] [1] https://chromium.googlesource.com/chromium/src/+/master/infra/config/global/cr-buildbucket.cfg#214 [2] https://chromium.googlesource.com/angle/angle/+/infra/config/cr-buildbucket.cfg#105 [3] https://groups.google.com/a/google.com/forum/#!topic/chrome-infra/FVHN2kdUX4I [4] https://docs.google.com/document/d/1GSTw4ysm5AYjNR6vMA7NJUxLK2VN9IpOEp_v0u-wyOE/edit?ts=5ad78165# Bug: 643346 Change-Id: Ic9a9dcfae86aca730d35fbb26c26b21135e05bf3 Recipe-Nontrivial-Roll: skia Recipe-Nontrivial-Roll: infra Recipe-Nontrivial-Roll: build_limited_scripts_slave Recipe-Nontrivial-Roll: skiabuildbot Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: release_scripts Reviewed-on: https://chromium-review.googlesource.com/1014356 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by: Aaron Gable <agable@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/480046798daeca78c14e4514b25da0c50cf2b680 cq: start using LUCI downstream recipe rollers as an experiment. (tandrii@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I565f90c1e6b79ab11710b5dd5a5fe2e75b1f0e5f Reviewed-on: https://chromium-review.googlesource.com/1024815 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
-
- 20 Apr, 2018 1 commit
-
-
https://crrev.com/c/1018488/13/auth.py#514Andrii Shyshkalov authored
TBR=vadimsh@google.com Change-Id: I96c4039d12ba3570d828b24009a2446fba44c14d Reviewed-on: https://chromium-review.googlesource.com/1020539 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
-
- 19 Apr, 2018 1 commit
-
-
Andrii Shyshkalov authored
Unfortunately, w/o rewrite of gerrit_util, one can't take advantage of existing auth.Authenticator (which also doesn't know about ~/.netrc or .gitcookies, but that's fixable). This rewrite, however, will likely cause issues for nasty scripts outside of depot_tools which use gerrit_util as a Python library. So, I followed outdated way of gerrit_util :( Also contains refactoring of auth library, which was kept backwards compatible for the same reasons as above. R=vadimsh@chromium.org Test-with: led tool Test-artifact: https://ci.chromium.org/swarming/task/3cf4687dfd26ca10?server=chromium-swarm.appspot.com Bug: 834536 Change-Id: I6b84b8b5732aee5d345e2b2ba44f47aaecc0f6c5 Reviewed-on: https://chromium-review.googlesource.com/1018488Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
- 18 Apr, 2018 1 commit
-
-
John Budorick authored
Bug: 830306 Change-Id: Id87a6f2053c7e3cd489647d1cbbc8a83f2e585db Reviewed-on: https://chromium-review.googlesource.com/1003326Reviewed-by: Aaron Gable <agable@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org>
-
- 13 Apr, 2018 2 commits
-
-
Edward Lesmes authored
It is used by CMDland but it was not declared and is causing failures. TBR=agable@chromium.org Bug: 832566 Change-Id: Ia8ba5df458f9a39e415b7a9495dc338def0b16a5 Reviewed-on: https://chromium-review.googlesource.com/1013056 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by: Michael Moss <mmoss@chromium.org>
-
Michael Moss authored
TBR=agable@google.com Change-Id: I680ab9441acffc91fae7500eb369e85d989f7443 Reviewed-on: https://chromium-review.googlesource.com/1012929Reviewed-by: Michael Moss <mmoss@chromium.org> Commit-Queue: Michael Moss <mmoss@chromium.org>
-