- 28 May, 2010 3 commits
-
-
nasser@codeaurora.org authored
Review URL: http://codereview.chromium.org/2380001 Change-Id: Icfef43fe507be04b8c178440834d26b9ac3ced77 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@48489 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
BUG=chromium-os:2308 Review URL: http://codereview.chromium.org/2337003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@48488 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
Add an explicit Register() function to be called outside of this file. Send the host fqdn to help know from where the exception comes. It is useful when a build slave throws an exception. Review URL: http://codereview.chromium.org/2327003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@48455 0039d316-1c4b-4281-b951-d872f2087c98
-
- 27 May, 2010 4 commits
-
-
maruel@chromium.org authored
TBR=jam Review URL: http://codereview.chromium.org/2342001 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@48449 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
Otherwise it would return the naked host name most of the time, especially on Windows. Review URL: http://codereview.chromium.org/2239010 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@48432 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
TBR=siggi Review URL: http://codereview.chromium.org/2287005 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@48396 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
Automatically generate help and enforce stricter argument parsing. Stops from throwing an exception when run outside a subversion checkout. Fixed gcl lint. Review URL: http://codereview.chromium.org/2301003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@48386 0039d316-1c4b-4281-b951-d872f2087c98
-
- 26 May, 2010 10 commits
-
-
maruel@chromium.org authored
This may not make sense in practice but is necessary for testing. Add regression test. TBR=msb TEST=smoke test BUG=23328 Review URL: http://codereview.chromium.org/2238004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@48317 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
I'll add a smoke test after. TBR=msb TEST=to be written later BUG=none Review URL: http://codereview.chromium.org/2240005 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@48314 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
BUG=23328 Review URL: http://codereview.chromium.org/2285003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@48311 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
""" Enable automatic command and one-liner doc. Reformat pydoc accordingly. Add parser as an argument and parse_args hook in preparation to move parse_args at the right place, inside the CMDxx functions. R.I.P. gclient_test.py """ original code review at: http://codereview.chromium.org/2253002 In addition: - Add more smoke tests: vars, hooks, runhooks - Bugs filed about misbehavior with git checkout - Fixed gclient runhooks TEST=smoke test BUG=23328 Review URL: http://codereview.chromium.org/2265002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@48309 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
Still broken. Review URL: http://codereview.chromium.org/2285002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@48290 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
""" Enable automatic command and one-liner doc. Reformat pydoc accordingly. Add parser as an argument and parse_args hook in preparation to move parse_args at the right place, inside the CMDxx functions. R.I.P. gclient_test.py """ original code review at: http://codereview.chromium.org/2253002 In addition: - Add more smoke tests: vars, hooks, runhooks - Bugs filed about misbehavior with git checkout - Fixed gclient runhooks TEST=smoke test BUG=23328 Review URL: http://codereview.chromium.org/2265002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@48289 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@48272 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
Add parser as an argument and parse_args hook in preparation to move parse_args at the right place, inside the CMDxx functions. R.I.P. gclient_test.py Review URL: http://codereview.chromium.org/2253002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@48271 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
gclient sync, revert and status are tested. GClientSmokeGIT.testRevertAndStatus is known to fail since git-backed revert doesn't work. Review URL: http://codereview.chromium.org/2189001 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@48239 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
TBR=jam Review URL: http://codereview.chromium.org/2252001 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@48235 0039d316-1c4b-4281-b951-d872f2087c98
-
- 25 May, 2010 1 commit
-
-
maruel@chromium.org authored
Review URL: http://codereview.chromium.org/2198001 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@48225 0039d316-1c4b-4281-b951-d872f2087c98
-
- 22 May, 2010 1 commit
-
-
scherkus@chromium.org authored
Turns out svn treats extra whitespace as part of the revision number and throws an exception. BUG=44790 TEST=insert some spaces in your revision arguments, gclient should still work Review URL: http://codereview.chromium.org/2077017 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@47979 0039d316-1c4b-4281-b951-d872f2087c98
-
- 19 May, 2010 2 commits
-
-
maruel@chromium.org authored
Review URL: http://codereview.chromium.org/2087015 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@47678 0039d316-1c4b-4281-b951-d872f2087c98
-
evan@chromium.org authored
configured for it when figuring out the patch to upload to the try server. This prevents git installations where the diff is configured to use an interactive tool to work without doing nasty workarounds. BUG=none TEST=none Review URL: http://codereview.chromium.org/1958002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@47661 0039d316-1c4b-4281-b951-d872f2087c98
-
- 18 May, 2010 1 commit
-
-
maruel@chromium.org authored
The unit tests are unbearable and the next change forces me to trash them. Thus adding smoke tests before. The current tests aren't involved enough yet but are a good base for further testing. I plan to only test the most important functionalities, the ones used in the continuous build and try server. TEST=new smoke test BUG=23328 Review URL: http://codereview.chromium.org/2092012 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@47580 0039d316-1c4b-4281-b951-d872f2087c98
-
- 17 May, 2010 8 commits
-
-
maruel@chromium.org authored
Review URL: http://codereview.chromium.org/2078011 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@47456 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
Enable automatic command and one-liner doc. Reformat pydoc accordingly. Add parser as an argument and parse_args hook in preparation to move parse_args at the right place, inside the CMDxx functions. Update unit tests Review URL: http://codereview.chromium.org/2129005 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@47449 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@47437 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@47436 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@47435 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@47434 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
Review URL: http://codereview.chromium.org/2102004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@47426 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
Review URL: http://codereview.chromium.org/2098009 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@47391 0039d316-1c4b-4281-b951-d872f2087c98
-
- 16 May, 2010 1 commit
-
-
maruel@chromium.org authored
Less text = better readability. Review URL: http://codereview.chromium.org/2125005 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@47389 0039d316-1c4b-4281-b951-d872f2087c98
-
- 15 May, 2010 1 commit
-
-
maruel@chromium.org authored
TBR Review URL: http://codereview.chromium.org/2077003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@47373 0039d316-1c4b-4281-b951-d872f2087c98
-
- 14 May, 2010 2 commits
-
-
maruel@chromium.org authored
The next step will be to generate help automatically and remove the command check loop. TEST=not much BUG=me Review URL: http://codereview.chromium.org/2096003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@47291 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
Make the documentation more manageable and use automatic function discovery. Review URL: http://codereview.chromium.org/2129003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@47290 0039d316-1c4b-4281-b951-d872f2087c98
-
- 13 May, 2010 1 commit
-
-
maruel@chromium.org authored
Add exception information and not just the stack trace. Make the url easier to change at runtime. Review URL: http://codereview.chromium.org/2109001 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@47179 0039d316-1c4b-4281-b951-d872f2087c98
-
- 12 May, 2010 2 commits
-
-
maruel@chromium.org authored
The code proved to be robust enough to not do false positive, i.e. no non-googler stack trace has been uploaded up to date. So stop wasting users time and just do it. BUG=none TEST=none Review URL: http://codereview.chromium.org/2014012 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@46992 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
TEST=chmod a-w .svn/gcl_info/cache/codereview.settings and see if an exception is thrown when the file is recent Review URL: http://codereview.chromium.org/2057006 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@46990 0039d316-1c4b-4281-b951-d872f2087c98
-
- 11 May, 2010 3 commits
-
-
maruel@chromium.org authored
TEST=should stop throwing an exception when retrying for git checkouts BUG=none Review URL: http://codereview.chromium.org/2002015 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@46960 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
Review URL: http://codereview.chromium.org/2027008 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@46948 0039d316-1c4b-4281-b951-d872f2087c98
-
jochen@chromium.org authored
Review URL: http://codereview.chromium.org/1993008 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@46923 0039d316-1c4b-4281-b951-d872f2087c98
-