- 29 May, 2018 1 commit
-
-
Aaron Gable authored
This is for security updates related to CVE 2018-11235 CVE 2018-11234 https://public-inbox.org/git/xmqqy3g2flb6.fsf@gitster-ct.c.googlers.com/ Bug: 847597 Change-Id: I3b2d6b7bf9fe2d93bdc375903357f07f4fff8573 Reviewed-on: https://chromium-review.googlesource.com/1077307Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org>
-
- 25 May, 2018 2 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/10f67fe223a7973a95bc5fff219d1a7a3d95a326 [recipe_modules] Create Tricium module (juliehockett@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I8037b9c0bed59dc082de43fc3824ce6bb6842a1c Reviewed-on: https://chromium-review.googlesource.com/1073197Reviewed-by:
Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/c51413ab9d4c5ed5c3db8117b80afe64e54016b4 [recipe_api] Add content type for source manifests (mknyszek@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I019b19c164ccf0507d6864d08fa6ed5887f34930 Reviewed-on: https://chromium-review.googlesource.com/1072326Reviewed-by:
-
- 24 May, 2018 8 commits
-
-
Aaron Gable authored
This library is no longer used by anything in depot_tools. Bug: 770408 Change-Id: I8f0a99f73cf9c52731994c830085678ca652d2c4 Reviewed-on: https://chromium-review.googlesource.com/1072491Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/611cfbdc328b50144e2790ed1e4b9db24adb9eea [raw_io] Make it succeed even with read only files. (maruel@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I706661a48211e87e395d5cf148a4a02ba3ead613 Reviewed-on: https://chromium-review.googlesource.com/1072549Reviewed-by:
-
Aaron Gable authored
This script only works (worked) for Rietveld issues, which effectively no longer exist. It serves no purpose anymore. Bug: 770408 Change-Id: Ic93ab3ce90d9c35b3bf5189e2beb4aa0c3983d44 Reviewed-on: https://chromium-review.googlesource.com/1070859Reviewed-by:
-
Aaron Gable authored
This simplifies future removals of unnecessary code from git-cl. Bug: 770408 Change-Id: I20329fb6d93b349bf2e9f4aebc795b3f7ef0b646 Reviewed-on: https://chromium-review.googlesource.com/1070588 Commit-Queue: Aaron Gable <agable@chromium.org> Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org>
-
Justin Cohen authored
Relevant changes: [mac_toolchain] Always call runFirstLaunch for Xcode 9+. Bug: 841910 TBR=iannucci@chromium.org Change-Id: I3f4b8fb793e66315492f8e53832e0ac9d00ceb0c Reviewed-on: https://chromium-review.googlesource.com/1072007 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Sergey Berezin <sergeyberezin@chromium.org>
-
Aaron Gable authored
The command itself was removed in https://chromium-review.googlesource.com/693339 Bug: 770408 Change-Id: Ie3006b75313715c395357efa6ffc67348e192c5c Reviewed-on: https://chromium-review.googlesource.com/1070757Reviewed-by:
-
Michael Moss authored
Reason for revert: This is breaking official release scripts, which have long used "None" URL functionality to allow gclient commands to run against "local" DEPS (buildspec) files. Please do not remove this behavior. This reverts the following commits: ebdd0db4: "gclient: Remove URLs from hierarchy." 54a5c2ba: "gclient: Refactor PrintRevInfo" 083eb25f: "gclient: Don't allow URL to be None." BUG=846194 TBR=agable@chromium.org,ehmaldonado@chromium.org Change-Id: Ibdd5581889bd4afd86474199c7b64555f01bbbca Reviewed-on: https://chromium-review.googlesource.com/1070893 Commit-Queue: Michael Moss <mmoss@chromium.org> Reviewed-by:
Michael Moss <mmoss@chromium.org>
-
Andrew Grieve authored
Allows easily getting at more than just the commit message. I intend to look at the author to whitelist bots from binary size checks (initially). Bug: 702625 Change-Id: I684fdfacc88635ec4849216c74183f63f9d54810 Reviewed-on: https://chromium-review.googlesource.com/1070483 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
-
- 22 May, 2018 4 commits
-
-
Edward Lemur authored
Bug: 839925 Change-Id: I66d0bd074433288e780e1bdde9ebfce4fa85db0f Reviewed-on: https://chromium-review.googlesource.com/1067496Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Edward Lemur authored
Bug: 839925 Change-Id: I9d1b2572676a7d61862382f6882622521d28ef97 Reviewed-on: https://chromium-review.googlesource.com/1068250Reviewed-by:
-
Ryan Harrison authored
https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1058722 changed the behaviour of reporting access errors to no longer interleave them throughout the output, but instead batch them together. This CL had the side effect of changing the way the errors are printed from using logging.error to print. This means that the errors are now printing to stdout instead of stderr. This is causing personal scripts I have for generating reports to fail, since they filtered out stderr. Change-Id: I664f6166c55f8d20d3c35b63eda695335ab7f8a6 Reviewed-on: https://chromium-review.googlesource.com/1069213 Commit-Queue: Ryan Harrison <rharrison@chromium.org> Reviewed-by:
-
Edward Lemur authored
Bug: 829134 Change-Id: Ifa4dc5572a17c9f2a3ab4bb04765106b1563ecae Reviewed-on: https://chromium-review.googlesource.com/1065081Reviewed-by:
-
- 18 May, 2018 1 commit
-
-
Edward Lemur authored
Bug: 839925 Change-Id: I5a559db846ac19e3c61e77f3019c7d5362beccba Reviewed-on: https://chromium-review.googlesource.com/1063029Reviewed-by:
-
- 17 May, 2018 4 commits
-
-
Edward Lemur authored
Bug: 839925 Change-Id: I5cb6655309d6aa8dada7e6bd245d859593fb055f Reviewed-on: https://chromium-review.googlesource.com/1064809 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
-
Edward Lemur authored
Bug: 839925 Change-Id: I5a56ad03866bd0b8f7d43bb3a643372d7b66343c Reviewed-on: https://chromium-review.googlesource.com/1064692Reviewed-by:
-
Edward Lemur authored
Bug: 843917, 839925 Change-Id: I84e52c95fc91d67375d4d954018f057561896914 Reviewed-on: https://chromium-review.googlesource.com/1064005Reviewed-by:
-
Edward Lemur authored
Custom deps not present in DEPS files cause errors when syncing, since we add them as strings in postprocess_deps, but deps_to_objects expects a dictionary. TBR=agable@chromium.org Bug: 839925 Change-Id: Ic08a83e8692f1bf90d4456c72fe99493363ba747 Reviewed-on: https://chromium-review.googlesource.com/1063326 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org>
-
- 16 May, 2018 3 commits
-
-
Edward Lemur authored
It not used anywhere. Bug: 839925 Change-Id: Iad07b548744f2c58d34427f3e2225d8c75926eea Reviewed-on: https://chromium-review.googlesource.com/1060632 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
-
Edward Lemur authored
This is done in gclient_eval, so we can remove all code that deals with deps_os and hooks_os from gclient. Bug: 839925 Change-Id: I491819207a712d62008ff010e313add87d22c937 Reviewed-on: https://chromium-review.googlesource.com/1058375 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
-
Edward Lesmes authored
This is a reland of e38cf570 Sinc the last reland catapult, custom-tab-client and syzygy had their origins updated to the source of truth: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1043254 https://chromium-review.googlesource.com/c/chromium/tools/build/+/1043355 This fixes the last problem we had, where the origin in gclient was different from the source of truth, and so the patch couldn't be applied. Original change's description: > bot_update: Patch on gclient by default. > > See [4] for the design doc for this change. > > We're moving the patching logic from bot_update to gclient. > This way we can test patches of dependencies that modify their DEPS > files as well, for example when ANGLE uploads a patch that modifies > DEPS files to be tested by a Chromium trybot. > > Chromium Linux CQ and Angle trybots are already running this way > (see [1] and [2]) and a PSA has already been sent [3] > > [1] https://chromium.googlesource.com/chromium/src/+/master/infra/config/global/cr-buildbucket.cfg#214 > [2] https://chromium.googlesource.com/angle/angle/+/infra/config/cr-buildbucket.cfg#105 > [3] https://groups.google.com/a/google.com/forum/#!topic/chrome-infra/FVHN2kdUX4I > [4] https://docs.google.com/document/d/1GSTw4ysm5AYjNR6vMA7NJUxLK2VN9IpOEp_v0u-wyOE/edit?ts=5ad78165# > > Bug: 643346 > Change-Id: Ic9a9dcfae86aca730d35fbb26c26b21135e05bf3 > Recipe-Nontrivial-Roll: skia > Recipe-Nontrivial-Roll: infra > Recipe-Nontrivial-Roll: build_limited_scripts_slave > Recipe-Nontrivial-Roll: skiabuildbot > Recipe-Nontrivial-Roll: build > Recipe-Nontrivial-Roll: release_scripts > Reviewed-on: https://chromium-review.googlesource.com/1014356 > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> > Reviewed-by: Aaron Gable <agable@chromium.org> Bug: 643346 Change-Id: Ia0db591c6bf9695f56e6b71777c567595986a511 Reviewed-on: https://chromium-review.googlesource.com/1031206 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
-
- 15 May, 2018 2 commits
-
-
Vadim Bendebury authored
When user invoking 'my_activity.py' does not have an account on one or more of the servers the utility queries, access errors are reported interleaving with access progress report printouts, this creates a messy looking output. With this patch access error messages are accumulated in a set and then, if there are any, get printed out separately. TEST=verified that error messages are printed neatly after servers queries finished running: > my_activity.py -u xxxyyzz Loading data................................. Access Errors: Looking up 'pdfium-review.googlesource.com': Bad Request: User xxxyyzz not found Looking up 'android-review.googlesource.com': Bad Request: User xxxyyzz not found Looking up 'chrome-internal-review.googlesource.com': Bad Request: User xxxyyzz not found Looking up 'chromium-review.googlesource.com': Bad Request: User xxxyyzz not found Signed-off-by:Vadim Bendebury <vbendeb@chromium.org> Change-Id: Ie9f41110becb67936f49095ff36a8eeaa7a4f114 Reviewed-on: https://chromium-review.googlesource.com/1058722Reviewed-by:
-
Vadim Bendebury authored
There is no point in trying to retrieve issues information when the issues list is empty, On top of that the attempt to start a thread pool with zero threads generates an exception. TEST=running my_activity.py when the user does not have issues on certain servers does not cause the exception any more. Signed-off-by:Sergiy Byelozyorov <sergiyb@chromium.org>
-
- 14 May, 2018 1 commit
-
-
Edward Lemur authored
Bug: 839925 Change-Id: Ibf97acf3c74b6f406904e14545e13497c680b883 Reviewed-on: https://chromium-review.googlesource.com/1054852Reviewed-by:
-
- 11 May, 2018 3 commits
-
-
John Budorick authored
Bug: 842235 Change-Id: Ie1a00b19a7ebb99dbac4a86562d4eb31493c216d Reviewed-on: https://chromium-review.googlesource.com/1055683 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/2ee036b744812ca2e9b30fae453ebe3e4dd83f5e api.py: Check if to_leak directory exists before deleting it (charliea@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I2e7c7ebf89bffdf0a4bdc072b9346f276dfa0ca5 Reviewed-on: https://chromium-review.googlesource.com/1054479Reviewed-by:
-
Edward Lemur authored
This is a reland of e877b177 Original change's description: > gclient: Get rid of parsed_url. > > There is no reason I can see to set parsed_url so late. > Also, the tests are misleading, since relative URLs don't behave the way > the tests led you to believe. > > Bug: 839925 > Change-Id: I08d92b7b7847bdc406f003d4a4139d968cc662b1 > Reviewed-on: https://chromium-review.googlesource.com/1047797 > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> > Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> TBR=agable@chromium.org Bug: 839925 Change-Id: I9200ec5fbe7289022e9754f0c78676dc931fcaeb Reviewed-on: https://chromium-review.googlesource.com/1054567 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org>
-
- 10 May, 2018 7 commits
-
-
Edward Lemur authored
It fails when both the revision and the url are None. Bug: 841936 Change-Id: Idef45a015624a92226d4ccd38ed5b978bf786993 Reviewed-on: https://chromium-review.googlesource.com/1053996 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Ryan Tseng <hinoka@chromium.org>
-
John Budorick authored
Suspected of breaking the world. This reverts commit e877b177. TBR=ehmaldonado@chromium.org,tandrii@chromium.org Bug: 841936 Change-Id: Iad2b55a2235d8d0b1a3d7681cbd577f795cb89dd Reviewed-on: https://chromium-review.googlesource.com/1054440Reviewed-by:
-
Edward Lemur authored
Bug: 840445 Change-Id: I9c9a13914bb2da0d07ed32f71453cbb0f30b59e0 Reviewed-on: https://chromium-review.googlesource.com/1053185 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
-
Edward Lemur authored
There is no reason I can see to set parsed_url so late. Also, the tests are misleading, since relative URLs don't behave the way the tests led you to believe. Bug: 839925 Change-Id: I08d92b7b7847bdc406f003d4a4139d968cc662b1 Reviewed-on: https://chromium-review.googlesource.com/1047797 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
-
Kimmo Kinnunen authored
It appears that newer VS 2017 installers install CppUnitFramework in different way. My version VS 15.6.6. The problem is that normal users do not seem to be able to download the VS 15.3.2 that Chromium suggests and this script was probably originally tested with. I installed: vs_professional__428566190.xxx.exe --add Microsoft.VisualStudio.Workload.NativeDesktop --add Microsoft.VisualStudio.Component.Debugger.JustInTime --add Microsoft.VisualStudio.Component.Graphics.Tools --add Microsoft.VisualStudio.Component.Graphics.Win81 --add Microsoft.VisualStudio.Component.NuGet --add Microsoft.VisualStudio.Component.Static.Analysis.Tools --add Microsoft.VisualStudio.Component.VC.ATL --add Microsoft.VisualStudio.Component.VC.DiagnosticTools --add Microsoft.VisualStudio.Component.VC.TestAdapterForGoogleTest --add Microsoft.VisualStudio.Component.VC.Tools.x86.x64 --add Microsoft.VisualStudio.Component.Windows10SDK.15063.Desktop --add Microsoft.VisualStudio.Component.Windows10SDK.15063.UWP --add Microsoft.VisualStudio.Component.Windows10SDK.15063.UWP.Native Go to apps -> Windows sdk 15063 Modify -> Change Select Debugging tools for Windows Ended up with VS 15.6.6 and Windows SDK 10.0.15063.673 Packaged with: python %HOME%\depot_tools\win_toolchain\package_from_installed.py -w 10.0.15063.0 2017 Bug: 834656 Change-Id: I5e6bf6a5f94a28d5ba81a3c8cd79e37028b9429b Reviewed-on: https://chromium-review.googlesource.com/1018470Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
-
Takuto Ikuta authored
GIT_TRACE_PERFORMANCE shows invocation time of each subcommands. https://git-scm.com/book/en/v2/Git-Internals-Environment-Variables This is tested on https://ci.chromium.org/swarming/task/3d605b8aab1a5a10?server=chromium-swarm.appspot.com bot_update ran successfully. Bug: 840592 Change-Id: I65ef733d1473f9f0f7e0109b0f727595766021b6 Reviewed-on: https://chromium-review.googlesource.com/1053028 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
-
Takuto Ikuta authored
This CL is tested on https://ci.chromium.org/swarming/task/3d5fde091e610010?server=chromium-swarm.appspot.com api.py change is for auto roller Bug: 840592 Change-Id: Ib6195dc1f4539c8f02fe0696dc140b4cf0973baf Reviewed-on: https://chromium-review.googlesource.com/1049987 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
-
- 09 May, 2018 4 commits
-
-
Edward Lemur authored
This is a reland of 3806b7fb Original change's description: > bot_update: Fetch references to be synced. > > If a solution is to be synced to a reference, such as > refs/branch-heads/#### fetch it so that it can later be > checked out. > > I tried this change on a LUCI task that runs chromium_presubmit > for crrev.com/c/1048868. The bot_update works as expected: > https://ci.chromium.org/swarming/task/3d5b294cff467710?server=chromium-swarm.appspot.com > > > Bug: 840445 > > Change-Id: I6444c0feb679ca89b2f4065215de915494e5082a > Recipe-Nontrivial-Roll: infra > Recipe-Nontrivial-Roll: build > Recipe-Nontrivial-Roll: build_limited > Recipe-Nontrivial-Roll: build_limited_scripts_slave > Reviewed-on: https://chromium-review.googlesource.com/1049007 > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> > Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Bug: 840445 Recipe-Nontrivial-Roll: infra Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: build_limited_scripts_slave Change-Id: I64a97aafe5fab9a26c478262e9ca104dc59e61f5 Reviewed-on: https://chromium-review.googlesource.com/1052387 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
-
Edward Lemur authored
Long term plan is to separate GitDependency and CipdDependency, where most of the current Dependency code is moved to GitDependency, since it's not relevant to Cipd anyway. Bug: 839925 Change-Id: Ic238a24fa7add302704934f79004e8a9ca886895 Reviewed-on: https://chromium-review.googlesource.com/1044651 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
-
agrieve authored
This reverts commit 3806b7fb. Reason for revert: Broke downstream tot bots Original change's description: > bot_update: Fetch references to be synced. > > If a solution is to be synced to a reference, such as > refs/branch-heads/#### fetch it so that it can later be > checked out. > > I tried this change on a LUCI task that runs chromium_presubmit > for crrev.com/c/1048868. The bot_update works as expected: > https://ci.chromium.org/swarming/task/3d5b294cff467710?server=chromium-swarm.appspot.com > > > Bug: 840445 > > Change-Id: I6444c0feb679ca89b2f4065215de915494e5082a > Recipe-Nontrivial-Roll: infra > Recipe-Nontrivial-Roll: build > Recipe-Nontrivial-Roll: build_limited > Recipe-Nontrivial-Roll: build_limited_scripts_slave > Reviewed-on: https://chromium-review.googlesource.com/1049007 > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> > Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> TBR=mmoss@chromium.org,machenbach@chromium.org,tandrii@chromium.org,ehmaldonado@chromium.org Change-Id: If94df8684e634504d8a0c11b2aa5862a458ba19f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 840445, 841306 Reviewed-on: https://chromium-review.googlesource.com/1052187Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org>
-
Edward Lemur authored
If a solution is to be synced to a reference, such as refs/branch-heads/#### fetch it so that it can later be checked out. I tried this change on a LUCI task that runs chromium_presubmit for crrev.com/c/1048868. The bot_update works as expected: https://ci.chromium.org/swarming/task/3d5b294cff467710?server=chromium-swarm.appspot.com Bug: 840445 Change-Id: I6444c0feb679ca89b2f4065215de915494e5082a Recipe-Nontrivial-Roll: infra Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: build_limited Recipe-Nontrivial-Roll: build_limited_scripts_slave Reviewed-on: https://chromium-review.googlesource.com/1049007 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
-
