Also reorder some patchset in preparation to patchset reording CL.

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/8066012

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@103147 0039d316-1c4b-4281-b951-d872f2087c98

Since we clobber the .pyc, it's not useful to generate them in the first place.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/8060026

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@103066 0039d316-1c4b-4281-b951-d872f2087c98

It's annoying to have it crash much later in a member function call when a
trailing backslash is provided.

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/8056016

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@103058 0039d316-1c4b-4281-b951-d872f2087c98

Take two at r102841.

Forgot to use $base_dir, so the .pyc files in the checkout were deleted, instead
of the ones in depot_tools. Since some slaves have very large checkouts, they
appeared as hung.

R=cmp@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/8059001

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@103056 0039d316-1c4b-4281-b951-d872f2087c98

When running an interactive python prompt, sys.modules['__main__'] has no
__file__ member.

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/8051027

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@103055 0039d316-1c4b-4281-b951-d872f2087c98

Merge _FindDependencies() back into __init__() now that __init__() is somewhat smaller.

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/8059011

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@103053 0039d316-1c4b-4281-b951-d872f2087c98

Set svn:eol-style=CRLF for all .bat files and everything in bootstrap/win/
Set svn:eol-style=LF for everything else.

Also delete depot_tools/git_cl/ since it's not used anymore.
Review URL: http://codereview.chromium.org/8055016

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@103051 0039d316-1c4b-4281-b951-d872f2087c98

This is a followup to: http://codereview.chromium.org/8059009/

Only add the file once instead of twice (since the diff has --- and +++ lines for each file).
Strip whitespace at the end (git diffs don't include a \t so split('\t') isn't enough).
Remove leading 'a/' from the path, since git diffs have these.

BUG=none
TEST=manual

Review URL: http://codereview.chromium.org/8050017

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@102934 0039d316-1c4b-4281-b951-d872f2087c98

Needed to make it so changes containing only *.mm are only sent to Mac trybots by default.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/8059009

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@102930 0039d316-1c4b-4281-b951-d872f2087c98

It was kept to easy the transition but it's been a while now.

TBR=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/8056005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@102924 0039d316-1c4b-4281-b951-d872f2087c98

TBR=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/8055012

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@102923 0039d316-1c4b-4281-b951-d872f2087c98

TBR=maruel,asvitkine
Review URL: http://codereview.chromium.org/8052003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@102859 0039d316-1c4b-4281-b951-d872f2087c98

Last change exhibited issues with stale .pyc files. Let's leave that bake in a
little to cleanup old .pyc files.

TBR=asvitkine@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/8048014

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@102841 0039d316-1c4b-4281-b951-d872f2087c98

Cause an infinite recursion in some context.

TBR=asvitkine@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/8036046

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@102836 0039d316-1c4b-4281-b951-d872f2087c98

This was causing issues for windows user with notepad2.

Fix trychange.py on python2.5.

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/8038028

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@102797 0039d316-1c4b-4281-b951-d872f2087c98

Needed to make it so changes containing only *.mm are only sent to Mac trybots by default.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/7925014

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@102783 0039d316-1c4b-4281-b951-d872f2087c98

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/7982005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@102777 0039d316-1c4b-4281-b951-d872f2087c98

First, it reduces the class size, which is too large at the moment.
Second, it makes clear what is 'static' for the livetime of the instance life.

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/8038015

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@102766 0039d316-1c4b-4281-b951-d872f2087c98

I heard some people like to review their changes themselves. :)

TBR=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/8045007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@102670 0039d316-1c4b-4281-b951-d872f2087c98

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/8034001

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@102578 0039d316-1c4b-4281-b951-d872f2087c98

Right now, it'd simply crash with a KeyError.

TBR=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/8020004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@102496 0039d316-1c4b-4281-b951-d872f2087c98

TBR=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7966018

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@102354 0039d316-1c4b-4281-b951-d872f2087c98

Enforce a reviewer, when $EMAIL_ADDRESS is not set

BUG=
TEST=


Review URL: http://codereview.chromium.org/7988012

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@102340 0039d316-1c4b-4281-b951-d872f2087c98

It's now live on codereview.appspot, codereview.chromium and the internal
instance so it's far more easier to get review stats now.

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/7989013

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@102331 0039d316-1c4b-4281-b951-d872f2087c98

Add more doc.

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/7991002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@102328 0039d316-1c4b-4281-b951-d872f2087c98

when --force is used.

BUG=96775
Review URL: http://codereview.chromium.org/7942007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@102324 0039d316-1c4b-4281-b951-d872f2087c98

Output details to stderr to make it redirect-friendly. Silence upload.py.

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/7979034

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@102277 0039d316-1c4b-4281-b951-d872f2087c98

TBR=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/7982048

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@102219 0039d316-1c4b-4281-b951-d872f2087c98

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/7983052

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@102211 0039d316-1c4b-4281-b951-d872f2087c98

Add search interface for rietveld.

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/7977030

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@102191 0039d316-1c4b-4281-b951-d872f2087c98

The dependencies will continue to be managed. A new flag is present in the .gclient file to control this behavior.

Review URL: http://codereview.chromium.org/7918027

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@102002 0039d316-1c4b-4281-b951-d872f2087c98

Make Dependency.file_list a tuple so it can't be modified.
Move the guesswork of file_list at the right place.
Remove tree() since it's unnecessary.

R=dpranke@chromium.org
BUG=
TEST=all smoke tests still pass


Review URL: http://codereview.chromium.org/7922011

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@101951 0039d316-1c4b-4281-b951-d872f2087c98

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/7889047

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@101950 0039d316-1c4b-4281-b951-d872f2087c98

Fix gcl sometimes stripping the new line characters when changing the issue description on the server. This change replaces \n with \r\n before giving the description to the editor on Windows (not through cygwin though), and then replaces \r\n with \n when saving it locally or sending it to reitveld.

BUG=95618
Review URL: http://codereview.chromium.org/7875004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@101863 0039d316-1c4b-4281-b951-d872f2087c98

I had forgot one access to _requirements. Now that tests are run, this change is
safer to commit.

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/7909012

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@101856 0039d316-1c4b-4281-b951-d872f2087c98

BUG=96775

Review URL: http://codereview.chromium.org/7922018

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@101771 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7894003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@101356 0039d316-1c4b-4281-b951-d872f2087c98

Add regression test.

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/7891061

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@101351 0039d316-1c4b-4281-b951-d872f2087c98

Add a warning when RunUnitTestsInDirectory() finds no test to run to
catch this kind of regression.

Fix all the regressions that where introduced in the meantime...

TBR=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/7906009

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@101347 0039d316-1c4b-4281-b951-d872f2087c98

Broke the tree. :(

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@101136 0039d316-1c4b-4281-b951-d872f2087c98