Commits · cd968c1833db55446db2ca1e3f8a939af78d065c · Linshizhi / Chromium_Depot_tools

01 Feb, 2010 1 commit

Always return a tuple from GIT.Capture · cd968c18

nasser@codeaurora.org authored Feb 01, 2010

Review URL: http://codereview.chromium.org/555198

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@37685 0039d316-1c4b-4281-b951-d872f2087c98

cd968c18

30 Jan, 2010 4 commits

Change CheckCall behavior when print_error=False · 7be5ef2e

maruel@chromium.org authored Jan 30, 2010

We now return the stderr half of the tuple.
This required a clean up of any usage of CheckCall and GIT.Capture.

Patch contributed by Nasser Grainawi <nasser@codeaurora.org>

Review URL: http://codereview.chromium.org/551215

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@37650 0039d316-1c4b-4281-b951-d872f2087c98

7be5ef2e

Using options.email for svn credential is not a good idea. · 519a8dd3

maruel@chromium.org authored Jan 30, 2010

It breaks the use case when a dev outside corp wants to send a job's email to someone else.

Review URL: http://codereview.chromium.org/558062

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@37644 0039d316-1c4b-4281-b951-d872f2087c98

519a8dd3

Remove stale revert.py unit test and fix another test I broke in r37487. · 56ca2c24

maruel@chromium.org authored Jan 30, 2010

TEST=unit tests
BUG=none

Review URL: http://codereview.chromium.org/556092

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@37618 0039d316-1c4b-4281-b951-d872f2087c98

56ca2c24

Simplify submitting try jobs directly from rietveld. · 5f423140

maruel@chromium.org authored Jan 30, 2010

trychange.py -R <review_url> is sufficient for try jobs when in a checkout directory.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/553166

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@37616 0039d316-1c4b-4281-b951-d872f2087c98

5f423140

29 Jan, 2010 1 commit

Delete the revert.py tool. · c19d95a4

maruel@chromium.org authored Jan 29, 2010

It's been replaced by drover a year ago.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/553145

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@37487 0039d316-1c4b-4281-b951-d872f2087c98

c19d95a4

28 Jan, 2010 4 commits

Fix the regexp in DEFAULT_WHITE_LIST. · a73d7931

maruel@chromium.org authored Jan 28, 2010

For example, r".*\.c" was triggering for foo.checksum.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/558026

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@37461 0039d316-1c4b-4281-b951-d872f2087c98

a73d7931

gclient: Keyboard interrupt should not cause request to send stack · 8912ead3

msb@chromium.org authored Jan 28, 2010

Patch-contributed-by: Alexey Marinichev <amarinichev@chromium.org>

Review URL: http://codereview.chromium.org/553139

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@37434 0039d316-1c4b-4281-b951-d872f2087c98

8912ead3

Change the default source lists; · ef77648d

maruel@chromium.org authored Jan 28, 2010

Remove *.txt and *.json, add *.pl and *.pm.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/548172

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@37406 0039d316-1c4b-4281-b951-d872f2087c98

ef77648d

Add a trailing \ when printing filenames for presubmit checks. · 593258b9

estade@chromium.org authored Jan 28, 2010

This makes it easier to apply commands to a set of files. For example:

Run the command: svn pset svn:eol-style LF \
  chrome/browser/extensions/extension_accessibility_apitest.cc \
  chrome/browser/extensions/extension_accessibility_api_constants.cc \
  chrome/browser/extensions/extension_accessibility_api.h \
  chrome/browser/extensions/extension_accessibility_api.cc \
  chrome/browser/extensions/extension_accessibility_api_constants.h \
  chrome/browser/gtk/accessible_widget_helper_gtk.h \
  chrome/browser/gtk/accessible_widget_helper_gtk.cc \
  chrome/browser/gtk/accessibility_event_router_gtk.h \
  chrome/browser/gtk/accessibility_event_router_gtk.cc \
  chrome/common/accessibility_events.cc \
  chrome/common/accessibility_events.h

requires just 1 copy-paste.

Review URL: http://codereview.chromium.org/552202

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@37350 0039d316-1c4b-4281-b951-d872f2087c98

593258b9

27 Jan, 2010 2 commits

Add presubmit_canned_checks.CheckLicense() · b9e7adaa

maruel@chromium.org authored Jan 27, 2010

It does a regexp search on the file contents to make sure it contains expected license boiler plate.

It is a generalization to implement the equivalent of ubuntu's license check script into the corresponding PRESUBMIT.py files.

TEST=unit tests
BUG=28291

Review URL: http://codereview.chromium.org/558007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@37338 0039d316-1c4b-4281-b951-d872f2087c98

b9e7adaa

Fix branching regex to match .*? and not /d+ so that it will match "249s" in · 3529954d

laforge@chromium.org authored Jan 27, 2010

addition to "249"
Review URL: http://codereview.chromium.org/553108

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@37203 0039d316-1c4b-4281-b951-d872f2087c98

3529954d

26 Jan, 2010 1 commit

Partial revert of r37053. Put back the gcl default CODEREVIEW_SETTINGS as we... · 172b6e74

thestig@chromium.org authored Jan 26, 2010

Partial revert of r37053. Put back the gcl default CODEREVIEW_SETTINGS as we had it before, except with an updated CC_LIST.

BUG=none
TEST=Using gcl from src/third_party/WebKit sends code reviews to codereview.chromium.org.
Review URL: http://codereview.chromium.org/552144

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@37069 0039d316-1c4b-4281-b951-d872f2087c98

172b6e74

25 Jan, 2010 5 commits

gcl.py cleanup · 4aa47816

thestig@chromium.org authored Jan 25, 2010

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/552139

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@37053 0039d316-1c4b-4281-b951-d872f2087c98

4aa47816

Fix condition where no author would be retrieved (revert on a branch for · 638044da

laforge@chromium.org authored Jan 25, 2010

something that was on trunk, svn info only knows about it when it's ref by trunk
url).

Also added an author override, useful for webkit merges or double reverts

Review URL: http://codereview.chromium.org/551137

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@37024 0039d316-1c4b-4281-b951-d872f2087c98

638044da

Make gclient cleanup a no-op for git · d8a63787

msb@chromium.org authored Jan 25, 2010

Patch-contributed-by: Nasser Grainawi <nasser@codeaurora.org>

Review URL: http://codereview.chromium.org/551023

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@37021 0039d316-1c4b-4281-b951-d872f2087c98

d8a63787

Use --force to reset a git repo before attempting to rebase during gclient sync/update · eafef3b3

msb@chromium.org authored Jan 25, 2010

Patch Contributed By: Nasser Grainawi <nasser@codeaurora.org>

Review URL: http://codereview.chromium.org/548079

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@37020 0039d316-1c4b-4281-b951-d872f2087c98

eafef3b3

Always list the args in the same order · 3904caa9

msb@chromium.org authored Jan 25, 2010

Patch-contributed-by: Nasser Grainawi <nasser@codeaurora.org>

Review URL: http://codereview.chromium.org/546045

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@37016 0039d316-1c4b-4281-b951-d872f2087c98

3904caa9

22 Jan, 2010 2 commits

Adding branch to branch merge support for drover. · 2d6af5fc

laforge@chromium.org authored Jan 22, 2010

Review URL: http://codereview.chromium.org/554054

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@36872 0039d316-1c4b-4281-b951-d872f2087c98

2d6af5fc

Fix svn mv/cp/ren diff for real this time, for try jobs. · 0836c561

maruel@chromium.org authored Jan 22, 2010

TEST=send a try job with a file moved with modified content
BUG=6825

Review URL: http://codereview.chromium.org/554013

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@36828 0039d316-1c4b-4281-b951-d872f2087c98

0836c561

19 Jan, 2010 1 commit

First take on zsh-completion functionality for gclient. · 41cdced8

antonm@chromium.org authored Jan 19, 2010

It's very basic, only subcommands.

If this would evolve, generation of _gclient should be automized (like a separate command
or some other tool.)

Review URL: http://codereview.chromium.org/546069

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@36521 0039d316-1c4b-4281-b951-d872f2087c98

41cdced8

13 Jan, 2010 4 commits

gclient: Add better error reporting when path is not a git repo. · e4af1ab4

msb@chromium.org authored Jan 13, 2010

Review URL: http://codereview.chromium.org/505007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@36172 0039d316-1c4b-4281-b951-d872f2087c98

e4af1ab4

Correct the value needed to disable auto-updates · 74f559a7

msb@chromium.org authored Jan 13, 2010

Also remove Windows-style line endings.
Patch-contributed-by: Nasser Grainawi <nasser@codeaurora.org>

Review URL: http://codereview.chromium.org/541034

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@36145 0039d316-1c4b-4281-b951-d872f2087c98

74f559a7

Update docs for git usage · d6504218

msb@chromium.org authored Jan 13, 2010

chromium-os BUG=1189

Review URL: http://codereview.chromium.org/551002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@36129 0039d316-1c4b-4281-b951-d872f2087c98

d6504218

gclient: git relative url implementation · e6f78352

msb@chromium.org authored Jan 13, 2010

Redo relative url implementation per maruel's comments here:
http://codereview.chromium.org/500015

Instead of adding an option, implement relative urls differently for
git urls.

Review URL: http://codereview.chromium.org/546022

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@36126 0039d316-1c4b-4281-b951-d872f2087c98

e6f78352

12 Jan, 2010 2 commits

gclient: fix unittests · 32906d1b

msb@chromium.org authored Jan 12, 2010

Review URL: http://codereview.chromium.org/550013

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@36022 0039d316-1c4b-4281-b951-d872f2087c98

32906d1b

Add the capability to filter out files on try job with regexp. · 8ede00e1

maruel@chromium.org authored Jan 12, 2010

By default, filters out 'ChangeLog'. A pain directly coming from Webkit.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/543012

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@36008 0039d316-1c4b-4281-b951-d872f2087c98

8ede00e1

11 Jan, 2010 1 commit

Allow gclient revert to remove symlinks · d2e78ff6

maruel@chromium.org authored Jan 11, 2010

Previously links weren't caught at the appropriate point and instead passed to RemoveDirectory which then rejected them because they were links.

Patch contributed by Nasser <nasser@codeaurora>

Review URL: http://codereview.chromium.org/541012

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@35936 0039d316-1c4b-4281-b951-d872f2087c98

d2e78ff6

10 Jan, 2010 2 commits

Fixed issue with try where patchset is passed. · 346737cf

mhm@chromium.org authored Jan 10, 2010

The new try execution should only be triggered when a user just passes the rietveld issue number. Usually, if your branch has a working patchset already defined, it shouldn't think the user passed it. The code has been updated to force patchset to be None (not 0 or any other number) so that specific occurence wont happen again.

TBR=maruel
BUG=None
TEST=git try, git try --issue=123, git try --issue=123 --patchset=0, should all work fine now.

Review URL: http://codereview.chromium.org/542007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@35889 0039d316-1c4b-4281-b951-d872f2087c98

346737cf

Allow git-try to try rietveld changes directly. · c2190cb2

mhm@chromium.org authored Jan 10, 2010

Some external contributors need their CL's try'd quickly, but currently its not easy unless we patch locally. This will allow you to submit the rietveld issue number and will do the rest automatically. As well, renable the dry_run option. It was removed.

BUG=None
TEST=git try --issue 12345
Review URL: http://codereview.chromium.org/481006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@35881 0039d316-1c4b-4281-b951-d872f2087c98

c2190cb2

08 Jan, 2010 10 commits

Fix case sensitivity issues and svn move patches for --sub_rep on Windows. · fd9cbbb7

maruel@chromium.org authored Jan 08, 2010

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/538009

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@35839 0039d316-1c4b-4281-b951-d872f2087c98

fd9cbbb7

append_const is not supported on python 2.4. · 51282ec8

maruel@chromium.org authored Jan 08, 2010

(which is increasingly becoming a pain to support)

TEST=gcl try --help doesn't throw an error.
BUG=none
Review URL: http://codereview.chromium.org/537004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@35832 0039d316-1c4b-4281-b951-d872f2087c98

51282ec8

Add --webkit option as a shorthand for -s third_party/WebKit. · 7538b862

maruel@chromium.org authored Jan 08, 2010

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/536002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@35830 0039d316-1c4b-4281-b951-d872f2087c98

7538b862

Change to a git repo before checking git-svn version · 8d4c15c3

maruel@chromium.org authored Jan 08, 2010

TEST=none
BUG=none
R=maruel

Patch contributed by Nasser <nasser@codeaurora>

Review URL: http://codereview.chromium.org/530001

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@35817 0039d316-1c4b-4281-b951-d872f2087c98

8d4c15c3

Catch ValueErrors when trying to convert the CL issue number in git presubmit hooks · 0dfc4ef2

rsesek@chromium.org authored Jan 08, 2010

BUG=31695
TEST=none
Review URL: http://codereview.chromium.org/528004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@35816 0039d316-1c4b-4281-b951-d872f2087c98

0dfc4ef2

Abort gclient sync when a svn command fails. · 54d1f1ae

maruel@chromium.org authored Jan 08, 2010

TEST=a svn locked directory will stop a gclient sync
BUG=none

Review URL: http://codereview.chromium.org/529002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@35815 0039d316-1c4b-4281-b951-d872f2087c98

54d1f1ae

Using the root codereview.settings seems to be a problem for NACL · 4970aa2b

bradnelson@google.com authored Jan 08, 2010

(there isn't one in their repo).
They've been manually specifying --host etc for over a week.

Why the change in behavior?

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/528003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@35814 0039d316-1c4b-4281-b951-d872f2087c98

4970aa2b

git svn --version doesn't work when called outside a git checkout. · 8dd7cc5c

maruel@chromium.org authored Jan 08, 2010

TEST=none
BUG=none
TBR=nasser

Review URL: http://codereview.chromium.org/523166

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@35800 0039d316-1c4b-4281-b951-d872f2087c98

8dd7cc5c

Fix unit tests (mostly esthetical) · 40f35c32

maruel@chromium.org authored Jan 08, 2010

TEST=none
BUG=none
TBR=bradnelson

Review URL: http://codereview.chromium.org/517068

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@35767 0039d316-1c4b-4281-b951-d872f2087c98

40f35c32

Check for the existence of git before running commands. · f3909bf2

maruel@chromium.org authored Jan 08, 2010

Checks in the gclient wrapper and when running any gclient git command.

TEST=none
BUG=none

Patch contributed by Nasser <nasser@codeaurora>

Review URL: http://codereview.chromium.org/518064

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@35762 0039d316-1c4b-4281-b951-d872f2087c98

f3909bf2