1. 16 Aug, 2018 1 commit
  2. 15 Aug, 2018 1 commit
    • Vadim Shtayura's avatar
      Revert "[cipd] Check CIPD client hash against pinned SHA256 during updates." · 5e5c2173
      Vadim Shtayura authored
      This reverts commit eebc3d82.
      
      Reason for revert: crbug.com/874586
      
      Original change's description:
      > [cipd] Check CIPD client hash against pinned SHA256 during updates.
      > 
      > Linux and OSX only for now. This also rolls CIPD client to a version that
      > supports pinned hashes (v2.2.5).
      > 
      > CIPD_CLIENT_VER and CIPD_CLIENT_SRV are no longer supported as env vars, since
      > it makes no sense when pinning hashes of the binaries at specific version on
      > the specific backend.
      > 
      > Also somewhat cleanup 'cipd' script to use "${VAR}", stderr and colored output
      > consistently.
      > 
      > R=​iannucci@chromium.org, nodir@chromium.org
      > BUG=870166
      > 
      > Change-Id: I9e61f9f8fbdcf10985c52828b2bfbec64b4234f0
      > Reviewed-on: https://chromium-review.googlesource.com/1171957
      > Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
      > Reviewed-by: Nodir Turakulov <nodir@chromium.org>
      
      TBR=iannucci@chromium.org,vadimsh@chromium.org,nodir@chromium.org
      
      # Not skipping CQ checks because original CL landed > 1 day ago.
      
      Bug: 870166
      Change-Id: I9aa8e7a7f07520aa69d366c76e4dbccae345bc00
      Reviewed-on: https://chromium-review.googlesource.com/1175294Reviewed-by: 's avatarVadim Shtayura <vadimsh@chromium.org>
      Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
      5e5c2173
  3. 14 Aug, 2018 1 commit
  4. 03 Aug, 2018 1 commit
  5. 26 Jul, 2018 2 commits
    • Vadim Shtayura's avatar
      [cipd] Try to bootstrap CIPD from scratch if selfupdate fails. · 7e50ee37
      Vadim Shtayura authored
      When updating the CIPD client to be identified by SHA256 hash, old clients (that
      have no idea about SHA256) fail during 'selfupdate'.
      
      We'll roll our SHA256 support in two stages:
        1. Deploy new client that understand SHA256 using its SHA1 name, so
           self-update from old clients works.
        2. Deploy same (or newer) client using its SHA256 name. This would work since
           the client doing the self-update already understands SHA256 at this point.
      
      But we can't guarantee that ALL depot_tools deployments will update through
      stages (1) and (2) sequentially. Some of them may skip (1) and end-up directly
      in (2), failing on 'selfupdate'.
      
      This CL makes sure they can recover from this state by rebootstraping the client
      from scratch (this works with SHA256 hashes).
      
      R=nodir@chromium.org, iannucci@chromium.org
      BUG=821194
      
      Change-Id: I27dece19e0305b5b2d6f8b0130631c1bf5f6499c
      Reviewed-on: https://chromium-review.googlesource.com/1149454
      Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
      Reviewed-by: 's avatarRobbie Iannucci <iannucci@chromium.org>
      7e50ee37
    • Wang Qing's avatar
      MIPS64: Add support for depot_tools on mips64. · 254538b9
      Wang Qing authored
      BUG= 865294
      
      R= tandrii@chromium.org
      
      Change-Id: I8ad56887882b897d605dc92e0e61c17de0a74967
      Reviewed-on: https://chromium-review.googlesource.com/1141563Reviewed-by: 's avatarRobbie Iannucci <iannucci@chromium.org>
      Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
      254538b9
  6. 19 Jun, 2018 1 commit
  7. 04 Apr, 2018 1 commit
  8. 20 Oct, 2017 1 commit
  9. 17 Oct, 2017 2 commits
  10. 10 Oct, 2017 1 commit
  11. 11 Sep, 2017 1 commit
  12. 07 Sep, 2017 1 commit
  13. 28 Jul, 2017 1 commit
    • Dan Jacques's avatar
      [cipd] Bump version, log at warning (#2). · eb1feb90
      Dan Jacques authored
      Bump the CIPD client version to
      b482bfa19d3fa79b4b40dd5ac7a34479052e3df1. This version inculdes support
      for the "-log-level" flag.
      
      Update CIPD bootstrap scripts and tool installation scripts to log at
      warning level, so that standard operation doesn't produce any logs.
      
      This version differs from the previous CL in that the "selfupdate"
      command no longer uses "-log-level". This fixes an issue where the
      current CIPD, which doesn't support "-log-level", is given the flag
      prior to actually updating to a version that does.
      
      BUG=chromium:748651
      TEST=canary
        - Tested this CIPD version on canary waterfall successfully.
      
      Change-Id: I69dfe522d890eb307214f18d0467ce921a766446
      Reviewed-on: https://chromium-review.googlesource.com/589568
      Commit-Queue: Daniel Jacques <dnj@chromium.org>
      Reviewed-by: 's avatarRobbie Iannucci <iannucci@chromium.org>
      eb1feb90
  14. 27 Jul, 2017 2 commits
    • Daniel Jacques's avatar
      Revert "[cipd] Bump version, log at warning." · 9f9d82ac
      Daniel Jacques authored
      This reverts commit 18aa2d93.
      
      Reason for revert: <INSERT REASONING HERE>
      
      Original change's description:
      > [cipd] Bump version, log at warning.
      > 
      > Bump the CIPD client version to
      > e2a98b41adb3403b5b7771c4101b42a55dc2dd9e. This version inculdes support
      > for the "-log-level" flag.
      > 
      > Update CIPD bootstrap scripts and tool installation scripts to log at
      > warning level, so that standard operation doesn't produce any logs.
      > 
      > BUG=chromium:748651
      > TEST=canary
      >   - Tested this CIPD version on canary waterfall successfully.
      >   - Tested "gclient" bootstrap and "vpython" / "led" on Windows system,
      >     no output and works.
      >   - Tested "vpython" / "led" on OSX system, no output and works.
      > 
      > Change-Id: Iae316908283c43c504f293aafdf897df83dccf8d
      > Reviewed-on: https://chromium-review.googlesource.com/588889
      > Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
      > Commit-Queue: Daniel Jacques <dnj@chromium.org>
      
      TBR=iannucci@chromium.org,dnj@chromium.org
      
      Change-Id: Ia611c1aeb204c609ff3469076b8256c54e702230
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: chromium:748651
      Reviewed-on: https://chromium-review.googlesource.com/589527Reviewed-by: 's avatarDaniel Jacques <dnj@chromium.org>
      Commit-Queue: Daniel Jacques <dnj@chromium.org>
      9f9d82ac
    • Dan Jacques's avatar
      [cipd] Bump version, log at warning. · 18aa2d93
      Dan Jacques authored
      Bump the CIPD client version to
      e2a98b41adb3403b5b7771c4101b42a55dc2dd9e. This version inculdes support
      for the "-log-level" flag.
      
      Update CIPD bootstrap scripts and tool installation scripts to log at
      warning level, so that standard operation doesn't produce any logs.
      
      BUG=chromium:748651
      TEST=canary
        - Tested this CIPD version on canary waterfall successfully.
        - Tested "gclient" bootstrap and "vpython" / "led" on Windows system,
          no output and works.
        - Tested "vpython" / "led" on OSX system, no output and works.
      
      Change-Id: Iae316908283c43c504f293aafdf897df83dccf8d
      Reviewed-on: https://chromium-review.googlesource.com/588889Reviewed-by: 's avatarRobbie Iannucci <iannucci@chromium.org>
      Commit-Queue: Daniel Jacques <dnj@chromium.org>
      18aa2d93
  15. 06 Jul, 2017 2 commits
    • Dan Jacques's avatar
      [cipd] Fix CIPD bootstraps run concurrently. · 7c2e05b4
      Dan Jacques authored
      It's currently possible for CIPD bootstraps that provision concurrently to:
      1) On Linux, step on each other during download, and
      2) On Windows, fail.
      
      Fix these respective scripts so that bootstraps are safe to use
      concurrently.
      
      On Linux and Mac, we download to a temporary file and use "mv" (atomic)
      to write it to the final destination. Concurrent initializations will
      perform parallel downloads, execute the "mv", and copy their downloaded
      file to the destination path.
      
      On Windows, we use filesystem locking to lock the operation and ensure
      that only one download can happen.
      
      BUG=chromium:739195
      TEST=local
        - Ran in parallel on Windows, Linux, and Max.
      
      Change-Id: Ie050d37598da67389f21728e781bd58904ef9c17
      Reviewed-on: https://chromium-review.googlesource.com/560521Reviewed-by: 's avatarRobbie Iannucci <iannucci@chromium.org>
      Commit-Queue: Daniel Jacques <dnj@chromium.org>
      7c2e05b4
    • Dan Jacques's avatar
      [cipd] Fail if setup has an error. · e82c0dec
      Dan Jacques authored
      Make Linux/Mac CIPD wrapper fail if any step returns an error.
      
      Include the "-f" curl flag, which will cause it to error on non-200
      status.
      
      BUG=chromium:739195
      TEST=local
      R=iannucci@chromium.org
      
      Change-Id: I3efea3f38c1ee322cb9d63f29819472564107ddc
      Reviewed-on: https://chromium-review.googlesource.com/560723Reviewed-by: 's avatarRobbie Iannucci <iannucci@chromium.org>
      Commit-Queue: Daniel Jacques <dnj@chromium.org>
      e82c0dec
  16. 13 Dec, 2016 1 commit