It result in less code, forces uploading the change for eventual review and most
importantly enables the commit queue to correctly handle this.

BUG=
TEST=

Review URL: http://codereview.chromium.org/7253015

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@91575 0039d316-1c4b-4281-b951-d872f2087c98

This may include Makefile but it's saner to not include it by default

R=dpranke@chromium.org
BUG=
TEST=updated

Review URL: http://codereview.chromium.org/7251002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@90403 0039d316-1c4b-4281-b951-d872f2087c98

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7215025

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@89884 0039d316-1c4b-4281-b951-d872f2087c98

TEST=Rewrote the unit test to catch that case.

R=dpranke@chromium.org
BUG=

Review URL: http://codereview.chromium.org/7192010

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@89700 0039d316-1c4b-4281-b951-d872f2087c98

Improve the list of exception to include very_long_symbol_names.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7097012

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@89696 0039d316-1c4b-4281-b951-d872f2087c98

See related repo change:
  https://review.source.android.com/#change,22722

Review URL: http://codereview.chromium.org/7111045
Patch from Doug Anderson <dianders@chromium.org>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@89361 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7178001

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@89268 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7172033

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@89261 0039d316-1c4b-4281-b951-d872f2087c98

R=cmp@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7172014

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@89208 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7111049

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@89036 0039d316-1c4b-4281-b951-d872f2087c98

This mirrors the git-cl changes by first moving git-try
to git_try.py (which git cl already had), then copying
git-cl to git-try and updating all references to git-cl
and git_cl.py to the corresponding git try references.

The main issue is that in the MINGW/Msysgit case we want
to use the Python in depot_tools since that is 100%
compatible with the Command Prompt.  Hence we need
to call it directly and then pass it the name of the
git_try.py script.

Note that 'git-try' will not (ever) work on Windows,
and users should only ever run 'git try'.  Hence the
need to modify the output of the command to avoid
further confusion.
Review URL: http://codereview.chromium.org/7114002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@89031 0039d316-1c4b-4281-b951-d872f2087c98

It was broken in 88979. Someone my limited testing missed that.

TBR=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7147016

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@88987 0039d316-1c4b-4281-b951-d872f2087c98

This will be used in commit queue tests.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7046110

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@88986 0039d316-1c4b-4281-b951-d872f2087c98

TEST=Add PanProjectChecks unittest, there was none.

R=dpranke@chromium.org
BUG=

Review URL: http://codereview.chromium.org/7104141

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@88982 0039d316-1c4b-4281-b951-d872f2087c98

Properly load --contributor value or use the git config user.email value.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7134097

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@88979 0039d316-1c4b-4281-b951-d872f2087c98

'Cause linux2 is so last decade.

TBR=evan@chromium.org
BUG=85845
TEST=

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@88788 0039d316-1c4b-4281-b951-d872f2087c98

R=dpranke@chromium.org
TEST=few
BUG=

Review URL: http://codereview.chromium.org/6995115

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@88779 0039d316-1c4b-4281-b951-d872f2087c98

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7044090

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@88777 0039d316-1c4b-4281-b951-d872f2087c98

R=evan@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7129059

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@88697 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/7003057

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@88341 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=

Review URL: http://codereview.chromium.org/7024021

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@88160 0039d316-1c4b-4281-b951-d872f2087c98

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7065074

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@87979 0039d316-1c4b-4281-b951-d872f2087c98

For a yet unknown reason, a chmod +x on a git svn checkout will set a 'A'
status. Will investigate separately.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/6993033

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@87903 0039d316-1c4b-4281-b951-d872f2087c98

Use p.is_new signal and set it manually with rietveld patches.
Add regression test for +x.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7054057

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@87858 0039d316-1c4b-4281-b951-d872f2087c98

TBR=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7112016

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@87844 0039d316-1c4b-4281-b951-d872f2087c98

presubmit_support.py can now creates a Rietveld object on its own.

This is necessary since the object needs to be recreated out of process. The
commit queue runs the presubmit check out of process for sanity reasons.

Added TODO to push the cookie instead of the password.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7058054

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@87842 0039d316-1c4b-4281-b951-d872f2087c98

Add is_new to be used in a later patch by checkout classes.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7054048

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@87838 0039d316-1c4b-4281-b951-d872f2087c98

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7056045

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@87827 0039d316-1c4b-4281-b951-d872f2087c98

This enables private issue checking and simplifies testing.

R=dpranke@chromium.org

Review URL: http://codereview.chromium.org/7058025

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@87743 0039d316-1c4b-4281-b951-d872f2087c98

The "^0" is not needed, and it confuses Windows since
the carret is a special character.
Review URL: http://codereview.chromium.org/6976050

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@87636 0039d316-1c4b-4281-b951-d872f2087c98

This makes it possible to dump logging information from a PRESUBMIT script when
calling git cl presubmit -v -v -v for example.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7027031

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@87603 0039d316-1c4b-4281-b951-d872f2087c98

The regression was introduced in r87253.

TBR=dpranke@chromium.org
BUG=
TEST=

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@87550 0039d316-1c4b-4281-b951-d872f2087c98

While using --jobs, empty lines are adding a lot of noise.

An example output would look like:

>gclient sync --jobs=10
1>
3>
4>
6>
5>
7>
5>
5>________ running 'git clone ...'
Review URL: http://codereview.chromium.org/7101012

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@87542 0039d316-1c4b-4281-b951-d872f2087c98

On Windows "git clone url path/repo" does not create 'path' if it does
not exist. It fails with:

Fatal: could not create work tree dir 'path\repo'.: No such file or directory

this patch manually creates the subdir if it does not exist.
Review URL: http://codereview.chromium.org/7080063

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@87522 0039d316-1c4b-4281-b951-d872f2087c98

This change makes it possible to run 'git cl' from
a Command Prompt using only the auto-installed git
from depot_tools.  It is needed because in MSysGit,
'git cl' invokes 'git' which calls 'git-cl'.  While
'git-cl' is pulled from depot_tools (since it's in
PATH), depot_tools/python_bin is not in PATH, and
so we execute git_cl.py through our auto-installed
python.exe directly.

update_depot_tools is fixed so that if we find
the auto-installed svn and git in depot_tools, we
execute those directly, otherwise falling back to
calling them based on PATH.

In both git-cl and update_depot_tools, we only enable
this new behavior if uname in PATH reports a 'MINGW'
environment.  This should not trigger on any other
environment where uname exists, including Cygwin which
should report 'CYGWIN'.
Review URL: http://codereview.chromium.org/7020035

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@87510 0039d316-1c4b-4281-b951-d872f2087c98

url is pointing to a git repo, the name of the directory created on disk will not
contain the .git suffix.
Review URL: http://codereview.chromium.org/7104009

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@87492 0039d316-1c4b-4281-b951-d872f2087c98

correctly.  The current behavior was to call git clone with --no-checkout, which
did not create a working copy, and made the checkout unusable by the users.
Review URL: http://codereview.chromium.org/7104007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@87491 0039d316-1c4b-4281-b951-d872f2087c98

TEST=covered by gclient_smoketest.py
Review URL: http://codereview.chromium.org/7062029

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@87367 0039d316-1c4b-4281-b951-d872f2087c98

It needs to be parsed manually and assumes '=*' for property that do not specify
a value.

Add clearer message on failure like that by specifiying the command line.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7085022

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@87255 0039d316-1c4b-4281-b951-d872f2087c98

Add "git cl set_commit" command to set the flag more easily.
Add --commit to "git cl upload" to streamline workflow even more.
Continue conversion to Rietveld object.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7084037

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@87253 0039d316-1c4b-4281-b951-d872f2087c98