Commits · cc6f585f055ae696170b22f0e8db906d27afe636 · Linshizhi / Chromium_Depot_tools

11 Sep, 2019 1 commit

Revert "depot_tools: Bootstrap Python 3 on Linux/Mac" · cc6f585f

Edward Lesmes authored Sep 11, 2019

This reverts commit dbca865e.

Reason for revert:

Fails on Mac

$ gclient sync --with_branch_heads
awk: syntax error at source line 1
 context is
	match($0, >>>  /cpython3\/.*version:([.0-9a-zA-Z]+)/, <<<
awk: bailing out at source line 1
Could not extract Python 3 version from manifest.


Original change's description:
> depot_tools: Bootstrap Python 3 on Linux/Mac
> 
> This will make it possible for developers to execute depot_tools
> scripts using Python 3 in a known environment.
> 
> Bug: 1002153
> Change-Id: I5ff492a49d227c1b5876f49adba020f51a575bdd
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1762664
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Reviewed-by: Andrii Shyshkalov <tandrii@google.com>

TBR=iannucci@chromium.org,dpranke@chromium.org,tandrii@google.com,ehmaldonado@chromium.org

Change-Id: I8e03a9e22655491d0f8e8d214d04ba749c2ab8ab
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1002153
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1797197Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

cc6f585f

10 Sep, 2019 5 commits

Roll recipe dependencies (trivial). · d207f492

recipe-roller authored Sep 10, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/ecd717a98c19eef1e814d4070e9ac597e636dda6 [tempfile] Remove the deprecated tempfile module. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia5bae8b78f9599773f993f689e81a35809da8387
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1796126Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

d207f492

depot_tools: Bootstrap Python 3 on Linux/Mac · dbca865e

Edward Lemur authored Sep 10, 2019

This will make it possible for developers to execute depot_tools
scripts using Python 3 in a known environment.

Bug: 1002153
Change-Id: I5ff492a49d227c1b5876f49adba020f51a575bdd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1762664
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>

dbca865e

Roll recipe dependencies (trivial). · 0ac171b2

recipe-roller authored Sep 10, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/73d140fa3a72d4944c9d2fc60619df10000b3661 [testing] Have @placeholder_step_data take a name (olivernewman@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I6a7ff0047c2fbba664fdd1c3e572e98d8dcbd330
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1796618Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

0ac171b2

Add a COMPONENT entry to the OWNERS file. · 53a5a504

Dirk Pranke authored Sep 10, 2019

This is used to help people figure out where to file bugs against
code in the repo.

Change-Id: I0253359f703c67116785995b84ed5ff0bbcae28c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1796610Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>

53a5a504

fix_encoding: Decode bytestrings on Python 3 · d9c1c856

Raul Tambre authored Sep 10, 2019

Strings need to be passed to WriteConsoleW, otherwise an exception will be thrown:
<Unicode console <stdout>>.write: ArgumentError("argument 2: <class 'TypeError'>: wrong type")
Traceback (most recent call last):
  File "C:\Google\depot_tools\metrics.py", line 267, in print_notice_and_exit
    yield
  File "C:\Google\depot_tools\gclient.py", line 3156, in <module>
    sys.exit(main(sys.argv[1:]))
  File "C:\Google\depot_tools\gclient.py", line 3142, in main
    return dispatcher.execute(OptionParser(), argv)
  File "C:\Google\depot_tools\subcommand.py", line 252, in execute
    return command(parser, args[1:])
  File "C:\Google\depot_tools\gclient.py", line 2699, in CMDsync
    ret = client.RunOnDeps('update', args)
  File "C:\Google\depot_tools\gclient.py", line 1771, in RunOnDeps
    self.RunHooksRecursively(self._options, pm)
  File "C:\Google\depot_tools\gclient.py", line 1064, in RunHooksRecursively
    hook.run()
  File "C:\Google\depot_tools\gclient.py", line 255, in run
    gclient_utils.CheckCallAndFilter(
  File "C:\Google\depot_tools\gclient_utils.py", line 592, in CheckCallAndFilter
    stdout_write(in_byte)
  File "C:\Google\depot_tools\gclient_utils.py", line 375, in write
    return self._wrapped.write(out)
  File "C:\Google\depot_tools\gclient_utils.py", line 343, in write
    self._wrapped.write(out, *args, **kwargs)
  File "C:\Google\depot_tools\fix_encoding.py", line 224, in write
    retval = self._WriteConsoleW(
ctypes.ArgumentError: argument 2: <class 'TypeError'>: wrong type

Bug: 984182
Change-Id: Icffe0e0ea1fe2be5bc7607e32f58605d02f1f870
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1778746
Commit-Queue: Raul Tambre <raul@tambre.ee>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Auto-Submit: Raul Tambre <raul@tambre.ee>

d9c1c856

09 Sep, 2019 6 commits

Roll recipe dependencies (nontrivial). · e5641be5

recipe-roller authored Sep 09, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


Please review the expectation changes, and LGTM+CQ.


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/f362dc019e5cedc0e5ce334039a16afcbc95dcb4 Reland "[fileutil] Add support for recursive glob" (atyfto@google.com)


R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ic5776fa97845d6330ad64a2a9c8dcbfcc4afb79a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1793532
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

e5641be5

Roll recipe dependencies (trivial). · 0db145b6

recipe-roller authored Sep 09, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/1c10db5713e9c6fb790ce6ccf4771019f8ffbab2 Revert "[fileutil] Add support for recursive glob" (atyfto@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia7042c7a229cda72e992bc6f4e0530d9183d11fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1793529Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

0db145b6

gclient: Fix gclient Python 3 errors and add to presubmit tests. · ca879322

Edward Lemur authored Sep 09, 2019

Bug: 984182
Change-Id: I06e88f56aebf31c0c1ca495e6cbf03b6698b3676
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1790603Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

ca879322

git-cl: Remove unused auth configs. · 934836a6

Edward Lemur authored Sep 09, 2019

auth_config is a Rietveld thing, so it's not necessary
in most of the code, except for triggering try bots.

Bug: 1001756
Change-Id: I0f243a297b05a43a61b052ba75c5886556e81b4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1793018Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

934836a6

Roll recipe dependencies (trivial). · 1e4d70d1

recipe-roller authored Sep 09, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/737c0e6ce158d8c53486c82d72443a387a057e42 [fileutil] Add support for recursive glob (atyfto@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I8c0fb47e3026b7df5e2853abc7c2bf266b18bfc2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1791278Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

1e4d70d1

Handle GOMA_DISABLED more precisely · 6a860326

Bruce Dawson authored Sep 09, 2019

This updates the comments and code regarding GOMA_DISABLED to more
precisely match its behavior and therefore avoid confusion.

Bug: b/140312943
Change-Id: I6208de282bd5ebf1d88f98c1f905cfc626de792e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1786676
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>

6a860326

07 Sep, 2019 1 commit

gclient_utils: Fix bug in CheckCallAndFilter in Python 3. · efce0d1b

Edward Lemur authored Sep 07, 2019

Header was printed using sys.stdout, but the rest of the output was
printed using sys.stdout.buffer, causing the output to be written
before the header.

Bug: 984182
Change-Id: If6aaa05a579c3b0c73ce8ffe48f3a4e777fa16fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1790254
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@google.com>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>

efce0d1b

06 Sep, 2019 4 commits

depot_tools: Fix flaky gclient_test test. · 4ebfe464

Edward Lemur authored Sep 06, 2019

Dependencies are processed in order, so they don't have to be sorted.
target_os for each dependency is a set [1], so it should be sorted to avoid flaky failures.

[1] https://cs.chromium.org/chromium/tools/depot_tools/gclient.py?l=368

Bug: 984182
Change-Id: I3e84f3cb85f9cb1920b7abf7a45766f3a518f4c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1789278
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@google.com>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>

4ebfe464

Use value of --user as monorail email address if it is an email address · 711dc5e1

Peter K. Lee authored Sep 06, 2019

While fetching monorail issues, @chromium.org is appended to the --user
option even if the original --user option is already a email address
(e.g. user@google.com).

Change-Id: I2442f4ea977b2681a72271f7c20fabb1ceaa351c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1790222Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Commit-Queue: Peter Lee <pkl@chromium.org>

711dc5e1

Have autoninja use -d stats when NINJA_SUMMARIZE_BUILD=1 · b3b46a26

Bruce Dawson authored Sep 06, 2019

The NINJA_SUMMARIZE_BUILD already triggers two types of build
performance data - setting NINJA_STATUS to give more details during the
build and running post_build_ninja_summary.py after the build.

One of the most common causes of slow builds is when CreateProcess
becomes slow, usually due to anti-virus overhead. Neither of these
reports make this problem easily visible, but ninja -d stats does. In
particular the StartEdge data is an excellent summary of CreateProcess
timing. If the StartEdge average (avg) is more than about 6,000 us
(6.0 ms) it might be worth investigating why.

Therefore this change makes it so that autoninja.py adds -d stats to the
command line when NINJA_SUMMARIZE_BUILD is set to 1.

Change-Id: I1b6b990708c784a2cd71d153713b422f090775e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1788399Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>

b3b46a26

Roll recipe dependencies (trivial). · 208e343d

recipe-roller authored Sep 06, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/8fd8dc56140820b86ce0bda8c61a66021413c9d6 [led] Expose led run ID (olivernewman@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I86281bf1d492ed0b2e9f7115c9d98847f5254da9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1788726Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

208e343d

05 Sep, 2019 5 commits

Roll led to latest version · f1a8a4aa

Robert Iannucci authored Sep 05, 2019

423aa5860 [led] Set logdog prefix as led_run_id property
40c1ac5b5 [led] Set recipe input property for recipes source
d9cf01212 [led] When consolidating isolateds, skip empty isolate hashes.
838b3cb14 [led] Pull isolate consolidation out of GetSwarmingTask.
7a6c68c7a [led] Make edit-isolated orthogonal to edit-recipe-bundle.
8e8edcb4f Have led launch set OutputResultJSONPath kitchen argument
93e7d934e [led] Add the ability for led edit-isolated to take a transform program.
f5808de3a Fix many shadowed symbols
371e55885 Fix many misspellings
1cc5f65cf [led edit-isolated] Fix bug when inputsref is missing.

R=tandrii@chromium.org

Change-Id: I8bef431fe57f7331a8f5fc85e898916ee93fa9f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1788412
Commit-Queue: Andrii Shyshkalov <tandrii@google.com>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>

f1a8a4aa

Roll recipe dependencies (trivial). · 43ad4452

recipe-roller authored Sep 05, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/852662ebd96dfb039d8f8300991000da4ba69b93 [step] Improve docs on step.__call__ (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ide5b720ab158155c99aedbbd73032cb113ba8178
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1788413Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

43ad4452

Roll recipe dependencies (trivial). · 02b5e243

recipe-roller authored Sep 05, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/a45835b14a68ad2f3562ed0f74ae9c6e2ff293b0 Remove tricium module properties (garymm@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ide73bc8fd61920838bebaf5b4cae5ec9c441a9a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1788409Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

02b5e243

Roll recipe dependencies (trivial). · 1ef851a1

recipe-roller authored Sep 05, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/191385725c1237d40cde9054c2c92b7e3f0042e9 Add qyearsley to tricium recipe module OWNERS (qyearsley@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I6526ee6b0676f8c5a3b38e4513630dea1f505a5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1788407Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

1ef851a1

Roll recipe dependencies (trivial). · 60954f11

recipe-roller authored Sep 05, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/67d2df8c6bceac3c0efebcf023013945686ae4ff [tempfile] More helpful docs in terms of what to use instead. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I7b23f155684bf8810fda57c750dcdd9dd84765c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1788403Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

60954f11

04 Sep, 2019 3 commits

Roll recipe dependencies (trivial). · 624bf6e4

recipe-roller authored Sep 04, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/6fca1db109d6dcc1083a751c7fafa8095db0a009 Enable specifying test data in RecipeTestApi.test. (gbeaty@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib78bc7f9fb91ff5c688925c082a6256678c4655d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1785619Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

624bf6e4

git cl try: stop supporting '-m|--master'. · 426adc83

Andrii Shyshkalov authored Sep 04, 2019

Use "git cl try -B <bucket>" instead.

R=smut

Bug: 570733
Change-Id: Id5fedadede9fd8305e4567028ce4a4326d775cf5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1779545
Commit-Queue: Andrii Shyshkalov <tandrii@google.com>
Reviewed-by: smut <smut@google.com>

426adc83

Roll recipe dependencies (trivial). · 183971ca

recipe-roller authored Sep 04, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/54739722d50ec6e17c06238b5cafc7b8df828dfd [tricium] Type check comments early (garymm@google.com)
  https://crrev.com/a3870eec10769a883eebbc3a0a08592742e56f5b cq: update its proto's revision. (tandrii@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I673ed9615d225e3cebb3463142630c8e770bb1d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1783870Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

183971ca

03 Sep, 2019 4 commits

git-cl: Clean up a bit · f38bc179

Edward Lemur authored Sep 03, 2019

Change-Id: I93809da721d410090e7ceb140cf5d9c4bded3744
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1765838
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>

f38bc179

depot_tools: Run some tests on Python 3 on the bots. · a877ee62

Edward Lemur authored Sep 03, 2019

Bug: 984182
Change-Id: I0b7f1e3e056548a27a416c9b4078e54c9e5d60d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1769400
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@google.com>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>

a877ee62

Add ANGLE issue tracker to my_activity.py. · 1db68ea0

Jamie Madill authored Sep 03, 2019

Useful tool for perf for the ANGLE team.

Bug: None
Change-Id: I78c3b7d8a4e2a6d19f6b2ea2c8e6d67b2a4dc0af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1778979Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

1db68ea0

[git-cl] Lint and clean-up git-cl, test, and related modules · d9cbe7ad

Quinten Yearsley authored Sep 03, 2019

In this CL:
 - Clarify some comments.
 - Remove some unused imports.
 - Make some style more consistent (e.g. quotes, whitespace)

Tools used: pyflakes, flake8 (most warnings ignored)

Change-Id: Ibfb6733c8d844b3c75a7f50b4f3c1d43afabb0ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1773856Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>

d9cbe7ad

31 Aug, 2019 1 commit

OWNERS: add tandrii@google.com. · 355e97e3

Andrii Shyshkalov authored Aug 31, 2019

I'm now using tandrii@google.com by default.

Also remove hinoka@.

R=vadimsh, maruel

Change-Id: I9c74c36c44ac4b5c025354a463c41840d35cf9cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1779550
Commit-Queue: Andrii Shyshkalov <tandrii@google.com>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Auto-Submit: Andrii Shyshkalov <tandrii@google.com>

355e97e3

30 Aug, 2019 3 commits

[lucicfg] Bump lucicfg to v1.8.6. · 5aeddeb9

Vadim Shtayura authored Aug 30, 2019

This version can load external proto descriptors. No other significant changes.

TBR=tandrii@chromium.org, iannucci@chromium.org
BUG=986972

Change-Id: I26317512ffcee0a50e051032d30ec79bbd805644
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1778707
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Auto-Submit: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>

5aeddeb9

git cl: get rid of builders-map. · 7542437e

Andrii Shyshkalov authored Aug 30, 2019

Builders-map is finally no longer necessary.

R=smut
TBR=ehmaldonado

Bug: 570733
Change-Id: I05c3087c877fdccfd878bb9befff4fb77b92b26b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1779543
Commit-Queue: Andrii Shyshkalov <tandrii@google.com>
Reviewed-by: smut <smut@google.com>
Auto-Submit: Andrii Shyshkalov <tandrii@google.com>

7542437e

README.git-cl.md: Remove reference to Rietveld · 17016be9

Marc-Antoine Ruel authored Aug 30, 2019

R=tandrii@chromium.org

Bug: 770408
Change-Id: Iac1d63afb2f3a59a8299c8316bf7de576b6f6589
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1773971Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>

17016be9

28 Aug, 2019 2 commits

owners: add owners_rooted_at_file() · ee8d9ce8

Elly Fong-Jones authored Aug 28, 2019

This method allows retrieving the owners listed in a file, as well as those
transitively listed in files included by it. This change also adds a new test to
cover this method, which is just a wrapper for the existing
_read_just_the_owners() internal method.

Bug: None
Change-Id: Iee956f115d3846acf0ee0806451807b0aa96d2f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1773904Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>

ee8d9ce8

Roll recipe dependencies (trivial). · cea9f9db

recipe-roller authored Aug 28, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/9ca245a1dc39e1fe957a4c8fb1774b731bef5415 [json] Handle nonexistent JSON placeholder file (olivernewman@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Iaa31495e9daa4cb26ab1efcaa02d5691251aa227
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1774745Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

cea9f9db

27 Aug, 2019 2 commits

Roll recipe dependencies (trivial). · 217195ca

recipe-roller authored Aug 27, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/19c4fbe5a863665b045e2d510b7a368c18c46edb [swarming] Allow customizing test task ids. (mohrr@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Idd5cf39f26fd19a383253b157d0e59e7dff0781a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1773696Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

217195ca

Roll recipe dependencies (trivial). · 59099ed6

recipe-roller authored Aug 27, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/c76e28ff61f722e8f67f06531e0fc31daa768837 [swarming] Roll client (joshuaseaton@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Idef7bea5758c9ef3c4b592acaedefb9527610178
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1772662Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

59099ed6

26 Aug, 2019 1 commit

Roll recipe dependencies (trivial). · 0e5fff1a

recipe-roller authored Aug 26, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/8f799e486a93f7f8bcc13531403dc4435b5e7259 Roll swarming client (atyfto@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I6c15d7a7a361271912a80ed36e17a68a39a61f9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1769195Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

0e5fff1a

25 Aug, 2019 2 commits

pylint: add myself as an owner · 31f187e5

Mike Frysinger authored Aug 25, 2019

Change-Id: Iac5da55340acbec5d55d5fe4c416a7f1a8e962e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1770421Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>

31f187e5

pylintrc: disable score reports · ed485e19

Mike Frysinger authored Aug 25, 2019

Pylint-1.7+ include a score report by default at the end of every
module lint. We disable reports in general, so silence this too.

Bug: 866772
Change-Id: Ie3df44c80b90daa59e46c8fd37a949176c9b09a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1770420Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>

ed485e19