Commits · cb5442bf76b968a9407269636289e8b66df6fa99 · Linshizhi / Chromium_Depot_tools

22 Sep, 2009 4 commits

gclient_scm: add test for unsupported scm · cb5442bf

msb@chromium.org authored Sep 22, 2009

gclient_scm: use a map for deciding whether or not the scm is supported

gclient_scm: add a checks for unsupported scm and unimplemented method

git_scm: pull out svn code into SVNWrapper

gclient_scm: create a create_scm factory method

Use a factory method to abstract SCMWrapper creation. This method
will eventually return the correct subclass of SCMWrapper. Initially,
there will only be SVNWrapper.

Review URL: http://codereview.chromium.org/215022

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@26823 0039d316-1c4b-4281-b951-d872f2087c98

cb5442bf

I made git-try also find diffs in one extra gip sub-repository · 742eb52c

yaar@chromium.org authored Sep 22, 2009

and append them to the patch sent to the try bots. This is
very useful for chromium+webkit tries.

Review URL: http://codereview.chromium.org/212034

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@26817 0039d316-1c4b-4281-b951-d872f2087c98

742eb52c

Implement fixes requested in review http://codereview.chromium.org/215039 · 5a180bb8

maruel@chromium.org authored Sep 22, 2009

TBR=nsylvain
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/216044

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@26806 0039d316-1c4b-4281-b951-d872f2087c98

5a180bb8

Fix gclient unittests. · c13c5ff5

maruel@chromium.org authored Sep 22, 2009

BUG=none
TEST=unittests

Review URL: http://codereview.chromium.org/215039

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@26804 0039d316-1c4b-4281-b951-d872f2087c98

c13c5ff5

21 Sep, 2009 2 commits

Use svn update --revision BASE instead of svn revert. · aa3dd476

maruel@chromium.org authored Sep 21, 2009

svn revert is broken in too many ways to work around it. I just discovered --revision BASE and it does everything I need.

BUG=none
TEST=gclient revert ignores externals, work with switched directories, work with files with inconsistent line endings (sigh)

Review URL: http://codereview.chromium.org/209052

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@26707 0039d316-1c4b-4281-b951-d872f2087c98

aa3dd476

Fix gclient revert for external, switched and conflicted directories. · 754960e9

maruel@chromium.org authored Sep 21, 2009

TEST=gclient revert more stuff but stops reverting external directories
BUG=none

Review URL: http://codereview.chromium.org/208025


git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@26672 0039d316-1c4b-4281-b951-d872f2087c98

754960e9

18 Sep, 2009 3 commits

Revert "Use a factory method to abstract SCMWrapper creation." totally broke gclient. · 5e73b0cf

maruel@chromium.org authored Sep 18, 2009

TBR=msb
TEST=none
BUG=none

Review URL: http://codereview.chromium.org/208028


git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@26606 0039d316-1c4b-4281-b951-d872f2087c98

5e73b0cf

Use a factory method to abstract SCMWrapper creation. · 56237087

msb@chromium.org authored Sep 18, 2009

This method will eventually return the correct subclass of SCMWrapper. Initially, there will only be SVNWrapper.

gclient_scm: add test for unsupported scm

gclient_scm: make SCMWrapper constructor parameters non-optional

gclient_scm: add a checks for unsupported scm and unimplemented method

git_scm: pull out svn code into SVNWrapper

gclient_scm: create a create_scm factory method

TEST=
BUG=none

Review URL: http://codereview.chromium.org/216014

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@26602 0039d316-1c4b-4281-b951-d872f2087c98

56237087

gclient_scm: add test to catch bug fixed by r208010 · b75db515

msb@google.com authored Sep 18, 2009

Review URL: http://codereview.chromium.org/214017

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@26577 0039d316-1c4b-4281-b951-d872f2087c98

b75db515

17 Sep, 2009 9 commits

Fix a coding error that was introduced in 26423. · de754ac6

maruel@chromium.org authored Sep 17, 2009

"file_list = file_list or []" would create a new empty list when an empty list is passed as a parameter, ditching the output parameter.

TEST=hooks are now run on gclient sync
BUG=none

Review URL: http://codereview.chromium.org/208010

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@26461 0039d316-1c4b-4281-b951-d872f2087c98

de754ac6

Add a new test case for SCMWrapper.revert. · c2c78f7f

maruel@chromium.org authored Sep 17, 2009

Add a test case for the UnversionedUnexpected file code path.

TEST=This test case will catch the bug fixed by r26425.
BUG=none

Patch contributed by msb@

Review URL: http://codereview.chromium.org/214005


git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@26458 0039d316-1c4b-4281-b951-d872f2087c98

c2c78f7f

Fix PyChecker errors caused by r26423. · 167b9e63

maruel@chromium.org authored Sep 17, 2009

Patch contributed by msb@

TEST=unit test
BUG=none

Review url: http://codereview.chromium.org/213006


git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@26457 0039d316-1c4b-4281-b951-d872f2087c98

167b9e63

Fix git-try so that it modifies the ---/+++ headers for new files correctly. · 832179b7

johnnyg@chromium.org authored Sep 17, 2009

Review URL: http://codereview.chromium.org/213004 


git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@26452 0039d316-1c4b-4281-b951-d872f2087c98

832179b7

Add missing import from r26426. · 0d3c7a86

robertshield@google.com authored Sep 17, 2009

BUG=gcl try and gcl upload don't work
TBR=maruel

Review URL: http://codereview.chromium.org/207007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@26429 0039d316-1c4b-4281-b951-d872f2087c98

0d3c7a86

Fixing issue in which for large patches, files fail to revert. · df7aea45

bradnelson@google.com authored Sep 17, 2009

Flaw in loop logic, causes it to miss the occasional file.

BUG=None
TEST=None
TBR=maruel

Review URL: http://codereview.chromium.org/209008

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@26427 0039d316-1c4b-4281-b951-d872f2087c98

df7aea45

Fix for r26423 part 2. · d090099e

maruel@chromium.org authored Sep 17, 2009

TBR=brad
BUG=gcl try is broken
TEST=none

Review URL: http://codereview.chromium.org/215003


git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@26426 0039d316-1c4b-4281-b951-d872f2087c98

d090099e

Fixing errors in gclient on a gclient revert --nohooks on windows. · 8f9c69f5

bradnelson@google.com authored Sep 17, 2009

BUG=None
TEST=None
TBR=maruel

Review URL: http://codereview.chromium.org/213002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@26425 0039d316-1c4b-4281-b951-d872f2087c98

8f9c69f5

gclient: remove wildcard import from git_scm · 5f3eee3b

maruel@chromium.org authored Sep 17, 2009

Part of a larger refactoring to abstract SCM-specific bits.

presubmit_support, revert, gcl: modify to import gclient_scm and gclient_utils

Part of a larger refactoring to abstract SCM-specific bits.

revert, gcl: modify to import gclient_scm and gclient_utils

Part of a larger refactoring to abstract SCM-specific bits.

gclient: pull out SCM bits

Pulled out SCMWrapper into gcliet_scm.py as part of a larger refactoring to
abstract SCM-specific bits. Plan is to evenutally add git support.

Pulling out SCMWrapper also required pulling out utility functions into
a gclient_utility.py.

Patch contributed by msb@

TEST=none
BUG=none


git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@26423 0039d316-1c4b-4281-b951-d872f2087c98

5f3eee3b

15 Sep, 2009 2 commits

Mark depot_tools scripts as bash scripts. · 6df3334c

thestig@chromium.org authored Sep 15, 2009

BUG=13668
TEST=none
Review URL: http://codereview.chromium.org/203075

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@26262 0039d316-1c4b-4281-b951-d872f2087c98

6df3334c

Modify gcl.py so that lint ignores only webkit/api, and not webkit/* · a135e356

dpranke@google.com authored Sep 15, 2009

   R=pam
   TEST=none
   BUG=none

M    gcl.py



git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@26194 0039d316-1c4b-4281-b951-d872f2087c98

a135e356

11 Sep, 2009 2 commits

Making gcl upload do tryupload from the same place as gcl try. · 57e7855b

bradnelson@google.com authored Sep 11, 2009

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/200103

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@26044 0039d316-1c4b-4281-b951-d872f2087c98

57e7855b

This adds a feature to gclient to allow the (optional) specification of the · df2d5905

gspencer@google.com authored Sep 11, 2009

name of the top level "DEPS" file of a solution from within the .gclient spec.

This allows users to edit their gclient once and use a different (perhaps
experimental) DEPS file instead of the traditionally named "DEPS".

Review URL: http://codereview.chromium.org/203040

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@26031 0039d316-1c4b-4281-b951-d872f2087c98

df2d5905

10 Sep, 2009 1 commit

Adding a project selection option to gcl. · 833b2270

bradnelson@google.com authored Sep 10, 2009

Defaulting to a value in codereview.settings

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/200078

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@25886 0039d316-1c4b-4281-b951-d872f2087c98

833b2270

09 Sep, 2009 2 commits

Report computation time before showing a prompt, so the response time · ed9a0833

pam@chromium.org authored Sep 09, 2009

isn't included in the calculation.

BUG=none
TEST=submit change with presubmit warning, note reported time

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@25806 0039d316-1c4b-4281-b951-d872f2087c98

ed9a0833

Add setlocal so {cpplin,gcl}.bat don't repeatedly add \depot_tools to %PATH%. · b671b223

sgk@google.com authored Sep 09, 2009

Review URL: http://codereview.chromium.org/201062

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@25751 0039d316-1c4b-4281-b951-d872f2087c98

b671b223

04 Sep, 2009 1 commit

Added "gclient pack" subcommand, which generates a patch relative to · ab318594

kbr@google.com authored Sep 04, 2009

the root of the source tree. It is similar to "gclient diff", and
shares much of the implementation, but it seems that developers may
want the semantics of each in different situations, which is why it is
being added as a new command.

Generalized SubprocessCallAndCapture into SubprocessCallAndFilter.
Added RunSVNAndFilterOutput; changed RunSVNAndGetFileList to use it.
Fixed problem in presubmit_canned_checks.py where it was not working
on Windows. Updated unit tests for gclient.

Review URL: http://codereview.chromium.org/193004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@25410 0039d316-1c4b-4281-b951-d872f2087c98

ab318594

02 Sep, 2009 2 commits

Change directory to repository root before running CheckSvnModifiedDirectories. · 6bd3170a

thestig@chromium.org authored Sep 02, 2009

Review URL: http://codereview.chromium.org/191002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@25270 0039d316-1c4b-4281-b951-d872f2087c98

6bd3170a

Unbreak `gcl try` if EMAIL_ADDRESS is not set. · 02701618

thakis@chromium.org authored Sep 02, 2009

Review URL: http://codereview.chromium.org/172099

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@25151 0039d316-1c4b-4281-b951-d872f2087c98

02701618

01 Sep, 2009 3 commits

Make git try work over svn. · 59ad6c72

thakis@chromium.org authored Sep 01, 2009

Codereview URL: http://codereview.appspot.com/110134


git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@25111 0039d316-1c4b-4281-b951-d872f2087c98

59ad6c72

Add licensing header to git-try. · 6f943c2c

chase@chromium.org authored Sep 01, 2009

TBR=maruel
Review URL: http://codereview.chromium.org/177047

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@24994 0039d316-1c4b-4281-b951-d872f2087c98

6f943c2c

Add script to create a local Chromium git repository. · 5ef7f344

chase@chromium.org authored Sep 01, 2009

BUG=none
TEST=creates a working Chromium git repository in src
Review URL: http://codereview.chromium.org/173599

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@24991 0039d316-1c4b-4281-b951-d872f2087c98

5ef7f344

29 Aug, 2009 1 commit

git-try: When -r isn't specified, let the try server decide the revision. · 4e633656

mattm@chromium.org authored Aug 29, 2009

Review URL: http://codereview.chromium.org/173446

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@24848 0039d316-1c4b-4281-b951-d872f2087c98

4e633656

28 Aug, 2009 2 commits

Enforce --force when running gclient runhooks · 5df6a463

maruel@chromium.org authored Aug 28, 2009

Review URL: http://codereview.chromium.org/173174


git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@24761 0039d316-1c4b-4281-b951-d872f2087c98

5df6a463

Add *.cfg to git-gs, buildbot configuration files. · 8663fe85

maruel@chromium.org authored Aug 28, 2009


git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@24757 0039d316-1c4b-4281-b951-d872f2087c98

8663fe85

25 Aug, 2009 1 commit

git-try: Use trychange library for HTTP submits. · b0e621f3

chase@chromium.org authored Aug 25, 2009

Make git-try use trychange for both SVN and HTTP try
server submits.  Simplifies git-try and reduces chance
of differences in behavior between SVN and HTTP try
job submits.

Exit early if the checkout's configured email address
does not pass validation.

Simplify trychange import.

BUG=none
TEST=git-try submits a job to the try server
Review URL: http://codereview.chromium.org/173394

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@24315 0039d316-1c4b-4281-b951-d872f2087c98

b0e621f3

24 Aug, 2009 1 commit

Treat .txt files as 'source' files (to enforce LF and line length) · d59982a1

maruel@chromium.org authored Aug 24, 2009

Review URL: http://codereview.chromium.org/174210


git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@24100 0039d316-1c4b-4281-b951-d872f2087c98

d59982a1

22 Aug, 2009 3 commits

Update git-try to find trychange after move. · dc54601f

chase@chromium.org authored Aug 22, 2009

TBR=maruel
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/173249

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@24064 0039d316-1c4b-4281-b951-d872f2087c98

dc54601f

Replace git-try stub with actual git-try script. · cabf2adf

chase@chromium.org authored Aug 22, 2009

BUG=none
TEST=none
TBR=maruel
Review URL: http://codereview.chromium.org/173246

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@24060 0039d316-1c4b-4281-b951-d872f2087c98

cabf2adf

Add 'time' to list of actual members. · 0e433add

chase@chromium.org authored Aug 22, 2009

This fixes the presubmit unit test.

BUG=none
TEST=presubmit tests pass
Review URL: http://codereview.chromium.org/173245

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@24059 0039d316-1c4b-4281-b951-d872f2087c98

0e433add

21 Aug, 2009 1 commit

Fix trychange.py --host and --port to work as expected · 35663168

mark@chromium.org authored Aug 21, 2009

Review URL: http://codereview.chromium.org/174244

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@23999 0039d316-1c4b-4281-b951-d872f2087c98

35663168