- 06 May, 2019 1 commit
-
-
Raul Tambre authored
Ran "2to3 -w -n -f print ./" and manually added imports. Ran "^\s*print " and "\s+print " to find batch/shell scripts, comments and the like with embedded code, and updated them manually. Also manually added imports to files, which used print as a function, but were missing the import. The scripts still work with Python 2. There are no intended behaviour changes. Bug: 942522 Change-Id: Id777e4d4df4adcdfdab1b18bde89f235ef491b9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1595684Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Auto-Submit: Raul Tambre <raul@tambre.ee>
-
- 12 Dec, 2017 2 commits
-
-
Aaron Gable authored
This is a reland of 9219d356 The original was reverted due to a typo (core,quotePath instead of core.quotePath). This version is fixed. Original change's description: > Use core.quotePath=false when git is listing files > > This prevents git from putting quotes around some file names > (those that have astral-plane characters) and not around others. > > R=maruel > > Bug: 792302 > > Change-Id: I3b6a6b36c4720116de811b40177b59aa25c263db > Reviewed-on: https://chromium-review.googlesource.com/815454 > Commit-Queue: Aaron Gable <agable@chromium.org> > Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> Bug: 792302 Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: build_limited_scripts_slave Change-Id: I28d2260948aaf63bd865888c2f60e4cdee9aea48 Reviewed-on: https://chromium-review.googlesource.com/822990 Commit-Queue: Aaron Gable <agable@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org>
-
Robbie Iannucci authored
This reverts commit 9219d356. Reason for revert: unfortunately this says "core,quotePath" and since it includes recipe changes, we need something that the roller can munch on :( Original change's description: > Use core.quotePath=false when git is listing files > > This prevents git from putting quotes around some file names > (those that have astral-plane characters) and not around others. > > R=maruel > > Bug: 792302 > Recipe-Nontrivial-Roll: build > Recipe-Nontrivial-Roll: build_limited_scripts_slave > Change-Id: I3b6a6b36c4720116de811b40177b59aa25c263db > Reviewed-on: https://chromium-review.googlesource.com/815454 > Commit-Queue: Aaron Gable <agable@chromium.org> > Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> TBR=maruel@chromium.org,agable@chromium.org Change-Id: I226388f19024403240a1443eb2b878b9293220e1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 792302 Reviewed-on: https://chromium-review.googlesource.com/821671Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
-
- 11 Dec, 2017 1 commit
-
-
Aaron Gable authored
This prevents git from putting quotes around some file names (those that have astral-plane characters) and not around others. R=maruel Bug: 792302 Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: build_limited_scripts_slave Change-Id: I3b6a6b36c4720116de811b40177b59aa25c263db Reviewed-on: https://chromium-review.googlesource.com/815454 Commit-Queue: Aaron Gable <agable@chromium.org> Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org>
-
- 29 Jun, 2017 1 commit
-
-
Aaron Gable authored
R=avayvod Bug: 738116 Change-Id: Idd1ea46dfd876b800868bba9cc981a4093e1c809 Reviewed-on: https://chromium-review.googlesource.com/556302Reviewed-by:
Andrew Bonventre <andybons@chromium.org> Commit-Queue: Andrew Bonventre <andybons@chromium.org>
-
- 27 Apr, 2017 1 commit
-
-
Aaron Gable authored
When uploading to either Rietveld or Gerrit, this will cause git-cl to add the appropriate reviewers to the cherry-pick review, so they're aware the change is being copied to the release branch. When uploading to Gerrit, this will also cause git-cl to set the Code-Review+1 bit, allowing the CL to be landed R=tandrii@chromium.org Bug: 714720 Change-Id: Ie04e2657a91e4345796ac2200c0115fb18e460a1 Reviewed-on: https://chromium-review.googlesource.com/486961 Commit-Queue: Aaron Gable <agable@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org>
-
- 21 Dec, 2016 1 commit
-
-
agable authored
R=iannucci@chromium.org BUG=475320 Review-Url: https://codereview.chromium.org/2354313003
-
- 16 Jun, 2016 1 commit
-
-
scottmg authored
git update-index would fail on long command lines when setting up a resolve. Instead of passing all the files names on the command line, pass them through --stdin and a file handle. BUG=598808 Review-Url: https://codereview.chromium.org/2067653002
-
- 27 Jan, 2016 1 commit
-
-
rob@robwu.nl authored
git rev-parse --git-dir returns a relative path, e.g. ".git". This should be resolved relative to the cwd of the git command instead of the current working dir. The cwd of the git command is set to _parent_repo (=the absolute path after resolving --parent_checkout), so use that. TEST=The following completes without errors. $ cd /tmp $ git init somegitrepo $ cd somegitrepo $ git drover --branch [branch] --cherry-pick [hash] -v --dry-run --parent_checkout /path/to/src $ cd /path/to/src $ git drover --branch [branch] --cherry-pick [hash] -v --dry-run Review URL: https://codereview.chromium.org/1640233002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298416 0039d316-1c4b-4281-b951-d872f2087c98
-
- 03 Nov, 2015 1 commit
-
-
sammc@chromium.org authored
Currently, git-drover gives up and cleans up if the cherry-pick fails. This change allows the user to manually resolve conflicts when using git-drover. BUG=404755 Review URL: https://codereview.chromium.org/1397313002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@297429 0039d316-1c4b-4281-b951-d872f2087c98
-
- 07 Oct, 2015 1 commit
-
-
scottmg@chromium.org authored
BUG=404755 R=sammc@chromium.org Review URL: https://codereview.chromium.org/1387223002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@297055 0039d316-1c4b-4281-b951-d872f2087c98
-
- 29 Sep, 2015 1 commit
-
-
sammc@chromium.org authored
This uses the same trick as git-new-workdir to reuse an existing git checkout without interfering with it. However, this makes it only usable on platforms where os.symlink exists. BUG=404755 Review URL: https://codereview.chromium.org/1342383002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296920 0039d316-1c4b-4281-b951-d872f2087c98
-