Commits · c98c0c52498632481f0073f55b4ef2918d0b5d63 · Linshizhi / Chromium_Depot_tools

06 Apr, 2011 5 commits

Make more tests pass on Windows. · c98c0c52

maruel@chromium.org authored Apr 06, 2011

Also fix a few issues found along the way.

Tests had regressed a lot. Add a lot of tweaks to make most test pass.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/6792060

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80618 0039d316-1c4b-4281-b951-d872f2087c98

c98c0c52

Convert PRESUBMIT.py to use check_output() instead of Popen(). · ccbb781a

maruel@chromium.org authored Apr 06, 2011

Fix execution on windows.

Remove more code.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/6792054

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80617 0039d316-1c4b-4281-b951-d872f2087c98

ccbb781a

Use check_call() instead of Popen() for canned checks. · 0e766050

maruel@chromium.org authored Apr 06, 2011

This removes a significant amount of code.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/6693100

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80616 0039d316-1c4b-4281-b951-d872f2087c98

0e766050

Use subprocess2 so check_call() can be use consistently in presubmit checks. · 84f4fe37

maruel@chromium.org authored Apr 06, 2011

Do s/Popen+communicate/check_call/ replacement in a later change in case it
breaks something.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/6794057

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80615 0039d316-1c4b-4281-b951-d872f2087c98

84f4fe37

Fix automatic shell detection, the check was reversed · f08b09c2

maruel@chromium.org authored Apr 06, 2011

Improved tests and added regression test.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/6793044

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80614 0039d316-1c4b-4281-b951-d872f2087c98

f08b09c2

05 Apr, 2011 3 commits

Add subprocess2 unit tests · eba4022d

maruel@chromium.org authored Apr 05, 2011

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/6693078

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80454 0039d316-1c4b-4281-b951-d872f2087c98

eba4022d

Convert drover.py to subprocess2. · 98385dd5

maruel@chromium.org authored Apr 05, 2011

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/6792029

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80453 0039d316-1c4b-4281-b951-d872f2087c98

98385dd5

Fix "local variable 'url' referenced before assignment" error. · e8c28623

maruel@chromium.org authored Apr 05, 2011

TBR=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/6792050

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80452 0039d316-1c4b-4281-b951-d872f2087c98

e8c28623

04 Apr, 2011 5 commits

Update svn:ignore · 3ed3e5e4

maruel@chromium.org authored Apr 04, 2011

NO CODE CHANGE.


git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80358 0039d316-1c4b-4281-b951-d872f2087c98

3ed3e5e4

Move patch.py and rietveld.py from commit-queue. · b3727a36

maruel@chromium.org authored Apr 04, 2011

It will be used for:
- git cl patch so binary files can be patched
- try jobs instead of doing a curl <url> | patch

BUG=
TEST=

Review URL: http://codereview.chromium.org/6792028

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80355 0039d316-1c4b-4281-b951-d872f2087c98

b3727a36

First pass to transition away for gclient_utils.Error and gclient_utils.CheckedCallError. · 31cb48a4

maruel@chromium.org authored Apr 04, 2011

Make sure every site that catches gclient_utils.Error also catch
subprocess2.CalledProcessError.

BUG=
TEST=

Review URL: http://codereview.chromium.org/6691034

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80339 0039d316-1c4b-4281-b951-d872f2087c98

31cb48a4

upload.py has a raw_input() that keeps on throwing crap, try to trap it as much as possible. · 9ce0dff6

maruel@chromium.org authored Apr 04, 2011

Otherwise I get useless stack traces and the user too.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/6794020

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80338 0039d316-1c4b-4281-b951-d872f2087c98

9ce0dff6

gcl delete <non-existent change> won't throw an exception anymore · a2d7edf8

maruel@chromium.org authored Apr 04, 2011

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/6735029

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80337 0039d316-1c4b-4281-b951-d872f2087c98

a2d7edf8

01 Apr, 2011 9 commits

Revert r80216 "Reapply r79779: "Removed gclient_utils.Popen() and use subprocess2's ..."" · 58ef297b

maruel@chromium.org authored Apr 01, 2011

Horked windows slaves this time.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/6689023

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80220 0039d316-1c4b-4281-b951-d872f2087c98

58ef297b

Reapply r79779: "Removed gclient_utils.Popen() and use subprocess2's version instead." · 93ef4107

maruel@chromium.org authored Apr 01, 2011

It should be fine now that I've fixed python2.5 compatilibity issues in subprocess2.py.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/6759074

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80216 0039d316-1c4b-4281-b951-d872f2087c98

93ef4107

Add a warning if the current version of python is not 2.5 · 725f1c3b

maruel@chromium.org authored Apr 01, 2011

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/6791018

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80212 0039d316-1c4b-4281-b951-d872f2087c98

725f1c3b

make git_cl lint cleanly on mac. I look forward to the day when json can · fe79c31e

dpranke@chromium.org authored Apr 01, 2011

be assumed to be installed.

R=maruel@chromium.org

Review URL: http://codereview.chromium.org/6771041

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80209 0039d316-1c4b-4281-b951-d872f2087c98

fe79c31e

Wrap raw_input() around a try/except to reduce the number of false-positive in breakpad · 90541738

maruel@chromium.org authored Apr 01, 2011

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/6706007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80182 0039d316-1c4b-4281-b951-d872f2087c98

90541738

Update docstrings and add VOID support · 421982fe

maruel@chromium.org authored Apr 01, 2011

And update local_rietveld to use it.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/6706022

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80179 0039d316-1c4b-4281-b951-d872f2087c98

421982fe

Add fix_encoding to git-cl too! · 6f09cd99

maruel@chromium.org authored Apr 01, 2011

Otherwise tree status with non-ascii characters could throw at the console.

TBR=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/6788013

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80173 0039d316-1c4b-4281-b951-d872f2087c98

6f09cd99

Switch half of PRESUBMIT.py to RunUnitTestsInDirectory() · 3c9f7cae

maruel@chromium.org authored Apr 01, 2011

Not changed git-cl integration tests because they assume the current directory
is ./tests/

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/6690046

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80156 0039d316-1c4b-4281-b951-d872f2087c98

3c9f7cae

Add subprocess.Popen().kill() to python 2.5. · fb3d3245

maruel@chromium.org authored Apr 01, 2011

Move code in tests/fake_repos.py to subprocess2.py.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/6783022

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80152 0039d316-1c4b-4281-b951-d872f2087c98

fb3d3245

31 Mar, 2011 6 commits

Add more python 2.5 compatibility. · 45d8db04

maruel@chromium.org authored Mar 31, 2011

Makes all the tests runnable on python 2.5.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/6690034

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80068 0039d316-1c4b-4281-b951-d872f2087c98

45d8db04

Update upload.py to r690 and include fix for "support for git mv in rietveld" · df3302b3

maruel@chromium.org authored Mar 31, 2011

I just don't want to wait for http://codereview.appspot.com/4333051 to be committed.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/6728033

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80045 0039d316-1c4b-4281-b951-d872f2087c98

df3302b3

Make owners check optional. · d57771d0

bradnelson@google.com authored Mar 31, 2011

BUG=None
TEST=None
R=thomasvl@google.com
Review URL: http://codereview.chromium.org/6728031

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80043 0039d316-1c4b-4281-b951-d872f2087c98

d57771d0

Add RunUnitTests() and RunUnitTestsInDirectory() canned checks. · 2b5ce56a

maruel@chromium.org authored Mar 31, 2011

Deprecate RunPythonUnitTests() since it is a bit awkward.

Add os_listdir, os_walk and platform to InputApi.

GOAL=Slowly adds python 2.5 support for unit tests
BUG=none
TEST=new unit test
R=dpranke@chromium.org

Review URL: http://codereview.chromium.org/6778027

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80009 0039d316-1c4b-4281-b951-d872f2087c98

2b5ce56a

merge in fixes for python 2.5 · e6a4ab30

dpranke@chromium.org authored Mar 31, 2011

R=maruel@chromium.org

Review URL: http://codereview.chromium.org/6740012

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@79942 0039d316-1c4b-4281-b951-d872f2087c98

e6a4ab30

Fix simplejson import for Mac OSX 10.5 users · b35c00ce

maruel@chromium.org authored Mar 31, 2011

BUG=none
TEST=Poor mac users should be able to use git-cl back again.

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@79932 0039d316-1c4b-4281-b951-d872f2087c98

b35c00ce

30 Mar, 2011 2 commits

Revert r79779: "Removed gclient_utils.Popen() and use subprocess2's version instead." · 5a376ed3
maruel@chromium.org authored Mar 30, 2011
```
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@79781 0039d316-1c4b-4281-b951-d872f2087c98
```
5a376ed3

Removed gclient_utils.Popen() and use subprocess2's version instead. · 24254940

maruel@chromium.org authored Mar 30, 2011

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/6770028

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@79779 0039d316-1c4b-4281-b951-d872f2087c98

24254940

29 Mar, 2011 4 commits

Make git cl patch authenticate the request for the diff. · e77ebbf8

maruel@chromium.org authored Mar 29, 2011

This make possible to apply private issues or rietveld instances requiring
authentication.

Forces simplejson to be installed or uses python 2.6's json

Make local_rietveld.py usable standalone.

R=dpranke@chromium.org
TEST=unit tests + manual testing, owners.sh is currentl broken, unrelated to this change.
BUG=none

Review URL: http://codereview.chromium.org/6721031

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@79734 0039d316-1c4b-4281-b951-d872f2087c98

e77ebbf8

Move git_cl back into depot_tools. · 2a74d37e

maruel@chromium.org authored Mar 29, 2011

Remove git_cl_hooks.py since it's now unnecessary.

BUG=
TEST=

Review URL: http://codereview.chromium.org/6758001

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@79715 0039d316-1c4b-4281-b951-d872f2087c98

2a74d37e

Disable owners.sh for now since it's known to fail. · de568681

maruel@chromium.org authored Mar 29, 2011

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/6755003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@79682 0039d316-1c4b-4281-b951-d872f2087c98

de568681

Making license presubmit check more verbose. · 393460b7

bradnelson@google.com authored Mar 29, 2011

BUG=None
TEST=None
R=dpranke@chromium.org
Review URL: http://codereview.chromium.org/6768006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@79644 0039d316-1c4b-4281-b951-d872f2087c98

393460b7

28 Mar, 2011 4 commits

add myself to watchlist · 711a70bf

dpranke@chromium.org authored Mar 28, 2011

Review URL: http://codereview.chromium.org/6757013

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@79597 0039d316-1c4b-4281-b951-d872f2087c98

711a70bf

Relax |const NSClass*| PRESUBMIT check to not detect false positives when · edf744da

mark@chromium.org authored Mar 28, 2011

encountering Foundation types that are not id-derived, including NSPoint, 
NSRange, NSRect, and NSSize. 

BUG=77438
TEST=Modify chrome/browser/renderer_host/render_widget_host_view_mac.mm
Review URL: http://codereview.chromium.org/6755007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@79564 0039d316-1c4b-4281-b951-d872f2087c98

edf744da

Align local_rietveld.py at +2 like the rest of the code. · 8062cc3a

maruel@chromium.org authored Mar 28, 2011

No behavior change.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/6757002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@79522 0039d316-1c4b-4281-b951-d872f2087c98

8062cc3a

Update rietveld to r681. · 03cc6ee9

maruel@chromium.org authored Mar 28, 2011

Remove django since it's not necessary anymore, rietveld now uses django 1.2 and
it's included in GAE SDK.

Review URL: http://codereview.chromium.org/6749025

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@79521 0039d316-1c4b-4281-b951-d872f2087c98

03cc6ee9

25 Mar, 2011 2 commits

Let the unittest avoid the upstream change. · d6f89d86

thomasvl@chromium.org authored Mar 25, 2011

Review URL: http://codereview.chromium.org/6696080

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@79452 0039d316-1c4b-4281-b951-d872f2087c98

d6f89d86

Copy subprocess2 from commit-queue so it can be reused here. · 4860f052

maruel@chromium.org authored Mar 25, 2011

A lot of functions in gclient_utils and elsewhere will be deleted.

Not used yet, committed as a separate change so it can be rubberstamped. :)

R=dpranke@chromium.org
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6711080

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@79449 0039d316-1c4b-4281-b951-d872f2087c98

4860f052