Commits · c07c59ddb0be93cecac66bb37a60b87670d246ab · Linshizhi / Chromium_Depot_tools

22 Jul, 2020 1 commit

Vadim Shtayura authored Jul 22, 2020

Two notable changes:
* luci.builder(experiments={...}, ...)
* When realms are enabled, scheduler configs include `realm` field.

R=tandrii@chromium.org
CC=yulanlin@google.com

Change-Id: I17e773bdd33058b71b64c7222f4e8471bf33e83d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2311565Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>

c07c59dd

21 Jul, 2020 2 commits

Decode "git cl" error messages to avoid printing Python bytes · 594fd332

Alan Cutter authored Jul 21, 2020

We were not decoding the stdout bytes before printing them when git
commands returned an error status. This CL fixes that.

Before:
Command "git cherry-pick FETCH_HEAD" failed.
b'Auto-merging chrome/browser/ui/web_applications/app_browser_controller.cc\nAuto-merging chrome/browser/ui/views/frame/opaque_browser_frame_view_browsertest.cc\nCONFLICT (content): Merge conflict in chrome/browser/ui/views/frame/opaque_browser_frame_view_browsertest.cc\nAuto-merging chrome/browser/ui/views/frame/browser_non_client_frame_view.cc\nAuto-merging chrome/browser/ui/views/frame/browser_frame.h\nAuto-merging chrome/browser/ui/views/frame/browser_frame.cc\n'

After:
Command "git cherry-pick FETCH_HEAD" failed.
Auto-merging chrome/browser/ui/web_applications/app_browser_controller.cc
Auto-merging chrome/browser/ui/views/frame/opaque_browser_frame_view_browsertest.cc
CONFLICT (content): Merge conflict in chrome/browser/ui/views/frame/opaque_browser_frame_view_browsertest.cc
Auto-merging chrome/browser/ui/views/frame/browser_non_client_frame_view.cc
Auto-merging chrome/browser/ui/views/frame/browser_frame.h
Auto-merging chrome/browser/ui/views/frame/browser_frame.cc
Change-Id: I162e666ca9f3a70259e6178d2e6d3b72f15b1f7b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2310016
Auto-Submit: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

594fd332

Revert "bot_update: Refactor branch to detach and checkout." · 720e010b

Edward Lesmes authored Jul 21, 2020

This reverts commit b99e61c5.

Reason for revert:
Doesn't work for refs/branch-heads/*

Original change's description:
> bot_update: Refactor branch to detach and checkout.
> 
> Refactor _git_checkout to use information from
> get_target_branch_and_revision to know what branch to checkout after
> cloning.
> 
> Bug: 1104182
> Change-Id: Ib3ba57ca0b6803f172b85121c2a4b123f17bfb8c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2303291
> Reviewed-by: Josip Sokcevic <sokcevic@google.com>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

TBR=ehmaldonado@chromium.org,infra-scoped@luci-project-accounts.iam.gserviceaccount.com,sokcevic@google.com

Change-Id: If51423df99fd9c164f8e42e0220ee2d9bc2a39f6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1104182
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2310293Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

720e010b

20 Jul, 2020 6 commits

Preliminary changes to git cl and presubmit_support · 9949ab7a

Saagar Sanghavi authored Jul 20, 2020

Added an rdb wrapper and use it to time CheckChangeOn{Commit, Upload} from every PRESUBMIT.py file, then reports the results to ResultSink.

Bug: http://crbug.com/1107588

Change-Id: I9bc8a18ba615a76f3e0611eae5b2c4adc5924276
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2242097
Commit-Queue: Saagar Sanghavi <saagarsanghavi@google.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Garrett Beaty <gbeaty@chromium.org>

9949ab7a

bot_update: Refactor branch to detach and checkout. · b99e61c5

Edward Lesmes authored Jul 20, 2020

Refactor _git_checkout to use information from
get_target_branch_and_revision to know what branch to checkout after
cloning.

Bug: 1104182
Change-Id: Ib3ba57ca0b6803f172b85121c2a4b123f17bfb8c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2303291Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

b99e61c5

gclient: deprecated use_relative_hooks · 801c2021

Corentin Wallez authored Jul 20, 2020

And merge it in use_relative_paths. In all Chromium repos,
use_relative_hooks is True iff:

 - use_relative_paths is True, and
 - there is at least one hook

It makes sense that you'd want to use relative hooks if you use relative
paths so this CL merges both flags into use_relative_paths.

Bug: chromium:1107325
Change-Id: I0fe40eba1e1c61be26c812c7ca4329efb72c7f90
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2306795
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Auto-Submit: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

801c2021

Roll recipe dependencies (trivial). · b655a28e

recipe-roller authored Jul 20, 2020

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/79f951ca7bfd9a119dbe0cb27a51bf78493836bd
  79f951c (iannucci@chromium.org)
      [raw_io] Reland: Make output_dir lazy.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I928c1bb09fc0b453e2bc8c3151a7907802a725c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2308250Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

b655a28e

git-cl: Fix "git cl tree" issues with Python 3. · 8b4eeffd

Daniel McArdle authored Jul 20, 2020

* First, we were treating the return value of HTTPResponse.read() as a
  string when it is really a byte string.

* Second, the urlparse library was renamed to urllib.parse in Python 3,
  so I made the appropriate substitution.

Change-Id: I0b23716e990eca8ddf77742f378ab54eda3d3717
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2307509Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Dan McArdle <dmcardle@chromium.org>

8b4eeffd

Roll out new goma client binary VERSION=203 · 39d31783

Yoshisato Yanagisawa authored Jul 20, 2020

Bug: b/159183955
Change-Id: I7cfd3dd84bb9be0c9d5a57aa9886cddacdfec593
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2306989Reviewed-by: Ye Kuang <yekuang@google.com>
Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org>

39d31783

18 Jul, 2020 1 commit

Roll recipe dependencies (trivial). · 642be1d2

recipe-roller authored Jul 18, 2020

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/0dbd020e420e02fc734492071693cb0c2cc62667
  0dbd020 (ddoman@chromium.org)
      [swarming] integrate TaskRequest with resultdb and realm

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I61c828df74eea4f15a1eb2c1d35d961179088e99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2305450Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

642be1d2

17 Jul, 2020 2 commits

Roll recipe dependencies (trivial). · 4bbdfa58

recipe-roller authored Jul 17, 2020

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/742a272b323d92aa97865daa3b806a8ee665eeb2
742a272 (bpastene@chromium.org)
Revert "[raw_io] Make output_dir lazy."

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I998005b279006438cf456ae3a7276cadde24855a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2303884Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

4bbdfa58

Roll recipe dependencies (trivial). · 320ceb93

recipe-roller authored Jul 17, 2020

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/c1b7a3041fc0dedb1ee46bcb206e0b048ce7a20f
  c1b7a30 (iannucci@chromium.org)
      [raw_io] Make output_dir lazy.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id287a3112147a80e5478bb41cb5e71baa08503dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2303880Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

320ceb93

16 Jul, 2020 3 commits

[dirmd] Roll to the latest version · 233589f2

Nodir Turakulov authored Jul 16, 2020

Latest dirmd tool to 8dba585435d2d50d5c9bfc9a347580ff275456d5

Bug: 1106176
Change-Id: Ia6939ef3b1d7342c3207148bd20b4619e36a61cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2303639
Auto-Submit: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

233589f2

Revert "Roll git to 2.27.0 on Windows" · 78a6bf63

Sébastien Marchand authored Jul 16, 2020

This reverts commit 5fcb4853.

Reason for revert: Broke Git on my gWindows machine, it fails for many Git operations with the following error message:

git pull                                                                                                    
  2 [main] sh (54140) shared_info::initialize: size of shared memory region changed from 45944 to 38776
fatal: Could not read from remote repository

I've confirmed that reverting this CL fixes the problem.

Original change's description:
> Roll git to 2.27.0 on Windows
> 
> Bug: 1070694
> Change-Id: I37af08864661ca92116776569b9285ceb6ff465c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2300204
> Reviewed-by: Josip Sokcevic <sokcevic@google.com>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

TBR=ehmaldonado@chromium.org,apolito@google.com,infra-scoped@luci-project-accounts.iam.gserviceaccount.com,sokcevic@google.com

Change-Id: I4d27eaa1b17cb056635dceed5ad1562debfc2e06
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1070694
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2302489Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>

78a6bf63

Roll recipe dependencies (trivial). · e9e8c01f

recipe-roller authored Jul 16, 2020

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/faf8628f68d07cb3cab497eaa207b0184099b304
faf8628 (tikuta@chromium.org)
update isolated client revision

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib80020f86a84b8f1e859403fe496cb3204ced37c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2301460Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

e9e8c01f

15 Jul, 2020 9 commits

Roll git to 2.27.0 on Windows · 5fcb4853

Edward Lesmes authored Jul 15, 2020

Bug: 1070694
Change-Id: I37af08864661ca92116776569b9285ceb6ff465c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2300204Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

5fcb4853

bot_update: Don't checkout 'master' after clone. · ed9e5acd

Edward Lesmes authored Jul 15, 2020

Checkout 'HEAD' instead. This is needed to have a detached HEAD, so we
can fetch refs/heads/main:refs/heads/main, where main is the default
branch.

Bug: 1104182
Change-Id: I7b7457b21b7d98d29583555b62e27e96e900adb4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2300533
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>

ed9e5acd

gclient: Unset core.worktree after cloning on Windows. · d4e20f24

Edward Lesmes authored Jul 15, 2020

Caused by https://github.com/git-for-windows/git/issues/2569

Bug: 1070694
Change-Id: Ice39e0f61e5c571562736a35e6441d01cb76ea06
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2300652Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

d4e20f24

Roll recipe dependencies (trivial). · 4531a053

recipe-roller authored Jul 15, 2020

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/034831f3848fd44d3bf28cd04a625e06e6a0e5c7
  034831f (iannucci@chromium.org)
      [luciexe] zlib compress build.proto output.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib8db59cfe720ff1c7e25c85d575af85d169b4b4d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2300762Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

4531a053

Add default filters to git cl lint. · b8c62cf5

Lei Zhang authored Jul 15, 2020

Use the same set of default filters as presubmit checks. Presubmit
checks use filters to give better lint results as expected by Google C++
style. Give git-cl's lint subcommand the same benefit.

Bug: 1106028
Change-Id: I51ff0737b310990ab424376d2721e8a6a50dfc6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2298122
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

b8c62cf5

Simplify a block of conditionals for git cl lint. · 379d1ad1

Lei Zhang authored Jul 15, 2020

Use continues to reduce the amount of nesting in a loop. At the same
time, give the variable involved better names.

Bug: 1097674
Change-Id: I105ed4a99da783fb235e304bbad4edd1f8a38889
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2298659Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

379d1ad1

presubmit_canned_checks: Add DIR_METADATA presubmit checks. · 6d938a0d

Edward Lesmes authored Jul 15, 2020

- Add a check to validate DIR_METADATA files.
- Add a check to enforce that OWNERS files contain no metadata if a
  DIR_METADATA file is present in the same directory.

Bug: 1102997
Change-Id: Iedb09941001577dc81b1dda2241481ff667b2568
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2298330
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>

6d938a0d

Roll recipe dependencies (trivial). · 2f6667ed

recipe-roller authored Jul 15, 2020

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/f4cd7a476cb9287e3c8fd2b615fb517a9cd0974e
  f4cd7a4 (yiwzhang@google.com)
      [luciexe] Set the initial build status to running

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Iafe30b0f8ef09c4f86491f60a6d7c848c171bcf9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2300522Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

2f6667ed

[led] Roll to latest · 9d9199a5

Chan Li authored Jul 15, 2020

Bug: 1099018
Change-Id: Ie40d213670f41f946c3111cee2247fbb8fa12754
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2298121Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Chan Li <chanli@chromium.org>

9d9199a5

14 Jul, 2020 5 commits

Add gerrit_change_owner field to tryserver recipe api · 35dec5f1

Greg Guterman authored Jul 14, 2020

Bug: 923016
Change-Id: I1d55fb2403306763a06b44d2ea65caa0014936d3
Recipe-Nontrivial-Roll: infra
Recipe-Nontrivial-Roll: build_limited_scripts_slave
Recipe-Nontrivial-Roll: build
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2292235
Commit-Queue: Gregory Guterman <guterman@google.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

35dec5f1

[dirmd] Add dirmd executables · 672e1dcf

Nodir Turakulov authored Jul 14, 2020

This should have been a part of
https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2298244

Bug: 1104246
Change-Id: I3a1ef07cb4443aa2d62af7f3cb28e0d58bd3951a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2297804
Auto-Submit: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

672e1dcf

[dirmd] Deploy dirmd · 3229d944

Nodir Turakulov authored Jul 14, 2020

Deploy dirmd tool via CIPD.

Bug: 1104246
Change-Id: I3681262192c2eaf706867d3c49a6293171c93d11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2298244
Auto-Submit: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

3229d944

Analyze DEPS autorolls · c3cb7eec

Greg Guterman authored Jul 14, 2020

This new logic tries to figure out which files really changed in a DEPS roll by checking out the old DEPS file and recursively running git diff on all of the repos listed in DEPS. When successful, affected_files turns from just ['DEPS'] into an actual list of affected files. When not successful, it falls back to the original logic.

When DEPS is autorolled, typically the change is just an updated git revision. We don't apply this logic to manual DEPS rolls, as they can contain changes to other variables, whose effects are not easily discernible.

MUST be applied in tandem with https://crrev.com/c/2250928

Bug: 923016
Change-Id: I9e33461ea4ae81dc056d229f8604943745e30389
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2283855
Commit-Queue: Gregory Guterman <guterman@google.com>
Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

c3cb7eec

Roll recipe dependencies (trivial). · fad2090a

recipe-roller authored Jul 14, 2020

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/59e7d3f289e8f160db10bbcd311b299805080c4b
59e7d3f (adrexler@google.com)
Add read_ and write_proto methods to file api.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib30f4f114faec72be2bbeafc6ba374abccc0af25
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2296496Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

fad2090a

13 Jul, 2020 2 commits

Roll recipe dependencies (trivial). · 68978076

recipe-roller authored Jul 13, 2020

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/7b45560ebbf38d17b1d3da28b61939736782f33d
  7b45560 (iannucci@chromium.org)
      [recipe_engine] Only retain child step presentations.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I09d1bce4ec82732a4d7d367c9f4078d93db94c4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2295693Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

68978076

Fix gclient_gn_args_file calculation when use_relative_paths=True. · 67283c06

Lei Zhang authored Jul 13, 2020

With https://chromium-review.googlesource.com/2279874, gclient started
taking |use_relative_paths| into account when calculating the path to
gclient_args.gni from |gclient_gn_args_file|. This CL introduced an
issue where the calculation depends on the current working directory.
e.g. Running gclient from ~/repo and ~/repo/sub_dir produced different
results for gclient_args.gni.

Fix this by prepending the root path, which is absolute, when
calculating the path to gclient_args.gni.

Bug: chromium:1102833
Change-Id: I970e38352aea77d857e49dc7dca58f21ba8e0331
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2296219Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

67283c06

12 Jul, 2020 1 commit

gclient: Make gclient_gn_args_file honor use_relative_paths · 271a78ac

Corentin Wallez authored Jul 12, 2020

Without this repos that use the use_relative_paths still need to use
their absolute path for gclient_gn_args_file.

Bug: chromium:1102833
Change-Id: I470096625061a28abf495f4d1035121edbcd581f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2279874Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>

271a78ac

11 Jul, 2020 1 commit

CodeInclusion: Rename whitelist/blacklist -> allowlist/blocklist · 0be4724e

Ayu Ishii authored Jul 11, 2020

Bug: 1097674
Change-Id: Ib1a4a3fe3eca37a1a3a90d62c19eeda5fe4bc499
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2293134Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Ayu Ishii <ayui@chromium.org>

0be4724e

10 Jul, 2020 1 commit

Added option to keep empty branches in rebase-update. · 8e404a7e

Allen Bauer authored Jul 10, 2020

Change-Id: I87b1edf242aa5c8483d8d84d223fc9187a194708
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2292962Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Allen Bauer <kylixrd@chromium.org>

8e404a7e

09 Jul, 2020 1 commit

Use inclusive parameters in PRESUBMIT.py · 9af33fa2

local_bot authored Jul 09, 2020

R=dpranke@google.com

Bug: 1098560
Change-Id: I22f7e89cafb6c8ab7e268afc7004c5ed57f12d12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2288510Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>

9af33fa2

08 Jul, 2020 5 commits

Rename blocklist/allowlist to skip_list/check_list · 6402141d

local_bot authored Jul 08, 2020

This change is backwards compatible.

R=dpranke@google.com

Bug: 1098560
Change-Id: Ic9447041a68b8c379f65900af11c89b006e3f806
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2285156
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>

6402141d

[lucicfg] Update to v1.18.2. · 26314e9f

Vadim Shtayura authored Jul 08, 2020

Contains some internal refactoring, no externally observable
changes.

TBR=tandrii@chromium.org, iannucci@chromium.org
BUG=1051724

Change-Id: I921c1a4adaa877dda07357463b4bb3f7dfc66676
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2288657Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>

26314e9f

Roll recipe dependencies (trivial). · a66f6082

recipe-roller authored Jul 08, 2020

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/e6e0924802b587b99fa0519bc95b5ff3f64a670e
e6e0924 (yiwzhang@google.com)
Remove allow_subannotation kwarg in step module to prevent new...

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I4cd70d63eaf91cc803a8a70c71b89e0f7bd22069
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2288427Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

a66f6082

mac: Add an arm64 slice to ninja-mac. · e64cd3ae

Nico Weber authored Jul 08, 2020

To build the arm ninja binary, I downloaded a zip with the ninja 1.8.2
code, and ran `./configure --bootstrap` on an arm mac, with Xcode 12 beta
installed, followed by `strip ninja`. That gave me a working ninja 1.8.2
arm binary. I then copied it to my intel mac and ran

    lipo -create -output ninja-mac ninja-mac ~/Downloads/ninja

to make a fat binary.

No intended behavior change on non-arm macs.

(This means the x86_64 slice, which is the previously existing binary,
has a LC_VERSION_MIN_MACOSX version 10.6, while the arm64 slice has
LC_BUILD_VERSION minos 11.0, according to `otool -arch ax86_64 -l ninja-mac`
and `otool -arch arm64 -l ninja-mac`.)

Bug: 1103315,762354
Change-Id: I2c4bea53a01d7a6135f9cd5554e3123dba960664
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2288417
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>

e64cd3ae

gclient: Force "git clone" to run arm git on arm macs. · c49c88ac

Nico Weber authored Jul 08, 2020

With this, `fetch chromium` manages to client src.git and all
dependencies in DEPS (and then dies in runhooks).

Bug: 1103236
Change-Id: I0e26b78f1c552aa23eaa6c43b61f3c6809a3ada1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2287751
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>

c49c88ac