Commits · c00ac8de899fc2a2440a22cbd2435eff00c03bd0 · Linshizhi / Chromium_Depot_tools

04 Mar, 2020 6 commits

gclient: Don't allow duplicate entries on deps · c00ac8de

Edward Lemur authored Mar 04, 2020

Bug: 809671
Change-Id: I74103304651417e6b6889cb713fe494c95279d69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2088422Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

c00ac8de

depot_tools: git-cl: Rename try job to tryjob for consistency · 777660f3

Quinten Yearsley authored Mar 04, 2020

Change-Id: I3310db47604dafead241db4d8d3540277daeb07c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2083675
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

777660f3

Roll recipe dependencies (trivial). · 83bc671b

recipe-roller authored Mar 04, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/529c1c9fa9ed3a118c777ca6a09033bfb0b56853 (olivernewman@google.com)
    [docs] Add recipes.cfg option to disable doc generation

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: If605022323d0b94bb6cc447f985b9fbcf2c4d350
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2088428Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

83bc671b

git-map-branches: Fix Python 3 errors. · 2bac03e8

Edward Lemur authored Mar 04, 2020

When no -v flag is given, the verbosity defaults to None instead of 0,
so set 0 as a default.

Bug: 1058315
Change-Id: Id69e62550b33cd18bb1e5aed9cdc3c94f1488516
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2088193Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

2bac03e8

git-cl: Use open instead of file. · b7f759f6

Edward Lemur authored Mar 04, 2020

file does not exist on Python 3.

Change-Id: I9392fd797b730784cff4d1144c5a3ab1027c7dd8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2086493Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

b7f759f6

git-cl: Fix Python 3 bugs · 1a83da1f

Edward Lemur authored Mar 04, 2020

- Don't encode description when calling presubmit,
  codecs.open already takes care of that.
- Don't use raw_input on Python 3
- Encode stdin when calling clang-format.

Bug: 1058318, 1058318
Change-Id: I825422e160c00b33b2c52b6e64e5f0a3e44606f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2086631Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

1a83da1f

03 Mar, 2020 4 commits

Roll recipe dependencies (trivial). · ec2a6ce2

recipe-roller authored Mar 03, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://crrev.com/b6adffa3a5c4cf889bc56c167aaa7872e87751d6 (yiwzhang@google.com)
Make _setup_build_step instance method

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I2962a728b687082a786df6c82aa3e917b0a9bf52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2086491Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

ec2a6ce2

Roll recipe dependencies (nontrivial). · fe6f7524

recipe-roller authored Mar 03, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

Please review the expectation changes, and LGTM+CQ.

recipe_engine:
  https://crrev.com/1c1b5028819c1e6ec876b2574f848f8b4b5f5f1c (yuanjunh@google.com)
    Prompt errors when README.recipes.md is not regenerated

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=martiniss@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Idcfb75c8434492e2f2a296d90e9a3966cf8bb828
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2084400
Auto-Submit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>

fe6f7524

gclient: Don't warn on Python 3 when GCLIENT_PY3=1 is set. · e1318818

Edward Lemur authored Mar 03, 2020

Change-Id: If33fe4531841921d79101ec8f0c1534a5308b74a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2083580Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

e1318818

gclient: Remove syntax validation flags. · 67cabcd7

Edward Lemur authored Mar 03, 2020

Change-Id: I7215335eb4592cba80d31595b3bac75f55372dee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2083589Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

67cabcd7

02 Mar, 2020 2 commits

Reland "my_activity.py: Run using vpython3 by default." · a3b6fd06

Edward Lemur authored Mar 02, 2020

Fix issue with gerrit_util.py and add tests.

Change-Id: Ie523ea59ddb93cf5c7fa35f3761310ce96747720
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2081092Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

a3b6fd06

git-cl: Remove support for GetPreferredTryMasters. · 45768514

Edward Lemur authored Mar 02, 2020

Bug: 1042324
Change-Id: I9d554d8ffe5c17278d4cd90d2aa0a49fc329f695
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2075797Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

45768514

29 Feb, 2020 5 commits

Roll recipe dependencies (trivial). · 9ca9c52c

recipe-roller authored Feb 29, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://crrev.com/ca01a2f6cb0d44631e89064dfbcef954b81417e6 (gbeaty@chromium.org)
Change the behavior of debug with no arguments to debug recent failure.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I70da6cf488bf206bdb5cb94c1249baf1c862d136
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2081311Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

9ca9c52c

Roll recipe dependencies (trivial). · 4eae5a25

recipe-roller authored Feb 29, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://crrev.com/0677e84086bd93f6d4ec1faefd1dfdff4b0225fb (gbeaty@chromium.org)
Add a function for parsing test names.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Iaa8bab59faafb653a39ea1cecc45f0fe4bf7924f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2079395Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

4eae5a25

bot_update: tell CQ to not retry patch application failures. · ef7a3390

Andrii Shyshkalov authored Feb 29, 2020

R=erikchen

Recipe-Nontrivial-Roll: build
Change-Id: I171daa3d61b2c20f963b8d587df8662740d80e71
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2050537Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Auto-Submit: Andrii Shyshkalov <tandrii@google.com>

ef7a3390

remove dead code. · e2aee980

Andrii Shyshkalov authored Feb 29, 2020

R=smut

Change-Id: Ie919e4f90378ecdeb6a2e015cb313f044aa2d214
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2080206
Auto-Submit: Andrii Shyshkalov <tandrii@google.com>
Reviewed-by: smut <smut@google.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

e2aee980

Revert "Improve git cl split" · ac5c55f6

Edward Lemur authored Feb 29, 2020

This reverts commit 68409634.

Reason for revert:
Breaks git-cl split.
https://bugs.chromium.org/p/chromium/issues/detail?id=1054888

Original change's description:
> Improve git cl split
>
> This CL changes the behavior of `git cl split` to split the change
> by the size of the resulting CLs. For now, this is based on the number
> of bytes changed, and not by the number of changed lines. Depending
> on the shape of change, this may still produce more CLs than expected
> (and possibly more than before).
>
> A future change will switch the split to be based on the number
> of affected lines, and also introduce a mode to base the split
> on the number of affected files.
>
> Bug: 998922
> Change-Id: I49f868972a61b89b426ef9e2ceedc733eacb4350
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1778744
> Commit-Queue: Yannic Bonenberger <yannic.bonenberger@gmail.com>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>

TBR=fdoray@chromium.org,dpranke@chromium.org,yannic.bonenberger@gmail.com,infra-scoped@luci-project-accounts.iam.gserviceaccount.com

Bug: 998922
Change-Id: I466e1245d5f1c934443d850c48c42d3e694e71c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2080205Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

ac5c55f6

28 Feb, 2020 10 commits

Roll recipe dependencies (trivial). · 55ab41d1

recipe-roller authored Feb 28, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://crrev.com/cda5bed0ae2531e7252f80da471f675158ab694c (gbeaty@chromium.org)
Add a property for previous_test_failures to RecipeDeps.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I1c1da5357df6f449c746c9894d878c9a622efe3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2080207Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

55ab41d1

depot_tools: Make it possible to run custom git scripts using Python 3. · 4d7d53b3

Edward Lemur authored Feb 28, 2020

Run custom git commands (e.g. git-cl, git-new-branch) using Python 3
when GCLIENT_PY3 is set to 1.

Bug: 984182
Change-Id: I81635b6cb83b2e0945d6596a7dc363f702075466
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2079704Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

4d7d53b3

Roll recipe dependencies (trivial). · 9f6558d3

recipe-roller authored Feb 28, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/695991201368bcca73189853a28f9679f2668da9 (atyfto@google.com)
    [file] Add flag to skip logs on write_raw & write_text

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I2d75290cbfadfa7ffd2482dc58036dfac9963cf2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2080915Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

9f6558d3

Print content of description backup on exit · 953278ad

Josip Sokcevic authored Feb 28, 2020

Change-Id: I9607035c8ee5e5f4423b7526c67f384cfebb2f1d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2079708
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Auto-Submit: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

953278ad

Revert "my_activity.py: Run using vpython3 by default." · eb5dabf9

Edward Lesmes authored Feb 28, 2020

This reverts commit 488712ab.

Reason for revert: Breaks when running on vpython3

Original change's description:
> my_activity.py: Run using vpython3 by default.
> 
> Also, prompt users to use vpython3 when running my_activity.py
> using Python 2.
> 
> Change-Id: I078517832520b3c7baf3324f83e9a3b5194a5bcb
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2079703
> Reviewed-by: Josip Sokcevic <sokcevic@google.com>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

TBR=ehmaldonado@chromium.org,apolito@google.com,infra-scoped@luci-project-accounts.iam.gserviceaccount.com,sokcevic@google.com

Change-Id: Ib217e8ec3613ee6645149f3d78ef9534ac68af8b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2080201Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

eb5dabf9

roll-dep: Make it possible to run using Python 3. · 4f489240

Edward Lemur authored Feb 28, 2020

Run roll-dep using Python 3 when GCLIENT_PY3 is set to 1.

Bug: 984182
Change-Id: I511b4cf34b4f5522218a24dff6d0ce9ef5c36c4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2080614Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

4f489240

Roll recipe dependencies (trivial). · 1e247059

recipe-roller authored Feb 28, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://crrev.com/33340afc751dd03e69ec96a67311e6d56a6ab50b (yuanjunh@google.com)
Add --no-docs for the command 'test run'

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I77b4bac44b57f8a6e3f4dbcad4b47bbb7775d7e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2079414Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

1e247059

Revert "Print content of description backup on exit" · b10ba796

Edward Lesmes authored Feb 28, 2020

This reverts commit 8c5cdf18.

Reason for revert:
https://bugs.chromium.org/p/chromium/issues/detail?id=1056958

Original change's description:
> Print content of description backup on exit
> 
> R=apolito@google.com
> 
> Bug: 1056193
> Change-Id: I656149b8ddad61f6b673193b72d780b72a585f43
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2078308
> Commit-Queue: Josip Sokcevic <sokcevic@google.com>
> Reviewed-by: Anthony Polito <apolito@google.com>

TBR=apolito@google.com,infra-scoped@luci-project-accounts.iam.gserviceaccount.com,sokcevic@google.com

Change-Id: I5190f4e0f342d0ee06474e6c432004ef95bec85b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1056193
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2079307Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

b10ba796

my_activity.py: Run using vpython3 by default. · 488712ab

Edward Lemur authored Feb 28, 2020

Also, prompt users to use vpython3 when running my_activity.py
using Python 2.

Change-Id: I078517832520b3c7baf3324f83e9a3b5194a5bcb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2079703Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

488712ab

gclient: Allow setting GCLIENT_PY3 to 0 to run on Python 2. · 780e6bf8

Edward Lemur authored Feb 28, 2020

As we update scripts to run Python 3 by default, we want to provide
developers a way to execute scripts on Python 2 if they encounter
any problems.

This change only affects Linux/Mac and not Windows developers.

Bug: 984182
Change-Id: I7c7bd2a45ef50e340f6f2b85e9bc8b63f22d8678
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2079701Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

780e6bf8

27 Feb, 2020 9 commits

git-cl: Run PostUpload hooks via CLI. · 7552630e

Edward Lemur authored Feb 27, 2020

Bug: 1042324
Change-Id: Iae90e632e9c1b2c798575ab940d82a145b47204a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2070681
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>

7552630e

presubmit_support: Refactor and add tests for DoPostUploadExecuter. · 6eb1d32f

Edward Lemur authored Feb 27, 2020

Remove input and output stream, that always pointed to sys.stdin
and sys.stdout.
Add tests for DoPostUploadExecuter.

Bug: 1042324
Change-Id: Ib5d092706a242ae97ec877af5dbceef6db7cbb73
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2079411Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

6eb1d32f

my_activity: search gerrit review too · 24fd8630

Mike Frysinger authored Feb 27, 2020

This is where PolyGerrit & repo & other Gerrit CLs land.

Change-Id: If584cfce7d6e78f01e30531e5eee70a51a354164
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2079413Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>

24fd8630

my_activity: add short url for android CLs · fdf027a7

Mike Frysinger authored Feb 27, 2020

Change-Id: I7e9c7c38b82d746cad28685f0eb8e24cc2f41572
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2079412
Auto-Submit: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

fdf027a7

Roll recipe dependencies (trivial). · c1371134

recipe-roller authored Feb 27, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/aed02b3aa61d3d56bfe5616667ab09cafc08fb4a (iannucci@chromium.org)
    [test] Fix location of --stop flag.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ieaa3ba8c0ff179a1822367f802246e2642733ced
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2078309Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

c1371134

Print content of description backup on exit · 8c5cdf18

Josip Sokcevic authored Feb 27, 2020

R=apolito@google.com

Bug: 1056193
Change-Id: I656149b8ddad61f6b673193b72d780b72a585f43
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2078308
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Anthony Polito <apolito@google.com>

8c5cdf18

git-cl: Add tests for git-cl presubmit · 9468eba7

Edward Lemur authored Feb 27, 2020

Bug: 1056309, 1042324
Change-Id: I69815044c199f2321a66760bbdfe251ed916154a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2076037Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

9468eba7

Refactor OWNERS for LUCI-related tools. · a4f9aa03

Robert Iannucci authored Feb 27, 2020

R=ehmaldonado@chromium.org, maruel@chromium.org, nodir@chromium.org, tandrii@chromium.org

Change-Id: I72e842bb07cf0a19d7afc417027ee7a70dddfd51
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2077460Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

a4f9aa03

fix git cl presubmit · 29d5cf85

Gregory Nisbet authored Feb 27, 2020

BUG=chromium:1056534
TEST=run git cl presubmit

Change-Id: I22a7951623b241b8b1cc49f107f024d95054506d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2077357
Auto-Submit: Gregory Nisbet <gregorynisbet@google.com>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

29d5cf85

26 Feb, 2020 3 commits

Roll recipe dependencies (trivial). · 005269a5

recipe-roller authored Feb 26, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/a36bdfd1c28f088e1c39736babb987e71284d646 (yiwzhang@google.com)
    [warning] Support recipe warning registration

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I1a333b850ee5791df514a01171b7488b1644fe44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2076682Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

005269a5

Reland "cros: switch CrOS programs to python3" · b847c567

Mike Frysinger authored Feb 26, 2020

This is a reland of 35b70cac.
With the recent vpython3 PATH fixes, hopefully this should pass now.

Original change's description:
> cros: switch CrOS programs to python3
>
> We start warning if people have outdated systems.
>
> Bug: 997354
> Test: `cros --help` uses python3 now
> Change-Id: I1491f1c0eea4d544cc508b461153c54c8072699d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2052243
> Commit-Queue: Mike Frysinger <vapier@chromium.org>
> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

Bug: 997354
Change-Id: Ic7e040af6a34d112cd0a1c1421cdd25bc557ee19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2052625
Commit-Queue: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

b847c567

Roll out new goma client binary VERSION=192 · 2a9042f8

Ye Kuang authored Feb 26, 2020

Bug: b/149963110
Change-Id: Iced9b2db2f93c42c78a94430c5ba4f06f4e971a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2072501Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@google.com>
Commit-Queue: Ye Kuang <yekuang@google.com>

2a9042f8

25 Feb, 2020 1 commit

git-cl: Invoke presubmit checks via subprocess execution instead of via module. · 227d5108

Edward Lemur authored Feb 25, 2020

PRESUBMIT.py scripts are executed in presubmit_support.py using exec().
Since PRESUBMIT.py scripts might not be yet compatible with python 3, we
have to execute presubmit_support.py using python 2.

git_cl.py imports presubmit_support.py, and executes presubmit checks using
presubmit_support as a module. This forces git_cl.py to be executed using
python 2 to maintain compatibility for PRESUBMIT.py scripts.

This change allows git_cl.py to be executed using python 3, while
presubmit_support.py is executed using python 2.

Similar changes for post-submit hooks and git-cl try masters will follow.

Bug: 1042324
Change-Id: Ic3bb1c2985459baf6aa04d0cc65017a1c2578153
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2068945Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

227d5108