Commits · be113f1365ffa02efe1fc2d0959d5f06029bc173 · Linshizhi / Chromium_Depot_tools

01 Sep, 2011 2 commits

Make filename processing a static method. · be113f13

maruel@chromium.org authored Sep 01, 2011

This is in preparation to support file rename, as a source_filename needs to be
added and processed.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7809001

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@99185 0039d316-1c4b-4281-b951-d872f2087c98

be113f13

Implement reverse mangling of svn properties. · 03152415

maruel@chromium.org authored Sep 01, 2011

That means some properties will being to be applied.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7776015

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@99182 0039d316-1c4b-4281-b951-d872f2087c98

03152415

30 Aug, 2011 1 commit

Add regression test for the parallel jobs dependency issue. · f40e2a56

maruel@chromium.org authored Aug 30, 2011

Well, the funny thing is that it doesn't find the bug but the framework is
already good enough as-is to be worth checked-in, so the next commit can show
the relevant difference.

R=dpranke@chromium.org
BUG=60725
TEST=

Review URL: http://codereview.chromium.org/7773001

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@98869 0039d316-1c4b-4281-b951-d872f2087c98

f40e2a56

26 Aug, 2011 4 commits

Move the parser creation code in its own function to enable unit testing. · 0895b752

maruel@chromium.org authored Aug 26, 2011

Unit test follow in next CL.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7766005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@98480 0039d316-1c4b-4281-b951-d872f2087c98

0895b752

Improve search algorithm for GAE SDK in depot_tools integration tests. · 943b1273

maruel@chromium.org authored Aug 26, 2011

Still not enough to fix presubmit checks on commit queue but a step in the
right direction.
Review URL: http://codereview.chromium.org/7748020

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@98445 0039d316-1c4b-4281-b951-d872f2087c98

943b1273

Make GAE instance bind all interfaces when a variable is set. · 6b5eae2d

maruel@chromium.org authored Aug 26, 2011

It's mostly for debugging when testing with a leaking service. It's going to be
rarely used but I used it often enough to warrant it being committed.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7744030

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@98438 0039d316-1c4b-4281-b951-d872f2087c98

6b5eae2d

Ignore C++ comments while checking for Singleton<T> in headers. · d22b970a

dilmah@chromium.org authored Aug 26, 2011

(without ignoring comments this check gives false positives on code like base/threading/thread_local.h)
Review URL: http://codereview.chromium.org/7747023

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@98421 0039d316-1c4b-4281-b951-d872f2087c98

d22b970a

23 Aug, 2011 2 commits

Update upload.py from rietveld @ 7696eca367d2. · 4f6d25c4

maruel@chromium.org authored Aug 23, 2011

---

Trap failure to get password from keyring

It happens when using upload.py from a ssh session without a X session but
gnomekeyring is used.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7715013

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@97909 0039d316-1c4b-4281-b951-d872f2087c98

4f6d25c4

Update upload.py from ed59464f8468. · b615edae

maruel@chromium.org authored Aug 23, 2011

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7709021

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@97854 0039d316-1c4b-4281-b951-d872f2087c98

b615edae

10 Aug, 2011 1 commit

chrome_set_ver: Add symlink to chromite_wrapper for new tool · e07b3ce3

zbehan@chromium.org authored Aug 10, 2011

BUG=none
TEST=run it
Review URL: http://codereview.chromium.org/7605017

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@96223 0039d316-1c4b-4281-b951-d872f2087c98

e07b3ce3

26 Jul, 2011 2 commits

Update chromite wrapper · 38e22e95

zbehan@chromium.org authored Jul 26, 2011

* Add a new version of the chromite wrapper as chromite_wrapper
* Create symlinks (chromite, cros_sdk, cbuildbot) pointing to it

TEST=inside repo checkout, run cros_sdk, chromite, cbuildbot
Review URL: http://codereview.chromium.org/7484062

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@94011 0039d316-1c4b-4281-b951-d872f2087c98

38e22e95

Do not interfere with git cl patch <issue> · d587f393

maruel@chromium.org authored Jul 26, 2011

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7493050

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@94004 0039d316-1c4b-4281-b951-d872f2087c98

d587f393

22 Jul, 2011 4 commits

GTTF: make gclient config overwrite the .gclient file if it exists · 26dd22b8

phajdan.jr@chromium.org authored Jul 22, 2011

This prevents bots waiting 20 minutes and failing the update step.
Review URL: http://codereview.chromium.org/7492019

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@93678 0039d316-1c4b-4281-b951-d872f2087c98

26dd22b8

Fix git-cl --contributor flag support for presubmit checks. · 13f623ca

maruel@chromium.org authored Jul 22, 2011

Chromium's presubmit check assumes the author is an email address.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7484002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@93645 0039d316-1c4b-4281-b951-d872f2087c98

13f623ca

Add merge attribute to OptionsObject in gclient_scm_test.py. · 4dd09375

bauerb@chromium.org authored Jul 22, 2011

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/7488015

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@93628 0039d316-1c4b-4281-b951-d872f2087c98

4dd09375

Add --merge option to gclient sync. · 2aad1b26

bauerb@chromium.org authored Jul 22, 2011

BUG=none
TEST=

Review URL: http://codereview.chromium.org/7277035

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@93611 0039d316-1c4b-4281-b951-d872f2087c98

2aad1b26

21 Jul, 2011 1 commit

Fix support for pylint 0.24. · 891f6454

maruel@chromium.org authored Jul 21, 2011

TBR=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7487001

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@93451 0039d316-1c4b-4281-b951-d872f2087c98

891f6454

06 Jul, 2011 1 commit

Remove manual --tbr support and convert it into automatic TBR= detection. · cc73ad68

maruel@chromium.org authored Jul 06, 2011

It result in less code, forces uploading the change for eventual review and most
importantly enables the commit queue to correctly handle this.

BUG=
TEST=

Review URL: http://codereview.chromium.org/7253015

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@91575 0039d316-1c4b-4281-b951-d872f2087c98

cc73ad68

24 Jun, 2011 1 commit

Remove files without an extension from the presubmit checks. · c33455af

maruel@chromium.org authored Jun 24, 2011

This may include Makefile but it's saner to not include it by default

R=dpranke@chromium.org
BUG=
TEST=updated

Review URL: http://codereview.chromium.org/7251002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@90403 0039d316-1c4b-4281-b951-d872f2087c98

c33455af

21 Jun, 2011 1 commit

Replace OSError by the correct class IOError · 004fb718

maruel@chromium.org authored Jun 21, 2011

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7215025

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@89884 0039d316-1c4b-4281-b951-d872f2087c98

004fb718

20 Jun, 2011 2 commits

Fix Checkout.post_processsors setup. __init__() was ignoring the argument! · a5129fb8

maruel@chromium.org authored Jun 20, 2011

TEST=Rewrote the unit test to catch that case.

R=dpranke@chromium.org
BUG=

Review URL: http://codereview.chromium.org/7192010

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@89700 0039d316-1c4b-4281-b951-d872f2087c98

a5129fb8

Improve CheckLongLines() to increase the hard limit at 50% when an exception is found. · eba64622

maruel@chromium.org authored Jun 20, 2011

Improve the list of exception to include very_long_symbol_names.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7097012

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@89696 0039d316-1c4b-4281-b951-d872f2087c98

eba64622

16 Jun, 2011 1 commit

Add --depth option to repo. · b25b69b8

maruel@chromium.org authored Jun 16, 2011

See related repo change:
  https://review.source.android.com/#change,22722

Review URL: http://codereview.chromium.org/7111045
Patch from Doug Anderson <dianders@chromium.org>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@89361 0039d316-1c4b-4281-b951-d872f2087c98

b25b69b8

15 Jun, 2011 3 commits

Wrap calls to git.bat in quotes. · 9e6ec10b

cmp@chromium.org authored Jun 15, 2011

Review URL: http://codereview.chromium.org/7178001

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@89268 0039d316-1c4b-4281-b951-d872f2087c98

9e6ec10b

In Windows Git, set autocrlf and filemode by default. · 8a4fb64c

cmp@chromium.org authored Jun 15, 2011

Review URL: http://codereview.chromium.org/7172033

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@89261 0039d316-1c4b-4281-b951-d872f2087c98

8a4fb64c

Fix presubmit check to not enforce git-try to be parsed as python · 57e48b82

maruel@chromium.org authored Jun 15, 2011

R=cmp@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7172014

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@89208 0039d316-1c4b-4281-b951-d872f2087c98

57e48b82

14 Jun, 2011 6 commits

git-try should be called as 'git try' from now on. · 79d98483

cmp@chromium.org authored Jun 14, 2011

Review URL: http://codereview.chromium.org/7111049

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@89036 0039d316-1c4b-4281-b951-d872f2087c98

79d98483

Make git try work on Windows. · bbb46658

cmp@chromium.org authored Jun 14, 2011

This mirrors the git-cl changes by first moving git-try
to git_try.py (which git cl already had), then copying
git-cl to git-try and updating all references to git-cl
and git_cl.py to the corresponding git try references.

The main issue is that in the MINGW/Msysgit case we want
to use the Python in depot_tools since that is 100%
compatible with the Command Prompt.  Hence we need
to call it directly and then pass it the name of the
git_try.py script.

Note that 'git-try' will not (ever) work on Windows,
and users should only ever run 'git try'.  Hence the
need to modify the output of the command to avoid
further confusion.
Review URL: http://codereview.chromium.org/7114002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@89031 0039d316-1c4b-4281-b951-d872f2087c98

bbb46658

Need to strip the config result value otherwise it contains a \n. · 63f78b0f

maruel@chromium.org authored Jun 14, 2011

It was broken in 88979. Someone my limited testing missed that.

TBR=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7147016

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@88987 0039d316-1c4b-4281-b951-d872f2087c98

63f78b0f

Make TrialDirMixIn so it can be used stand alone. · e424b220

maruel@chromium.org authored Jun 14, 2011

This will be used in commit queue tests.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7046110

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@88986 0039d316-1c4b-4281-b951-d872f2087c98

e424b220

Use tuple everywhere with explicit conversion. · 69eaecb3

maruel@chromium.org authored Jun 14, 2011

TEST=Add PanProjectChecks unittest, there was none.

R=dpranke@chromium.org
BUG=

Review URL: http://codereview.chromium.org/7104141

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@88982 0039d316-1c4b-4281-b951-d872f2087c98

69eaecb3

Fix support for AUTHOR presubmit check in git cl. · 03b3bdcb

maruel@chromium.org authored Jun 14, 2011

Properly load --contributor value or use the git config user.email value.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7134097

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@88979 0039d316-1c4b-4281-b951-d872f2087c98

03b3bdcb

12 Jun, 2011 3 commits

Add linux3 support. · 244e3447

maruel@chromium.org authored Jun 12, 2011

'Cause linux2 is so last decade.

TBR=evan@chromium.org
BUG=85845
TEST=

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@88788 0039d316-1c4b-4281-b951-d872f2087c98

244e3447

Make prepare() accept a revision argument. · 51919774

maruel@chromium.org authored Jun 12, 2011

R=dpranke@chromium.org
TEST=few
BUG=

Review URL: http://codereview.chromium.org/6995115

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@88779 0039d316-1c4b-4281-b951-d872f2087c98

51919774

Make post_processors part of the Checkout object state. · 6ed8b50b

maruel@chromium.org authored Jun 12, 2011

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7044090

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@88777 0039d316-1c4b-4281-b951-d872f2087c98

6ed8b50b

10 Jun, 2011 1 commit

Initializes correctly 'url'. · 740f9d7e

maruel@chromium.org authored Jun 10, 2011

R=evan@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7129059

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@88697 0039d316-1c4b-4281-b951-d872f2087c98

740f9d7e

08 Jun, 2011 1 commit

Ignore empty lines in OWNERS files. · 20d1943f

bauerb@chromium.org authored Jun 08, 2011

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/7003057

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@88341 0039d316-1c4b-4281-b951-d872f2087c98

20d1943f

07 Jun, 2011 1 commit

turn off source filter for owners check · 751797ac

dpranke@chromium.org authored Jun 07, 2011

BUG=
TEST=

Review URL: http://codereview.chromium.org/7024021

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@88160 0039d316-1c4b-4281-b951-d872f2087c98

751797ac

06 Jun, 2011 1 commit

git diff can have 'new file mode' for new files and 'new mode' for current files · 378a419f

maruel@chromium.org authored Jun 06, 2011

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7065074

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@87979 0039d316-1c4b-4281-b951-d872f2087c98

378a419f

04 Jun, 2011 1 commit

Do no delete file if they exist, even if p.is_new is True. · 4869bcfb

maruel@chromium.org authored Jun 04, 2011

For a yet unknown reason, a chmod +x on a git svn checkout will set a 'A'
status. Will investigate separately.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/6993033

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@87903 0039d316-1c4b-4281-b951-d872f2087c98

4869bcfb