- 29 Jul, 2020 1 commit
-
-
Mike Frysinger authored
We moved chromite to require python 3.6 all the time, so update the wrappers to match. Bug: 997354 Test: `cros_sdk` still works Change-Id: I78f5dc101f98a074fdc92a1f270395e2d04a2ea1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2324825Reviewed-by:
Michael Mortensen <mmortensen@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org>
-
- 26 Feb, 2020 1 commit
-
-
Mike Frysinger authored
This is a reland of 35b70cac. With the recent vpython3 PATH fixes, hopefully this should pass now. Original change's description: > cros: switch CrOS programs to python3 > > We start warning if people have outdated systems. > > Bug: 997354 > Test: `cros --help` uses python3 now > Change-Id: I1491f1c0eea4d544cc508b461153c54c8072699d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2052243 > Commit-Queue: Mike Frysinger <vapier@chromium.org> > Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Bug: 997354 Change-Id: Ic7e040af6a34d112cd0a1c1421cdd25bc557ee19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2052625 Commit-Queue: Mike Frysinger <vapier@chromium.org> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org>
-
- 12 Feb, 2020 2 commits
-
-
John Budorick authored
This reverts commit 35b70cac. Reason for revert: causing problems for the chromium cq, e.g. https://ci.chromium.org/p/chromium/builders/try/chromeos-amd64-generic-rel/471366 https://ci.chromium.org/p/chromium/builders/try/chromeos-arm-generic-rel/197740 Original change's description: > cros: switch CrOS programs to python3 > > We start warning if people have outdated systems. > > Bug: 997354 > Test: `cros --help` uses python3 now > Change-Id: I1491f1c0eea4d544cc508b461153c54c8072699d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2052243 > Commit-Queue: Mike Frysinger <vapier@chromium.org> > Reviewed-by: Robbie Iannucci <iannucci@chromium.org> TBR=vapier@chromium.org,iannucci@chromium.org,saklein@chromium.org,infra-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: Ie85691d9f847ad7edb4c9932a0788431c886fec2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 997354 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2052543Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org>
-
Mike Frysinger authored
We start warning if people have outdated systems. Bug: 997354 Test: `cros --help` uses python3 now Change-Id: I1491f1c0eea4d544cc508b461153c54c8072699d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2052243 Commit-Queue: Mike Frysinger <vapier@chromium.org> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org>
-
- 24 Oct, 2019 1 commit
-
-
Mike Frysinger authored
The support/ dir has only ever been used to host a single CrOS file. We can move that to `cros` (which is the primary tool in the CrOS world), and have the few other wrapped programs point to that. Bug: None Change-Id: I3ba3cc7375d357d62fb464e1b6dc37e73bc83cb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1876639Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org>
-
- 17 Dec, 2012 1 commit
-
-
davidjames@chromium.org authored
The cros wrapper in depot_tools is a centralized wrapper for all cros commands. Adding this to depot_tools allows developers to run the 'cros' tool from anywhere inside a Chrome OS checkout. BUG=none TEST=Verify the cros wrapper works. Review URL: https://chromiumcodereview.appspot.com/11600002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@173491 0039d316-1c4b-4281-b951-d872f2087c98
-
- 23 Mar, 2012 1 commit
-
-
ferringb@google.com authored
The original design of this had some issues: 1) forced targets to be importable via 'buildbot.cbuildbot', rather than the proper/full 'chromite.buildbot.cbuildbot'. Scripts worked around this, but it's an unwanted limitation. 2) That importation requirement means that within the chroot, we've had to export cros_sdk *and* cros_sdk.py in the PATH. This is undesirable clutter, and introduces potential errors as scripts localize themselves to cros_sdk.py rather than invoking cros_sdk (the consumers should be agnostic to the language the tool is written in). 3) chromite_wrapper enforced assumptions about python namespace w/in the targets- specifically that 'main' must always be invokable without any arguments. This limits refactoring/cleanup in chromite via having to support ancient API assumptions (api's that weren't public); modern chromite has repurposed main changing the prototype, and using it's own wrapper doing signal handler setup, and general framework behaviour. Longer term, that 'main' functor is unlikely to even exist. The strong coupling chromite_wrapper forced limits are refactoring possibilities. 4) In modern chromite, all user consumable tools are now required to exist w/in chromite/bin/, and be executable and invokable. This is what we want going forward. 5) Implied we want chromite_wrapper used w/in the chroot; we don't, thus drop all CROS_WORKON_SRCROOT awareness. 6) Exposed a chromite_wrapper invokable (that didn't work) into the PATH outside the chroot; this is resolved via moving it into a support directory and repointing symlinks to it. At this point, if it's working with a modern chromite checkout the script is a simple execv pass thru. If it isn't, then it will fallback to the old import trickery. This has been tested against R16, R17, R18, ToT, 0.11.241.B, factory-*, basically all branches w/in chromite without issue. git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@128555 0039d316-1c4b-4281-b951-d872f2087c98
-
- 26 Jul, 2011 1 commit
-
-
zbehan@chromium.org authored
* Add a new version of the chromite wrapper as chromite_wrapper * Create symlinks (chromite, cros_sdk, cbuildbot) pointing to it TEST=inside repo checkout, run cros_sdk, chromite, cbuildbot Review URL: http://codereview.chromium.org/7484062 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@94011 0039d316-1c4b-4281-b951-d872f2087c98
-