- 30 Oct, 2019 10 commits
-
-
Edward Lemur authored
The problems on crbug.com/1017367 should have been fixed by crrev.com/c/1880013 Bug: 1009814 Change-Id: Ia98304ca983b4e7e293fedb9df1fee589de58ba9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1887714Reviewed-by:
Anthony Polito <apolito@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Edward Lemur authored
Bug: 1009814 Change-Id: Ifb073dc0b54a3291f1f874866da3c0fbbeab2db9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1888443Reviewed-by:
Anthony Polito <apolito@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Edward Lemur authored
Bug: 1009809 Change-Id: I47c9a468b2922248b823ebae5e71863a698c30f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1889166Reviewed-by:
Anthony Polito <apolito@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Edward Lemur authored
It's not used and uses basestring, which is not supported in Python 3. Bug: 1002209 Change-Id: I9df900076978636c4a5c75e84432a8cc02d46909 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1891654Reviewed-by:
Anthony Polito <apolito@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Edward Lemur authored
basestring doesn't exist in Python 3. scm.Capture status doesn't need to support strings either. Bug: 1002209 Change-Id: Ie9edfdfd09b789bfaace038a6ad8f3a7da344bc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1890925Reviewed-by:
Anthony Polito <apolito@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/5f5aea33b7cac05bfc7f7b68332de60ddd143be3 Roll swarming go client (dcheng@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I7ba97dd288a975b9eba69b7b66137a9e221fbe60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1891548Reviewed-by:
Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
Haiyang Pan authored
This reverts commit 512f92b7. Reason for revert: bot_update is having infra failure on ci bots. For example https://ci.chromium.org/p/chromium/builders/ci/Closure%20Compilation%20Linux/249684. Original change's description: > Fetch the input commit ref when both ref and id are specified. > > This causes --refs refs/head/master to be added to bot_update > calls when the input build message contains a commit id and the > refs/head/master ref. This is an effective no-op. > > Bug: 922150 > Change-Id: I119d9b3cede727713a0b66bff83b5ee4e1848790 > Recipe-Nontrivial-Roll: build > Recipe-Nontrivial-Roll: infra > Recipe-Nontrivial-Roll: build_limited_scripts_slave > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1884457 > Commit-Queue: Garrett Beaty <gbeaty@chromium.org> > Auto-Submit: Garrett Beaty <gbeaty@chromium.org> > Reviewed-by: Andrii Shyshkalov <tandrii@google.com> TBR=tandrii@google.com,gbeaty@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 922150 Change-Id: Ie9275c21827688f59449f052c768452a8652e139 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1891000 Commit-Queue: Haiyang Pan <hypan@google.com> Reviewed-by:
Haiyang Pan <hypan@google.com>
-
John Budorick authored
This reverts commit 1e4dbf3f. Reason for revert: unlikely but possible cause of http://shortn/_sgL4PqICVB Original change's description: > Add more git tracing. > > This CL adds more perf tracing to `git fetch` from bot_update.py and > git_cache.py > > Change-Id: I9b69c60b6c81fc0c5f23f82fcc889b4d45a27556 > Recipe-Nontrivial-Roll: build_limited_scripts_slave > Recipe-Nontrivial-Roll: build > Recipe-Nontrivial-Roll: infra > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1888433 > Reviewed-by: Andrii Shyshkalov <tandrii@google.com> > Commit-Queue: Erik Chen <erikchen@chromium.org> > Auto-Submit: Erik Chen <erikchen@chromium.org> TBR=danakj@chromium.org,tandrii@google.com,erikchen@chromium.org Change-Id: I03b33bf1532212f83a6b89b1de32fafb6b8aafc4 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1891001Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org>
-
Edward Lemur authored
Checking for LUCI_CONTEXT is not enough. To use local auth, the stored config must be valid and have a default account id. Bug: 1018069 Change-Id: I5bbe880cc217a06ae0e1ae8d7e00ef09502af6a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1888211Reviewed-by:
Vadim Shtayura <vadimsh@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Fumitoshi Ukai authored
This reverts commit a0aed87f. Reason for revert: install goma client without update_hook update_hook would disrupt current users, so start without update_hook, which means goma cient in depot_tools user might need to restart compiler_proxy manually when updated. https://docs.google.com/document/d/1pnwfkU6Rd9dRtQC0sg2vATmyRbkYWhnNUTD5k1PddC0/edit# Original change's description: > Revert "put goma client in depot_tools" > > This reverts commit 77780358. > > Reason for revert: AttributeError: 'GomaEnvPosix' object has no attribute 'RestartCompilerProxy' > > Original change's description: > > put goma client in depot_tools > > > > install goma client cipd package in depot_tools. > > > > should not use $MYPATH/goma_ctl in cipd_bin_setup > > since $MYPATH/goma_ctl uses cipd_bin_setup in itself, > > so causing recursive calls. > > invoke python to run .cipd/goma_ctl.py in cipd_bin_setup > > instead. > > > > Bug: b/77663154 > > Change-Id: I9f82c766a886a2acfb899e3594e5f05a7b7bc75a > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1866350 > > Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> > > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > > Commit-Queue: Fumitoshi Ukai <ukai@chromium.org> > > TBR=sque@chromium.org,ukai@chromium.org,yyanagisawa@google.com,vadimsh@chromium.org,dpranke@chromium.org,tikuta@chromium.org,ehmaldonado@chromium.org,yekuang@google.com > > Change-Id: Ie050dfb524dd885634c31be829d733613e80aece > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: b/77663154 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1872129 > Reviewed-by: Fumitoshi Ukai <ukai@chromium.org> > Commit-Queue: Fumitoshi Ukai <ukai@chromium.org> TBR=sque@chromium.org,ukai@chromium.org,yyanagisawa@google.com,vadimsh@chromium.org,dpranke@chromium.org,tikuta@chromium.org,ehmaldonado@chromium.org,yekuang@google.com Bug: b/77663154 Change-Id: I8bb51631e4418ff63953099814bdb464128eb279 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1875982Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Fumitoshi Ukai <ukai@chromium.org>
-
- 29 Oct, 2019 4 commits
-
-
Erik Chen authored
This CL adds more perf tracing to `git fetch` from bot_update.py and git_cache.py Change-Id: I9b69c60b6c81fc0c5f23f82fcc889b4d45a27556 Recipe-Nontrivial-Roll: build_limited_scripts_slave Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: infra Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1888433Reviewed-by:
Andrii Shyshkalov <tandrii@google.com> Commit-Queue: Erik Chen <erikchen@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/fa1af6362953b8c5c24e3082b0081e688f2be32d [swarming] Add tags to swarming task request. (ihuh@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I7d13586e7ba49d89ac141dfa5319969ec02f69d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1888717Reviewed-by:
Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
Garrett Beaty authored
This causes --refs refs/head/master to be added to bot_update calls when the input build message contains a commit id and the refs/head/master ref. This is an effective no-op. Bug: 922150 Change-Id: I119d9b3cede727713a0b66bff83b5ee4e1848790 Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: infra Recipe-Nontrivial-Roll: build_limited_scripts_slave Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1884457 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@google.com>
-
Haiyang Pan authored
Bug: 1017286 Change-Id: Ibb9f2c94eb87024a3d9b9f334ffa5f8e2429b368 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1881377Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com>
-
- 28 Oct, 2019 3 commits
-
-
Erik Chen authored
This picks up tracing v2 to better track git performance. Bug: 1018953 Change-Id: I13616280b534ad80eb1904ef5012c42dadb45ca4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1884704 Auto-Submit: Erik Chen <erikchen@chromium.org> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
-
Edward Lemur authored
This is a reland of 5bfa3ae8 Replace cStringIO with StringIO and add tests. Original change's description: > gerrit_util: Refactor ReadHttpResponse and add more tests. > > Bug: 1016601 > Change-Id: Ie6afc5b1ea29888b0bf40bdb39b2b492d2d0494c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1880014 > Reviewed-by: Anthony Polito <apolito@google.com> > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Bug: 1016601 Change-Id: I0c83a83202169b6a1acc60bdf6f4cd00eac6e2a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1884461Reviewed-by:
Anthony Polito <apolito@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Edward Lesmes authored
This reverts commit 5bfa3ae8. Reason for revert: Fails when fetching status for cl 1708084 Original change's description: > gerrit_util: Refactor ReadHttpResponse and add more tests. > > Bug: 1016601 > Change-Id: Ie6afc5b1ea29888b0bf40bdb39b2b492d2d0494c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1880014 > Reviewed-by: Anthony Polito <apolito@google.com> > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> TBR=ehmaldonado@chromium.org,apolito@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1016601 Change-Id: I84bc378ed5f58e911e0900b1a5dbea70dc06ade1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1883677Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
- 26 Oct, 2019 1 commit
-
-
Erik Chen authored
Change-Id: Iad21c3fa60f563f479ad0a0cadcfd8c1beb2fcc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1881910 Auto-Submit: Erik Chen <erikchen@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@google.com> Reviewed-by:
Andrii Shyshkalov <tandrii@google.com>
-
- 25 Oct, 2019 5 commits
-
-
Edward Lesmes authored
Change-Id: I649bee199e52ecbd66467cfaf850a7a57e2eedf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1874506Reviewed-by:
Anthony Polito <apolito@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Edward Lemur authored
Bug: 1016601 Change-Id: Ie6afc5b1ea29888b0bf40bdb39b2b492d2d0494c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1880014Reviewed-by:
Anthony Polito <apolito@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Edward Lemur authored
Previously, it returned bytes if the file did not contain valid Unicode data, and a Unicode string otherwise. It is confusing to reason about such a function, and no current caller needs bytes data AFAICT, so make FileRead always return Unicode strings. Bug: 1009814 Change-Id: I89dd1935e5d4fcaf9af71585b85bda6c47695950 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1880013Reviewed-by:
Anthony Polito <apolito@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Edward Lemur authored
PRESUBMIT.py scripts might execute commands directly instead of using CallCommand, so that the conversion to vpython is bypassed, resulting in errors. See e.g. https://cs.chromium.org/chromium/src/third_party/blink/web_tests/PRESUBMIT.py?l=79 Bug: 1017410 Change-Id: If1943fe46cd2fc1e37b89aee14865429f884332b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1879493Reviewed-by:
Anthony Polito <apolito@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Yura Yaroshevich authored
This fixes an error on some Windows installations: ``` fetch webrtc Traceback (most recent call last): File "googlesource.com\depot_tools\bootstrap\bootstrap.py", line 365, in <module> sys.exit(main(sys.argv[1:])) File "googlesource.com\depot_tools\bootstrap\bootstrap.py", line 324, in main git_postprocess(template, os.path.join(bootstrap_dir, 'git')) File "googlesource.com\depot_tools\bootstrap\bootstrap.py", line 264, in git_postprocess maybe_copy( File "googlesource.com\depot_tools\bootstrap\bootstrap.py", line 108, in maybe_copy content = fd.read() File "googlesource.com\depot_tools\bootstrap-3_8_0b1_chromium_1_bin\python3\bin\lib\encodings\cp1251.py", line 23, in decode return codecs.charmap_decode(input,self.errors,decoding_table)[0] UnicodeDecodeError: 'charmap' codec can't decode byte 0x98 in position 18734: character maps to <undefined> ``` Bug: None Change-Id: I43cf7b51879ac9a66c33566536dcdcb4c93e0fc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1881227Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
- 24 Oct, 2019 14 commits
-
-
Vadim Shtayura authored
Most notable public API change is that '../' is no longer allowed in lucicfg.emit(dest=...). R=tandrii@chromium.org Change-Id: Iff162c6e1cbd0c7fcbbafc8b2f56eb827660aa93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1880301 Auto-Submit: Vadim Shtayura <vadimsh@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@google.com> Commit-Queue: Andrii Shyshkalov <tandrii@google.com>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/1485ed120ff670c0b32905d28c824e7af6f32aa6 [cipd] Add CIPD UI link to register() presentation (joshuaseaton@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I2c1e1bfab975e69329128e830fb4aaf22c422d3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1880299Reviewed-by:
Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/64c4a05dc93199fc5a8aca78f9427b09bd43776c [file] Add read text to presentation (joshuaseaton@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I3e8f53f28862189e86df9b590d5e7a35e6973ed3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1880297Reviewed-by:
Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/acfec855b3a03ad8c28df551c3ea7a6bbee75967 [file][cipd] Run YAPF (joshuaseaton@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: If247077c00e153423332b6f1bf06101bd0f6e36b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1880295Reviewed-by:
Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
Edward Lesmes authored
Change-Id: Ia6844cd6da6a9c68ed3d83144bd032933ab69fcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1875110 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Anthony Polito <apolito@google.com>
-
Jamie Madill authored
Lets the client repository make 'git cl format' use the '--full' option by default. This solves issues when using less common clang-format options that don't behave well with small diffs. For example, AlignConsecutiveAssignments. This is a replacement for the 'diff-lines-of-context' setting. Bug: angleproject:4003 Change-Id: I81dc3b4992a7420e7235da88ec78e51ec4c0d24f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1879148Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
-
Edward Lemur authored
Exceptions other than OSError are not surfaced. This caused errors like this to be printed, but not block presubmit, allowing bugs to sneak in. Exception in thread Thread-8: Traceback (most recent call last): File "C:\b\s\w\ir\cipd_bin_packages\cpython\bin\Lib\threading.py", line 801, in __bootstrap_inner self.run() File "C:\b\s\w\ir\cipd_bin_packages\cpython\bin\Lib\threading.py", line 754, in run self.__target(*self.__args, **self.__kwargs) File "C:\b\s\w\ir\kitchen-checkout\depot_tools\presubmit_support.py", line 199, in _WorkerFn result = self.CallCommand(test) File "C:\b\s\w\ir\kitchen-checkout\depot_tools\presubmit_support.py", line 170, in CallCommand p = subprocess.Popen(cmd, **test.kwargs) File "C:\b\s\w\ir\kitchen-checkout\depot_tools\subprocess2.py", line 143, in __init__ super(Popen, self).__init__(args, **kwargs) File "C:\b\s\w\ir\cipd_bin_packages\cpython\bin\Lib\subprocess.py", line 390, in __init__ errread, errwrite) File "C:\b\s\w\ir\cipd_bin_packages\cpython\bin\Lib\subprocess.py", line 640, in _execute_child startupinfo) TypeError: environment can only contain strings https://logs.chromium.org/logs/infra/buildbucket/cr-buildbucket.appspot.com/8898840708364523888/+/steps/presubmit/0/stdout Change-Id: I34e65d8c0050eed7ed26fd782e0a5dc8616f30f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1877051 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Anthony Polito <apolito@google.com> Reviewed-by:
Dirk Pranke <dpranke@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/70031fbf3a131685d9d0f0de3675cb946368743e recipe module buildbucket: migrate to protos for inputs. (tandrii@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I9a365934b6255068cea7c5e9d80f767a0c2e888d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1879499Reviewed-by:
Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
Takuto Ikuta authored
This is followup for crrev.com/c/1877747 Bug: 1002153 Change-Id: I7f5e6f9be9e69ecfbaad75f531d5027ef20a3966 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1878847 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
-
Ben Pastene authored
eg: https://logs.chromium.org/logs/chrome/buildbucket/cr-buildbucket.appspot.com/8898770399362199536/+/steps/bot_update/0/stdout bot_update ends up clobbering the checkout in that build due to: "Error: 161> Called rmtree(/b/s/w/ir/cache/builder/src/......) in non-directory" That's because we're trying to rmtree a file. This will instead unlink it. Bug: 991276 Change-Id: Icffa18c27ddbaced20fb3410a91ca8fcc849d5e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1877727Reviewed-by:
Andrii Shyshkalov <tandrii@google.com> Commit-Queue: Ben Pastene <bpastene@chromium.org>
-
Jamie Madill authored
This reverts commit 812ac228. Reason for revert: The fix was not sufficient to solve the git cl format difference between 'git cl format' and 'git cl format --full'. Looks like we'll need a different solution. Original change's description: > git-cl: Add diff lines of context setting. > > Clients using some Clang-Format options can run into bugs when using > 0 lines of context. AlignConsecutiveAssignments in particular is picky > and behaves differently with 0 lines of context. > > This behaviour lead to 'git cl format' behaving differently from > 'git cl format --full'. That could also break presubmit format checks. > Using >0 lines of context for 'git diff' fixes the inconsistency. > > Add a setting 'DIFF_LINES_OF_CONTEXT' that can be controlled via > codereview.settings. Defaults to zero to preserve the old behaviour. > The setting allows the client to control the number of lines of context > to use when running 'git cl format'. > > Bug: angleproject:4003 > Change-Id: Ied2ebf23df4c41ba19bfbd5b8ddf526b56a20b31 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1864309 > Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> > Commit-Queue: Jamie Madill <jmadill@chromium.org> TBR=agable@chromium.org,ehmaldonado@chromium.org,jmadill@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: angleproject:4003 Change-Id: Ib6b70969509a1e5446922d488f11d13a0c59c536 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1877003Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
-
Takuto Ikuta authored
This property is not used anymore. Bug: 1002153 Change-Id: I19a503a73ec00e9121b2d9a2c130824a974d307a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1877747 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@google.com>
-
Mike Frysinger authored
The support/ dir has only ever been used to host a single CrOS file. We can move that to `cros` (which is the primary tool in the CrOS world), and have the few other wrapped programs point to that. Bug: None Change-Id: I3ba3cc7375d357d62fb464e1b6dc37e73bc83cb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1876639Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org>
-
Andrii Shyshkalov authored
Includes 2019-10-23 tandrii@google.com vpython: more logging when incomplete virtualenv dir can't be removed. R=iannucci Bug: 869227 Change-Id: Ie06fc55322ac5a467a8ac78c7f8b6ad42bcf0aa9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1877553Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Auto-Submit: Andrii Shyshkalov <tandrii@google.com>
-
- 23 Oct, 2019 3 commits
-
-
Edward Lemur authored
This reverts commit a834f39e. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=1017367 Original change's description: > presubmit_support: Fix tests on Python 3. > > Bug: 1009814 > Change-Id: I2c2a835fc4fa0a7fc9e68dfff680fb0beacb491e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1869535 > Reviewed-by: Anthony Polito <apolito@google.com> > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> TBR=ehmaldonado@chromium.org,apolito@google.com Bug: 1009814 Change-Id: I48907caeca9b9b32e4e3a7cb5a636280d017a4c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1877350Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Andrii Shyshkalov authored
Picks up hopeful workarounds for failure to remove virtual env: https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/1876802 https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/1876638 R=iannucci Bug: 869227 Change-Id: Ib18180bf94651bdc5559d630021b05259651e242 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1877348 Commit-Queue: Andrii Shyshkalov <tandrii@google.com> Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Auto-Submit: Andrii Shyshkalov <tandrii@google.com> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org>
-
Edward Lemur authored
presubmit_support.py should correctly find and use .vpython files. This will prevent issues like https://chromium-review.googlesource.com/c/infra/luci/luci-py/+/1874458 Bug: 1002153 Change-Id: I677f40b1fd2c436867cb5c6cbdeaff0d16f33a2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1874892Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-