- 05 Dec, 2014 1 commit
-
-
avakulenko@google.com authored
This just a copy of cpplint.py from upstream [1]. [1] https://code.google.com/p/google-styleguide/source/detail?spec=svn141&r=141 The change in gclient_scm.py is to address a presubmit check error which was introduced by https://codereview.chromium.org/227163002 "print_func" parameter was being passed to a function instead of the object constructor. BUG=None NOTRY=True Change-Id: I4dca890d5f02957ddae33c4bd4269fd37758be3d Review URL: https://codereview.chromium.org/777533005 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293276 0039d316-1c4b-4281-b951-d872f2087c98
-
- 07 Apr, 2011 3 commits
-
-
maruel@chromium.org authored
Reapply r80770 "Switch from xml.dom.minidom to xml.etree". TBR=dpranke@chromium.org BUG= TEST= git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80785 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
Throws exceptions on mac. R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/6811020 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80771 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
The reason of this change (beside deleting 30 lines) is to fix pylint on Mac. For an unknown reason, it was dying here trying to process the minidom import. R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/6799021 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80770 0039d316-1c4b-4281-b951-d872f2087c98
-
- 01 Apr, 2011 1 commit
-
-
maruel@chromium.org authored
R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/6791018 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80212 0039d316-1c4b-4281-b951-d872f2087c98
-
- 25 Mar, 2011 1 commit
-
-
maruel@chromium.org authored
Mostly happening on Mac. Will investigate later. TBR=dpranke BUG= TEST= Review URL: http://codereview.chromium.org/6696094 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@79354 0039d316-1c4b-4281-b951-d872f2087c98
-
- 23 Mar, 2011 2 commits
-
-
tony@chromium.org authored
with python 2.5.1. Traceback (most recent call last): File "/Users/tc/depot_tools/gclient.py", line 1270, in <module> fix_encoding.fix_encoding() File "/Users/tc/depot_tools/fix_encoding.py", line 350, in fix_encoding ret &= fix_default_encoding() File "/Users/tc/depot_tools/fix_encoding.py", line 51, in fix_default_encoding lang = locale.getlocale(aref)[0] File "/System/Library/Frameworks/Python.framework/Versions/2.5/lib/python2.5/locale.py", line 460, in getlocale return _parse_localename(localename) File "/System/Library/Frameworks/Python.framework/Versions/2.5/lib/python2.5/locale.py", line 373, in _parse_localename raise ValueError, 'unknown locale: %s' % localename ValueError: unknown locale: C/UTF-8/C/C/C/C R=dpranke@chromium.org,chase@chromium.org,bradnelson@google.com,maruel@chromium.org,evan@chromium.org,nsylvain@chromium.org,nsylvain@google.com Review URL: http://codereview.chromium.org/6730008 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@79213 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
Reapply r79006 with fixes for ubuntu 10.4. The only change is in fix_default_encoding() to trap an exception locale.getlocale() may throw. R=dpranke@chromium.org BUG=none TEST=unit test Review URL: http://codereview.chromium.org/6721029 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@79144 0039d316-1c4b-4281-b951-d872f2087c98
-
- 22 Mar, 2011 2 commits
-
-
maruel@chromium.org authored
It is causing exception for some users on ubuntu 10.4 with: "category LC_ALL is not supported" TBR=dpranke Review URL: http://codereview.chromium.org/6717025 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@79012 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
With this code in action, I can successfully print arabic and chinese on linux and cygwin. It fails to print chinese on my Mac but prints arabic. It prints '?' on Windows console but it *doesn't throw* which is the biggest improvement here. It was particularly a problem on windows because WindowsError's description text is in the current ANSI code page so it failed to print if the text was not pure ASCII, like error message when using Windows' French UI. R=dpranke@chromium.org BUG=none TEST=manual unit test ./tests/fix_encoding_test.py and it shouldn't throw Review URL: http://codereview.chromium.org/6676090 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@79006 0039d316-1c4b-4281-b951-d872f2087c98
-