Commits · b24ca5ac742e6c65e949b2f7f83a2d9b95cff3e9 · Linshizhi / Chromium_Depot_tools

17 Jan, 2020 3 commits

presubmit_support: Initialize Gerrit object when gerrit URL is given. · b24ca5ac

Edward Lemur authored Jan 17, 2020

Only gerrit_url is needed to initialize gerrit_obj.
This will be needed for git cl to call presubmit support
as a script.

Bug: 1042324
Change-Id: I79d78fb67465f989755bf8c8ceb48d665464fa05
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2005050Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

b24ca5ac

scm: Add GetAllFiles method. · 98cfac11

Edward Lemur authored Jan 17, 2020

Will be used by presubmit_support to run checks over all files on a repo.

Bug: 1042324
Change-Id: I872b4eb7f287f3a4b14d753cad73d0c5d7beb00c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2002961Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

98cfac11

presubmit_support: Use single quotes and convert to ArgumentParser. · a5799e3b

Edward Lemur authored Jan 17, 2020

Change-Id: I54f0fe3a2257166cba2a69659e5128e4ac9310bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2001707Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

a5799e3b

16 Jan, 2020 1 commit

Roll bb tool to @ 9b687fbe · 05b001c2

Andrii Shyshkalov authored Jan 16, 2020

Old revision: b7405423

Change logs:
  infra/infra:
    https://chromium.googlesource.com/infra/infra/+log/b7405423..9b687fbe
  luci-go
    https://chromium.googlesource.com/infra/luci/luci-go/+log/93937dc8..fa8b9bf0

Bug: 1041950
Change-Id: I79998caa77685240a61273d7f9a99b7fff2d0cd4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2005468
Auto-Submit: Andrii Shyshkalov <tandrii@google.com>
Reviewed-by: LaMont Jones <lamontjones@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@google.com>

05b001c2

15 Jan, 2020 1 commit

subprocess2: Ensure environment keys and values are strings on Python 3 · e9730d75

Raul Tambre authored Jan 15, 2020

Example error during "git cl upload":
Traceback (most recent call last):
  File "C:\Google\depot_tools\presubmit_support.py", line 220, in CallCommand
    returncode, stdout = self._RunWithTimeout(cmd, test.stdin, test.kwargs)
  File "C:\Google\depot_tools\presubmit_support.py", line 204, in _RunWithTimeout
    p = subprocess.Popen(cmd, **kwargs)
  File "C:\Google\depot_tools\subprocess2.py", line 143, in __init__
    super(Popen, self).__init__(args, **kwargs)
  File "C:\Google\depot_tools\bootstrap-3_8_0b1_chromium_1_bin\python\bin\Lib\subprocess.py", line 390, in __init__
    errread, errwrite)
  File "C:\Google\depot_tools\bootstrap-3_8_0b1_chromium_1_bin\python\bin\Lib\subprocess.py", line 640, in _execute_child
    startupinfo)
TypeError: environment can only contain strings

Bug: 984182
Change-Id: Id996d73a80845aaeaa061107ed123627091cb600
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1815872
Commit-Queue: Raul Tambre <raul@tambre.ee>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Auto-Submit: Raul Tambre <raul@tambre.ee>

e9730d75

14 Jan, 2020 4 commits

my_activity: Make compatible with Python 3. · 2a048032

Edward Lemur authored Jan 14, 2020

Bug: 1009820
Change-Id: I2aa619eb1cc70f7cacd27cbc2afc5c04c3a77d1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2001224Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

2a048032

subcommand: Add tests. · 1c3b4bec

Edward Lemur authored Jan 14, 2020

Change-Id: I730f364f30b0d211c2db6da0d6bb4f5ff3c948da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1999280Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

1c3b4bec

[lucicfg] Update v1.11.14 => v1.11.17. · ce09ca54

Vadim Shtayura authored Jan 14, 2020

Changes:
  * luci.notifier_template(...) validates its name.
  * time.epoch(...) functions to parse timestamp strings into Unix times.
  * Internal digests.star module to calculate SHA256s.

R=iannucci@chromium.org

Change-Id: I58a3d9e11a2b278a0fd1e74169d6c57e048488f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2000986
Auto-Submit: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

ce09ca54

Run autoninja scripts using vpython. · 59a3b2fd

Edward Lemur authored Jan 14, 2020

Bug: 1002153
Change-Id: I769a5370d726f4ce478035f59bfd1df50fef452e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1992315Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

59a3b2fd

13 Jan, 2020 4 commits

metrics: Update documentation · 22470358

Edward Lesmes authored Jan 13, 2020

The link that points to all known strings is outdated.

Change-Id: I40f7fd2b80fc0129eff5947ed6881d11934cb275
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1998084
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Anthony Polito <apolito@google.com>

22470358

Reland "presubmit_canned_checks: Run pylint on parent directory for depot_tools." · bce1ec1d

Edward Lemur authored Jan 13, 2020

This is a reland of d3bfd23c

Don't modify cwd for paths other than depot_tools.

Original change's description:
> presubmit_canned_checks: Run pylint on parent directory for depot_tools.
>
> On Windows, scripts on the current directory take precedence over PATH.
> When pylint.bat calls vpython, it executes the vpython of the depot_tools
> under test instead of the one in the bot.
> As a workaround, run the tests from the parent directory instead.
>
> Change-Id: I7fa3f5b268df516194063ff39907ada18f7ef544
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1994216
> Reviewed-by: Anthony Polito <apolito@google.com>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

No-Presubmit: True
Change-Id: I4236ec17b2642ed7f53844af532ec1f5234b80d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1995783
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Anthony Polito <apolito@google.com>

bce1ec1d

Revert "presubmit_canned_checks: Run pylint on parent directory for depot_tools." · a1266b63

Dean Berris authored Jan 13, 2020

This reverts commit d3bfd23c.

Reason for revert: Breaks non-depot_tools based presubmits that use canned checks that expect the presubmit to be run in the sub-repository (for example, in Catapult where it's hosted in third_party/catapult instead of being directly in chromium).

Original change's description:
> presubmit_canned_checks: Run pylint on parent directory for depot_tools.
> 
> On Windows, scripts on the current directory take precedence over PATH.
> When pylint.bat calls vpython, it executes the vpython of the depot_tools
> under test instead of the one in the bot.
> As a workaround, run the tests from the parent directory instead.
> 
> Change-Id: I7fa3f5b268df516194063ff39907ada18f7ef544
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1994216
> Reviewed-by: Anthony Polito <apolito@google.com>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

TBR=ehmaldonado@chromium.org,apolito@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: If989527a53be90e1ae32cb3fa30f5e4777824480
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1994753Reviewed-by: Dean Berris <dberris@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Dean Berris <dberris@chromium.org>

a1266b63

Re-land "git-cl: Fix format --dry-run not working with --full." · 5e96ad12

Jamie Madill authored Jan 13, 2020

Re-land fixes format always saying the folder was dirty.

The --full option would skip setting the return value of the format
command when used with --dry-run. This in turn would cause the
presubmit check to always pass when --full was enabled in a repo by
default.

Was discovered in the ANGLE repository.

Bug: angleproject:4241
Change-Id: I986646336d1857af2826863ef4becbf2b9ee3049
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1993910
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

5e96ad12

11 Jan, 2020 1 commit

vpython3: Fix path to python 3 · 7a8bf948

Edward Lesmes authored Jan 11, 2020

Bug: 1036606
Change-Id: I035250757e346f89390b36d44701f0b6b8d8d024
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1995888
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>

7a8bf948

10 Jan, 2020 6 commits

Reland "vpython: Specify interpreter to run." · dfadd9d7

Edward Lesmes authored Jan 10, 2020

This is a reland of 797d74a2

Original change's description:
> vpython: Specify interpreter to run.
> 
> Specify the interpreter to run to avoid issues with several
> python installations on Windows.
> 
> Bug: 1036606
> 
> Change-Id: Ib70d041acc52c940711460219acd8f4ad58637a9
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1992608
> Reviewed-by: Anthony Polito <apolito@google.com>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

Bug: 1036606
Change-Id: Ibf6727249b40c5a9f5f877353c8d42fe66404cf8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1994215Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

dfadd9d7

presubmit_canned_checks: Run pylint on parent directory for depot_tools. · d3bfd23c

Edward Lemur authored Jan 10, 2020

On Windows, scripts on the current directory take precedence over PATH.
When pylint.bat calls vpython, it executes the vpython of the depot_tools
under test instead of the one in the bot.
As a workaround, run the tests from the parent directory instead.

Change-Id: I7fa3f5b268df516194063ff39907ada18f7ef544
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1994216Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

d3bfd23c

git-map: Refactor and add simple tests · b800fde5

Edward Lemur authored Jan 10, 2020

Change-Id: I8fd0034f6a6d7623792620f92208b25961fa174e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1990142Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

b800fde5

gsutil.vpython: Set vpython_version: 2.7 · 8b52ca7a

Edward Lesmes authored Jan 10, 2020

Bug: 1041020
Change-Id: I725a599dcd5dc8b2a18d49bad33b2dbdcfe7ac8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1994428
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

8b52ca7a

Revert "git-cl: Fix format --dry-run not working with --full." · 177710b3

Jamie Madill authored Jan 10, 2020

This reverts commit fc132e61.

Reason for revert: Causes all presubmit checks to return dirty
format because of a non-zero diff output.

Original change's description:
> git-cl: Fix format --dry-run not working with --full.
> 
> The --full option would skip setting the return value of the format
> command when used with --dry-run. This in turn would cause the
> presubmit check to always pass when --full was enabled in a repo by
> default.
> 
> Was discovered in the ANGLE repository.
> 
> Bug: angleproject:4241
> Change-Id: Ie6cb423a6818c1e26781d77938a0dd22c02b4c16
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1987835
> Commit-Queue: Jamie Madill <jmadill@chromium.org>
> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
> Auto-Submit: Jamie Madill <jmadill@chromium.org>

TBR=ehmaldonado@chromium.org,jmadill@chromium.org

Change-Id: I0a4c51117ab20606f6dbb1f7a3ba40f87da1e939
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: angleproject:4241
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1993907Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

177710b3

git-cl: Fix format --dry-run not working with --full. · fc132e61

Jamie Madill authored Jan 10, 2020

The --full option would skip setting the return value of the format
command when used with --dry-run. This in turn would cause the
presubmit check to always pass when --full was enabled in a repo by
default.

Was discovered in the ANGLE repository.

Bug: angleproject:4241
Change-Id: Ie6cb423a6818c1e26781d77938a0dd22c02b4c16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1987835
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Auto-Submit: Jamie Madill <jmadill@chromium.org>

fc132e61

09 Jan, 2020 4 commits

Revert "vpython: Specify interpreter to run." · 13928b7e

Edward Lesmes authored Jan 09, 2020

This reverts commit 797d74a2.

Reason for revert: Causes pylint to fail executing on "Depot Tools Presubmit (win)".

Original change's description:
> vpython: Specify interpreter to run.
> 
> Specify the interpreter to run to avoid issues with several
> python installations on Windows.
> 
> Bug: 1036606
> 
> Change-Id: Ib70d041acc52c940711460219acd8f4ad58637a9
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1992608
> Reviewed-by: Anthony Polito <apolito@google.com>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

TBR=ehmaldonado@chromium.org,apolito@google.com

Change-Id: I5902ceb9db85fdad81e781b51281fba8534a99d5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1036606
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1994114Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

13928b7e

Roll recipe dependencies (trivial). · 12f8d69f

recipe-roller authored Jan 09, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/ec5140c30b91e961996b5bd690b8c27f01dd9c56 path: add relpath to the list of filtered methods. (jbudorick@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I637192b1f4ad38d75300267a88031a3ac593130c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1993512Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

12f8d69f

vpython: Specify interpreter to run. · 797d74a2

Edward Lesmes authored Jan 09, 2020

Specify the interpreter to run to avoid issues with several
python installations on Windows.

Bug: 1036606

Change-Id: Ib70d041acc52c940711460219acd8f4ad58637a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1992608Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

797d74a2

vpython3: Add Python3 bin dir to PATH on Windows · b92d2052

Edward Lesmes authored Jan 09, 2020

As a workaround, add the Python3 bin dir to PATH so that the necessary DLLs are available.

Bug: 1003139
Change-Id: I7b3e05922be3fcb7b0ec2b06783a86f25484310b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1992270Reviewed-by: smut <smut@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

b92d2052

08 Jan, 2020 4 commits

Roll recipe dependencies (trivial). · 081c5b59

recipe-roller authored Jan 08, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/2438e081638a16b8de53752c5a78c807195ed186 Return a disabled ModuleTestData from DisabledTestData. (gbeaty@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ide989abae53f5c3f7079f0da4f7305fe41b158a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1991991Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

081c5b59

git-hyper-blame: Simplify code and tests. · 0d462e99

Edward Lemur authored Jan 08, 2020

Remove default value from optional arguments, since they are always passed.

In particular, the default value for `out` was a text stream (sys.stdout),
but the value passed to `out` is always a binary stream, which is confusing.
Get rid of the `err` argument, since it is always sys.stderr, and only used
for testing.

Change-Id: Ia289e9a97b968a0c802fc2f419397c1e494f713c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1986064Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>

0d462e99

depot_tools: Add tests for gclient_paths · 84b5f9a2

Edward Lemur authored Jan 08, 2020

Change-Id: I544aa85b040544508df8ed16310def982356fbcc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1949417
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Anthony Polito <apolito@google.com>

84b5f9a2

Roll recipe dependencies (trivial). · 9253a685

recipe-roller authored Jan 08, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/a100ae5fb1cd5a66508d69f9bee7fb69b70b0135 [vpython] Bump asn1crypto to 1.0.1 to fix crash on macOS Catalina (athom@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I9247a743105b8d1a5a0e4796cdec8fc4710863e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1992106Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

9253a685

07 Jan, 2020 7 commits

Roll recipe dependencies (trivial). · 3a797afd

recipe-roller authored Jan 07, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/1cbfca1cec9aedcd01cfe190a1569d2f42c8912b Update the attrs dependency to the current version. (gbeaty@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ic4173c4b07358fdbbeb53ee9d204d44311cda951
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1987844Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

3a797afd

Revert "Move httplib2 import above third_party." · 19610433

Edward Lesmes authored Jan 07, 2020

This reverts commit cd1331ea.

Reason for revert:
Original CL was reverted.

Original change's description:
> Move httplib2 import above third_party.
> 
> 7fd6347b removed the third_party/httplib2 files, but left the pyc files. This is breaking CQ for nest.
> 
> move httplib2 import above adding third_party to the path in ninjalog_uploader_wrapper to fix.
> 
> Change-Id: Id28f68ce7e3eb94783bdd5ee7ce15ae5930fde7e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1988690
> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
> Commit-Queue: Mark Orchard <morchard@google.com>

TBR=ehmaldonado@webrtc.org,ehmaldonado@chromium.org,morchard@google.com,apolito@google.com

Change-Id: Ic7775cdb4abae1855358711335349fc39eb37dfb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1988739Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

19610433

Update "git cl format --python" to default to PEP-8 · fa40bfa3

Andrew Grieve authored Jan 07, 2020

This matches the recent change Chromium's Python style guide.
This also changes the .style.yapf in depot_tools to be explicit
about the style used in this repo.

Bug: 846432
Change-Id: I4947a90aec1739a9a86ffc9bfc5eacc1182dc186
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1987006Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>

fa40bfa3

Move httplib2 import above third_party. · cd1331ea

Mark Orchard authored Jan 07, 2020

7fd6347b removed the third_party/httplib2 files, but left the pyc files. This is breaking CQ for nest.

move httplib2 import above adding third_party to the path in ninjalog_uploader_wrapper to fix.

Change-Id: Id28f68ce7e3eb94783bdd5ee7ce15ae5930fde7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1988690Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Mark Orchard <morchard@google.com>

cd1331ea

Roll recipe dependencies (trivial). · 6ae3921d

recipe-roller authored Jan 07, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/f46d187695175b7a4cd0a76ef58b364890499f2d Minor clean-up of docs (garymm@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I0af5598af451814b5c2d700e114522bed577443b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1989013Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

6ae3921d

Roll recipe dependencies (trivial). · 2616b72b

recipe-roller authored Jan 07, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/bf4885534ce2e5214c7ef1a015296d79bfab6b7b [resultdb] Log output (nodir@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Iceccf6abb75db28c2155e48d540c0be5d0d6f31a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1989011Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

2616b72b

Revert "depot_tools: Remove third_party/httplib2." · d0de3a7b

Dan Field authored Jan 07, 2020

This reverts commit 7fd6347b.

Reason for revert: This broke Flutter CI - we're not using vpython everywhere yet

Original change's description:
> depot_tools: Remove third_party/httplib2.
> 
> depot_tools' scripts have been using vpython httplib2 for a while.
> 
> Change-Id: I9403d92332c74de0ed69d6f59f60c81772d0577a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1978983
> Reviewed-by: Anthony Polito <apolito@google.com>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

TBR=ehmaldonado@chromium.org,apolito@google.com

Change-Id: Ie53a8d07ccfba5a7cc5bcb431d4f7b897f66788a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1989012Reviewed-by: Dan Field <dnfield@google.com>
Commit-Queue: Dan Field <dnfield@google.com>

d0de3a7b

06 Jan, 2020 5 commits

depot_tools: Use mock from vpython (or unittest.mock) instead of third_party/mock · a8145025

Edward Lemur authored Jan 06, 2020

Change-Id: I3a188b34ae5f62649108afe08fe0e389a408c2ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1947933
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Anthony Polito <apolito@google.com>

a8145025

Add flag to "git cl format" to avoid invoking clang-format. · ed0cc5f6

Garrett Beaty authored Jan 06, 2020

In repos that are checked out separately from chromium, invoking
"git cl format" on a change that has files that would be formatted using
clang-format causes an error because the depot_tools version of
clang-format looks for a clang-format inside the repo.

This prevents using proto-based properties (the preferred mechanism
going forward) in recipe repos that enforce formatting. The
--no-clang-format flag provides a workaround that can be used to
prevent trying to format any files where clang-format doesn't work.

Bug: 979330
Change-Id: Ice8561d88b29623deb953465253f92c88aa7fc2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1986111
Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

ed0cc5f6

Fix the --no-python flag for git cl format. · 91a6f338

Garrett Beaty authored Jan 06, 2020

The current behavior of the --no-python flag doesn't disable formatting
for python files. Instead, it has the same effect as the --python flag.

Change-Id: I26024d3030b9c873180b488d00351676c37c9492
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1985785
Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

91a6f338

presubmit_support: Add timeout to presubmit tests. · ecc27074

Edward Lemur authored Jan 06, 2020

Change-Id: I7a434d4420573c6e5fc014455b011984f4d681b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1952159Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

ecc27074

depot_tools: Remove third_party/httplib2. · 7fd6347b

Edward Lemur authored Jan 06, 2020

depot_tools' scripts have been using vpython httplib2 for a while.

Change-Id: I9403d92332c74de0ed69d6f59f60c81772d0577a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1978983Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

7fd6347b