- 09 Nov, 2018 5 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/519790719eb481c3c7282d76da6010dc0f5418c7 Add ability to mock git ref (sergiyb@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I200ce62c30b96523912701c723ab88d3f772d61d Reviewed-on: https://chromium-review.googlesource.com/c/1330183Reviewed-by:
Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
-
Mohamed Heikal authored
Currently git cl owners tries to fetch the current reviewers of a CL from gerrit. However, this fails with a KeyError when there are no reviewers currently. This cl fixes that bug. Bug: 895722 Change-Id: I78a998ee234d207523aa2cef4b5058ba7cfecbc2 Reviewed-on: https://chromium-review.googlesource.com/c/1330122 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org>
-
Peter Boström authored
Mentioning these commands make it easier for folks to get rid of the large notice. Bug: None Change-Id: I85dd0e1ec0d33999af46f9e20b95bea05bd40a1e Reviewed-on: https://chromium-review.googlesource.com/c/1330181 Auto-Submit: Peter Boström <pbos@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org>
-
Vadim Shtayura authored
The most notable change is in how the integrity of the tag cache file is checked. Once deployed, existing tag cache files will be considered invalid and wiped. The only observable side effect is the following line in the log: "can't deserialize tag cache - no sha256 is recorded in the file" R=tandrii@chromium.org, iannucci@chromium.org Change-Id: I7ea300a4e7ad8be0c1d42ae561c5202420d2db62 Reviewed-on: https://chromium-review.googlesource.com/c/1327823Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
-
Yoshisato Yanagisawa authored
Bug: b/77176746 Change-Id: I8f027daa6f867d61f0a9124a6d22c512bf91f219 Reviewed-on: https://chromium-review.googlesource.com/c/1325267Reviewed-by:
-
- 08 Nov, 2018 6 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/a5a5b1ee65266762db9839ed8ac32eb325c53dca Remove old run code (martiniss@google.com) https://crrev.com/0c993cb828b335e2fc0528c149f8060c35ebf0ac Revert "Remove old run code" (martiniss@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I7fbab5d8255120016278cde25eefcbe6bb6f2f67 Reviewed-on: https://chromium-review.googlesource.com/c/1327627Reviewed-by:
-
Ben Pastene authored
I'm writing a recipe that makes heavy use of gsutil's ls and cat, and some of the calls are expected to fail. So this allows the user to make those that fail do so as normal steps. R=iannucci, tandrii Bug: 866062 Change-Id: I4c9cdcb77c00afd4ab8fefd146f22fa94fcc37d7 Reviewed-on: https://chromium-review.googlesource.com/c/1325332Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org>
-
Stephen Martinis authored
This reverts commit fc810ab2. Reason for revert: Broke everything Original change's description: > Roll recipe dependencies (trivial). > > This is an automated CL created by the recipe roller. This CL rolls recipe > changes from upstream projects (e.g. depot_tools) into downstream projects > (e.g. tools/build). > > > More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. > recipe_engine: > https://crrev.com/a5a5b1ee65266762db9839ed8ac32eb325c53dca Remove old run code (martiniss@google.com) > > > TBR=iannucci@chromium.org > > Recipe-Tryjob-Bypass-Reason: Autoroller > Bugdroid-Send-Email: False > Change-Id: Ieac443303891c032ddec11b24004774595cd954a > Reviewed-on: https://chromium-review.googlesource.com/c/1327623 > Reviewed-by: Recipe Roller <recipe-roller@chromium.org> > Commit-Queue: Recipe Roller <recipe-roller@chromium.org> TBR=iannucci@chromium.org,recipe-roller@chromium.org Change-Id: Iad38bee7bc5dcb0d342f5a3b1a072c458a8257d6 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1327505Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/a5a5b1ee65266762db9839ed8ac32eb325c53dca Remove old run code (martiniss@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ieac443303891c032ddec11b24004774595cd954a Reviewed-on: https://chromium-review.googlesource.com/c/1327623Reviewed-by:
-
Edward Lemur authored
Tbr: tandrii@chromium.org Bug: 881860 Change-Id: I17dd5c3b6e3fc6da126487b03ea4fc5aa06c2898 Reviewed-on: https://chromium-review.googlesource.com/c/1326561Reviewed-by:
-
Dan Beam authored
Example error: https://gist.github.com/danbeam/3c6b1f98b5d4a921a583a6f070ed0bf0 R=dpranke@chromium.org BUG=none Change-Id: Ib3406ce04782b08b1761506b494b96a827fa4a84 Reviewed-on: https://chromium-review.googlesource.com/c/1299615 Commit-Queue: Dan Beam <dbeam@chromium.org> Reviewed-by:
-
- 07 Nov, 2018 6 commits
-
-
Allen Bauer authored
Bug: 902930 Change-Id: I5f160cd2ff7a9da603b029c894c84db1c5ed8374 Reviewed-on: https://chromium-review.googlesource.com/c/1324650Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org>
-
Edward Lemur authored
Bug: 881860 Change-Id: I96a1e8f3ed9fe032307b49d7a130d512e050369e Reviewed-on: https://chromium-review.googlesource.com/c/1306013Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/5d8bfa9fef017493107749f2af885ba5e6b805f7 Add ability to override buildnumber via buildbucket module's test API (sergiyb@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I5eebd5b44c729ebc4e1488d6c0ef498b25edf3d4 Reviewed-on: https://chromium-review.googlesource.com/c/1323869Reviewed-by:
-
Lowell Manners authored
Before this change, when running gn.py outside of the checkout, the error was: AttributeError: 'NoneType' object has no attribute 'endswith' R=scottmg@chromium.org Bug: gn:14 Change-Id: I4f2f83b2a861bd6f9436c16c2c422fe18fab8f2a Reviewed-on: https://chromium-review.googlesource.com/c/1299023Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Lowell Manners <lowell@google.com>
-
Yoshisato Yanagisawa authored
When people execute autoninja, I believe people would expect ninja in the autoninja directory would be used. However, the original code find ninja from PATH, and ninja in other directory could be used. People usually do not notice this because having depot_tools in PATH is recommended for Chromium developers. However, in some environments, an old version ninja is pre-installed, and unexpected version ninja could be used upon PATH environment. Also, in most of bots, depot_tools directory is not included in PATH. Autoninja execution would fail there because the system cannot find ninja. Bug: b/77176746 Change-Id: Iad8bd952dc1e34a9d303fd5b493c555156369a17 Reviewed-on: https://chromium-review.googlesource.com/c/1319489Reviewed-by:
Fumitoshi Ukai <ukai@chromium.org> Reviewed-by:
Shinya Kawanaka <shinyak@chromium.org> Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Auto-Submit: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
-
John Budorick authored
Bug: 856278 Change-Id: I9aa7cd933a54ba675bdeadb7888d0205a080ea62 Reviewed-on: https://chromium-review.googlesource.com/c/1315470Reviewed-by:
-
- 05 Nov, 2018 3 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/c00f13df3e9b3c9bbd191ace36502341f1f2cc52 [isolated] Add ability to add an array of files. (joshuaseaton@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I1da91c43f113b1536e744e0f93714dfaadd8b43c Reviewed-on: https://chromium-review.googlesource.com/c/1318494Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/0aa0d59a984e8a2fbc99205ea3de860416bc5107 [isolated] Update path to isolated binary (joshuaseaton@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I074d077d42c3637eb6f69f5841bbe26778da13ce Reviewed-on: https://chromium-review.googlesource.com/c/1318492Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/834ac61e122d54c0409b2789490f7b5d5684aea2 [cipd] Permit unicode cipd tags (joshuaseaton@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ice67d5f088116fbfcde1c312325cae2c776deb27 Reviewed-on: https://chromium-review.googlesource.com/c/1318491Reviewed-by:
-
- 03 Nov, 2018 3 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/001848147e74b8f8e63e32dc8bed9ff16e11820f [isolated] Upstream fuchsia's isolated recipe module (joshuaseaton@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Iad829cba40508e05be2a351474f35ceb6f3c48fd Reviewed-on: https://chromium-review.googlesource.com/c/1316907Reviewed-by:
-
Edward Lemur authored
Bug: 897394 Change-Id: I07959e870fef4e6a6b8e6e7c974397d3306460c1 Reviewed-on: https://chromium-review.googlesource.com/c/1315839 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
-
Mathieu Binette authored
Change-Id: I97fc6e677cdbab0e2bd74b5b04a74badbd1b0b1e Reviewed-on: https://chromium-review.googlesource.com/c/1313232 Commit-Queue: Mathieu Binette <mbinette@google.com> Reviewed-by:
Jao-ke Chin-Lee <jchinlee@chromium.org> Reviewed-by:
-
- 01 Nov, 2018 6 commits
-
-
Edward Lemur authored
Bug: 897394 Change-Id: I52a31bb4840b5de89b96545a3e7544c6708f148f Reviewed-on: https://chromium-review.googlesource.com/c/1312240Reviewed-by:
-
Edward Lemur authored
Make it possible to refer to built-in variables without having to declare then in DEPS files. Bug: None Change-Id: I5403963052463befc074f29750de56cce13927ce Reviewed-on: https://chromium-review.googlesource.com/c/1312234Reviewed-by:
-
Takuto Ikuta authored
Change-Id: I6923bced3700434a15756fa33f713cf4521b9041 Reviewed-on: https://chromium-review.googlesource.com/c/1312416Reviewed-by:
-
Daniel Cheng authored
The script gets confused on Windows, because the path delimieter is \, not /. Bug: 899724 Change-Id: Id907aceb4f7bb6fcc0460245890b9e4716054ff9 Reviewed-on: https://chromium-review.googlesource.com/c/1308897Reviewed-by:
-
Yoshisato Yanagisawa authored
Make autoninja path also available via depot_tools recipe module, and make autoninja used where it is needed. Bug: b/77176746 Change-Id: I8553cb3fb32f98e2e3ff420c255461b7e7da7df6 Reviewed-on: https://chromium-review.googlesource.com/c/1293112Reviewed-by:
-
Yoshisato Yanagisawa authored
autoninja automatically sets -l <num_cores>. -l option makes ninja not invoke a new command if current CPU load average is above -l. However, as far as I investigated, -l <num_cores> make the build much slower than without -l especially on Linux & OSX machines with small numbers of cores. I should say -l decreases the build performance. When I build Chromium with Goma with the same -j with autoninja without -l, the load average goes more than the number of cores while keeping the machine working as usual. Also, ninja can invoke commands until the spike of command invocation is reflected to load average, -l might not mitigate for a machine to get stuck by too high load. Note that from what I understand from the implementation, Windows ninja's posix-compatible load average is always less than num_cores. i.e. -l <num_cores> won't limit the process invocation. https://github.com/ninja-build/ninja/blob/59849864592b421e0a8f993011e7e5c2ab27e77b/src/util.cc#L479 Let me make autoninja not set -l and bring better build performance on machines with small number of cores. Bug: b/117810340 Change-Id: I50f231f1a8976f8ecfc3a0c778f0f1ac98d3827f Reviewed-on: https://chromium-review.googlesource.com/c/1290611Reviewed-by:
-
- 31 Oct, 2018 1 commit
-
-
Edward Lemur authored
Bug: None Change-Id: I73545ad59134c6e5dbeb47fb2e8168a5afc0e497 Reviewed-on: https://chromium-review.googlesource.com/c/1296861 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
-
- 30 Oct, 2018 6 commits
-
-
Stephen Martinis authored
Manual roll for https://crrev.com/c/1239574/ TBR=iannucci Recipe-Manual-Change: build Recipe-Manual-Change: infra Recipe-Manual-Change: build_limited_scripts_slave Recipe-Manual-Change: release_scripts Recipe-Manual-Change: skiabuildbot Recipe-Manual-Change: skia Bug: 646142 Change-Id: I56f156c05a695cfb00b9e0a7f335d516153a70c7 Reviewed-on: https://chromium-review.googlesource.com/c/1305041 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
-
Edward Lemur authored
Bug: 897394 Change-Id: I055e844299e262be81d5ac52ef24571b8fdfd47c Reviewed-on: https://chromium-review.googlesource.com/c/1292245 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Andy Perelson <ajp@chromium.org> Reviewed-by:
-
Andrii Shyshkalov authored
Except when TBR is active, because it's not clear how to compute max score for Code-Review label before uploading a change. Tested with this very own CL: To https://chromium.googlesource.com/chromium/tools/depot_tools.git * [new branch] c78de165c7be156bdf8032c0ce3d8bad42778f1c -> refs/for/refs/heads/master%ready,notify=ALL,m=Initial_upload,r=ehmaldonado, cc=ajp,cc=chromium-reviews@chromium.org,cc=iannucci+depot_tools@chromium.org, l=Commit-Queue+1,hashtag=git-cl-upload R=ehmaldonado Bug: 877717 Change-Id: I464d9df2814bd830dd608bb881040e2dd3c41dbb Reviewed-on: https://chromium-review.googlesource.com/c/1307052Reviewed-by:
-
Andrii Shyshkalov authored
For other hosts, behavior is not changed. Tested on this very CL: To https://chromium.googlesource.com/chromium/tools/depot_tools.git * [new branch] 9057c2235b096f1feae61d65569641fc7c08a0e2 -> refs/for/refs/heads/master%ready,notify=ALL,m=Initial_upload,r=ehmaldonado,cc=chromium-reviews@chromium.org,cc=iannucci+depot_tools@chromium.org,hashtag=git-cl-upload R=ehmaldonado Bug: 877717 Change-Id: I951fc576105211590c6c303ce0ed2fe142628224 Reviewed-on: https://chromium-review.googlesource.com/c/1307051Reviewed-by:
-
Andrii Shyshkalov authored
R=ehmaldonado Change-Id: I321de4b0f33dd17473b012bcaddbb925aab7929f Bug: 877717 Reviewed-on: https://chromium-review.googlesource.com/c/1296855Reviewed-by:
-
Andrii Shyshkalov authored
R=ehmaldonado Bug: 877717 Change-Id: If8cce9453ca72b3b300902f5a03e7a8aa93d17b5 Reviewed-on: https://chromium-review.googlesource.com/c/1296856Reviewed-by:
-
- 28 Oct, 2018 1 commit
-
-
Sergiy Byelozyorov authored
R=tandrii@chromium.org Change-Id: Icc4a4432ee51f24bd46001180a009b5b6bff8998 Reviewed-on: https://chromium-review.googlesource.com/c/1296521Reviewed-by:
-
- 24 Oct, 2018 1 commit
-
-
Sergiy Byelozyorov authored
R=nodir@chromium.org Change-Id: I0816a109bc50cbc5c06339b832748f03abee372a Reviewed-on: https://chromium-review.googlesource.com/c/1296511 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
Nodir Turakulov <nodir@chromium.org>
-
- 23 Oct, 2018 2 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/04620158d8f45c68cc8bc39e30ce4a85c368046a [archive] Add extended-length path support for windows. (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ic26a7c96c2eda21b232e11c407a198fe928568e7 Reviewed-on: https://chromium-review.googlesource.com/c/1297194Reviewed-by:
-
Edward Lemur authored
Bug: 897394 Change-Id: I92d2514e4347f02dbcf2884bef3a073095ee03a3 Reviewed-on: https://chromium-review.googlesource.com/c/1292242 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
-
