- 26 May, 2015 1 commit
-
-
maruel@chromium.org authored
Subversion usage is going away, tests get the kick first. R=iannucci@chromium.org BUG=475320 Review URL: https://codereview.chromium.org/1158043003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295411 0039d316-1c4b-4281-b951-d872f2087c98
-
- 17 Feb, 2015 1 commit
-
-
primiano@chromium.org authored
Reland crrev.com/743083002, which was reverted in crrev.com/796053002 due to some test flakiness, probably related with an old version of Git on the bots. Relanding now that the infra has been updated to Trusty (plus adding some de-flake precautions). Original CL Description: Make gclient ready for the Blink (DEPS to main project) transition This CL makes gclient understand correctly whether a git project is being moved from DEPS to an upper project and vice-versa. The driving use case for this is the upcoming Blink merge, where third_party/Webkit will be removed from DEPS (and .gitignore) and will become part of the main project. At present state, gclient leaves the .git folder around when a project is removed from DEPS, and that causes many problems. Furthermore this CL solves the performance problem of bisecting across the merge point. The subproject's (Blink) .git/ folder is moved to a backup location (in the main checkout root) and is restored when moving backwards, avoiding a re-fetch when bisecting across the merge point. BUG=431469 Review URL: https://codereview.chromium.org/910913003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@294082 0039d316-1c4b-4281-b951-d872f2087c98
-
- 11 Dec, 2014 2 commits
-
-
primiano@chromium.org authored
Revert of Make gclient ready for the Blink (DEPS to main project) transition (patchset #6 id:180001 of https://codereview.chromium.org/743083002/) Reason for revert: The test intoruced is flake (see crrev.com/753543006/). Need to look into that with more patience as it reproduces only on precise. Original issue's description: > Make gclient ready for the Blink (DEPS to main project) transition > > This CL makes gclient understand correctly whether a git project is > being moved from DEPS to an upper project and vice-versa. > The driving use case for this is the upcoming Blink merge, where > third_party/Webkit will be removed from DEPS (and .gitignore) and will > become part of the main project. > > At present state, gclient leaves the .git folder around when a project > is removed from DEPS, and that causes many problems. > > Furthermore this CL solves the performance problem of bisecting across > the merge point. The subproject's (Blink) .git/ folder is moved to a > backup location (in the main checkout root) and is restored when moving > backwards, avoiding a re-fetch when bisecting across the merge point. > > BUG=431469 > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=293329 TBR=iannucci@chromium.org,maruel@chromium.org,jochen@chromium.org NOTREECHECKS=true NOTRY=true BUG=431469 Review URL: https://codereview.chromium.org/796053002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293352 0039d316-1c4b-4281-b951-d872f2087c98
-
sbc@chromium.org authored
I ran into several failures running the presubmit checks on my Ubuntu/Trusty laptop and it looks like a some of the tests were broken by recent versions of svn and git. Review URL: https://codereview.chromium.org/795723003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293341 0039d316-1c4b-4281-b951-d872f2087c98
-
- 10 Dec, 2014 1 commit
-
-
primiano@chromium.org authored
This CL makes gclient understand correctly whether a git project is being moved from DEPS to an upper project and vice-versa. The driving use case for this is the upcoming Blink merge, where third_party/Webkit will be removed from DEPS (and .gitignore) and will become part of the main project. At present state, gclient leaves the .git folder around when a project is removed from DEPS, and that causes many problems. Furthermore this CL solves the performance problem of bisecting across the merge point. The subproject's (Blink) .git/ folder is moved to a backup location (in the main checkout root) and is restored when moving backwards, avoiding a re-fetch when bisecting across the merge point. BUG=431469 Review URL: https://codereview.chromium.org/743083002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293329 0039d316-1c4b-4281-b951-d872f2087c98
-
- 09 Apr, 2014 1 commit
-
-
borenet@google.com authored
BUG=skia:1638 Review URL: https://codereview.chromium.org/189913020 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@262761 0039d316-1c4b-4281-b951-d872f2087c98
-
- 10 Mar, 2014 2 commits
-
-
thakis@chromium.org authored
Revert of Another attempt: gclient: delete mismatching checkouts (https://codereview.chromium.org/183283003/) Reason for revert: Broke `gclient sync` for me, failing with: Error: 1> Can't update/checkout /Volumes/MacintoshHD2/src/chrome-git/src if an unversioned directory is present. Delete the directory and try again. For someone else, it broke it with: % gclient sync ________ unmanaged solution; skipping src Error: Command svn info --xml returned non-zero exit status 1 in /Users/pawliger/chromium/src/. <?xml version="1.0" encoding="UTF-8"?> <info> svn: E155007: '/Users/pawliger/chromium/src' is not a working copy Original issue's description: > Another attempt: gclient: delete mismatching checkouts > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=255930 TBR=iannucci@chromium.org,szager@chromium.org,maruel@chromium.org,mmoss@chromium.org,borenet@google.com NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/192323006 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@256005 0039d316-1c4b-4281-b951-d872f2087c98
-
borenet@google.com authored
Review URL: https://codereview.chromium.org/183283003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@255930 0039d316-1c4b-4281-b951-d872f2087c98
-
- 15 Oct, 2013 1 commit
-
-
borenet@google.com authored
These are run for a given dependency after it has been synced but before its DEPS have been synced. This will help to switch Chromium to depend on Skia's git repository (skia:1638). Review URL: https://codereview.chromium.org/25322002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@228651 0039d316-1c4b-4281-b951-d872f2087c98
-
- 12 Sep, 2013 1 commit
-
-
rmistry@google.com authored
I cannot reproduce the test failures in https://chromiumcodereview.appspot.com/24047003/ but I figure there must be a good reason tear_down_svn had this check so adding it to tear_down_git. Review URL: https://chromiumcodereview.appspot.com/23437029 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@222785 0039d316-1c4b-4281-b951-d872f2087c98
-
- 18 Apr, 2013 1 commit
-
-
kustermann@google.com authored
Changed the behaviour of '--transitive' in gclient.py to use revision instead of timestamp for identical repositories. Here's some background why we need this: We discovered that google code defines the timestamp of a revision to be the time when a commit was started rather than when it was finished (apache subversion takes the timestamp when the commit transaction is finished). This can result in a situation where revision R(i-1) has a higher timestamp than Ri. See bug: https://code.google.com/p/support/issues/detail?id=30419 When using 'gclient --transitive' we effectively do date-based checkouts. If a parent has a dependency (without a ...@revision) and that dependency lives in the same repository as the parent does we'd like to checkout the exact same revision as the parent (if we do a date-based checkout as we do now the google code bug can result in a situation where we don't get the same revision). Review URL: https://chromiumcodereview.appspot.com/13814012 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@194852 0039d316-1c4b-4281-b951-d872f2087c98
-
- 13 Dec, 2011 1 commit
-
-
maruel@chromium.org authored
That helps weed out some issues faces with svn plus helped me figure out some misuses. Most of the commands have been implicitly depending on os.getcwd(). This change makes it always consistent and clear when dependence on the current directory is needed. Remove default arguments to scm.SVN.GenerateDiff and a few other calls to be sure the refactoring was done right. R=dpranke@chromium.org BUG= TEST=make sure most commands aren't broke Review URL: http://codereview.chromium.org/8771042 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@114262 0039d316-1c4b-4281-b951-d872f2087c98
-
- 30 Nov, 2011 1 commit
-
-
maruel@chromium.org authored
Also, increase the wait for socket binding to 0.2 seconds because OSX10.6 is broken _and_ slow. R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/8749005 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@112277 0039d316-1c4b-4281-b951-d872f2087c98
-
- 11 Nov, 2011 1 commit
-
-
maruel@chromium.org authored
It will simplify importing utility modules from other projects. Otherwise I was getting name conflicts with 'test'. Reenable W0403 that was disabled in the previous CL. R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/8508015 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@109636 0039d316-1c4b-4281-b951-d872f2087c98
-
- 31 May, 2011 1 commit
-
-
nsylvain@google.com authored
TEST=covered by gclient_smoketest.py Review URL: http://codereview.chromium.org/7062029 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@87367 0039d316-1c4b-4281-b951-d872f2087c98
-
- 06 Apr, 2011 1 commit
-
-
maruel@chromium.org authored
Also fix a few issues found along the way. Tests had regressed a lot. Add a lot of tweaks to make most test pass. R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/6792060 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80618 0039d316-1c4b-4281-b951-d872f2087c98
-
- 01 Apr, 2011 1 commit
-
-
maruel@chromium.org authored
Move code in tests/fake_repos.py to subprocess2.py. R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/6783022 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80152 0039d316-1c4b-4281-b951-d872f2087c98
-
- 31 Mar, 2011 1 commit
-
-
maruel@chromium.org authored
Makes all the tests runnable on python 2.5. R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/6690034 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80068 0039d316-1c4b-4281-b951-d872f2087c98
-
- 24 Mar, 2011 1 commit
-
-
maruel@chromium.org authored
This reduces the likehood of conflict with local server and makes possible to run this check two times in parallel. R=dpranke@chromium.org TEST=moar unit tests BUG=none Review URL: http://codereview.chromium.org/6725042 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@79281 0039d316-1c4b-4281-b951-d872f2087c98
-
- 13 Mar, 2011 1 commit
-
-
dpranke@chromium.org authored
Review URL: http://codereview.chromium.org/6681019 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@77955 0039d316-1c4b-4281-b951-d872f2087c98
-
- 09 Mar, 2011 1 commit
-
-
maruel@chromium.org authored
Keep an alias to RemoveDirectory, will be removed in a later change. TEST=new unit test to test this function BUG=none Review URL: http://codereview.chromium.org/6628032 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@77463 0039d316-1c4b-4281-b951-d872f2087c98
-
- 08 Mar, 2011 1 commit
-
-
maruel@chromium.org authored
The tests now base the directory in mkdtemp() which is much safer than using the source's file directory as before. BUG=none TEST=none Review URL: http://codereview.chromium.org/6625018 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@77278 0039d316-1c4b-4281-b951-d872f2087c98
-
- 04 Mar, 2011 2 commits
-
-
maruel@chromium.org authored
Ease support for different port if necessary. BUG=none TEST=none Review URL: http://codereview.chromium.org/6632007 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@76968 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
Add code to wait for the bound port to open and close correctly, removing race conditions. BUG=test reliability TEST=better Review URL: http://codereview.chromium.org/6627013 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@76966 0039d316-1c4b-4281-b951-d872f2087c98
-
- 02 Feb, 2011 2 commits
-
-
maruel@chromium.org authored
NO CODE CHANGE. BUG=none TEST=none Review URL: http://codereview.chromium.org/6349053 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@73510 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
This enables seamless unit tests that check-in files without side-effects on the remaining unit tests. BUG=none TEST=none TBR=dpranke Review URL: http://codereview.chromium.org/6250073 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@73456 0039d316-1c4b-4281-b951-d872f2087c98
-
- 25 Jan, 2011 1 commit
-
-
maruel@chromium.org authored
Also remove the harcoding of the names by putting them in a variable. This will help testing of the commit queue. BUG=none TEST=none Review URL: http://codereview.chromium.org/6350013 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@72454 0039d316-1c4b-4281-b951-d872f2087c98
-
- 21 Dec, 2010 2 commits
-
-
maruel@chromium.org authored
TBR=dpranke BUG= TEST= Review URL: http://codereview.chromium.org/6051004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@69848 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
FakeRepos is useful for offline SCM tests but it was hardcoded for depot_tools requirements. Luckily, it was already modular enought that it merely required to shuffle code around to split it in two classes to be able to reuse the code as-is. BUG= TEST= Review URL: http://codereview.chromium.org/6029004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@69845 0039d316-1c4b-4281-b951-d872f2087c98
-
- 14 Dec, 2010 1 commit
-
-
maruel@chromium.org authored
Change RunPylint to parse all .py files when one is modified. Make all depot_tools/tests pass on pylint. That mostly meant fixing some builtins aliasing, wrong alignment and turning off most remaining warnings. BUG=none TEST=unit tests Review URL: http://codereview.chromium.org/5695007 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@69159 0039d316-1c4b-4281-b951-d872f2087c98
-
- 10 Sep, 2010 1 commit
-
-
maruel@chromium.org authored
For now that involves disabling a lot of tests when they can't be run. I'm unsure about the ascii encoding, it fails here if I keep this call on a French UI. TEST=none BUG=none Review URL: http://codereview.chromium.org/3333028 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@59137 0039d316-1c4b-4281-b951-d872f2087c98
-
- 07 Sep, 2010 1 commit
-
-
maruel@chromium.org authored
Change CheckCallError to inherit from Error. This will simplify try/except changes. TEST=none BUG=none Review URL: http://codereview.chromium.org/3324007 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@58695 0039d316-1c4b-4281-b951-d872f2087c98
-
- 12 Jul, 2010 2 commits
-
-
maruel@chromium.org authored
Emulate running gclient from a checkout containing .gclient and a DEPS, with the solution having an url set to None. TEST=new smoke test Review URL: http://codereview.chromium.org/2897010 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@52119 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
This case covers the webkit gclient usage. TEST=improved smoke test Review URL: http://codereview.chromium.org/2968005 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@52092 0039d316-1c4b-4281-b951-d872f2087c98
-
- 11 Jul, 2010 1 commit
-
-
maruel@chromium.org authored
TBR=bradnelson Review URL: http://codereview.chromium.org/2910006 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@52064 0039d316-1c4b-4281-b951-d872f2087c98
-
- 08 Jul, 2010 1 commit
-
-
maruel@chromium.org authored
TEST=new smoke tests Review URL: http://codereview.chromium.org/2865039 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@51824 0039d316-1c4b-4281-b951-d872f2087c98
-
- 23 Jun, 2010 1 commit
-
-
maruel@chromium.org authored
Move DEPS parsing into a single function. This is a move towards having each DEPS entry being a Dependency instance. TEST=new revinfo unit tests Review URL: http://codereview.chromium.org/2839008 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@50630 0039d316-1c4b-4281-b951-d872f2087c98
-
- 21 Jun, 2010 2 commits
-
-
maruel@chromium.org authored
TBR=nasserg Review URL: http://codereview.chromium.org/2815017 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@50372 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
Move DEPS parsing into a single function. This is a move towards having each DEPS entry being a Dependency instance. TEST=new revinfo unit tests Review URL: http://codereview.chromium.org/2839008 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@50367 0039d316-1c4b-4281-b951-d872f2087c98
-
- 10 Jun, 2010 1 commit
-
-
maruel@chromium.org authored
The recursive DEPS is to be used with From() testing. Didn't enable From() yet since it broke tests and to simplify this change. Review URL: http://codereview.chromium.org/2699005 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@49427 0039d316-1c4b-4281-b951-d872f2087c98
-