- 09 Oct, 2017 1 commit
-
-
Nico Weber authored
The newline is probably here to protect against a hook that doesn't print a trailing newline. I've never seen a hook that did that, and if we found one, we could make the logic look like "print a trailing newline if it's not there" -- or just fix the hook. The newline has been around since depot_tools was created (https://codereview.chromium.org/92087, gclient.py), back then this was in a general "run stuff" function, not in hooks-specific code. Maybe it made more sense back then. This is part of a few changes to make `gclient runhooks` less noisy. Bug: 772741 Change-Id: I285f76dc3f01c5acf5bbaa0be4db9f6edb9c0366 Reviewed-on: https://chromium-review.googlesource.com/706914Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org>
-
- 16 Dec, 2016 1 commit
-
-
Quinten Yearsley authored
This affects a bunch of files, but only changes comments, and shouldn't make any difference to behavior. The purpose is to slightly improve readability of pylint disable comments. Change-Id: Ic6cd0f8de792b31d91c6125f6da2616450b30f11 Reviewed-on: https://chromium-review.googlesource.com/420412Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
-
- 11 Oct, 2016 2 commits
-
-
tandrii authored
Revert of gclient: kill git fetch operation that hangs. (patchset #12 id:220001 of https://codereview.chromium.org/2241843002/ ) Reason for revert: Didn't help. Original issue's description: > gclient: kill git fetch operation that hangs. > > This provides env variable GCLIENT_KILL_GIT_FETCH_AFTER > that kills git fetch if it produces no output for that > many seconds. > > Note that this is not final patch, but an experiment. > See http://crbug.com/635641#c24 for the deployment plan. > > BUG=635641 > R=hinoka@chromium.org > > Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/f8757b7e02226594655230ccbeae3543c7dc49c6 TBR=hinoka@chromium.org,hinoka@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=635641 Review-Url: https://codereview.chromium.org/2410853002
-
tandrii authored
Revert of bot_update/gclient: kill git fetch after timeout regardless of output. (patchset #2 id:20001 of https://codereview.chromium.org/2293013002/ ) Reason for revert: didn't work. Original issue's description: > bot_update/gclient: kill git fetch after timeout regardless of output. > > Also spits out whatever output was produced by git fetch for debugging. > > BUG=635641 > R=machenbach@chromium.org,hinoka@chromium.org > > Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/db8b839320168ab4f5156399ecb275478c0aa2cd TBR=hinoka@chromium.org,machenbach@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=635641 Review-Url: https://codereview.chromium.org/2410053002
-
- 30 Aug, 2016 1 commit
-
-
tandrii authored
Also spits out whatever output was produced by git fetch for debugging. BUG=635641 R=machenbach@chromium.org,hinoka@chromium.org Review-Url: https://codereview.chromium.org/2293013002
-
- 25 Aug, 2016 1 commit
-
-
tandrii authored
This provides env variable GCLIENT_KILL_GIT_FETCH_AFTER that kills git fetch if it produces no output for that many seconds. Note that this is not final patch, but an experiment. See http://crbug.com/635641#c24 for the deployment plan. BUG=635641 R=hinoka@chromium.org Review-Url: https://codereview.chromium.org/2241843002
-
- 11 Apr, 2014 1 commit
-
-
scr@chromium.org authored
BUG=362248 Review URL: https://codereview.chromium.org/233333003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@263252 0039d316-1c4b-4281-b951-d872f2087c98
-
- 13 Mar, 2014 1 commit
-
-
stip@chromium.org authored
depot_tools PRESUBMIT.py and tools/build PRESUBMIT.py both run on cq.golo. If broken dev_appserver.py instances are left around, they will conflict with master ports. BUG=351926 Review URL: https://codereview.chromium.org/197073007 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@256721 0039d316-1c4b-4281-b951-d872f2087c98
-
- 28 Feb, 2014 1 commit
-
-
hinoka@google.com authored
Instead of having custom logic for dealing with cache directories, use git_cache.py to populate caches. Also fixes a bug in git_cache.py where it was looking for lockfiles in cwd rather than the cache dir. Other changes: * _Run now returns output. * Always print to stdout in CheckCallAndFilterOutput, even if it gets a carriage return. This is done because git progress report are carriage returns and not newlines and we don't want everything on the same line and not strip out the CRs. * Removed members changed tests, its not very useful to know a new import is added. BUG=339171 Review URL: https://codereview.chromium.org/180243006 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@254248 0039d316-1c4b-4281-b951-d872f2087c98
-
- 26 Feb, 2014 2 commits
-
-
szager@chromium.org authored
This reverts commit 6ff54485. 'fetch --nohooks chromium' is broken with this change. BUG= Review URL: https://codereview.chromium.org/177003023 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@253640 0039d316-1c4b-4281-b951-d872f2087c98
-
borenet@google.com authored
Review URL: https://codereview.chromium.org/164053003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@253616 0039d316-1c4b-4281-b951-d872f2087c98
-
- 24 Feb, 2014 1 commit
-
-
agable@chromium.org authored
The git cache command is a central place to manage a machine's git cache. It provides two subcommands: * populate -- creates or updates the cache of a given repository * exists -- prints the path to the cache of a repo, if it exists Gclient, deps2git, bot_update, and any other tools that touch the cache will be able to use this command to make sure that everyone is interacting with the cache in the same way. R=hinoka@chromium.org, iannucci@chromium.org BUG=339168 Review URL: https://codereview.chromium.org/164823002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@253007 0039d316-1c4b-4281-b951-d872f2087c98
-
- 16 Jan, 2014 1 commit
-
-
nick@chromium.org authored
as part of the Chromium checkout. This follows the approach used by gn. Changes include: - in-the-PATH clang-format trampoline scripts - clang_format.py, which finds clang-format binaries inside of Chrome - Hook 'git cl format' to the new binaries and scripts - Rearrange some code, for reuse between clang_format.py and gn.py BUG=240309 TEST=presubmits (one failure on mac, but it fails on a clean checkout too) Review URL: https://codereview.chromium.org/134313007 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@245074 0039d316-1c4b-4281-b951-d872f2087c98
-
- 17 Oct, 2013 1 commit
-
-
szager@chromium.org authored
Add retry for all git operations that speak to a remote. This should smooth out issues with the git/gerrit-on-borg service. Review URL: https://codereview.chromium.org/26234004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@229219 0039d316-1c4b-4281-b951-d872f2087c98
-
- 20 Sep, 2013 1 commit
-
-
cyrille@nnamrak.org authored
This solves a problem with "os.rename" sometimes failing with an exception after cloning a dependency to a temporary directory. It's possible the dying git processes still hold a handle to the directory. Since gclient delete the temporary directory regardless of the success of the process, it results in a lot of GB downloaded for nothing. SafeRename solves this by retrying a few times if the renaming fails, sleeping one second every time to get other processes the time to release their lock on the directory. It gives up retrying after 15 times. BUG= R=maruel@chromium.org Review URL: https://chromiumcodereview.appspot.com/23875041 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@224372 0039d316-1c4b-4281-b951-d872f2087c98
-
- 12 Jul, 2013 1 commit
-
-
ilevy@chromium.org authored
We can use this to evaluate the usefulness of making hooks run in parallel. Review URL: https://chromiumcodereview.appspot.com/18851005 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@211446 0039d316-1c4b-4281-b951-d872f2087c98
-
- 03 May, 2013 1 commit
-
-
xusydoc@chromium.org authored
SVN traps SIGINT and attempts to clean itself up, but this results in hangs waiting for TCP. This patch does two things: daemonizes worker threads so they are culled when the main thread dies (is ctrl-C'd) and keeps track of spawned subprocesses to kill any remaining ones when the main program is ctrl-C'd. A user ctrl-C'ing gclient has to manually terminate hung SVN processes, so this introduces no extra data loss or hazard. stracing a hung SVN process shows that it is indeed hanging on TCP reads after receiving a SIGINT, implying there is an underlying but in the SVN binary. Review URL: https://chromiumcodereview.appspot.com/14759006 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@198205 0039d316-1c4b-4281-b951-d872f2087c98
-
- 24 Apr, 2013 1 commit
-
-
digit@chromium.org authored
The 'RemoveDirectory()' function in gclient_utils is deprecated and rmtree() should be used instead for consistency. This patch modifies all clients in depot_tools to use rmtree() instead and removes the RemoveDirectory function. + The SVNWrapperTestCase.testRevertNoDotSvn() mocking expectation has been slightly changed. This was required because the test invokes code that used to call gclient_utils.RemoveDirectory() directly, while only gclient_utils.rmtree() was mocked. BUG=NONE R=maruel@chromium.org, ilevy@chromium.org TEST=manually run gclient_utils_test / gclient_smoketest / scm_unittest / gclient_scm_test Review URL: https://chromiumcodereview.appspot.com/14134010 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@196133 0039d316-1c4b-4281-b951-d872f2087c98
-
- 18 Apr, 2013 1 commit
-
-
borenet@google.com authored
This is needed because the current implementation commonly fails on Windows due to "directory not empty" errors. Using rd is more reliable. Review URL: https://chromiumcodereview.appspot.com/13581005 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@194932 0039d316-1c4b-4281-b951-d872f2087c98
-
- 16 Oct, 2012 1 commit
-
-
ilevy@chromium.org authored
- On high core, fast machines, jobs=8 is does not offer good parallelization. Switch to use number of local cpus. R=maruel@chromium.org BUG= Review URL: https://chromiumcodereview.appspot.com/11140019 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@162072 0039d316-1c4b-4281-b951-d872f2087c98
-
- 12 Sep, 2012 1 commit
-
-
https://codereview.chromium.orgjam@chromium.org authored
Switch gcl/git upload to use https://codereview.chromium.org instead of https://chromiumcodereview.appspot.com. It's been a week since the SSL certificate got added, and the old DNS records had a TTL of 7 days. Review URL: https://chromiumcodereview.appspot.com/10910225 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@156316 0039d316-1c4b-4281-b951-d872f2087c98
-
- 03 Jul, 2012 1 commit
-
-
maruel@chromium.org authored
Otherwise, the files are opened in 'whatever happens to be the current encoding' which is highly system-dependent. Even if some files are not encoded with utf-8, the status quo is even worse. So it's worth trying out. TBR=cmp@chromium.org BUG= TEST= Review URL: https://chromiumcodereview.appspot.com/10697036 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@145306 0039d316-1c4b-4281-b951-d872f2087c98
-
- 16 Apr, 2012 2 commits
-
-
maruel@chromium.org authored
This completely broke syncing on Windows. TBR=mukai@chromium.org BUG= TEST= Review URL: https://chromiumcodereview.appspot.com/9956149 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@132451 0039d316-1c4b-4281-b951-d872f2087c98
-
mukai@chromium.org authored
BUG=114483 TEST=manually Review URL: http://codereview.chromium.org/10034011 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@132446 0039d316-1c4b-4281-b951-d872f2087c98
-
- 16 Jan, 2012 2 commits
-
-
maruel@chromium.org authored
Enable it for git-cl and gcl. R=nsylvain@chromium.org BUG=107838 TEST=New connections go through https:// Review URL: http://codereview.chromium.org/9214004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@117857 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
So any modification to the defaults is coded at only one place. TBR=nsylvain@chromium.org BUG=107838 TEST= Review URL: http://codereview.chromium.org/9214002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@117853 0039d316-1c4b-4281-b951-d872f2087c98
-
- 11 Nov, 2011 1 commit
-
-
maruel@chromium.org authored
It will simplify importing utility modules from other projects. Otherwise I was getting name conflicts with 'test'. Reenable W0403 that was disabled in the previous CL. R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/8508015 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@109636 0039d316-1c4b-4281-b951-d872f2087c98
-
- 10 Nov, 2011 1 commit
-
-
maruel@chromium.org authored
Disable temporarily W0403, will be reenabled on the next CL R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/8508017 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@109435 0039d316-1c4b-4281-b951-d872f2087c98
-
- 25 Oct, 2011 1 commit
-
-
maruel@chromium.org authored
Windows users wouldn't get the same behavior on git cl vs gcl. Improve automatic CRLF<->LF conversion, some gcl users would be \n repeated in their description depending on the editor used. R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/8360007 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@107106 0039d316-1c4b-4281-b951-d872f2087c98
-
- 23 Oct, 2011 1 commit
-
-
maruel@chromium.org authored
Otherwise isatty() could not be proxied correctly. R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/8370004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@106864 0039d316-1c4b-4281-b951-d872f2087c98
-
- 20 Oct, 2011 1 commit
-
-
maruel@chromium.org authored
directory doesn't exist, on fresh checkout and --jobs >1. It happens in the case where there is 3 dependencies: a a/b/c/d a/b/c/e 'a' is processed first. Then 'a/b/c/d' and 'a/b/c/e' are fired simultaneously. If both are not present, both svn checkout tries to mkdir b and b/c and a race condition occurs between their call for isdir() and mkdir(). This works around the issue by creating the intermediary directories ourself before calling out svn and managing the error ourself. TBR=dpranke@chromium.org BUG= TEST=fresh checkout shouldn't be flaky Review URL: http://codereview.chromium.org/8359018 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@106636 0039d316-1c4b-4281-b951-d872f2087c98
-
- 19 Sep, 2011 1 commit
-
-
maruel@chromium.org authored
I had forgot one access to _requirements. Now that tests are run, this change is safer to commit. R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/7909012 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@101856 0039d316-1c4b-4281-b951-d872f2087c98
-
- 15 Sep, 2011 1 commit
-
-
maruel@chromium.org authored
Add a warning when RunUnitTestsInDirectory() finds no test to run to catch this kind of regression. Fix all the regressions that where introduced in the meantime... TBR=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/7906009 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@101347 0039d316-1c4b-4281-b951-d872f2087c98
-
- 28 Apr, 2011 1 commit
-
-
floitsch@google.com authored
When specifying a revision (with -r) propagates the date of the revision to its children. Review URL: http://codereview.chromium.org/6873110 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@83313 0039d316-1c4b-4281-b951-d872f2087c98
-
- 07 Apr, 2011 3 commits
-
-
maruel@chromium.org authored
Reapply r80770 "Switch from xml.dom.minidom to xml.etree". TBR=dpranke@chromium.org BUG= TEST= git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80785 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
Throws exceptions on mac. R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/6811020 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80771 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
The reason of this change (beside deleting 30 lines) is to fix pylint on Mac. For an unknown reason, it was dying here trying to process the minidom import. R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/6799021 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80770 0039d316-1c4b-4281-b951-d872f2087c98
-
- 01 Apr, 2011 2 commits
-
-
maruel@chromium.org authored
Horked windows slaves this time. R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/6689023 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80220 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
It should be fine now that I've fixed python2.5 compatilibity issues in subprocess2.py. R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/6759074 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80216 0039d316-1c4b-4281-b951-d872f2087c98
-
- 31 Mar, 2011 1 commit
-
-
maruel@chromium.org authored
Makes all the tests runnable on python 2.5. R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/6690034 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80068 0039d316-1c4b-4281-b951-d872f2087c98
-