Commits · ad80e3b96eb0bd7b768eae8461fab25aab805c04 · Linshizhi / Chromium_Depot_tools

09 Sep, 2010 3 commits

Simplify GIT.Capture() code to always redirect stderr by default and always... · ad80e3b9

maruel@chromium.org authored Sep 09, 2010

Simplify GIT.Capture() code to always redirect stderr by default and always throw an exception on failure.

Make gclient_scm_test silent.

Replace raise Exception() with raise gclient_utils.Error().

BUG=54084
TEST=none

Review URL: http://codereview.chromium.org/3353018

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@58936 0039d316-1c4b-4281-b951-d872f2087c98

ad80e3b9

Improve tests and remove some unused GIT test. · 389d6dea

maruel@chromium.org authored Sep 09, 2010

This is needed to improve the git tests further in a later change.

BUG=54084
TEST=none

Review URL: http://codereview.chromium.org/3294017

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@58934 0039d316-1c4b-4281-b951-d872f2087c98

389d6dea

Change scm.SVN.Capture to redirect stderr and throw an exception on call failure. · 54019f3c

maruel@chromium.org authored Sep 09, 2010

Added try/except to the places where errors are tolerated.

Renamed scm.SVN.CaptureBaseRevision to CaptureRevision and removed CaptureHeadRevision.

BUG=54084
TEST=none

Review URL: http://codereview.chromium.org/3307016

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@58932 0039d316-1c4b-4281-b951-d872f2087c98

54019f3c

08 Sep, 2010 5 commits

Update branch path-finding regex to work directly with WebKit repository. · 7aae8fb1

dglazkov@chromium.org authored Sep 08, 2010

R=laforge
TEST=use drover.py with WebKit repo -- it should work!
BUG=none

Review URL: http://codereview.chromium.org/3368007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@58844 0039d316-1c4b-4281-b951-d872f2087c98

7aae8fb1

Enter a description of the change. · 9c53126d

maruel@chromium.org authored Sep 08, 2010

Add back support for python 2.4.

Looks like a few slaves haven't been updated yet.

TBR=bradnelson
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3338017

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@58820 0039d316-1c4b-4281-b951-d872f2087c98

9c53126d

Add automatic auto-flushing stdout. · db111f71

maruel@chromium.org authored Sep 08, 2010

An automated work around for python lack of stdout flushing.
This design simplifies life once parallel checkout is enabled.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/3342024

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@58819 0039d316-1c4b-4281-b951-d872f2087c98

db111f71

Fix small nits. · 6985efce

maruel@chromium.org authored Sep 08, 2010

pylint is useful to catch errors before they go live so fix little annoyances.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3372001

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@58817 0039d316-1c4b-4281-b951-d872f2087c98

6985efce

Do not blindly assume that a .gclient file in a parent directory belongs to the current directory. · 20760a54

jochen@chromium.org authored Sep 08, 2010

BUG=54238
TEST=gclient_smoketest.py
Review URL: http://codereview.chromium.org/3342020

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@58800 0039d316-1c4b-4281-b951-d872f2087c98

20760a54

07 Sep, 2010 4 commits

Improve exception handling. · 7b194c1a

maruel@chromium.org authored Sep 07, 2010

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3320012

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@58756 0039d316-1c4b-4281-b951-d872f2087c98

7b194c1a

Add options argument to _Run() to redirect output. · 37e89873

maruel@chromium.org authored Sep 07, 2010

Add automatic 'header' on command execution

BUG=54084
TEST=none

Review URL: http://codereview.chromium.org/3319008

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@58700 0039d316-1c4b-4281-b951-d872f2087c98

37e89873

Rename retcode to returncode to be consistent with subprocess. · 66c83e68

maruel@chromium.org authored Sep 07, 2010

Change CheckCallError to inherit from Error. This will simplify try/except changes.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/3324007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@58695 0039d316-1c4b-4281-b951-d872f2087c98

66c83e68

Split _Run() in two to make redirection simpler in a later change. · 6cafa13a

maruel@chromium.org authored Sep 07, 2010

Simplify GitWrapper._Run() and move logging at the right place.

TEST=none
BUG=54084

Review URL: http://codereview.chromium.org/3358015

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@58694 0039d316-1c4b-4281-b951-d872f2087c98

6cafa13a

03 Sep, 2010 3 commits

Remove kwargs copy, it is not necessary. Remove ordered argument support from popen to simplify it. · a1693bef

maruel@chromium.org authored Sep 03, 2010

Move logging call to the base function.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3300008

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@58523 0039d316-1c4b-4281-b951-d872f2087c98

a1693bef

Replace a few os.path.join() calls to use self.checkout_path instead. · 8469bf93

maruel@chromium.org authored Sep 03, 2010

Fix SVN pack.

TEST=smoke tests
BUG=none

Review URL: http://codereview.chromium.org/3309005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@58519 0039d316-1c4b-4281-b951-d872f2087c98

8469bf93

gclient: exponential backoff of SCM commands on known failure types. · 2aee2298

cbentzel@chromium.org authored Sep 03, 2010

This starts at 5 seconds (used to be 15) and goes up to ~60 seconds on the tenth round.

BUG=None
TEST=None
Review URL: http://codereview.chromium.org/3326004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@58488 0039d316-1c4b-4281-b951-d872f2087c98

2aee2298

02 Sep, 2010 7 commits

Revert "Do not blindly assume that a .gclient file in a parent directory belongsto the cu..." · 15804091

maruel@chromium.org authored Sep 02, 2010

This reverts commit 58371

TBR=jochen
BUG=
TEST=

Review URL: http://codereview.chromium.org/3357005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@58372 0039d316-1c4b-4281-b951-d872f2087c98

15804091

Do not blindly assume that a .gclient file in a parent directory belongs to the current directory. · 2509f866

jochen@chromium.org authored Sep 02, 2010

BUG=54238
TEST=GClientSmoke.testWrongConfig

Review URL: http://codereview.chromium.org/3300007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@58371 0039d316-1c4b-4281-b951-d872f2087c98

2509f866

Revert "Do not blindly assume that a .gclient file in a parent directory belongs to the cur..." · d765d9c8

maruel@chromium.org authored Sep 02, 2010

This reverts commit 58352.

TBR=jochen
BUG=breaks build bots

Review URL: http://codereview.chromium.org/3334005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@58355 0039d316-1c4b-4281-b951-d872f2087c98

d765d9c8

If no description is given, use the log messages of all commits for presubmit checks. · b96b92f6

jochen@chromium.org authored Sep 02, 2010

BUG=54240
TEST=none

Review URL: http://codereview.chromium.org/3345003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@58353 0039d316-1c4b-4281-b951-d872f2087c98

b96b92f6

Do not blindly assume that a .gclient file in a parent directory belongs to the current directory. · 9806750e

jochen@chromium.org authored Sep 02, 2010

BUG=54238
TEST=GClientSmoke.testWrongConfig

Review URL: http://codereview.chromium.org/3304007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@58352 0039d316-1c4b-4281-b951-d872f2087c98

9806750e

Convert all print statements to use options.stdout. · f5d37bf9

maruel@chromium.org authored Sep 02, 2010

Needed to fix a few function calls to make it work.

BUG=54084
TEST=unit tests

Review URL: http://codereview.chromium.org/3303004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@58287 0039d316-1c4b-4281-b951-d872f2087c98

f5d37bf9

Fix try jobs not within a gclient checkout · 21779a56

maruel@chromium.org authored Sep 02, 2010

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3331004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@58286 0039d316-1c4b-4281-b951-d872f2087c98

21779a56

01 Sep, 2010 4 commits

Fix GetCachedFile. · 1736800a

thestig@chromium.org authored Sep 01, 2010

BUG=none
TEST=gcl upload works when there's no codereview.settings in the cache.
Review URL: http://codereview.chromium.org/3366001

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@58270 0039d316-1c4b-4281-b951-d872f2087c98

1736800a

Remove scm.SVN.Run() and all stdout argument to more calls. · 669600d3

maruel@chromium.org authored Sep 01, 2010

BUG=54084
TEST=unit tests

Review URL: http://codereview.chromium.org/3338003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@58214 0039d316-1c4b-4281-b951-d872f2087c98

669600d3

Cleanup the code in gclient_utils to standardize on CheckCall nomenclature. · 17d01795

maruel@chromium.org authored Sep 01, 2010

Simplify code by removing fail_status
Rename print_messages to always
Simplify the doc.

Review URL: http://codereview.chromium.org/3104036

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@58201 0039d316-1c4b-4281-b951-d872f2087c98

17d01795

Remove --webkit from trychange.py since it never really worked correctly. · 48c4160e

maruel@chromium.org authored Sep 01, 2010

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/3328002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@58200 0039d316-1c4b-4281-b951-d872f2087c98

48c4160e

31 Aug, 2010 1 commit

Don't cache the fact that codereview.settings wasn't found. · b3b494f3

maruel@chromium.org authored Aug 31, 2010

It must always be present.

BUG=none
TBR=none

Review URL: http://codereview.chromium.org/3280013

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@58060 0039d316-1c4b-4281-b951-d872f2087c98

b3b494f3

26 Aug, 2010 2 commits

Handle the case when there is unicode in the tree status more gracefully. · 4c13cccd

bradnelson@google.com authored Aug 26, 2010

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/3184024

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@57447 0039d316-1c4b-4281-b951-d872f2087c98

4c13cccd

Adding json based tree open check. · c0b332a8

bradnelson@google.com authored Aug 26, 2010

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/3107038

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@57438 0039d316-1c4b-4281-b951-d872f2087c98

c0b332a8

25 Aug, 2010 2 commits

Blacklist --non-interactive on MacOSX · 02913a53

maruel@chromium.org authored Aug 25, 2010

It's broken on 10.5.2.

TEST=gcl works all the time on Mac
TBR=nsylvain

Review URL: http://codereview.chromium.org/3169044

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@57381 0039d316-1c4b-4281-b951-d872f2087c98

02913a53

Refactor SubprocessCallAndFilter() to remove positional arguments. · 2b9aa8e0

maruel@chromium.org authored Aug 25, 2010

This way the function is much more similar to subprocess.call(). Further changes
will be done, to be able to convert all the function, to be able to parallelize
output without corrupting it.

Used pylint to verify call graph correctness, causing some other unrelated
changes.

TEST=unit tests
BUG=none

Review URL: http://codereview.chromium.org/3117039

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@57369 0039d316-1c4b-4281-b951-d872f2087c98

2b9aa8e0

24 Aug, 2010 1 commit

Disable the use of -s or --server with gcl upload. · 10ccd112

maruel@chromium.org authored Aug 24, 2010

It contradicts the previous changes to enforce codereview.settings.

TEST=new unit test
BUG=none

Review URL: http://codereview.chromium.org/3171026

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@57195 0039d316-1c4b-4281-b951-d872f2087c98

10ccd112

23 Aug, 2010 3 commits

Add stdout param to SubprocessCallAndFilter(). · 559c3f89

maruel@chromium.org authored Aug 23, 2010

It will eventually replace 'print_messages' and be used to annotate printed
lines when using --jobs.

Review URL: http://codereview.chromium.org/3174020

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@57092 0039d316-1c4b-4281-b951-d872f2087c98

559c3f89

Redo of r56893 with fix to support python 2.5. · 3a292688

maruel@chromium.org authored Aug 23, 2010

Original Description:

Remove code duplication and improve style.

Create a Popen function to reduce code duplication.
Use RemoveDirectory where relevant.
Make drover slightly more posix friendly.

Review URL: http://codereview.chromium.org/3199011

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@57083 0039d316-1c4b-4281-b951-d872f2087c98

3a292688

Make codereview.setting syntax more liberal and add more unit tests. · dd218e59

maruel@chromium.org authored Aug 23, 2010

Improve gclient_utils to test output lacking trailing LF

BUG=none
TEST=new unit tests

Review URL: http://codereview.chromium.org/3140023

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@57047 0039d316-1c4b-4281-b951-d872f2087c98

dd218e59

22 Aug, 2010 1 commit

Fix for files not ending with \n, otherwise the last line would be ignored. · a488c7d7

maruel@chromium.org authored Aug 22, 2010

TBR=bradnelson

Review URL: http://codereview.chromium.org/3110030

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@57010 0039d316-1c4b-4281-b951-d872f2087c98

a488c7d7

20 Aug, 2010 3 commits

Revert "Remove code duplication and improve style." · ad0b13da

maruel@chromium.org authored Aug 20, 2010

This reverts commit 850ee065.

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@56894 0039d316-1c4b-4281-b951-d872f2087c98

ad0b13da

Remove code duplication and improve style. · 850ee065

maruel@chromium.org authored Aug 20, 2010

Create a Popen function to reduce code duplication.
Use RemoveDirectory where relevant.
Make drover slightly more posix friendly.

Review URL: http://codereview.chromium.org/3126020

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@56893 0039d316-1c4b-4281-b951-d872f2087c98

850ee065

Add an error message for MacOSX 10.5.2 users · 3c84298e

maruel@chromium.org authored Aug 20, 2010

TBR=bradnelson

Review URL: http://codereview.chromium.org/3201005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@56880 0039d316-1c4b-4281-b951-d872f2087c98

3c84298e

19 Aug, 2010 1 commit

Added -x --ignore-eol-style arguments when running svn diff for · 802933db

kbr@chromium.org authored Aug 19, 2010

gclient pack because of spurious EOL-only changes seen on Linux.

BUG=none
TEST=ran gclient pack in Chromium repository and verified output manually

Review URL: http://codereview.chromium.org/3189010

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@56710 0039d316-1c4b-4281-b951-d872f2087c98

802933db