- 20 Oct, 2017 4 commits
-
-
Robert Iannucci authored
From https://chromium.googlesource.com/infra/luci/luci-go: git log a90d36d07f65098da34b600f6cfb8a5f05199ac5..63bd11762eec0b8604bc89dcfb9de4f5dad3777a --oneline vpython e638db97 [vpython] Normalize spec before verification. 22c141ce [vpython] Remove maximum script path length check. b1e7bc36 [vpython] Better failure output. 3edc75c8 [vpython] Better VirtualEnv isolation. R=dnj@chromium.org, nodir@chromium.org Bug: Change-Id: I20d06c51760b27e70b9ce65c7ddd856943fab7eb Reviewed-on: https://chromium-review.googlesource.com/731512Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
-
Daniel Cheng authored
This will let progress show the name of the hook while it's running. Change-Id: I14ef2a9b5fd2bc4d8d778f5402f78a5827ffbb08 Reviewed-on: https://chromium-review.googlesource.com/731469Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org>
-
Daniel Cheng authored
This is a reland of 5fd1defb Original change's description: > gclient runhooks: now with less spammy progress notifications > > Bug: 772741 > Change-Id: I62ad64219ba27ee4ea26ceb603b1133dff4a2e04 > Reviewed-on: https://chromium-review.googlesource.com/727194 > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Commit-Queue: Daniel Cheng <dcheng@chromium.org> Bug: 772741 Change-Id: Idd6fcd46a8c97716d68ed0975940705a90540a4d Reviewed-on: https://chromium-review.googlesource.com/728961Reviewed-by:
-
Jao-ke Chin-Lee authored
If the revision has not yet propagated, then we never retry, because the amount of time to fetch HEAD already exceeds the deadline. Bug: 771007 Change-Id: I91ac30b2b53b4f75729357b3298c52856a4d350e Reviewed-on: https://chromium-review.googlesource.com/729328 Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org>
-
- 19 Oct, 2017 4 commits
-
-
Daniel Cheng authored
This reverts commit 5fd1defb. Reason for revert: breaks v8 because hook names are optional Original change's description: > gclient runhooks: now with less spammy progress notifications > > Bug: 772741 > Change-Id: I62ad64219ba27ee4ea26ceb603b1133dff4a2e04 > Reviewed-on: https://chromium-review.googlesource.com/727194 > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Commit-Queue: Daniel Cheng <dcheng@chromium.org> TBR=dcheng@chromium.org,thakis@chromium.org,dpranke@chromium.org Change-Id: I7dee0ca188f5ca34232f16e6496249fc9f49fa96 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 772741 Reviewed-on: https://chromium-review.googlesource.com/728959Reviewed-by:
-
Daniel Cheng authored
Bug: 772741 Change-Id: I62ad64219ba27ee4ea26ceb603b1133dff4a2e04 Reviewed-on: https://chromium-review.googlesource.com/727194Reviewed-by:
-
Michael Achenbach authored
This reverts commit 037f9b80. Reason for revert: The structural change to manifest breaks the recipe tester: https://cs.chromium.org/chromium/infra/recipes/recipes/recipe_roll_tryjob.py?q=recipe_roll_tryjob.py&sq=package:chromium&dr&l=149 https://crbug.com/776299 Original change's description: > bot_update recipe: Upload source manifest > > Bug: 772529 > Change-Id: I3f833740ddfbc71be42b140c99dcd4bbfeed54fe > Reviewed-on: https://chromium-review.googlesource.com/706071 > Commit-Queue: Ryan Tseng <hinoka@chromium.org> > Reviewed-by: Robbie Iannucci <iannucci@chromium.org> TBR=iannucci@chromium.org,hinoka@chromium.org,agable@chromium.org Change-Id: Iba9653d73b7f117ca2f94619ae5da900cd0c8c98 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 772529,776299 Reviewed-on: https://chromium-review.googlesource.com/728059Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org>
-
Ryan Tseng authored
Bug: 772529 Change-Id: I3f833740ddfbc71be42b140c99dcd4bbfeed54fe Reviewed-on: https://chromium-review.googlesource.com/706071 Commit-Queue: Ryan Tseng <hinoka@chromium.org> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org>
-
- 18 Oct, 2017 2 commits
-
-
Marc-Antoine Ruel authored
When 'gclient recurse' is called from a unconfigured directory. No functional change otherwise. R=agable@chromium.org Bug:774749 Change-Id: Ifb2b74c042ce31faf3e1287c5614739e58e9178c Reviewed-on: https://chromium-review.googlesource.com/726419Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>
-
Michael Achenbach authored
Bug: 775854 Change-Id: I6f831a2536de3cadbeaede7b78cfcf7d41f77052 Reviewed-on: https://chromium-review.googlesource.com/725328Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
-
- 17 Oct, 2017 5 commits
-
-
Dirk Pranke authored
R=estaab@chromium.org Change-Id: I318a1897fa1d10fce4aaad2dd1f4a553d14aff47 Reviewed-on: https://chromium-review.googlesource.com/723999Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org>
-
Andrew Grieve authored
Follow-up to d86c8037. The error message was still saying "src" rather than the repository root. Bug: 768962 Change-Id: I781191e561db889a28acf51ee49a20d6d352b489 Reviewed-on: https://chromium-review.googlesource.com/719718Reviewed-by:
-
Dan Jacques authored
Update "vpython" and "led" pins to version which includes PPC64 support: d1e9a52e1c8414cd0a0df8bec6c37f325e0fbaa1 TBR=iannucci@chromium.org BUG=chromium:773857 TEST=presubmit Change-Id: I7d5fd91b08b114e534926db45e1d499638659fbd Reviewed-on: https://chromium-review.googlesource.com/723165Reviewed-by:
Daniel Jacques <dnj@chromium.org> Commit-Queue: Daniel Jacques <dnj@chromium.org>
-
Dan Jacques authored
The uname was reported incorrectly, and should have read "ppc64le". Update the script to reference this. TBR=iannucci@chromium.org BUG=chromium:773857 TEST=None Change-Id: Ice5ffe1257333b2bc1bfef7da60dcea4ead4d4c8 Reviewed-on: https://chromium-review.googlesource.com/723162Reviewed-by:
-
Dan Jacques authored
BUG=chromium:773857 TEST=None Change-Id: I9deb95f7f6c30b5970d74bf3d43df2038db3087e Reviewed-on: https://chromium-review.googlesource.com/721165Reviewed-by:
Vadim Shtayura <vadimsh@chromium.org> Reviewed-by:
-
- 14 Oct, 2017 1 commit
-
-
Ryan Tseng authored
To pick up flag changes in kitchen: https://chromium-review.googlesource.com/c/infra/infra/+/718117 Bug: Change-Id: Ib6ce2d76a2e688e1f7da56cf03e1b57d95600e2c Reviewed-on: https://chromium-review.googlesource.com/720250Reviewed-by:
-
- 13 Oct, 2017 1 commit
-
-
Michael Moss authored
This fixes an issue introduced by crrev.com/b40a4514 where a 404 result might return None contents. R=agable@google.com, phajdan@google.com Bug:774355 Change-Id: I993a029adb8d92cb27e043cd3d9b17cc8aee2432 Reviewed-on: https://chromium-review.googlesource.com/717937 Commit-Queue: Michael Moss <mmoss@chromium.org> Reviewed-by:
Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-
- 12 Oct, 2017 9 commits
-
-
Dirk Pranke authored
Previously, gclient would attempt to write an args file after a dependency was checked out, but before any sub-dependencies had been checked out. If the args file path pointed at something inside a sub-dependency, this wouldn't work, because the directory might not yet exist. This most obviously happened for buildspec clobber builds. The fix is to wait until after the sub-dependencies have been checked out to write the file. R=phajdan.jr@chromium.org, mmoss@chromium.org BUG=773933 Change-Id: I0cf4564204f7dabd9f843dc7904db7050fcc0d23 Reviewed-on: https://chromium-review.googlesource.com/714644Reviewed-by:
-
Stefan Zager authored
R=agable@chromium.org,tandrii@chromium.org Bug: Change-Id: I83c285c333a21f2ed0138723a1cd5347e65f41ae Reviewed-on: https://chromium-review.googlesource.com/710742 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
-
Michael Moss authored
This is needed in the release recipes because there are times when we want to check that a file is _not_ there yet (i.e. 404 response). R=agable@chromium.org, dnj@chromium.org Change-Id: Iedf646d6c73ebf898e90afd2009840b1e5c5b1ab Reviewed-on: https://chromium-review.googlesource.com/709916Reviewed-by:
-
Ryan Tseng authored
Normally, if dfgs is started with multiple threads, the first time gsutil.py is called, it may be called by many different threads at the same time and hit a race condition where multiple threads are all trying to download gsutil at the same time. This works around the problem by calling it for the first time in the main thread before anything else happens. Bug: 773671 Change-Id: Ie75d90d6d20d11f46a601500b75a198fa5e5f111 Reviewed-on: https://chromium-review.googlesource.com/713750Reviewed-by:
Jao-ke Chin-Lee <jchinlee@chromium.org> Commit-Queue: Ryan Tseng <hinoka@chromium.org>
-
Michael Achenbach authored
Bug: 773769 Change-Id: I3c1a394c5995e0c56046da5f2509e63060aa6a29 Reviewed-on: https://chromium-review.googlesource.com/712935Reviewed-by:
-
Andrii Shyshkalov authored
R=smut@chromium.org Recipe-Nontrivial-Roll: build Change-Id: If90d6b172c3cd67ca57ad35345a9988e91da2345 Reviewed-on: https://chromium-review.googlesource.com/714776 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
smut <smut@google.com>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/c07de907b2223efcacbf45d7b793fc0d8a964f31 Remove Rietveld CQ config. (tandrii@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I5dfed3933d85bf674ee16e5a89d15d66c90e3e0f Reviewed-on: https://chromium-review.googlesource.com/714656Reviewed-by:
Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
-
Stefan Zager authored
R=agable@chromium.org,tandrii@chromium.org Bug: Change-Id: I7a5ec6ca1bb05d67b1ddbee60eac89d57464a480 Reviewed-on: https://chromium-review.googlesource.com/710007Reviewed-by:
-
Andrii Shyshkalov authored
Rietveld CQ has already been disabled and is no longer supoorted. TBR=iannucci@chromium.org No-Try: True Bug: 770592 Change-Id: I35b0c6c9da585519b9ad6df316709fb58b17b24f Reviewed-on: https://chromium-review.googlesource.com/714298Reviewed-by:
-
- 11 Oct, 2017 4 commits
-
-
Bruce Dawson authored
Sometimes it is necessary to recreate a VS toolchain package with a tiny change such as editing or removing a single file. Recreating the VS environment can be time consuming or even impossible (the VS installer does not allow going to arbitrary versions) so this switch allows repackaging an existing unpacked directory. The typical usage would be to make the modifications to one of the toolchain directories in depot_tools\win_toolchain\vs_files and then repackage it using: python package_from_installed.py --repackage third_party\depot_tools\win_toolchain\vs_files\9bc7ccbf9f4bd50d4a3bd185e8ca94ff1618de0b Bug: 772123 Change-Id: I77b928f695e5f07e33f68dd37711c8761a3c7a22 Reviewed-on: https://chromium-review.googlesource.com/713562Reviewed-by: -
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/16a83eb5fd3d855a2bd41974fe7268d42fef3866 Update source_manifest (hinoka@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ie0b9f4f84c0cb3644906890f938e2726b0a35b11 Reviewed-on: https://chromium-review.googlesource.com/714037Reviewed-by:
-
Ryan Tseng authored
This reverts commit c3eb3fa3. Reason for revert: Broke everything, probably due to version pin mismatch somewhere (gclient/git_cache likely getting called across repo boundary) Original change's description: > git_cache: Remove locks > > These aren't in use, and the original problem they were > meant to solve has been solved at the gclient.py layer > using resource locking: > https://codereview.chromium.org/2049583003 > > Bug: 773008 > Change-Id: I6609f39d7f15604e0bb3d742a41c4f9fec87a57a > Reviewed-on: https://chromium-review.googlesource.com/707728 > Reviewed-by: Aaron Gable <agable@chromium.org> > Reviewed-by: Robbie Iannucci <iannucci@chromium.org> > Commit-Queue: Ryan Tseng <hinoka@chromium.org> TBR=iannucci@chromium.org,hinoka@chromium.org,agable@chromium.org,phajdan.jr@chromium.org Change-Id: Ia9061f0ac827599d81d7638f535f97e15efa75fe No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 773008 Reviewed-on: https://chromium-review.googlesource.com/711055Reviewed-by:
-
Vadim Shtayura authored
This reverts commit c3eb3fa3. Reason for revert: lots of "runhooks" failure everywhere Example: https://build.chromium.org/p/chromium.linux/builders/Linux%20Builder/builds/92720 Original change's description: > git_cache: Remove locks > > These aren't in use, and the original problem they were > meant to solve has been solved at the gclient.py layer > using resource locking: > https://codereview.chromium.org/2049583003 > > Bug: 773008 > Change-Id: I6609f39d7f15604e0bb3d742a41c4f9fec87a57a > Reviewed-on: https://chromium-review.googlesource.com/707728 > Reviewed-by: Aaron Gable <agable@chromium.org> > Reviewed-by: Robbie Iannucci <iannucci@chromium.org> > Commit-Queue: Ryan Tseng <hinoka@chromium.org> TBR=iannucci@chromium.org,hinoka@chromium.org,agable@chromium.org,phajdan.jr@chromium.org Change-Id: I31d5fef94f39f3a9f97b9e59121073b1f433d11e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 773008 Reviewed-on: https://chromium-review.googlesource.com/711054Reviewed-by:
-
- 10 Oct, 2017 8 commits
-
-
Ryan Tseng authored
These aren't in use, and the original problem they were meant to solve has been solved at the gclient.py layer using resource locking: https://codereview.chromium.org/2049583003 Bug: 773008 Change-Id: I6609f39d7f15604e0bb3d742a41c4f9fec87a57a Reviewed-on: https://chromium-review.googlesource.com/707728Reviewed-by:
-
Stefan Zager authored
Sometimes I want to get try bot results without checking out the relevant branch. R=agable@chromium.org Bug: Change-Id: I89d118962ee37b10d95cf4044b61a0f2234b7e60 Reviewed-on: https://chromium-review.googlesource.com/710500 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
-
Nico Weber authored
clang-cl relies on this env var being set for 2017 to find the linker. Bug: 772123 Change-Id: Id03896504d38dc706b2bd96a2c3834c6cb9db9fe TBR=brucedawson Reviewed-on: https://chromium-review.googlesource.com/709697 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
-
William Hesse authored
BUG=768318 R=phajdan.jr@chromium.org R=dnj@chromium.org R=iannucci@chromium.org Change-Id: I2c85f9d30e74cfaebf2718bee075d6a21a6e0421 Reviewed-on: https://chromium-review.googlesource.com/708738Reviewed-by:
-
Dan Jacques authored
Add CIPD manifest PRESUBMIT canned checks. BUG=None TEST=local Change-Id: Ibf739147f47b4f38a2892c856cf45c5839d1c3e7 Reviewed-on: https://chromium-review.googlesource.com/707557 Commit-Queue: Daniel Jacques <dnj@chromium.org> Reviewed-by:
-
Dan Jacques authored
Bump CIPD client version to: c8044eb23015ef176913df6f4493c13f67e4d44b BUG=None TEST=staging - Deployed as staging on BuildBot instances. Change-Id: I234fc7a16b0bb259e41d28c01a3a7d611d361f81 Reviewed-on: https://chromium-review.googlesource.com/707939Reviewed-by:
-
Paweł Hajdan, Jr authored
Bug: 772843 Change-Id: I994f829cba7577e6b628d36d894f4c5d1f3c429c Reviewed-on: https://chromium-review.googlesource.com/708656 Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by:
-
Nico Weber authored
Apparently several scripts in other repros call this function directly. Bug: 772741 Change-Id: I486483e44a072af6cf8c75373a2da6ef5469fc2c TBR=dpranke Reviewed-on: https://chromium-review.googlesource.com/707937 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
-
- 09 Oct, 2017 2 commits
-
-
Nodir Turakulov authored
If -m option value starts with "luci.", most probably the user intends to schedule a build on a LUCI bucket. Print an error message asking the user to use -B option. Bug: 749696 Change-Id: If7a038a1f629ee808e3261ae1c753e388bfea893 Reviewed-on: https://chromium-review.googlesource.com/707534Reviewed-by:
-
Nico Weber authored
The script prints a bunch of stuff behind `if verbose` checks, but then "verbose" was turned on by default in https://bugs.chromium.org/p/chromium/issues/detail?id=504452 I think the wrong lesson was learned from that bug – it sounds like the problem was that an error message was printed only if verbose was set. After this change, the script is silent when it does nothing, and prints something if something happens. (Arguably, it still prints too much in the case where it successfully downloads something.) This is part of a few changes to make `gclient runhooks` less noisy. Bug: 772741,504452 Change-Id: I5823c296abe97611ba4411bab2743673b10dca4b Reviewed-on: https://chromium-review.googlesource.com/706915 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
-
