Review URL: http://codereview.chromium.org/254012

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@27492 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/249021

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@27386 0039d316-1c4b-4281-b951-d872f2087c98

Replaced a call to CaptureSVNStatus with a SCMWrapper::status

gclient: store gclient_entries as a dict

Currently we only store the relative path for entries.
We need to also store the url so that learn the repo type: git or snv.

Review URL: http://codereview.chromium.org/248011

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@27370 0039d316-1c4b-4281-b951-d872f2087c98

gclient_tests: add GitWrapper test cases

gclient_scm: make RunGit private and add url check

gclient_scm: add revert, run_hooks, and status

gclient_scm: add git implementations of cleanup, diff, and export

gclient_scm: implment GitSCM::update

gclient_scm: add a checks for unsupported scm and unimplemented method

Review URL: http://codereview.chromium.org/235005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@27241 0039d316-1c4b-4281-b951-d872f2087c98

When using svn for try job for the first time, svn will ask for the credentials.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/223024

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@27103 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/218016

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@27077 0039d316-1c4b-4281-b951-d872f2087c98

Current checkout revision was ignored so it was always acting like if --force was used.
This was overloading the subversion server, creating timeouts, causing a cascading effect that destroyed the tree.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/225022

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@27027 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/222010

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@26980 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@26977 0039d316-1c4b-4281-b951-d872f2087c98

It was adding a space in front of every line.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/223009

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@26973 0039d316-1c4b-4281-b951-d872f2087c98

Currently, revision numbers are stored as int. This won't work
for git's SHA1s. So storing revisions as strings.

Review URL: http://codereview.chromium.org/208060

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@26940 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=http://code.google.com/p/gclient/issues/detail?id=12

Review URL: http://codereview.chromium.org/227003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@26931 0039d316-1c4b-4281-b951-d872f2087c98

Original review url: http://codereview.chromium.org/225007 


git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@26928 0039d316-1c4b-4281-b951-d872f2087c98

This is for situations where the solution is checked out by another SCM
mechanism (e.g. update-webkit or just svn co) but we want to use gclient to
fetch the dependencies.

Review URL: http://codereview.chromium.org/211057

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@26876 0039d316-1c4b-4281-b951-d872f2087c98

gclient_scm: use a map for deciding whether or not the scm is supported

gclient_scm: add a checks for unsupported scm and unimplemented method

git_scm: pull out svn code into SVNWrapper

gclient_scm: create a create_scm factory method

Use a factory method to abstract SCMWrapper creation. This method
will eventually return the correct subclass of SCMWrapper. Initially,
there will only be SVNWrapper.

Review URL: http://codereview.chromium.org/215022

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@26823 0039d316-1c4b-4281-b951-d872f2087c98

and append them to the patch sent to the try bots. This is 
very useful for chromium+webkit tries.

Review URL: http://codereview.chromium.org/212034

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@26817 0039d316-1c4b-4281-b951-d872f2087c98

TBR=nsylvain
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/216044

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@26806 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=unittests

Review URL: http://codereview.chromium.org/215039

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@26804 0039d316-1c4b-4281-b951-d872f2087c98

svn revert is broken in too many ways to work around it. I just discovered --revision BASE and it does everything I need.

BUG=none
TEST=gclient revert ignores externals, work with switched directories, work with files with inconsistent line endings (sigh)

Review URL: http://codereview.chromium.org/209052

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@26707 0039d316-1c4b-4281-b951-d872f2087c98

TEST=gclient revert more stuff but stops reverting external directories
BUG=none

Review URL: http://codereview.chromium.org/208025


git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@26672 0039d316-1c4b-4281-b951-d872f2087c98

TBR=msb
TEST=none
BUG=none

Review URL: http://codereview.chromium.org/208028


git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@26606 0039d316-1c4b-4281-b951-d872f2087c98

This method will eventually return the correct subclass of SCMWrapper. Initially, there will only be SVNWrapper.

gclient_scm: add test for unsupported scm

gclient_scm: make SCMWrapper constructor parameters non-optional

gclient_scm: add a checks for unsupported scm and unimplemented method

git_scm: pull out svn code into SVNWrapper

gclient_scm: create a create_scm factory method

TEST=
BUG=none

Review URL: http://codereview.chromium.org/216014

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@26602 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/214017

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@26577 0039d316-1c4b-4281-b951-d872f2087c98

"file_list = file_list or []" would create a new empty list when an empty list is passed as a parameter, ditching the output parameter.

TEST=hooks are now run on gclient sync
BUG=none

Review URL: http://codereview.chromium.org/208010


git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@26461 0039d316-1c4b-4281-b951-d872f2087c98

Add a test case for the UnversionedUnexpected file code path.

TEST=This test case will catch the bug fixed by r26425.
BUG=none

Patch contributed by msb@

Review URL: http://codereview.chromium.org/214005


git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@26458 0039d316-1c4b-4281-b951-d872f2087c98

Patch contributed by msb@

TEST=unit test
BUG=none

Review url: http://codereview.chromium.org/213006


git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@26457 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/213004 


git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@26452 0039d316-1c4b-4281-b951-d872f2087c98

BUG=gcl try and gcl upload don't work
TBR=maruel

Review URL: http://codereview.chromium.org/207007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@26429 0039d316-1c4b-4281-b951-d872f2087c98

Flaw in loop logic, causes it to miss the occasional file.

BUG=None
TEST=None
TBR=maruel

Review URL: http://codereview.chromium.org/209008

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@26427 0039d316-1c4b-4281-b951-d872f2087c98

TBR=brad
BUG=gcl try is broken
TEST=none

Review URL: http://codereview.chromium.org/215003


git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@26426 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None
TBR=maruel

Review URL: http://codereview.chromium.org/213002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@26425 0039d316-1c4b-4281-b951-d872f2087c98

Part of a larger refactoring to abstract SCM-specific bits.

presubmit_support, revert, gcl: modify to import gclient_scm and gclient_utils

Part of a larger refactoring to abstract SCM-specific bits.

revert, gcl: modify to import gclient_scm and gclient_utils

Part of a larger refactoring to abstract SCM-specific bits.

gclient: pull out SCM bits

Pulled out SCMWrapper into gcliet_scm.py as part of a larger refactoring to
abstract SCM-specific bits. Plan is to evenutally add git support.

Pulling out SCMWrapper also required pulling out utility functions into
a gclient_utility.py.

Patch contributed by msb@

TEST=none
BUG=none


git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@26423 0039d316-1c4b-4281-b951-d872f2087c98

BUG=13668
TEST=none
Review URL: http://codereview.chromium.org/203075

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@26262 0039d316-1c4b-4281-b951-d872f2087c98

   R=pam
   TEST=none
   BUG=none

M    gcl.py



git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@26194 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/200103

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@26044 0039d316-1c4b-4281-b951-d872f2087c98

name of the top level "DEPS" file of a solution from within the .gclient spec.

This allows users to edit their gclient once and use a different (perhaps
experimental) DEPS file instead of the traditionally named "DEPS".

Review URL: http://codereview.chromium.org/203040

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@26031 0039d316-1c4b-4281-b951-d872f2087c98

Defaulting to a value in codereview.settings

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/200078

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@25886 0039d316-1c4b-4281-b951-d872f2087c98

isn't included in the calculation.

BUG=none
TEST=submit change with presubmit warning, note reported time

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@25806 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/201062

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@25751 0039d316-1c4b-4281-b951-d872f2087c98

the root of the source tree. It is similar to "gclient diff", and
shares much of the implementation, but it seems that developers may
want the semantics of each in different situations, which is why it is
being added as a new command.

Generalized SubprocessCallAndCapture into SubprocessCallAndFilter.
Added RunSVNAndFilterOutput; changed RunSVNAndGetFileList to use it.
Fixed problem in presubmit_canned_checks.py where it was not working
on Windows. Updated unit tests for gclient.

Review URL: http://codereview.chromium.org/193004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@25410 0039d316-1c4b-4281-b951-d872f2087c98