Commits · a7ba43a3a8d7c50d403743ee6ec5fbdcb1dbb0fc · Linshizhi / Chromium_Depot_tools

19 Apr, 2017 3 commits

Revert "bot_update: pin depot_tools" · a7ba43a3

Nodir Turakulov authored Apr 19, 2017

This reverts commit e8acd40a.

Reason for revert: broke windows builds :(

Original change's description:
> bot_update: pin depot_tools
> 
> gclient runhooks often calls scripts that depend on scripts in depot_tools.
> Currently bot_update only ensures that depot_tools is present in $PATH, but
> otherwise uses whatever depot_tools already specified in $PATH. We don't pin
> depot_tools before running a recipe, so using whatever depot_tools in $PATH
> is not hermetic.
> 
> Insert the path to the pinned depot_tools to the beginning of $PATH
> 
> R=iannucci@chromium.org
> 
> Bug:
> 
> Change-Id: I31d04ba2ec7c409f89d58a51502ce3565e3a02a1
> Reviewed-on: https://chromium-review.googlesource.com/481072
> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
> Commit-Queue: Nodir Turakulov <nodir@chromium.org>
> 

TBR=iannucci@chromium.org,nodir@chromium.org,phajdan.jr@chromium.org,chromium-reviews@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Change-Id: I1a70f0f54e9b9cea7fc2f9897e62f558204a4684
Reviewed-on: https://chromium-review.googlesource.com/481440Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

a7ba43a3

[git-cl] set math is done with | not + · 100aa213

Robert Iannucci authored Apr 19, 2017

TBR=tandrii@chromium.org

Bug:

Change-Id: I1f533344b915bc4581739f508978f837a8c90f8c
Reviewed-on: https://chromium-review.googlesource.com/481073Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

100aa213

bot_update: pin depot_tools · e8acd40a

Nodir Turakulov authored Apr 18, 2017

gclient runhooks often calls scripts that depend on scripts in depot_tools.
Currently bot_update only ensures that depot_tools is present in $PATH, but
otherwise uses whatever depot_tools already specified in $PATH. We don't pin
depot_tools before running a recipe, so using whatever depot_tools in $PATH
is not hermetic.

Insert the path to the pinned depot_tools to the beginning of $PATH

R=iannucci@chromium.org

Bug:

Change-Id: I31d04ba2ec7c409f89d58a51502ce3565e3a02a1
Reviewed-on: https://chromium-review.googlesource.com/481072Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

e8acd40a

18 Apr, 2017 10 commits

Flip gerrit_util to raise exceptions on 404 by default · 6f5a8d99

Aaron Gable authored Apr 18, 2017

This makes the library behave more like what we'd expect,
while still allowing certain function to specify that
returning 204 or 404 is expected/acceptable behavior.

Change-Id: If3ce5598d1603819ee97aaeab0072a9e786ed96d
Reviewed-on: https://chromium-review.googlesource.com/481043Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>

6f5a8d99

Reland "Refactor ReadHttpResponse to be error-friendlier" · 19ee16c8

Aaron Gable authored Apr 18, 2017

Gerrit sometimes returns a full response json object at
the same time as returning a non-200 status code. This
refactor makes it easier for calling code to request
access to that object and handle error cases on its own.

The original version of this commit had a bug where
ReadHttpResponse properly set the default value for
accept_statuses, but all calls which came through
ReadHttpJsonResponse were setting None instead.

Bug: 710028
Change-Id: I8cee435d8acd487fb777b3fd69b5e48e19d2e5a3
Reviewed-on: https://chromium-review.googlesource.com/481060Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>

19ee16c8

[git-cl] fix assertion. · a28592e5

Robert Iannucci authored Apr 18, 2017

We want to assert that if add_owners_to is provided, change is also
provided.

Bug:

Change-Id: I0b9674dcd1cdd5e42a8ab92583570ecc02ba1dcd
Reviewed-on: https://chromium-review.googlesource.com/481040Reviewed-by: Daniel Jacques <dnj@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

a28592e5

Roll recipe dependencies (trivial). · e04f4616

recipe-roller authored Apr 18, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/fb848fdb71cd25df01eba89b30d5e90ffe138c1d Update docs referring to deprecated 'simulation_test' command (phajdan.jr@chromium.org)

TBR=iannucci@chromium.org

Change-Id: I718401eb2ca7c51db743c961cb7dfb2232750b77
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/481119
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>

e04f4616

Revert "Refactor ReadHttpResponse to be error-friendlier" · 382674be

Aaron Gable authored Apr 18, 2017

This reverts commit 6d7ab1bf.

Reason for revert: Stacktrace:
 File "/s/depot_tools/gerrit_util.py", line 816, in GetAccountDetails
   return ReadHttpJsonResponse(conn)
 File "/s/depot_tools/gerrit_util.py", line 376, in ReadHttpJsonResponse
   fh = ReadHttpResponse(conn, accept_statuses)
 File "/s/depot_tools/gerrit_util.py", line 365, in ReadHttpResponse
   if response.status not in accept_statuses:
TypeError: argument of type 'NoneType' is not iterable

Original change's description:
> Refactor ReadHttpResponse to be error-friendlier
> 
> Gerrit sometimes returns a full response json object at
> the same time as returning a non-200 status code. This
> refactor makes it easier for calling code to request
> access to that object and handle error cases on its own.
> 
> Bug: 710028
> Change-Id: Id1017d580d2fb843d5ca6287efcfed8775c52cd6
> Reviewed-on: https://chromium-review.googlesource.com/479450
> Commit-Queue: Aaron Gable <agable@chromium.org>
> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
> 

TBR=agable@chromium.org,tandrii@chromium.org,chromium-reviews@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Change-Id: Ia9d9ce835e207a32e7cc8ee35c0cf40c823c7b78
Reviewed-on: https://chromium-review.googlesource.com/481059Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>

382674be

[git-cl] add --tbrs flag. · 6c98dc69

Robert Iannucci authored Apr 18, 2017

Bug:

Change-Id: I6c8ffaa5d8b934e287c97b97faf6909df5d02978
Reviewed-on: https://chromium-review.googlesource.com/479781
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

6c98dc69

Refactor ReadHttpResponse to be error-friendlier · 6d7ab1bf

Aaron Gable authored Apr 18, 2017

Gerrit sometimes returns a full response json object at
the same time as returning a non-200 status code. This
refactor makes it easier for calling code to request
access to that object and handle error cases on its own.

Bug: 710028
Change-Id: Id1017d580d2fb843d5ca6287efcfed8775c52cd6
Reviewed-on: https://chromium-review.googlesource.com/479450
Commit-Queue: Aaron Gable <agable@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

6d7ab1bf

[git-cl] add --r-owners · f2708bd7

Robert Iannucci authored Apr 17, 2017

This will be useful for tools like the recipe autoroller to
semi-intelligently choose a collection of reviewers.

Bug:

Change-Id: I7a238127e126340c033fc8e80523ef2408ebf970
Reviewed-on: https://chromium-review.googlesource.com/479679
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

f2708bd7

setup_color.py should not be executable, as it pollutes $PATH. · 9c0930ef

Andrii Shyshkalov authored Apr 12, 2017

R=iannucci@chromium.org

Change-Id: Ieb9d76736203a346d8364c6c0448d9bb4391a3f7
Reviewed-on: https://chromium-review.googlesource.com/475832Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

9c0930ef

Gerrit git cl upload <diff_base>: respect diff_base argumnent. · 550e924d

Andrii Shyshkalov authored Apr 12, 2017

This CL propagates <diff_base> all the way to become parent commit
of the syntentic commit generated by squashing the current branch.

BUG=649846
R=agable@chromium.org

Change-Id: Ided7ebbb5c3a1114cac18adb62b3a9c27610018c
Reviewed-on: https://chromium-review.googlesource.com/475229Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

550e924d

17 Apr, 2017 1 commit

Use OldContents() for OWNERS files to do checks · d0573ec0

Jochen Eisinger authored Apr 13, 2017

BUG=141253
R=dpranke@chromium.org

Change-Id: Iacbc2f0571e725e4f2ccf5ea7878f101972289bb
Reviewed-on: https://chromium-review.googlesource.com/476610Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Jochen Eisinger <jochen@chromium.org>

d0573ec0

16 Apr, 2017 1 commit

Roll recipe dependencies (trivial). · 7d1681b4

recipe-roller authored Apr 16, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/d4e0f46079a50a1707240e214809bf4bbac63bc6 [package] fix race in cleanup_pyc. (iannucci@chromium.org)

TBR=iannucci@chromium.org

Change-Id: Ie3a314ff2e4676187ff190c72a469bbed02fdf66
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/479152
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>

7d1681b4

15 Apr, 2017 2 commits

[recipes.cfg] add autoroll options. · 971533c2

Robert Iannucci authored Apr 15, 2017

TBR=dnj@chromium.org

Bug:

Change-Id: I6f607578197408734da238189465ae1ff6a2000d
Reviewed-on: https://chromium-review.googlesource.com/478833Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

971533c2

Roll recipe dependencies (trivial). · 01dfb361

recipe-roller authored Apr 15, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/71848f7add95e74692387c3feadaee93e185169d [autoroll] exclude recipes_simulation_test stdout from non-verbose json. (iannucci@chromium.org)

TBR=iannucci@chromium.org

Change-Id: I07f0e821dbaed7771cf5bf796083ae98bc084c8a
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/479051
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>

01dfb361

14 Apr, 2017 4 commits

Roll recipe dependencies (trivial). · 2093ebef

recipe-roller authored Apr 14, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/b7cd5ee1ea736116d35559ff0e2fb61081d1ca01 [autoroll] Count empty rolls as successful. (iannucci@chromium.org)

TBR=iannucci@chromium.org

Change-Id: I841a8ba5845bfe9149627c9e2a5b26376372704f
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/478651
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>

2093ebef

Roll recipe dependencies (trivial). · 7a9b425d

recipe-roller authored Apr 14, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/cb0d71bf2638680b85a7937ab57add4ba776ade0 Speedier autoroller algorithm. (iannucci@chromium.org)

TBR=iannucci@chromium.org

Change-Id: I047f940bc70f0bdbe4fd6b918b850077af6ba1bf
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/478431
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>

7a9b425d

Roll recipe dependencies (trivial). · 48f1fdcd

recipe-roller authored Apr 14, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/a161d97046d010134d81308a27b9c6490b090005 errors_test: switch to new 'test' command (phajdan.jr@chromium.org)
  https://crrev.com/88d8d807fbcd9c59be19dbb1068c63fab11b1915 Add post_process hooks to verify recipe result (phajdan.jr@chromium.org)

TBR=iannucci@chromium.org

Change-Id: I5c1c5be5761e3fc62064ff326e27a109cf14d166
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/478251
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>

48f1fdcd

[presub] lstrip line limit exceptions; ignore <g and <path · 9b9b94c4

Dave Schuyler authored Apr 13, 2017

Previously, the <link lines in HTML are allowed to have longer than 80 characters.
This CL adds <g and <path to the HTML lines that may have unlimited characters.
(These g and path tags are used in svg image data).
These HTML exemptions also have a trailing space. The space is intended to reduce
false-positives in matching. There are some occurrences of these tags followed by a 
\n which will not match (but the line ends there, so it's not an issue).

These new tags may be preceded by blank space so .lstrip() was added to
the test. I believe this .lstrip() should not be an issue for the other
languages and exemptions present.

Bug: None
Change-Id: Ie9c2bca0e7147033e360ddcfc6eee3b73e167228
Reviewed-on: https://chromium-review.googlesource.com/477371Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>

9b9b94c4

13 Apr, 2017 4 commits

Roll recipe dependencies (trivial). · cc458639

recipe-roller authored Apr 13, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/0afe202a0f678a31dd725b31268e9629ead6f20a [autoroll] make json even less verbose, use nicer keys. (iannucci@chromium.org)

TBR=iannucci@chromium.org

Change-Id: I26ae23a4b0bbea66b24dfc5a988a317a0f8e7209
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/477670
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>

cc458639

Fix GetOldContents() to return an empty string if the file didn't exist. · d67e7158

Daniel Cheng authored Apr 13, 2017

Bug: 700108
Change-Id: I9010aa3b4aa467c91b93ffac924b3ec5a16cfaa2
Reviewed-on: https://chromium-review.googlesource.com/476590Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>

d67e7158

Roll recipe dependencies (trivial). · 3a3de33b

recipe-roller authored Apr 13, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/3a3f9c4eb9219f52e3203f38ac38de87b31daeb4 [autoroller] remove unused diff field. (iannucci@chromium.org)

TBR=iannucci@chromium.org

Change-Id: I0dd92aec95984574b577785f51d141fbf6b50606
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/476313
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>

3a3de33b

Roll recipe dependencies (trivial). · f84a8abf

recipe-roller authored Apr 13, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/a7afc5a62ed0e2c5237785128159a65921816796 [autoroll] remove unused --projects option. (iannucci@chromium.org)

TBR=iannucci@chromium.org

Change-Id: I3028cd65c26e98bba04c48418e5b589f3d35e1eb
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/476191
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>

f84a8abf

12 Apr, 2017 12 commits

Roll recipe dependencies (trivial). · 2c8a25e3

recipe-roller authored Apr 12, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/7d77ae17f27d76191bc42e370de2b19b4cdd66bd [autoroll] make rejected_candidate_details optional. (iannucci@chromium.org)

TBR=iannucci@chromium.org

Change-Id: I84b3e5a51bdf8d404422c6e2f5faf2f7eeb3f79f
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/476312
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>

2c8a25e3

Roll recipe dependencies (trivial). · 9705d61c

recipe-roller authored Apr 12, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/c0de54ec5af381455323647cf5611ef51a2db3a6 [bootstrap] make ultimate invocation more isolated (iannucci@chromium.org)

TBR=iannucci@chromium.org

Change-Id: I9d4a58a3396a6dddb55d85d852d008390793584a
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/476270
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>

9705d61c

bot_update: Show failed patch in "Patch Failure". · 8dd4edae

Dan Jacques authored Apr 12, 2017

Have "bot_update.py" export the failing patch body in its JSON. Have the
recipe actually emit the patch body in the "Patch Failure" step instead
of the "bot_update" step, and remove the "Patch Failure" step's
indirection to the "bot_update" step for patch failure.

This will provide a more straightforward user interface: the red step
that says "Patch Failure" now includes the details of the patch failure!

BUG=chromium:710477
TEST=expectations

Change-Id: I6ad305f0b972de89e4f0b5eb70edf41980447abd
Reviewed-on: https://chromium-review.googlesource.com/475950
Commit-Queue: Daniel Jacques <dnj@chromium.org>
Reviewed-by: Ryan Tseng <hinoka@chromium.org>

8dd4edae

Enable strict coverage for all modules · 3978290b

Paweł Hajdan, Jr authored Apr 12, 2017

Bug: chromium:693058
Change-Id: I6e00f73141722dc47f8da16e21dadd1d4e26a14f
Reviewed-on: https://chromium-review.googlesource.com/475911
Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

3978290b

Roll recipe dependencies (trivial). · 313c4e44

recipe-roller authored Apr 12, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/6357a418547dc444ed93544fa236642515f8ddca Correctly handle unused expectations for recipe module tests (phajdan.jr@chromium.org)

TBR=iannucci@chromium.org

Change-Id: Ifebcc357d97c76e843d953917d67d9587860368f
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/475167
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>

313c4e44

bot_update: add with_tags argument to ensure_checkout · f4597a4f

Paweł Hajdan, Jr authored Apr 12, 2017

Bug: 710817
Change-Id: Ifb2a9abe605d9e403c55ec1360d186af12dd2f34
Reviewed-on: https://chromium-review.googlesource.com/475775Reviewed-by: Michael Moss <mmoss@chromium.org>
Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>

f4597a4f

bot_update: add --with_tags switch · 7ac2c9a2

Paweł Hajdan, Jr authored Apr 12, 2017

Bug: 710817
Change-Id: Ice7cefaf5c5a5cac431a95d3adfa44f323eafb2f
Reviewed-on: https://chromium-review.googlesource.com/475230Reviewed-by: Michael Moss <mmoss@chromium.org>
Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>

7ac2c9a2

Refactor git cl tests. · 73827d15

Andrii Shyshkalov authored Apr 12, 2017

R=machenbach@chromium.org

Change-Id: I54f4a0507352f4d4e460188c9bc6425ff83f28bb
Reviewed-on: https://chromium-review.googlesource.com/475910Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

73827d15

Roll recipe dependencies (trivial). · 413b9ccf

recipe-roller authored Apr 12, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/addc0640c912a43c6ea02dbfda992407cc9957ff Revert of path: Add tracking of volatile paths. (patchset #3 id:40001 of https://codereview.chromium.org/2808713003/ ) (dnj@chromium.org)

TBR=iannucci@chromium.org

Change-Id: I1b643d307efcfc0dbbc7b9e575e9df7e9f6d4d9d
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/475166
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>

413b9ccf

git cl tests: improve readability of test helper. · e05d4882

Andrii Shyshkalov authored Apr 12, 2017

Shorten lines and remove useless stacktrace to make sure the actually
usefull exception fits on tandrii@'s screen :)

R=sergiyb@chromium.org

Change-Id: I387da6c70f72a122d64f7a044d201d72a858fc3f
Reviewed-on: https://chromium-review.googlesource.com/475811Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

e05d4882

Roll recipe dependencies (trivial). · fcc67b45

recipe-roller authored Apr 12, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/d6ceb66a08508d430a0fbdd5a6a17c09b9633694 Enable strict coverage for step module (reland #1) (phajdan.jr@chromium.org)

TBR=iannucci@chromium.org

Change-Id: I208c0ad51e88e052682315628247a0389167dfd7
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/475246
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>

fcc67b45

Roll recipe dependencies (trivial). · a143749f

recipe-roller authored Apr 12, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/f9234eae58f62b6af33d74391de1ead436fb3117 [fetch.py] only do a reset if diff is unclean. (iannucci@chromium.org)

TBR=iannucci@chromium.org

Change-Id: I9a2e5e960810826065e7469407ed15f4075ba922
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/475510
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>

a143749f

11 Apr, 2017 3 commits

Give Rietveld git-cl-status the 'not lgtm' state · a1bab27a

Aaron Gable authored Apr 11, 2017

While working on fixing git-cl-status for gerrit, I realized
it would be really easy to bring the Rietveld version up to
parity and simplify it at the same time.

Bug: 706460
Change-Id: Icff32b532fa29f8869205111cd117176e0d34b8f
Reviewed-on: https://chromium-review.googlesource.com/470448
Commit-Queue: Aaron Gable <agable@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

a1bab27a

Roll recipe dependencies (trivial). · 3922f54b

recipe-roller authored Apr 11, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/7bd2024cede7b97a253c496d263bf9bde6cc9815 [test] make --filter imply *.* instead of .* (iannucci@chromium.org)

TBR=iannucci@chromium.org

Change-Id: Ie635aaf72e305cd1c89b1d269ee4f5ea1acdfbda
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/475244
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>

3922f54b

Fix gerrit git-cl-status to be simpler and correct · 9ab38c68

Aaron Gable authored Apr 06, 2017

The loop over the messages didn't early-exit when it found
a non-CQ message, so it would continue looking until it
found any message by a non-owner. So all CLs with any comments
by anyone other than the uploader would be in 'reply' state
forever.

This CL fixes that, and also makes some other tweaks to
make the gerrit status code simpler and faster.

Bug: 706460
Change-Id: I5cc06962f5121fe042a315e5e2e205e556eb85da
Reviewed-on: https://chromium-review.googlesource.com/470586Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>

9ab38c68