- 11 Dec, 2019 1 commit
-
-
Robert Iannucci authored
goma_ctl.py recommends that folks run `pip install pywin32`, which will work up until python in depot_tools is updated, at which point it will break again. Running with vpython means that the vpython spec which ships with goma will correctly take effect. R=brucedawson@chromium.org, tikuta@chromium.org Bug: 1033106 Change-Id: Icafadf381df782ab30d6cc156419dd7ed424d2bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1962721 Auto-Submit: Robbie Iannucci <iannucci@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@google.com> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
-
- 30 Oct, 2019 1 commit
-
-
Fumitoshi Ukai authored
This reverts commit a0aed87f. Reason for revert: install goma client without update_hook update_hook would disrupt current users, so start without update_hook, which means goma cient in depot_tools user might need to restart compiler_proxy manually when updated. https://docs.google.com/document/d/1pnwfkU6Rd9dRtQC0sg2vATmyRbkYWhnNUTD5k1PddC0/edit# Original change's description: > Revert "put goma client in depot_tools" > > This reverts commit 77780358. > > Reason for revert: AttributeError: 'GomaEnvPosix' object has no attribute 'RestartCompilerProxy' > > Original change's description: > > put goma client in depot_tools > > > > install goma client cipd package in depot_tools. > > > > should not use $MYPATH/goma_ctl in cipd_bin_setup > > since $MYPATH/goma_ctl uses cipd_bin_setup in itself, > > so causing recursive calls. > > invoke python to run .cipd/goma_ctl.py in cipd_bin_setup > > instead. > > > > Bug: b/77663154 > > Change-Id: I9f82c766a886a2acfb899e3594e5f05a7b7bc75a > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1866350 > > Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> > > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > > Commit-Queue: Fumitoshi Ukai <ukai@chromium.org> > > TBR=sque@chromium.org,ukai@chromium.org,yyanagisawa@google.com,vadimsh@chromium.org,dpranke@chromium.org,tikuta@chromium.org,ehmaldonado@chromium.org,yekuang@google.com > > Change-Id: Ie050dfb524dd885634c31be829d733613e80aece > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: b/77663154 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1872129 > Reviewed-by: Fumitoshi Ukai <ukai@chromium.org> > Commit-Queue: Fumitoshi Ukai <ukai@chromium.org> TBR=sque@chromium.org,ukai@chromium.org,yyanagisawa@google.com,vadimsh@chromium.org,dpranke@chromium.org,tikuta@chromium.org,ehmaldonado@chromium.org,yekuang@google.com Bug: b/77663154 Change-Id: I8bb51631e4418ff63953099814bdb464128eb279 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1875982Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Fumitoshi Ukai <ukai@chromium.org>
-
- 10 May, 2019 1 commit
-
-
Robert Nagy authored
on non-linux systems bash is not the default shell (by default) and lives in a completely different path Change-Id: I6580c776dda1b60b3d5c5f5f1ce4d6694ac45fe9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1605902Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
-
- 30 Jan, 2019 1 commit
-
-
Vadim Shtayura authored
It knows how to interpret configuration files written in Starlark-based DSL and produce a bunch of protobuf messages as a result. Will be used to generate various infra configs. In particular, will be used by infra developers (to update configs), by PRESUBMIT.py on dev machines (to verify configs before uploading CLs) and by bots (to verify configs before submitting CLs). R=tandrii@chromium.org BUG=833946 Change-Id: Iceec7d808ce180f7d4a341fab8b5ce11933c2a6b Reviewed-on: https://chromium-review.googlesource.com/c/1444499 Commit-Queue: Vadim Shtayura <vadimsh@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org>
-
- 28 Jul, 2017 1 commit
-
-
Dan Jacques authored
Have the "update_depot_tools" script also do a CIPD tool sync. This will ensure that users and systems have access to tooling at sync-time rather than just-in-time loading them at execution time. Update the tool boostraps to suppress any sort of syncing logs, if it does happen. This will ensure that users who execute the tools don't see unexpected output. BUG=chromium:748651 TEST=local - Tested on Mac and Windows. Change-Id: I1aad897d885a07beeac40a372a658681720efd2a Reviewed-on: https://chromium-review.googlesource.com/591229 Commit-Queue: Daniel Jacques <dnj@chromium.org> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org>
-
- 26 Jul, 2017 1 commit
-
-
Dirk Pranke authored
This reverts commit 4d92fe43. Reason for revert: This moved the logging from invoking `led` or `vpython` to whenever someone would run something that would end up invoking `update_depot_tools`. It's good that we are calling this when we run update_depot_tools, but we probably should've suppressed the logging there in at least the success case, because now things are even more confusing. See crbug.com/748651. Original change's description: > [bootstraps] Sync at gclient, suppress output. > > Have the "update_depot_tools" script also do a CIPD tool sync. This will > ensure that users and systems have access to tooling at sync-time rather > than just-in-time loading them at execution time. > > Update the tool boostraps to suppress any sort of syncing logic, if it > does happen. This will ensure that users who execute the tools don't se > unexpected output. > > BUG=None > TEST=local > - Tested on Mac and Windows. > > R=dpranke@chromium.org, iannucci@chromium.org > > Change-Id: I8efce8c73cc4e82ffdf5067ba9b917119a81e843 > Reviewed-on: https://chromium-review.googlesource.com/581494 > Commit-Queue: Daniel Jacques <dnj@chromium.org> > Reviewed-by: Robbie Iannucci <iannucci@chromium.org> TBR=iannucci@chromium.org,dpranke@chromium.org,dnj@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: None Change-Id: I2485c9dd2e48a8dbdeebfff5da9d4c708e0edcb7 Reviewed-on: https://chromium-review.googlesource.com/585867Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org>
-
- 24 Jul, 2017 1 commit
-
-
Dan Jacques authored
Have the "update_depot_tools" script also do a CIPD tool sync. This will ensure that users and systems have access to tooling at sync-time rather than just-in-time loading them at execution time. Update the tool boostraps to suppress any sort of syncing logic, if it does happen. This will ensure that users who execute the tools don't se unexpected output. BUG=None TEST=local - Tested on Mac and Windows. R=dpranke@chromium.org, iannucci@chromium.org Change-Id: I8efce8c73cc4e82ffdf5067ba9b917119a81e843 Reviewed-on: https://chromium-review.googlesource.com/581494 Commit-Queue: Daniel Jacques <dnj@chromium.org> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org>
-
- 27 May, 2017 1 commit
-
-
Robert Iannucci authored
R=nodir@chromium.org Bug: 662654 Change-Id: I18898cb426ccbb895a82410dc61910a8b8e48f14 Reviewed-on: https://chromium-review.googlesource.com/517664 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by:
Nodir Turakulov <nodir@chromium.org>
-
- 10 May, 2017 1 commit
-
-
Dan Jacques authored
BUG=None TEST=None R=sergeyberezin@chromium.org Change-Id: I2bb22ad002b82767c6a7efb68412f9c1dbf57c27 Reviewed-on: https://chromium-review.googlesource.com/502228Reviewed-by:
Sergey Berezin <sergeyberezin@chromium.org> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
-
- 01 May, 2017 1 commit
-
-
Sergey Berezin authored
BUG=717208 R=dnj@chromium.org Change-Id: If937a382be9aa4d8eb5f957386e8b1b28cc1c3ac Reviewed-on: https://chromium-review.googlesource.com/492086Reviewed-by:
Daniel Jacques <dnj@chromium.org> Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Commit-Queue: Sergey Berezin <sergeyberezin@chromium.org>
-