Commits · 991ead187c148de57990cbeecb9ad35767987a7c · Linshizhi / Chromium_Depot_tools

29 Sep, 2020 2 commits

Roll recipe dependencies (trivial). · 991ead18

recipe-roller authored Sep 29, 2020

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/69e35c3f12132996e3699c66cc802f482dc3adfb
  69e35c3 (tikuta@chromium.org)
      [swarming] add cas support

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I1a702b46a11f3d5676e9309d43c29416414b0365
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2437031Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

991ead18

Roll recipe dependencies (trivial). · ead81e2b

recipe-roller authored Sep 29, 2020

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/cdb7d63bdd49ed097743766fbf58491336200965
  cdb7d63 (yiwzhang@google.com)
      [warning] Add integration tests

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I8eaef35153c78d4e51b8d11aad1a80c4f681a329
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2436800Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

ead81e2b

28 Sep, 2020 12 commits

Roll recipe dependencies (trivial). · c7853870

recipe-roller authored Sep 28, 2020

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/c4ca5123942d5269c153605a4e8ddcbb7b12928a
  c4ca512 (yiwzhang@google.com)
      [warning] print collected warning in simulation output

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I2371a9a2c2fe77c50d7c486a4fea444867808f61
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2436558Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

c7853870

Roll recipe dependencies (trivial). · 17db36a7

recipe-roller authored Sep 28, 2020

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/3015ec10c736b0485b09018ae1449c705ffd34ee
  3015ec1 (yiwzhang@google.com)
      [warning] Records import warnings when initialize api

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I226ac99f2cf21bc552f31fa34b75b5003ce33bce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2436557Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

17db36a7

Roll recipe dependencies (trivial). · 1099c11d

recipe-roller authored Sep 28, 2020

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/ffde22444e429925ff1b27ca51eae3e63da1e985
  ffde224 (iannucci@chromium.org)
      [luci_context] Make LUCI_CONTEXT modifications show in expectat...

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I7fd7f29470ad18ef6a799ef93471e1fb711a3aec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2436552Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

1099c11d

Roll recipe dependencies (trivial). · 3782c416

recipe-roller authored Sep 28, 2020

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/334a1ceb935fc30c26509b231a0a05c0d00fcc3f
  334a1ce (iannucci@chromium.org)
      [engine_step] Remove vestigial _asdict method.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I22bc9479ef4fd38183c07cd3a79b41080f6fb94c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2435152Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

3782c416

Roll recipe dependencies (trivial). · a5b83524

recipe-roller authored Sep 28, 2020

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/d60a98793de9dfb6711944edb203670f4adae39c
d60a987 (iannucci@chromium.org)
Revert "[swarming] add cas support"

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Idd39a54e3faeea21b3467fc79a6eff5260a0dc01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2435150Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

a5b83524

[depot_tools] Roll led to latest · 6db318ae

Chan Li authored Sep 28, 2020

This is to release https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/2424709

Change-Id: Ic68a20fc1e3e62fa031e432a3a00aa2b21126146
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2431573Reviewed-by: Scott Lee <ddoman@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Chan Li <chanli@chromium.org>

6db318ae

Roll recipe dependencies (trivial). · e78f45a1

recipe-roller authored Sep 28, 2020

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/2307f31506c879bb57ddfed06c14ec3835bd27ff
  2307f31 (iannucci@chromium.org)
      [runtime] Convert to proto based PROPERTIES, remove is_luci.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib936bdb6e86b2ae4d3d955a38feaa33d26a77797
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2434629Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

e78f45a1

Roll recipe dependencies (trivial). · 9a49d4b5

recipe-roller authored Sep 28, 2020

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/ad6afcb57861e86a926cdc22162e182b112c3d2c
  ad6afcb (iannucci@chromium.org)
      [runtime] Re-add is_luci PROPERTY to unblock roller.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I72b8c29aa75a674073531b0f7f5951e11110f9c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2434627Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

9a49d4b5

Roll recipe dependencies (trivial). · 77397c4f

recipe-roller authored Sep 28, 2020

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/12ab0ef8c9da852fe9d026704f6042545b63a15b
  12ab0ef (tikuta@chromium.org)
      [swarming] add cas support

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I608360932f3e8a67461f2c9f3154dff8593ab74d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2434801Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

77397c4f

Roll recipe dependencies (trivial). · 337cce5f

recipe-roller authored Sep 28, 2020

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/2ec61d59704a48de57db290e793dcd9eac1854ae
  2ec61d5 (tikuta@chromium.org)
      [cas] expand instance name if only project ID is given

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I11c3f9f36d982e783a66bbbac537b74f7eefc64f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2434800Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

337cce5f

Roll recipe dependencies (trivial). · 40640de5

recipe-roller authored Sep 28, 2020

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/a02e9a9b143043bd3b5b297c822d5aa8b1265e64
  a02e9a9 (tikuta@chromium.org)
      [cas] add instance property

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Iab79fe7fe67302269a506a84b34be47c7974dce4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2434795Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

40640de5

Roll recipe dependencies (trivial). · 26fef59e

recipe-roller authored Sep 28, 2020

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/9d0e5a6b275244f94be1e3e1f2748f13dc3b9ded
  9d0e5a6 (tikuta@chromium.org)
      [runtime] remove is_luci

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I5f18302dcf8970d77050e4cb7ad5b22efe532900
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2434835Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

26fef59e

26 Sep, 2020 2 commits

Miscellaneous fixes to post_build_ninja_summary.py · 0081a128

Bruce Dawson authored Sep 26, 2020

In Python 3 dict.values() is not a sortable type so it must be converted
to a list prior to returning targets data from the ReadTargets function.

In Python 3 you cannot compare arbitrary objects. This could happen when
sorting task_start_stop_times if the time and types were identical. This
is fixed by using the first two entries in the tuple as the sorting key.

When a .ninja_log file is corrupt it triggers a diagnostic message which
has only caused confusion. This changes that message to suggest the most
likely root cause (corruption) since that is the only cause I have seen.

If a build step generates multiple targets with long names then wrapping
of lines may occur. To avoid that the target description size is capped.

Bug: 941669
Change-Id: I2a808d2629a639e231ce2dbf2dab41251110b156
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2432409
Auto-Submit: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>

0081a128

Roll recipe dependencies (trivial). · 5b4d110a

recipe-roller authored Sep 26, 2020

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/d00eb7d8d5edfb623b8d2082a7ae74ae2cfeeebd
  d00eb7d (yiwzhang@google.com)
      [legacy_annotation] Add tests to cover kitchen code path

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib121b53c10d77dcd7285711c87b6fb7b4b3d3a89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2433180Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

5b4d110a

25 Sep, 2020 4 commits

Roll recipe dependencies (trivial). · fa0ad23b

recipe-roller authored Sep 25, 2020

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/d9e3644cddf23ec62d91964bbeb44eaf65927348
  d9e3644 (iannucci@chromium.org)
      [proto_support] Sort the _ProtoInfo.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I2caec44103928b311e77e7436ac86445acd42b1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2432410Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

fa0ad23b

[lucicfg] Update to v1.20.0. · d08de190

Vadim Shtayura authored Sep 25, 2020

It adds standard JSON module with json.encode(...), json.decode(...)
and json.indent(...).

R=iannucci@chromium.org
BUG=1130833

Change-Id: I0b217fdcd062cb5102991c506bc431c9eafe9e95
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2432110Reviewed-by: Scott Lee <ddoman@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>

d08de190

Roll recipe dependencies (trivial). · 7f386135

recipe-roller authored Sep 25, 2020

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/6cb11c0a89878d15a0488d6bb4512e2b3c86e119
  6cb11c0 (yiwzhang@google.com)
      [legacy_annotation] Raise StepFailure for failed step status

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I10d3673e750cd98e5705d7eeab7821573d4795b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2430671Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

7f386135

Roll recipe dependencies (trivial). · ad48fed4

recipe-roller authored Sep 25, 2020

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/deff8ff8d787bef8a50926755e30479a60e8096e
  deff8ff (tikuta@chromium.org)
      [cas] add a cas recipe module

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I042cad82d59662b4a7c3f31e17c1b4366e01a22b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2429213Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

ad48fed4

24 Sep, 2020 3 commits

Support main as default branch · c39ab997

Josip Sokcevic authored Sep 24, 2020

R=apolito@google.com

Change-Id: Ic338c698b8eb8d2e04fc1ef23ae4b13cae08b80f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2404701Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>

c39ab997

Roll recipe dependencies (trivial). · 3eb2555a

recipe-roller authored Sep 24, 2020

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/fa5f3282ef17fed733e73cae1770fff8bd183c59
  fa5f328 (yekuang@google.com)
      [swarming] Deep copy TaskRequest and TaskSlice

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I67b614928ce79973df9b7a14926fd479993fb31a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2427727Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

3eb2555a

mac-arm64: Provide an arm64-native ninja-mac for builds in ¼ of the time · 4005bb74

Mark Mentovai authored Sep 24, 2020

ninja-mac is expanded to become a universal (“fat”) executable. The
existing x86_64 slice was taken from the x86_64 ninja-mac as it
previously existed in this location, and a new arm64 slice was added.

This is an aid to native development on arm64. In macOS, subprocesses
inherit their parent’s “binpref,” meaning that children of a translated
process will, by default, also be translated, if there’s a choice
between native and translated. Where ninja-mac is x86_64-only and runs
translated on arm64, all tools it invokes will also run translated, even
if native versions are available. This has an impact on any part of the
toolchain for which universal versions are available: in Chrome’s case,
tools such as ld64 are affected. In Crashpad’s build, which uses the
compiler provided by Xcode, it even affects the compiler, leading to
significant differences in build time on arm64.

mark@arm-and-hammer zsh% file $(which ninja-mac)
…/ninja-mac: Mach-O 64-bit executable x86_64
mark@arm-and-hammer zsh% time ninja -C out/release
ninja: Entering directory `out/release'
[1/1] Regenerating ninja files
[511/511] LINK ./crashpad_minidump_test
ninja -C out/release  1384.03s user 111.05s system 393% cpu 6:19.53 total

mark@arm-and-hammer zsh% file $(which ninja-mac)
…/ninja-mac: Mach-O universal binary with 2 architectures: [x86_64:Mach-O 64-bit executable x86_64] [arm64:Mach-O 64-bit executable arm64]
…/ninja-mac (for architecture x86_64):	Mach-O 64-bit executable x86_64
…/ninja-mac (for architecture arm64):	Mach-O 64-bit executable arm64
mark@arm-and-hammer zsh% time ninja -C out/release
ninja: Entering directory `out/release'
[1/1] Regenerating ninja files
[511/511] LINK ./crashpad_minidump_test
ninja -C out/release  606.80s user 34.71s system 701% cpu 1:31.41 total

This differs from the previous attempt, e64cd3ae
(https://chromium-review.googlesource.com/c/2288417) in that the arm64
version was built with Xcode 12.2b1 (12B5018i). The linker in this
version of Xcode produces linker-signed output for arm64 by default. As
of macOS 11.0db6 (20A5364e), all arm64 code must be signed. More
information at
https://developer.apple.com/documentation/macos-release-notes/macos-big-sur-11-universal-apps-beta-release-notes#Code-Signing.
In the previous attempt, an older Xcode was used and the output was not
signed at all. Because it did not run on systems upgraded to 11.0db6,
this version of ninja-mac was backed out in a070dd18
(https://chromium-review.googlesource.com/c/2393775).

To create this ninja-mac:

% git clone https://github.com/ninja-build/ninja.git
% cd ninja
% git checkout v1.8.2
% mkdir ../build
% cd ../build
% LDFLAGS=-Wl,-s ../ninja/configure.py --bootstrap
% lipo -create -output ninja-mac $(which ninja-mac) ninja

An explanation of the LDFLAGS: e64cd3ae used “strip” on the output,
matching the stripped x86_64 slice, but “strip” is not currently
compatible with linker-signed executables. This is documented at
https://developer.apple.com/documentation/xcode-release-notes/xcode-12_2-beta-release-notes#Apple-Clang-Compiler.
I was unable to use the recommended workaround in this case. Rather than
leave the output unstripped, I asked ld64 to strip symbols using its -s
option, which it believes is obsolete, but in fact provides the intended
behavior.

The x86_64 slice is unsigned, as it was previously. The new arm64 slice
is linker-signed with an ad-hoc signature. The x86_64 slice was built
with the macOS 10.12 SDK and runs on Mac OS X 10.6 or later. The arm64
slice was built with and has a minimum runtime requirement of macOS
11.0. In practice, the difference doesn’t matter, as the 11.0 SDK is
required to build for arm64, and no macOS version earlier than 11.0 will
run on arm64.

Bug: chromium:1103315
Change-Id: I9f201d0d6f476e187acc0008681c3fd2c1a72aa0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2427051Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>

4005bb74

22 Sep, 2020 3 commits

Add xcode version for Mac OS 10.15.4 in osx_sdk · d1580d53

Jeff Yoon authored Sep 22, 2020

Adding a version map entry for 10.15.6 to default to XCode 12
GM (12a7209) as machines upgrade to 10.15.

Bug: 1128042, 1128044
Change-Id: I6396b67fdce006d19be35d972602bac3bd4ae0a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2422449Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Jeff Yoon <jeffyoon@chromium.org>

d1580d53

Use rstrip when getting footer tags · 407b5a54

Shahbaz Youssefi authored Sep 22, 2020

A quick bugfix was made in cc290980 that removed trailing empty lines
when getting tags out of the git log.  This preserved the behavior that
tags with trailing whitespace would retain said whitespace.

This change instead simplifies the logic that removes trailing
whitespace with the side effect that whitespace at the end of the last
tag is also stripped.  The unittests are adjusted accordingly

Bug: 1130601
Change-Id: I26d39736179b36ac2573de1ca003a5bc09f30a28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2423050
Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>

407b5a54

CheckDirMetadataFormat: LocalPath() -> AbsoluteLocalPath() · 02ffb6f4

Andrew Grieve authored Sep 22, 2020

LocalPath() should be used in error messages, but never when actually
trying to access a path.

Bug: 1127507
Change-Id: I03ec5421891ac67a8620cd3c7e88c2de1811e914
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2418914Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Auto-Submit: Andrew Grieve <agrieve@chromium.org>

02ffb6f4

21 Sep, 2020 2 commits

Strip trailing empty lines when getting footers · cc290980

Shahbaz Youssefi authored Sep 21, 2020

Take the following git change description (Note: added ~ to avoid
having these lines be parsed as tags):

```
~Test
~
~Bug: something
~Change-Id: Something
```

Sometimes(?) `git log --pretty=format:%B%n <hash>..` returns:

```
~Test
~
~Bug: something
~Change-Id: Something

```

The trailing empty line trips split_footers() up, making it return
an empty footer.

This change removes trailing empty lines before processing them.

Bug: 1130601
Change-Id: Ib8d6c37ad6817a47a744245d1a2455ac9af6c469
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2422378
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>

cc290980

Roll lucicfg tool to @ 8803da5d · e0244d97

Andrii Shyshkalov authored Sep 21, 2020

Old revision: 97cc28c4

Change logs:
  infra/infra:
    https://chromium.googlesource.com/infra/infra/+log/97cc28c4..8803da5d
  luci-go
    https://chromium.googlesource.com/infra/luci/luci-go/+log/9424c451..de333632/lucicfg

Bug: 1119883
Change-Id: Icaed8304e7d268bb4e7842fbc75895040df76d84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2420523Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Andrii Shyshkalov <tandrii@google.com>

e0244d97

18 Sep, 2020 3 commits

Roll recipe dependencies (trivial). · 244d7702

recipe-roller authored Sep 18, 2020

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/c02bbc83a32cb6edb9de4a0a108ed1934075bc88
c02bbc8 (lamontjones@chromium.org)
recipes.py: Run yapf

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I2ddf32e33c2543eaf83d05ba1aa53c953cc0b622
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2419166Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

244d7702

[cipd] Rollback latest CIPD deployment. · df123b29

Vadim Shtayura authored Sep 18, 2020

It was built with go1.15 which has a bug in deflate implementation
which may result in corruption when uploading >2GB files.

R=iannucci@chromium.org
BUG=1129704

Change-Id: Id61eaaed5dd18d8e51ac5150a9d29a5825805a17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2418899Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>

df123b29

gclient: Don't try opening pseudo-terminal pipes on AIX · d949c910

Milad Fa authored Sep 18, 2020

Change-Id: I57228d5b9d15253ae525cb2d138bfa9e73fea0e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2416977Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Dirk Pranke <dpranke@google.com>

d949c910

17 Sep, 2020 3 commits

Roll recipe dependencies (trivial). · fc79097f

recipe-roller authored Sep 17, 2020

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/7c33aeefa596b8af9fd017e591e3e5a4db47abb4
  7c33aee (ddoman@chromium.org)
      [resultdb] add param test_location_base to api.resultdb.wrap

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I1d3a64b6b9a35e4d061e5b16bed5615ab4342280
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2416781Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

fc79097f

Modify git map-branches to show the number of commits on a branch · 8d7201bc

Gavin Mak authored Sep 17, 2020

Currently, for a given branch, map-branches displays the number of
commits ahead and behind it is. This change replaces ahead with
commits, representing the number of commits a branch has, starting from
its base commit, and more accurately reflects the state of a repo.

Bug:1128716
Change-Id: I7c070b4efd452d82d878e1cfb7c20d1c80f38ec7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2412991
Commit-Queue: Gavin Mak <gavinmak@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>

8d7201bc

[depot_tools] Roll led to latest · e2e75b23

Chan Li authored Sep 17, 2020

Change-Id: I77d93d35c337b6834b1a39487bc925befa822783
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2416777Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Chan Li <chanli@chromium.org>

e2e75b23

16 Sep, 2020 6 commits

Update man files related to merge-base with better description · a787cd5e

Gavin Mak authored Sep 16, 2020

Change-Id: I9796d2034a8a3c1243defc7f18f0aee1d701ba00
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2414569Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Gavin Mak <gavinmak@google.com>

a787cd5e

[recipes] remove is_luci specification · 5c4c28f1

Takuto Ikuta authored Sep 16, 2020

This is always True now.

Bug: 1128847
Change-Id: Ief951e9312ea8bd13c98b4bbc87c18d7307bb43a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2413667Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>

5c4c28f1

Roll recipe dependencies (trivial). · 6854d1dd

recipe-roller authored Sep 16, 2020

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/ff8e5c909f5f4049ccf543af4f36e5a8b58b379f
  ff8e5c9 (tikuta@chromium.org)
      [runtime] remove is_luci usage from recipe test

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I83e94271c9d8a502bacc25d9e2bd6519c0072eb9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2413485Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

6854d1dd

tandrii: switch OWNERS to @google.com account. · 7b7bdcd0

Andrii Shyshkalov authored Sep 16, 2020

R=tikuta
TBR=tandrii@chromium.org

Change-Id: I8ce4eb78e8ec2cf4c6d816b8a5ca63dbb0de66c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2411985Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>

7b7bdcd0

Roll recipe dependencies (trivial). · 2595f13f

recipe-roller authored Sep 16, 2020

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/ad8c0d9aab73a9593a4505bb828abd536f4cd68a
  ad8c0d9 (tikuta@chromium.org)
      [runtime] fixed to set True for is_luci

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I8936f5116843a243ae767c2e78b3a732a3a75399
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2413484Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

2595f13f

[depot_tools] Roll led to latest · 8e500174

Chan Li authored Sep 16, 2020

This is to include the change of https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/2343646

Bug: 1099018
Change-Id: Iade31e972e45d59542e7b4ee24dfd1136056eb5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2412992Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Chan Li <chanli@chromium.org>

8e500174