Commits · 9705d61c7ca22f225ff07708908b6d84d3bc31cc · Linshizhi / Chromium_Depot_tools

12 Apr, 2017 11 commits

Roll recipe dependencies (trivial). · 9705d61c

recipe-roller authored Apr 12, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/c0de54ec5af381455323647cf5611ef51a2db3a6 [bootstrap] make ultimate invocation more isolated (iannucci@chromium.org)

TBR=iannucci@chromium.org

Change-Id: I9d4a58a3396a6dddb55d85d852d008390793584a
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/476270
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>

9705d61c

bot_update: Show failed patch in "Patch Failure". · 8dd4edae

Dan Jacques authored Apr 12, 2017

Have "bot_update.py" export the failing patch body in its JSON. Have the
recipe actually emit the patch body in the "Patch Failure" step instead
of the "bot_update" step, and remove the "Patch Failure" step's
indirection to the "bot_update" step for patch failure.

This will provide a more straightforward user interface: the red step
that says "Patch Failure" now includes the details of the patch failure!

BUG=chromium:710477
TEST=expectations

Change-Id: I6ad305f0b972de89e4f0b5eb70edf41980447abd
Reviewed-on: https://chromium-review.googlesource.com/475950
Commit-Queue: Daniel Jacques <dnj@chromium.org>
Reviewed-by: Ryan Tseng <hinoka@chromium.org>

8dd4edae

Enable strict coverage for all modules · 3978290b

Paweł Hajdan, Jr authored Apr 12, 2017

Bug: chromium:693058
Change-Id: I6e00f73141722dc47f8da16e21dadd1d4e26a14f
Reviewed-on: https://chromium-review.googlesource.com/475911
Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

3978290b

Roll recipe dependencies (trivial). · 313c4e44

recipe-roller authored Apr 12, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/6357a418547dc444ed93544fa236642515f8ddca Correctly handle unused expectations for recipe module tests (phajdan.jr@chromium.org)

TBR=iannucci@chromium.org

Change-Id: Ifebcc357d97c76e843d953917d67d9587860368f
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/475167
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>

313c4e44

bot_update: add with_tags argument to ensure_checkout · f4597a4f

Paweł Hajdan, Jr authored Apr 12, 2017

Bug: 710817
Change-Id: Ifb2a9abe605d9e403c55ec1360d186af12dd2f34
Reviewed-on: https://chromium-review.googlesource.com/475775Reviewed-by: Michael Moss <mmoss@chromium.org>
Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>

f4597a4f

bot_update: add --with_tags switch · 7ac2c9a2

Paweł Hajdan, Jr authored Apr 12, 2017

Bug: 710817
Change-Id: Ice7cefaf5c5a5cac431a95d3adfa44f323eafb2f
Reviewed-on: https://chromium-review.googlesource.com/475230Reviewed-by: Michael Moss <mmoss@chromium.org>
Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>

7ac2c9a2

Refactor git cl tests. · 73827d15

Andrii Shyshkalov authored Apr 12, 2017

R=machenbach@chromium.org

Change-Id: I54f4a0507352f4d4e460188c9bc6425ff83f28bb
Reviewed-on: https://chromium-review.googlesource.com/475910Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

73827d15

Roll recipe dependencies (trivial). · 413b9ccf

recipe-roller authored Apr 12, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/addc0640c912a43c6ea02dbfda992407cc9957ff Revert of path: Add tracking of volatile paths. (patchset #3 id:40001 of https://codereview.chromium.org/2808713003/ ) (dnj@chromium.org)

TBR=iannucci@chromium.org

Change-Id: I1b643d307efcfc0dbbc7b9e575e9df7e9f6d4d9d
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/475166
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>

413b9ccf

git cl tests: improve readability of test helper. · e05d4882

Andrii Shyshkalov authored Apr 12, 2017

Shorten lines and remove useless stacktrace to make sure the actually
usefull exception fits on tandrii@'s screen :)

R=sergiyb@chromium.org

Change-Id: I387da6c70f72a122d64f7a044d201d72a858fc3f
Reviewed-on: https://chromium-review.googlesource.com/475811Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

e05d4882

Roll recipe dependencies (trivial). · fcc67b45

recipe-roller authored Apr 12, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/d6ceb66a08508d430a0fbdd5a6a17c09b9633694 Enable strict coverage for step module (reland #1) (phajdan.jr@chromium.org)

TBR=iannucci@chromium.org

Change-Id: I208c0ad51e88e052682315628247a0389167dfd7
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/475246
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>

fcc67b45

Roll recipe dependencies (trivial). · a143749f

recipe-roller authored Apr 12, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/f9234eae58f62b6af33d74391de1ead436fb3117 [fetch.py] only do a reset if diff is unclean. (iannucci@chromium.org)

TBR=iannucci@chromium.org

Change-Id: I9a2e5e960810826065e7469407ed15f4075ba922
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/475510
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>

a143749f

11 Apr, 2017 17 commits

Give Rietveld git-cl-status the 'not lgtm' state · a1bab27a

Aaron Gable authored Apr 11, 2017

While working on fixing git-cl-status for gerrit, I realized
it would be really easy to bring the Rietveld version up to
parity and simplify it at the same time.

Bug: 706460
Change-Id: Icff32b532fa29f8869205111cd117176e0d34b8f
Reviewed-on: https://chromium-review.googlesource.com/470448
Commit-Queue: Aaron Gable <agable@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

a1bab27a

Roll recipe dependencies (trivial). · 3922f54b

recipe-roller authored Apr 11, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/7bd2024cede7b97a253c496d263bf9bde6cc9815 [test] make --filter imply *.* instead of .* (iannucci@chromium.org)

TBR=iannucci@chromium.org

Change-Id: Ie635aaf72e305cd1c89b1d269ee4f5ea1acdfbda
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/475244
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>

3922f54b

Fix gerrit git-cl-status to be simpler and correct · 9ab38c68

Aaron Gable authored Apr 06, 2017

The loop over the messages didn't early-exit when it found
a non-CQ message, so it would continue looking until it
found any message by a non-owner. So all CLs with any comments
by anyone other than the uploader would be in 'reply' state
forever.

This CL fixes that, and also makes some other tweaks to
make the gerrit status code simpler and faster.

Bug: 706460
Change-Id: I5cc06962f5121fe042a315e5e2e205e556eb85da
Reviewed-on: https://chromium-review.googlesource.com/470586Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>

9ab38c68

Roll recipe dependencies (trivial). · a6c7d95f

recipe-roller authored Apr 11, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/5a74d04e181b07592fb57abd5602bafe276e2b17 bootstrap: Invoke "pip" through Python. (dnj@chromium.org)

TBR=iannucci@chromium.org

Change-Id: Iadb36eb631b2fbbefa9ea61b72c55a69564f9b81
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/473894
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>

a6c7d95f

Roll recipe dependencies (trivial). · 898c2795

recipe-roller authored Apr 11, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/939068138596e0259bd19be9e40c1ab17f55b3d6 Revert of Enable strict coverage for step module (patchset #3 id:40001 of https://codereview.chromium.org/2806363004/ ) (phajdan.jr@chromium.org)

TBR=iannucci@chromium.org

Change-Id: I54dcc754d21caff570f9a6473130cb288a147f61
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/473851
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>

898c2795

bot_update: add basic deapply_patch logic · 36d66752

Paweł Hajdan, Jr authored Apr 11, 2017

This will make it reusable, e.g. for https://chromium-review.googlesource.com/c/465417/

Bug: none
Change-Id: I96f13c6ff3aff22c787e290979602e7a0d725213
Reviewed-on: https://chromium-review.googlesource.com/474139Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>

36d66752

Roll recipe dependencies (trivial). · f20776d5

recipe-roller authored Apr 11, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/3bd327959845d8cb93d1987b3da790a20384a1e1 Enable strict coverage for step module (phajdan.jr@chromium.org)

TBR=iannucci@chromium.org

Change-Id: I7c49190fc5fa556ad462e9a0c9b0f25bb042f5ad
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/473950
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>

f20776d5

apply_issue: remove old hack. · eebca917

Andrii Shyshkalov authored Apr 11, 2017

Nothing should depend on this magic file any more.

R=maruel@chromium.org,agable@chromium.org

Change-Id: Ibff8e2b575b119733c6c21ca6aebe38856c578c1
Reviewed-on: https://chromium-review.googlesource.com/474826
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>

eebca917

Shamelessly plug $ git cl creds-check into yet another place. · 51acef99

Andrii Shyshkalov authored Apr 11, 2017

R=machenbach@chromium.org

Bug: 689543
Change-Id: I73607e7afe78bac3bbe509fe9c4387dfd0095011
Reviewed-on: https://chromium-review.googlesource.com/474138Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

51acef99

git cl patch <url>: better handling of URLs. · c971239e

Andrii Shyshkalov authored Apr 11, 2017

* if --rietveld or --gerrit is given, parse only using appropriate
  parser.
* if url has '$HOST-review' in the beginning, assume it's Gerrit
* if type of codereview is detected based on URL, then print this
  information for the user.
  This also applies to `git cl description` but message is logged instead,
  because in '-d|--display' option git cl is supposed to print only description,
  and some tooling likely relies on this :(

R=jochen@chromium.org
BUG=706406

Change-Id: I21c9355c5334fd71db27618cda11287f75168b59
Reviewed-on: https://chromium-review.googlesource.com/473186
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>

c971239e

Roll recipe dependencies (trivial). · 38bbd23a

recipe-roller authored Apr 11, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/05d9ed6145e2b05b7430fb7306f279fb2e2f19b2 [bundle] allow empty directories. (iannucci@chromium.org)

TBR=iannucci@chromium.org

Change-Id: I98f5d744f11e7de7ce82ad4ee648c367799fabd6
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/474685
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>

38bbd23a

Stop running deprecated simulation_test · ec576ecf

Paweł Hajdan, Jr authored Apr 10, 2017

See https://codereview.chromium.org/2808833003/
for context.

Bug: 699120, 693058
Change-Id: I1420c347d4ae2bac8bea54bc1b921fe6b65e6161
Reviewed-on: https://chromium-review.googlesource.com/474027Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>

ec576ecf

Roll recipe dependencies (trivial). · 94fd88ee

recipe-roller authored Apr 11, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/168be2068b30c07600603f1ce7fffe8f21348965 [doc/recipes.py] stop intercepting --help (iannucci@chromium.org)

TBR=iannucci@chromium.org

Change-Id: If3c76b68fd224eae3bf5c333ca80ef633a7554a1
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/473791
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>

94fd88ee

Roll recipe dependencies (trivial). · b55f20bc

recipe-roller authored Apr 11, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/e47e63a157739d48e41f71a2d3827d1a38277359 Fix autoroller updates() criteria. (iannucci@chromium.org)

TBR=iannucci@chromium.org

Change-Id: Ifda7ecac9682dbf5cfd72b0ff911187180bcc3f8
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/473790
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>

b55f20bc

Roll recipe dependencies (trivial). · 1eedff07

recipe-roller authored Apr 11, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/8ccde4e6c9059cd907363ff4771fc6f222aee05e Fix typobug (iannucci@google.com)

TBR=iannucci@chromium.org

Change-Id: I0de51cbb16b8bc7f94f054e39a7242b8f0afff1a
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/474188
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>

1eedff07

git hyper-blame: Fixed --no-default-ignores option to not take argument. · 17a53072

Matt Giuca authored Apr 10, 2017

BUG=709835

Change-Id: Ia203cf24adf752ef3acdf660b4fe0990503782b9
Reviewed-on: https://chromium-review.googlesource.com/472587Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Matt Giuca <mgiuca@chromium.org>

17a53072

Roll recipe dependencies (trivial). · 56431bf3

recipe-roller authored Apr 11, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/cc1f2ad78df7d3d19cff8e2d31866b9e49f732a9 Heavily refactor repo backends system. (iannucci@chromium.org)

TBR=iannucci@chromium.org

Change-Id: I6d0883bd514106852ad11bab40422392389e0fcc
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/473890
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>

56431bf3

10 Apr, 2017 12 commits

Roll recipe dependencies (trivial). · 109907e6

recipe-roller authored Apr 10, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/f5e47cfc28b5964701572db12f96c7a5a3f1821a Enable strict coverage for json, path, platform, properties, raw_io (phajdan.jr@chromium.org)

TBR=iannucci@chromium.org

Change-Id: Ib252420e515f7521a4b36129edcdcc6d2dbe1be4
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/474186
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>

109907e6

Roll recipe dependencies (trivial). · 10364a7c

recipe-roller authored Apr 10, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/56ba34248d8319cfdaff19ae55d68004fdd8ebf8 Stop running deprecated simulation_test (phajdan.jr@chromium.org)

TBR=iannucci@chromium.org

Change-Id: I7c379c112ee63a2daf6050ab3ccccd9ae940d90b
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/473929
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>

10364a7c

Actually enable crash dump collection on builders · 93e1a76e

Bruce Dawson authored Apr 10, 2017

Change crrev.com/1825163003 attempted to enable crash dump collection
on build machines, and it worked fine on local testing. However it only
worked because local testing was done using 64-bit Python. The builders
use python from depot_tools which is 32-bit Python so the changes all
went to "HKEY_LOCAL_MACHINE\SOFTWARE\Wow6432Node\Microsoft" instead of
to "HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft", which means they were
ignored. For a year. This made investigation of linker crashes more
complicated than needed.

This change uses the necessary winreg.KEY_WOW64_64KEY dance so that the
64-bit registry is always used, whether running 32-bit Python or 64-bit
Python. Both versions were tested locally. The behavior on 32-bit
Windows is unknown but we don't support building on 32-bit Windows
anyway, and any failures would be rendered harmless by the try/except
block.

R=scottmg@chromium.org
BUG=704286

Change-Id: I6abc0e1e9c69b9a4e4b9c705bea9e4faadd0945c
Reviewed-on: https://chromium-review.googlesource.com/473567Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>

93e1a76e

Add *.proto to git-gs · 2b4ac398

Scott Graham authored Apr 10, 2017

Change-Id: I393579c9cfafbd6a5331abb13e33b61c8fa69df7
Reviewed-on: https://chromium-review.googlesource.com/473548Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>

2b4ac398

Roll recipe dependencies (trivial). · 5c25aae6

recipe-roller authored Apr 10, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/4afdf69bc15cbcf6a88076da7074d24cb88780d2 Add test coverage for testing recipe configs and test_api (phajdan.jr@chromium.org)

TBR=iannucci@chromium.org

Change-Id: Ia28a35f38794ae2baae3b29a58594eb67b6647b6
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/473927
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>

5c25aae6

Manual recipe roll (trivial). · 4f0fb066

Dan Jacques authored Apr 10, 2017

Recipe rolling is encountering difficulty, so manually roll.

BUG=None
TEST=None

Change-Id: I0f406b4fcb4b2dfc1485e881ea7893cd3267ec8e
Reviewed-on: https://chromium-review.googlesource.com/473547Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Daniel Jacques <dnj@chromium.org>

4f0fb066

git cl: remember codereview type when parsing issue/change URL. · 90f31927

Andrii Shyshkalov authored Apr 10, 2017

R=jochen@chromium.org
BUG=706406

Change-Id: I477d1cf629bb0bccebead6e5c0189830ea76be7e
Reviewed-on: https://chromium-review.googlesource.com/472867
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>

90f31927

git_hyper_blame: Fix wrong line number on lines changed many times. · 2cd3c14e

Matt Giuca authored Apr 10, 2017

This could, in extreme cases, result in a crash due to the wrong line
number being out of bounds of the file line count.

BUG=709831

Change-Id: I08ec75362d49c4a72e7ee9fd489d5f9baa6d31bd
Reviewed-on: https://chromium-review.googlesource.com/472648Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>

2cd3c14e

git cl patch: when URL matches both codereview systems, choose rietveld. · 28d840eb

Andrii Shyshkalov authored Apr 10, 2017

This is temporary, and will be changed in subsequent CLs. For now,
it suffices to stop relying on pseudo-random dictionary order in tests
and prod.

R=jochen@chromium.org
BUG=706406

Change-Id: I26c467a28bc63b5f81d20fc222a2b6f0511c507f
Reviewed-on: https://chromium-review.googlesource.com/472750Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

28d840eb

Gerrit git cl upload: if -m is given, don't prompt for patchset title. · 2d8a2074

Andrii Shyshkalov authored Apr 10, 2017

R=sergiyb@chromium.org
BUG=697625

Change-Id: I493bcc9212baf9030270cb71cf75ac969a67f2a0
Reviewed-on: https://chromium-review.googlesource.com/472724
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>

2d8a2074

git cl: suggest git cl creds-check if Gerrit API returns 401. · 4956f798

Andrii Shyshkalov authored Apr 10, 2017

R=sergiyb@chromium.org
BUG=708785

Change-Id: Id25d3ef9a1449a0c259ed48b782e1b766e1a5fc9
Reviewed-on: https://chromium-review.googlesource.com/472906Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

4956f798

git cl comment: cleanup mistakenly left TODO. · 70909e1e

Andrii Shyshkalov authored Apr 10, 2017

R=sergiyb@chromium.org

Change-Id: Ieea94428c7d9932242fb57b80afc1cf366b7bb54
Reviewed-on: https://chromium-review.googlesource.com/472827Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

70909e1e