- 07 Jul, 2015 1 commit
-
-
sergiyb@chromium.org authored
This is needed to ensure that it resolves to a correct URL on Gitiles. R=maruel@chromium.org, smut@google.com Review URL: https://codereview.chromium.org/1225713002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295932 0039d316-1c4b-4281-b951-d872f2087c98
-
- 22 Jun, 2015 1 commit
-
-
rmistry@google.com authored
Motivation: The conversation in https://docs.google.com/document/d/1KZGFKZpOPvco81sYVRCzwlnjGctup71RAzY0MSb0ntc/edit?disco=AAAAAXU60E8 BUG=502257 Review URL: https://codereview.chromium.org/1191473002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295779 0039d316-1c4b-4281-b951-d872f2087c98
-
- 11 Jun, 2015 1 commit
-
-
pgervais@chromium.org authored
BUG=496892 Review URL: https://codereview.chromium.org/1156223008 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295634 0039d316-1c4b-4281-b951-d872f2087c98
-
- 08 Jun, 2015 1 commit
-
-
smut@google.com authored
Because some interfaces aren't linkifying the URL when the commit message ends with it. BUG=480922 TESTED=tests/git_cl_test.py; presubmit ok Review URL: https://codereview.chromium.org/1165293002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295566 0039d316-1c4b-4281-b951-d872f2087c98
-
- 28 May, 2015 1 commit
-
-
wychen@chromium.org authored
Before this change, the commit message only contains issue number and patchset number. Adding CL description should be more informative. Review URL: https://codereview.chromium.org/1128473003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295449 0039d316-1c4b-4281-b951-d872f2087c98
-
- 04 May, 2015 1 commit
-
-
luqui@chromium.org authored
NOPRESUBMIT because it's broke on CQ, Cf. https://codereview.chromium.org/1124803002 BUG=478260 NOPRESUBMIT=true Review URL: https://codereview.chromium.org/1110293002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295124 0039d316-1c4b-4281-b951-d872f2087c98
-
- 28 Apr, 2015 2 commits
-
-
wychen@chromium.org authored
After crrev.com/896453002, if "git cl diff" ends up having conflict, it would be cleaned up. However, if "git cl patch" ends up with conflict, the user should still be able to manually resolve them. BUG=438362 TEST=tests/git_cl_test.py Review URL: https://codereview.chromium.org/1091283004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295051 0039d316-1c4b-4281-b951-d872f2087c98
-
wychen@chromium.org authored
The assertion in TestGitCl.tearDown should be done after super.tearDown is finished. Otherwise if the assertion fails, mocked objects won't be restored properly, and the next TestCase would be affected. Review URL: https://codereview.chromium.org/1093943002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295049 0039d316-1c4b-4281-b951-d872f2087c98
-
- 20 Apr, 2015 1 commit
-
-
vadimsh@chromium.org authored
ClientLogin will be supposedly turned off on Apr 20. R=maruel@chromium.org BUG=356813 Review URL: https://codereview.chromium.org/1095033002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@294899 0039d316-1c4b-4281-b951-d872f2087c98
-
- 17 Apr, 2015 1 commit
-
-
vadimsh@chromium.org authored
OAuth token cache file (as implemented by oauth2client library) stores refresh token and can in theory be deployed via Puppet as the credential. But it is mutated by the library (to store access tokens, rotated each hour), and so it is not static and managing it via Puppet (or however else) is a big pain. Instead, now depot_tools accepts --auth-refresh-token-json parameter with a path to a static JSON file (with minimal body being {"refresh_token": "....."}). It can be used to pass previously prepared refresh tokens of role accounts. It will be used for blink DEPS roller account and similar @chromium.org accounts. R=maruel@chromium.org BUG=356813 Review URL: https://codereview.chromium.org/1060193005 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@294870 0039d316-1c4b-4281-b951-d872f2087c98
-
- 13 Apr, 2015 1 commit
-
-
akuegel@chromium.org authored
BUG=356813 Review URL: https://codereview.chromium.org/1083693002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@294777 0039d316-1c4b-4281-b951-d872f2087c98
-
- 10 Apr, 2015 1 commit
-
-
vadimsh@chromium.org authored
This CL introduces new top level command for managing cached auth tokens: $ depot-tools-auth login codereview.chromium.org $ depot-tools-auth info codereview.chromium.org $ depot-tools-auth logout codereview.chromium.org All scripts that use rietveld.Rietveld internally should be able to use cached credentials created by 'depot-tools-auth' subcommand. Also 'depot-tools-auth' is the only way to run login flow. If some scripts stumbles over expired or revoked token, it dies with the error, asking user to run 'depot-tools-auth login <hostname>'. Password login is still default. OAuth2 can be enabled by passing --oauth2 to all scripts. R=maruel@chromium.org BUG=356813 Review URL: https://codereview.chromium.org/1074673002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@294764 0039d316-1c4b-4281-b951-d872f2087c98
-
- 09 Apr, 2015 2 commits
-
-
vadimsh@chromium.org authored
It is done in preparation for switching to OAuth2 as default (and only) authentication method. Having all auth options handled by the same code makes it easier to gradually add OAuth2 support. As part of this, some options that would no longer work with OAuth2 (and that are not being used from anywhere now, as far as I can tell) are removed: * Passing account password for authentication via command line. * Overriding 'Host' header when making requests to Rietveld (won't work with SSL anyway). * --account_type option (seems to be ClientLogin specific). R=maruel@chromium.org BUG=356813 Review URL: https://codereview.chromium.org/1075723002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@294746 0039d316-1c4b-4281-b951-d872f2087c98
-
sbc@chromium.org authored
Error out of the current tree is dirty (previously the dirty content would be incorporated silently into the newly squashed branch!). Review URL: https://codereview.chromium.org/1064933004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@294744 0039d316-1c4b-4281-b951-d872f2087c98
-
- 03 Mar, 2015 1 commit
-
-
rmistry@google.com authored
Context: In https://codereview.chromium.org/781523002/ I added the ability for target_ref to be set to any branch name. Eg: For Skia a ref of 'refs/remotes/origin/chrome/m42' would be correctly set to 'refs/heads/chrome/m42'. But in https://codereview.chromium.org/822503005/ this was changed to treat any branch that did not start with 'refs/remotes/branch-heads' or 'refs/remotes/origin/refs' to be 'refs/remotes/origin/master'. This makes it very chromium specific, there are plenty of other projects that use depot_tools that does not work like this. For Skia 'refs/remotes/origin/chrome/m42' would now change to 'refs/remotes/origin/master' which is wrong. The default behavior should be to preserve the original ref not to override it to master. I handled 'lkgr' and 'lkcr' as special cases in this CL because many developers track it and would like it to land in master by default. BUG=chromium:463109 NOPRESUBMIT=true Review URL: https://codereview.chromium.org/967453004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@294303 0039d316-1c4b-4281-b951-d872f2087c98
-
- 26 Feb, 2015 1 commit
-
-
rmistry@google.com authored
Motivation: There are a few things we want to do in Skia infrastructure that is not possible to do without this functionality. Eg1: If there is a change made to Skia's markdown then automatically include a 'DOCS_PREVIEW_URL=https://skia.org?cl=1234' in the CL's description. Eg2: Automatically add 'NOTRY=true' for changes impacting things that do not need trybot runs. Eg3: Include CL specific links to skia's perf (https://perf.skia.org/) and correctness (https://gold.skia.org/) servers. BUG=chromium:462208 Review URL: https://codereview.chromium.org/949273002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@294242 0039d316-1c4b-4281-b951-d872f2087c98
-
- 16 Feb, 2015 1 commit
-
-
bauerb@chromium.org authored
This makes uploading to Gerrit with `git cl` more similar to uploading to Rietveld, by uploading a squashed commit containing the diff to the newest common ancestor. Uploaded commits are stored in refs/heads/git_cl_uploads/<branch> (and their commit message is used for the squash commit), which allows amending the commit message to change it on the uploaded CL, and looking through the reflog to find old uploaded versions. BUG=none Review URL: https://codereview.chromium.org/200023004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@294077 0039d316-1c4b-4281-b951-d872f2087c98
-
- 26 Jan, 2015 1 commit
-
-
wittman@chromium.org authored
This is similar to the Gerrit behavior in that we default to master, unless the remote upstream is a branch head. BUG=435702 Review URL: https://codereview.chromium.org/822503005 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293807 0039d316-1c4b-4281-b951-d872f2087c98
-
- 02 Dec, 2014 1 commit
-
-
kjellander@chromium.org authored
This fix is created to avoid having to rebuild all the WebRTC Git mirrors since they're configured to sync with the http URL instead of https (resulting in git-svn-id Git footers with the http URL in the commit messages). Without rewriting this, it is not possible to commit to SVN since Google code disallows committing to a http URL. BUG=412012 TEST=Created a CL using a Git repo like this (both before and after landing https://webrtc-codereview.appspot.com/32569004): git clone https://chromium.googlesource.com/external/webrtc.git cd webrtc git auto-svn git checkout master git checkout -b test (edit whitespace change) git commit -am "Whitespace edit git cl upload --bypass-hooks" git cl dcommit R=agable@chromium.org, machenbach@chromium.org, mmoss@chromium.org Review URL: https://codereview.chromium.org/760903004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293171 0039d316-1c4b-4281-b951-d872f2087c98
-
- 22 Aug, 2014 2 commits
-
-
jam@chromium.org authored
This is broken for a few reasons (see bug for details). Also, this works automatically now with the analyze step. This is a revert of r280039. BUG=406238 R=iannucci@chromium.org, sky@chromium.org Review URL: https://codereview.chromium.org/501503002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291526 0039d316-1c4b-4281-b951-d872f2087c98
-
vadimsh@chromium.org authored
R=iannucci@chromium.org BUG=404214 Review URL: https://codereview.chromium.org/496073002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291302 0039d316-1c4b-4281-b951-d872f2087c98
-
- 23 Jul, 2014 1 commit
-
-
maruel@chromium.org authored
It serves no purpose, and it's annoying when the presubmit checks take more than 2-3 seconds because I always switch off to another window, so I come back minutes later seeing this prompt waiting for me. R=stip@chromium.org BUG= Review URL: https://codereview.chromium.org/407413002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@285071 0039d316-1c4b-4281-b951-d872f2087c98
-
- 07 Jul, 2014 2 commits
-
-
bratell@opera.com authored
Revert of Allow git cl also in repos with read-only git-svn. (https://codereview.chromium.org/344013005/) Reason for revert: Breaks WebRTC (and possibly other projects actually using https:// for svn access). Original issue's description: > Allow git cl also in repos with read-only git-svn. > > If you have read-only git-svn git cl would still try > to use svn commands, which would then fail. This > changes git cl to only use git-svn if the remote > svn repository use the svn:// protocol. It matches > how chromium works and it allowed me to upload a patch. > > BUG=391430 > > R=iannucci > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=281500 TBR=iannucci@chromium.org NOTREECHECKS=true NOTRY=true BUG=391430 Review URL: https://codereview.chromium.org/375553002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@281513 0039d316-1c4b-4281-b951-d872f2087c98
-
bratell@opera.com authored
If you have read-only git-svn git cl would still try to use svn commands, which would then fail. This changes git cl to only use git-svn if the remote svn repository use the svn:// protocol. It matches how chromium works and it allowed me to upload a patch. BUG=391430 R=iannucci Review URL: https://codereview.chromium.org/344013005 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@281500 0039d316-1c4b-4281-b951-d872f2087c98
-
- 26 Jun, 2014 2 commits
-
-
martiniss@chromium.org authored
BUG= Review URL: https://codereview.chromium.org/355063004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@280051 0039d316-1c4b-4281-b951-d872f2087c98
-
martiniss@chromium.org authored
This is part of my intern project, which is detailed here: "https://docs.google.com/a/google.com/document/d/10bkzag1UUbtESPkEWHYaZtGMEEbCN5Zad72PuoRpwZE/edit#" The idea is to have "git cl upload" annotate the CL description with a flag like "CQ_TRYBOTS=...", which CQ will then look at to determine which trybots to run the the given CL. The CL for the change for CQ is at "https://chromereviews.googleplex.com/51757013/". R=dpranke@google.com, iannucci@google.com BUG=378097 Review URL: https://codereview.chromium.org/348473003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@280039 0039d316-1c4b-4281-b951-d872f2087c98
-
- 11 Jun, 2014 1 commit
-
-
sheyang@chromium.org authored
BUG=374398 Review URL: https://codereview.chromium.org/298703003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@276491 0039d316-1c4b-4281-b951-d872f2087c98
-
- 16 May, 2014 1 commit
-
-
bauerb@chromium.org authored
BUG=374121 Review URL: https://codereview.chromium.org/284113005 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@270972 0039d316-1c4b-4281-b951-d872f2087c98
-
- 15 May, 2014 1 commit
-
-
https://codereview.chromium.org/271703010/sheyang@chromium.org authored
Reason for revert: CQ rejects all chromium projects because of this change. Original issue's description: > use canonical base URL for projects > > BUG=372645 > R=iannucci@chromium.org, sergeyberezin@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270460 TBR=iannucci@chromium.org,sergeyberezin@chromium.org NOTREECHECKS=true NOTRY=true BUG=372645 Review URL: https://codereview.chromium.org/287063002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@270803 0039d316-1c4b-4281-b951-d872f2087c98
-
- 14 May, 2014 1 commit
-
-
sheyang@google.com authored
BUG=372645 R=iannucci@chromium.org, sergeyberezin@chromium.org Review URL: https://codereview.chromium.org/271703010 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@270460 0039d316-1c4b-4281-b951-d872f2087c98
-
- 01 May, 2014 1 commit
-
-
bauerb@chromium.org authored
BUG=none Review URL: https://codereview.chromium.org/259523006 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@267480 0039d316-1c4b-4281-b951-d872f2087c98
-
- 11 Apr, 2014 1 commit
-
-
iannucci@chromium.org authored
R=agable@chromium.org, szager@chromium.org BUG=338102 Review URL: https://codereview.chromium.org/224863006 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@263202 0039d316-1c4b-4281-b951-d872f2087c98
-
- 04 Apr, 2014 1 commit
-
-
iannucci@chromium.org authored
upstreams. In the event that users are NOT using the enhanced tooling, this is equivalent to `git merge-base "@{u}" HEAD`. In the event that they are, this will catch the case where their parent branch got rebased, but this branch hasn't been rebased on the parent yet. R=agable@chromium.org, szager@chromium.org BUG= Review URL: https://codereview.chromium.org/224703002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@261601 0039d316-1c4b-4281-b951-d872f2087c98
-
- 11 Mar, 2014 1 commit
-
-
thestig@chromium.org authored
Review URL: https://codereview.chromium.org/134223010 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@256289 0039d316-1c4b-4281-b951-d872f2087c98
-
- 11 Feb, 2014 2 commits
-
-
thestig@chromium.org authored
Relative root no longer makes sense after an os.chdir(). This is effectively a partial revert of r250248. Review URL: https://codereview.chromium.org/135213006 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@250478 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
Additionally: - replace some RunCommand(['git', ...]) calls with RunGit(). - replace Settings._GetConfig('rietveld.foo') _GetRietveldConfig('foo'). - merge and cache calls to git rev-parse --show-cdup. - merge some calls to git merge-base. Review URL: https://codereview.chromium.org/157913005 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@250248 0039d316-1c4b-4281-b951-d872f2087c98
-
- 14 Jan, 2014 2 commits
-
-
rmistry@google.com authored
This change will allow projects other than chromium to specify 'BUG_PREFIX: project_name:' in their codereview.settings file. Currently, the change is created with 'BUG=', entering a project's bug number there will point it to chromium's issue tracker. Adding a project specific prefix will make the links point to the project's issue tracker without the developer having to know about the magic prefix. BUG=skia:1983 Review URL: https://codereview.chromium.org/132233006 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@244801 0039d316-1c4b-4281-b951-d872f2087c98
-
jochen@chromium.org authored
BUG=none R=iannucci@chromium.org,maruel@chromium.org Review URL: https://codereview.chromium.org/130803004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@244793 0039d316-1c4b-4281-b951-d872f2087c98
-
- 03 Jan, 2014 1 commit
-
-
pgervais@chromium.org authored
These options have been added to the 'git cl config' subcommand. --deactivate-update tells git cl not to update the values inside .git/config from the codereview.settings file. --activate-update does the opposite. This is designed for testing/development purposes only, for example, to be able to change the rietveld URL. BUG=327901 Review URL: https://codereview.chromium.org/104043008 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@242943 0039d316-1c4b-4281-b951-d872f2087c98
-
- 28 Nov, 2013 1 commit
-
-
ukai@chromium.org authored
BUG=maruel@chromium.org,szager@chromium.org Review URL: https://codereview.chromium.org/90763004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@237657 0039d316-1c4b-4281-b951-d872f2087c98
-