1. 23 Jan, 2020 2 commits
  2. 22 Jan, 2020 2 commits
  3. 21 Jan, 2020 2 commits
  4. 17 Jan, 2020 3 commits
  5. 16 Jan, 2020 1 commit
  6. 15 Jan, 2020 1 commit
    • Raul Tambre's avatar
      subprocess2: Ensure environment keys and values are strings on Python 3 · e9730d75
      Raul Tambre authored
      Example error during "git cl upload":
      Traceback (most recent call last):
        File "C:\Google\depot_tools\presubmit_support.py", line 220, in CallCommand
          returncode, stdout = self._RunWithTimeout(cmd, test.stdin, test.kwargs)
        File "C:\Google\depot_tools\presubmit_support.py", line 204, in _RunWithTimeout
          p = subprocess.Popen(cmd, **kwargs)
        File "C:\Google\depot_tools\subprocess2.py", line 143, in __init__
          super(Popen, self).__init__(args, **kwargs)
        File "C:\Google\depot_tools\bootstrap-3_8_0b1_chromium_1_bin\python\bin\Lib\subprocess.py", line 390, in __init__
          errread, errwrite)
        File "C:\Google\depot_tools\bootstrap-3_8_0b1_chromium_1_bin\python\bin\Lib\subprocess.py", line 640, in _execute_child
          startupinfo)
      TypeError: environment can only contain strings
      
      Bug: 984182
      Change-Id: Id996d73a80845aaeaa061107ed123627091cb600
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1815872
      Commit-Queue: Raul Tambre <raul@tambre.ee>
      Reviewed-by: 's avatarEdward Lesmes <ehmaldonado@chromium.org>
      Auto-Submit: Raul Tambre <raul@tambre.ee>
      e9730d75
  7. 14 Jan, 2020 4 commits
  8. 13 Jan, 2020 4 commits
  9. 11 Jan, 2020 1 commit
  10. 10 Jan, 2020 6 commits
  11. 09 Jan, 2020 4 commits
  12. 08 Jan, 2020 4 commits
  13. 07 Jan, 2020 6 commits