- 27 Jan, 2021 3 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/4e80714e17ff99f6d750d54b69cf9cebd7a2f835 4e80714 (gbeaty@chromium.org) Return None from CommitList.advance_to for backwards advances. More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: If35f2ee09a01b6dd859a6eacb8e9f37483594872 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2654083Reviewed-by:
Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/1cf8c5966f860b5e3cc4d5ed8ec0622b0a660fd3 1cf8c59 (vadimsh@chromium.org) [proto] Update go.chromium.org/luci protos. More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I5f27fc78df5b07b43b877ad11274f74b791d8fdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2651464Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/da848b8552a021206e2acd957f9a4520292a7949 da848b8 (lamontjones@chromium.org) [buildbucket] include ref in try_build_message More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I7bb907c81a55ffcb43b51f1de77460e19e727e29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2651456Reviewed-by:
-
- 26 Jan, 2021 6 commits
-
-
Stephanie Kim authored
As chrome browser infra works to improve CQ times, we would like to easily glance at builds and see how many new commits were checked out. Currently you have to open up bot_update stdout to see the previous HEAD revision and go from there. Having this conveniently outputted would be very convenient. If the bot has previously checked out the repo, output which revision and commit position were checked out. example LED build showing new output: https://ci.chromium.org/swarming/task/51592e46d6a70e10?server=chromium-swarm.appspot.com Change-Id: Ib8a6f152a593446ce4082477bc9ada44f1fd1fc3 Bug: 1170568 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2644829Reviewed-by:
Josip Sokcevic <sokcevic@google.com> Commit-Queue: Stephanie Kim <kimstephanie@google.com>
-
Josip Sokcevic authored
If bot_update is not patching, it shouldn't look into gitiles patch information. R=ehmaldonado@google.com Bug: 1147625 Recipe-Nontrivial-Roll: build Change-Id: I111f0dc1c36d588341c02930bf1cda1f5b8cc2e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2644199Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Josip Sokcevic <sokcevic@google.com>
-
Edward Lesmes authored
Bug: b/178502800 Bug: 1170806 Change-Id: If66cf06b9954520ddd909dce869e2a15da3055ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2650965 Commit-Queue: Josip Sokcevic <sokcevic@google.com> Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/21a0be68ef57127c04b91aa66b4d6f46aadd096d 21a0be6 (iannucci@chromium.org) [buildbucket] Remove validation of output commit id in test mode. More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I527dea0540fffafb517635d532aeace372594654 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2650776Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/90828211cac09bce63ebfc5b8b85ecca1d13afd9 9082821 (adrexler@google.com) Update go.chromium.org/luci/ protos. More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I73c4ecd5e9bdfe046fc67c16cbfeed81b83528c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2650353Reviewed-by:
-
Ola Rozenfeld authored
Bug: 1149386 Change-Id: I7b04450b4da84ca0a1f599a7fe1bfe27d1dd648f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2639604 Commit-Queue: Ola Rozenfeld <olaola@google.com> Reviewed-by:
Dirk Pranke <dpranke@google.com>
-
- 25 Jan, 2021 5 commits
-
-
Edward Lesmes authored
This is a reland of 0489cc12 Don't remove email_regexp argument, as downstream still passes it. Original change's description: > Reland "presubmit: Use new API to check for owners approval" > > New API was updated to properly support '*' as owner. > > Change-Id: If14144f83484731fd5534c03cb9fde4b18f49fe9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2628703 > Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> > Reviewed-by: Josip Sokcevic <sokcevic@google.com> > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Change-Id: Id137aca0036c2ebf11ec56a12f4e053cd2cc6637 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2639411 Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Gavin Mak <gavinmak@google.com> Reviewed-by:
Gavin Mak <gavinmak@google.com>
-
Gavin Mak authored
This change also adds a ScoreOwners function in owners_client that replaces user scoring functionality in owners_finder. Change-Id: Ifd8841c6d320d9bb644907b6eca0a02d4ef35640 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2641532Reviewed-by:
-
Gavin Mak authored
When using git cl upload --message-file, the text editor prompts the user to edit the description. This change suppresses the editor when a message file is passed in. Change-Id: Ifa568e155e72eeb49f55ded0ddac1b5a940687af Bug:916230 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2643781Reviewed-by:
-
Yoshisato Yanagisawa authored
This reverts commit 6c939860. Reason for revert: I started to see Exceptions after the rollout. Let me speculatively revert. Original change's description: > Roll out new goma client binary VERSION=211 > > Bug: b/177285551 > Change-Id: I59ca57d05555a2fe922d3056e6d52842b4bb66ac > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2646141 > Reviewed-by: Takuto Ikuta <tikuta@chromium.org> > Reviewed-by: Fumitoshi Ukai <ukai@google.com> > Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> TBR=ukai@google.com,yyanagisawa@chromium.org,tikuta@chromium.org,yekuang@google.com,infra-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I94b829d33f7f0bc897cdf661e892ff1264e773e1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b/177285551 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2646767Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@chromium.org> Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
-
Yoshisato Yanagisawa authored
Bug: b/177285551 Change-Id: I59ca57d05555a2fe922d3056e6d52842b4bb66ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2646141Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Fumitoshi Ukai <ukai@google.com> Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
-
- 22 Jan, 2021 3 commits
-
-
Edward Lesmes authored
Will use this change to test reverting in the Gerrit UI. Using TBR= so as to not spam anyone else. TBR= Change-Id: If95898b00d6468512157d120e24c8246c1655f8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2645231 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
-
Edward Lesmes authored
Change-Id: I70fad9c369e36d7dcbf3cb8a4eb2c8ee66ceb7b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2642771 Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Josip Sokcevic <sokcevic@google.com> Reviewed-by:
-
Josip Sokcevic authored
This reverts commit e7a31f42. Reason for revert: has typo and doesn't work if typo is fixed Original change's description: > Support main branch in bot_update > > Change-Id: I58e88e9505779c309ac0af9d5b78b45feaa75543 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2528669 > Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> > Commit-Queue: Josip Sokcevic <sokcevic@google.com> TBR=ehmaldonado@chromium.org,infra-scoped@luci-project-accounts.iam.gserviceaccount.com,sokcevic@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Ib6b266250b854e2554249b956766214be84ec522 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2643961Reviewed-by:
-
- 21 Jan, 2021 4 commits
-
-
Chan Li authored
To deploy change https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/2639156 Bug: 1103287 Change-Id: Idf7fe6f7c355321aaa72afbd96c710d33c7af5d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2642768Reviewed-by:
Scott Lee <ddoman@chromium.org> Commit-Queue: Chan Li <chanli@chromium.org>
-
Vadim Shtayura authored
Changes: [lucicfg] Add `extends` to luci.bucket(...). [resultdb] Add history options to starlark files. [lucicfg] Fix issues related to Go deps roll. Remove experiment gating luci.tree_closer. [Lucicfg] change repository_whitelist to repository_allowlist R=iannucci@chromium.org, tandrii@chromium.org CC=robertocn@chromium.org Change-Id: Ife18f8469a6083a476fae817a0163f7f9e6a1448 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2642769Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/34f43c51585b6113740640659cca0ddd27289684 34f43c5 (bryner@google.com) Fix JSON serialization of PackageDef preserve_mtime/preserve_wr... More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I4c58ee1065e40a447c428bb5ac2e3a239361e3d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2641533Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/5edec0a657694629de0b9037326ef9daaebb8bf2 5edec0a (yiwzhang@google.com) [luciexe] Normalize each segment instead of the entire stream name More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I53524d132ae5871a94ecbe50ec4e3e9f1cefe7d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2641048Reviewed-by:
-
- 20 Jan, 2021 4 commits
-
-
Takuto Ikuta authored
python3 is currently not recognized on git bash. https://crrev.com/c/2629087/15#message-b5093e69201df42adb7ac643e4f97f9f366a299d This is partial revert of https://crrev.com/c/2629087 https://crrev.com/c/2631396 Bug: b/177465438 Change-Id: I1b2698f5fc27144035598249c43800d25801a0f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2638834Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
-
Edward Lesmes authored
This reverts commit 0489cc12. Reason for revert: Chromium presubmit needs to be updated too Original change's description: > Reland "presubmit: Use new API to check for owners approval" > > New API was updated to properly support '*' as owner. > > Change-Id: If14144f83484731fd5534c03cb9fde4b18f49fe9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2628703 > Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> > Reviewed-by: Josip Sokcevic <sokcevic@google.com> > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> TBR=ehmaldonado@chromium.org,gavinmak@google.com,infra-scoped@luci-project-accounts.iam.gserviceaccount.com,sokcevic@google.com Change-Id: Id6f55a8fbc692ad1a82154a6646d487bb37cbe63 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2637539Reviewed-by:
-
Michael Savigny authored
Adds reproxy setup and teardown to autoninja. Since reproxy is intended to run for a single build (unlike the goma proxy), having setup and teardown happen as part of autoninja makes management of the proxy execution easier. To use this as it is currently implemented, set the RBE_BIN_DIR and RBE_CFG_DIR environment variables to point to the reclient binaries and reclient configuration files. Note the reproxy.cfg file is NOT included in this change, and at the time of this CL you need to provide one yourself. Bug: 1149386 Change-Id: I23601cc9b13193ac617ffc5963b9d443f6840d33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2597837Reviewed-by:
Ye Kuang <yekuang@google.com> Commit-Queue: Michael Savigny <msavigny@google.com> Auto-Submit: Michael Savigny <msavigny@google.com>
-
Edward Lesmes authored
This is a reland of 968b1fe7 Original change's description: > [git-cl] Use owners client when processing --[tb]r-owners. > > Change-Id: Id094bce2aa731359cd8af16f10ce79ae7e02bd85 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2572809 > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> > Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> > Reviewed-by: Josip Sokcevic <sokcevic@google.com> Change-Id: I9f93d755b10517c5296f7095f735ec2295be34e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2632840 Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Josip Sokcevic <sokcevic@google.com> Reviewed-by:
-
- 19 Jan, 2021 5 commits
-
-
Edward Lesmes authored
This feature will not be supported when using Gerrit Code-Owners plugin. Change-Id: I7ad0d5bf004ba39818e57fc00e40592a44d1d11f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2638140 Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Gavin Mak <gavinmak@google.com> Reviewed-by:
-
Edward Lesmes authored
New API was updated to properly support '*' as owner. Change-Id: If14144f83484731fd5534c03cb9fde4b18f49fe9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2628703 Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
-
Andrii Shyshkalov authored
<ExceptionObj>.message worked in py2, but not in py3. R=ehmaldonado@google.com Change-Id: I1f1302d453e9142b59de4ccab0298367bffde295 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2631495 Auto-Submit: Andrii Shyshkalov <tandrii@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
-
Takuto Ikuta authored
This removes dependency to httplib2 by using urllib. https://docs.python.org/3/library/http.client.html#httpresponse-objects Use six for both py2/py3 unittest. Bug: b/177465438 Change-Id: I48383559842615f97abea45b55ca0acf4d7c8bd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2629087 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@google.com> Reviewed-by:
-
Takuto Ikuta authored
This is for comments in https://crrev.com/c/2629087/11/autoninja and https://crrev.com/c/2629087/11/autoninja.bat Change-Id: I2edafaee7916b7c826af7a7f8f0150a541c8d098 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2631396Reviewed-by:
-
- 15 Jan, 2021 4 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/2030661a4ff2a6b64b0651f2c44aabed8c71223f 2030661 (yuanzhi@google.com) [resultdb] Add option to include new invocation using rdb. More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: If1e8fed40c1fe3e464a382cf594dddfb3e0af76b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2632976Reviewed-by:
-
Edward Lesmes authored
Bug: 1166467 Change-Id: Ib6c32b11ca2892841cad477cee61edef38a0ed62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2628702 Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Gavin Mak <gavinmak@google.com> Reviewed-by:
-
Yoshisato Yanagisawa authored
This reverts commit b7ddc5a0. Reason for revert: This broke the builder where depot_tools is not in PATH. https://logs.chromium.org/logs/infra-internal/buildbucket/cr-buildbucket.appspot.com/8858077852309878080/+/u/build/stdout Original change's description: > Check whether goma is running when it is enabled > > One of the mistakes one can make when running ninja is having goma > enabled (use_goma=true in args.gn) but not having goma running. This can > lead to ~1,000 failed compile steps, which is messy. > > This change teaches autoninja.py to check whether goma is running. If > not then it tells autoninja to just print a warning message. The > check costs roughly 30 ms which seems reasonable. > > In fact, because this change also switches away from vpython (necessary > to use python3 to use subprocess.run) it actually runs about 600 ms > _faster_ than before this change. > > If build acceleration is requested through use_rbe then no checking for > whether the service is running is done. That could be added in the > future. > > autoninja.py could auto-start goma but that is error prone and has > limited additional value. > > This was tested on Linux, OSX, and Windows. > > Bug: 868590, b/174673874 > Change-Id: Ie773e574878471e5136b9b82d52f86af3d848318 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2627014 > Commit-Queue: Bruce Dawson <brucedawson@chromium.org> > Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@google.com> TBR=yyanagisawa@google.com,dpranke@google.com,brucedawson@chromium.org,sanfin@chromium.org,infra-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I57a6c73ea853259f3d1ec7ad0ce51e495acc96db No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 868590 Bug: b/174673874 Bug: 1167064 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2632018Reviewed-by:
-
Yoshisato Yanagisawa authored
This reverts commit 2241db8a. Reason for revert: Cannot merge https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2632018 due to conflict. Original change's description: > Avoid capture_output to support Python 3.6 > > autoninja.py uses subprocess.run which requires Python 3 and used > capture_output which requires Python 3.6. One user reported this as an > issue and it turns out that it is easy to avoid by using subprocess.NULL > which then means that Python versions back to 3.3 are supported. > > Bug: 868590, b/174673874 > Change-Id: Ife5e186d9c54747d35ff989dc2afadba5b9a57f5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2630525 > Auto-Submit: Bruce Dawson <brucedawson@chromium.org> > Reviewed-by: Justin Cohen <justincohen@chromium.org> > Commit-Queue: Bruce Dawson <brucedawson@chromium.org> TBR=justincohen@chromium.org,brucedawson@chromium.org,infra-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I5131a43eeb9410a6b45920d409a392a2df9d9af0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 868590 Bug: b/174673874 Bug: 1167064 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2632022Reviewed-by:
-
- 14 Jan, 2021 6 commits
-
-
Josip Sokcevic authored
Currently, gclient sync assumes the default branch is master, and it doesn't work at all if such branch doesn't exist. This change queries local git copy to get remote HEAD. If local git version is not available, it queries remote git server using ls-remote. This change requires git version 2.28 (depot_tools comes with 2.29). R=ehmaldonado@chromium.org Bug: 1156318 Change-Id: Id348e0f1004093f395139e8f4d62adb66b94ca9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2628359 Commit-Queue: Josip Sokcevic <sokcevic@google.com> Reviewed-by:
-
Bruce Dawson authored
autoninja.py uses subprocess.run which requires Python 3 and used capture_output which requires Python 3.6. One user reported this as an issue and it turns out that it is easy to avoid by using subprocess.NULL which then means that Python versions back to 3.3 are supported. Bug: 868590, b/174673874 Change-Id: Ife5e186d9c54747d35ff989dc2afadba5b9a57f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2630525 Auto-Submit: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
-
Bruce Dawson authored
One of the mistakes one can make when running ninja is having goma enabled (use_goma=true in args.gn) but not having goma running. This can lead to ~1,000 failed compile steps, which is messy. This change teaches autoninja.py to check whether goma is running. If not then it tells autoninja to just print a warning message. The check costs roughly 30 ms which seems reasonable. In fact, because this change also switches away from vpython (necessary to use python3 to use subprocess.run) it actually runs about 600 ms _faster_ than before this change. If build acceleration is requested through use_rbe then no checking for whether the service is running is done. That could be added in the future. autoninja.py could auto-start goma but that is error prone and has limited additional value. This was tested on Linux, OSX, and Windows. Bug: 868590, b/174673874 Change-Id: Ie773e574878471e5136b9b82d52f86af3d848318 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2627014 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
-
Takuto Ikuta authored
I'll update to python3 separately. Bug: b/177465438 Change-Id: Id204789f2d0854a796e5408597700d90dc8cd191 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2626863Reviewed-by:
-
Ben Pastene authored
This reverts commit 64d94dea. Reason for revert: tentative revert for https://crbug.com/1166467 Original change's description: > presubmit: Use new API to check for owners approval > > It also allows us to improve unit tests. > > Change-Id: I356a2fddcbcc5af0e628f79ede1ba277008f5cde > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2612222 > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> > Reviewed-by: Josip Sokcevic <sokcevic@google.com> > Reviewed-by: Gavin Mak <gavinmak@google.com> > Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> TBR=ehmaldonado@chromium.org,gavinmak@google.com,infra-scoped@luci-project-accounts.iam.gserviceaccount.com,sokcevic@google.com Bug: 1166467 Change-Id: I1df97f8fdbc56942fdcc7bafffed517e24a9481d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2628574Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/3effff55e74af70a8eb875fedc28feb82e36a458 3effff5 (chanli@chromium.org) [resultdb] get invocation ids from invocation names More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I4e63f95aeef91180a5f571f6c47a3e713d3d540a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2628614Reviewed-by:
-
