- 07 Aug, 2015 1 commit
-
-
smut@google.com authored
BUG=493885 Review URL: https://codereview.chromium.org/1284453002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296246 0039d316-1c4b-4281-b951-d872f2087c98
-
- 06 Aug, 2015 1 commit
-
-
tandrii@chromium.org authored
Before this change, running $ git reparent-branch produced stacktrace and "TypeError: sequence item 4: expected string, NoneType found" R=iannucci@chromium.org TEST=manual + unittest + coverage. BUG= Review URL: https://codereview.chromium.org/1280633003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296235 0039d316-1c4b-4281-b951-d872f2087c98
-
- 04 Aug, 2015 1 commit
-
-
dpranke@chromium.org authored
R=agable@chromium.org BUG=481696 Review URL: https://codereview.chromium.org/1266713009 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296204 0039d316-1c4b-4281-b951-d872f2087c98
-
- 31 Jul, 2015 2 commits
-
-
dpranke@chromium.org authored
TBR=ianh@google.com Review URL: https://codereview.chromium.org/1263253002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296187 0039d316-1c4b-4281-b951-d872f2087c98
-
spang@chromium.org authored
The majority of chromium projects are on googlesource.com, which can display a range of commits on the web. Use this feature instead of dumping logs into the commit message. Particularly, this avoids creating large commit messages as these logs sometimes contain upwards of 50 commits. Review URL: https://codereview.chromium.org/1257233006 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296184 0039d316-1c4b-4281-b951-d872f2087c98
-
- 29 Jul, 2015 1 commit
-
-
hinoka@chromium.org authored
This does one last check to see if the file downloaded by download_from_google_storage.py actually matches its sha1 BUG= Review URL: https://codereview.chromium.org/1252313005 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296155 0039d316-1c4b-4281-b951-d872f2087c98
-
- 28 Jul, 2015 1 commit
-
-
iannucci@chromium.org authored
R=hinoka@chromium.org, maruel@chromium.org, stip@chromium.org BUG=513567,475230 Review URL: https://codereview.chromium.org/1260913002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296138 0039d316-1c4b-4281-b951-d872f2087c98
-
- 20 Jul, 2015 1 commit
-
-
sergiyb@chromium.org authored
Original CL: https://codereview.chromium.org/1242013003/ Executing a bat file from another bat file will replace that first bat file with the second one. To call the second one and then return and execute the rest of the first one, you have to do "call second.bat" "python" is really "python.bat" so that this happened was not obvious. More obvious now. R=bratell@opera.com TBR=pgervais@chromium.org BUG=511926 Review URL: https://codereview.chromium.org/1239263003 . git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296063 0039d316-1c4b-4281-b951-d872f2087c98
-
- 17 Jul, 2015 2 commits
-
-
hinoka@chromium.org authored
gclient should be checking out origin/deployed, not deployed. --revision deployed is local, origin/deployed actually causes it to fetch BUG= Review URL: https://codereview.chromium.org/1236133005 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296055 0039d316-1c4b-4281-b951-d872f2087c98
-
hinoka@chromium.org authored
Example usage: yo cq_stats --help BUG= R=stip@chromium.org Review URL: https://codereview.chromium.org/1232573007 . git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296053 0039d316-1c4b-4281-b951-d872f2087c98
-
- 16 Jul, 2015 1 commit
-
-
aiolos@chromium.org authored
Don't throw "line too long" presubmit error on python import statements or when pylint "line too long" is disabled. BUG= Review URL: https://codereview.chromium.org/1234333002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296035 0039d316-1c4b-4281-b951-d872f2087c98
-
- 15 Jul, 2015 2 commits
-
-
hinoka@chromium.org authored
BUG= TESTS= alpaca(gsutil_version) ~/depot_tools$ ./gsutil.py version gsutil version: 4.13 Review URL: https://codereview.chromium.org/1237013003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296023 0039d316-1c4b-4281-b951-d872f2087c98
-
rmistry@google.com authored
Revert of Comment out applying patchset dependencies in apply_issue.py (patchset #2 id:20001 of https://codereview.chromium.org/1194063003/) Reason for revert: https://chromereviews.googleplex.com/221697013/ has landed. Re-enable applying patchset dependencies in apply_issue.py Original issue's description: > Comment out applying patchset dependencies in apply_issue.py > > Context is in the internal chrome-infra thread here: > https://groups.google.com/a/google.com/d/msg/chrome-infra/dNQGjNoP-Dg/XDymPAwOCXkJ > > NOPRESUBMIT=true > > BUG=chromium:480453 > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295800 TBR=phajdan.jr@chromium.org BUG=chromium:480453 Review URL: https://codereview.chromium.org/1237703004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296016 0039d316-1c4b-4281-b951-d872f2087c98
-
- 13 Jul, 2015 1 commit
-
-
smut@google.com authored
A flag for showing the description instead of opening the editor to modify it. BUG=493885 Review URL: https://codereview.chromium.org/1237483003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296000 0039d316-1c4b-4281-b951-d872f2087c98
-
- 08 Jul, 2015 1 commit
-
-
rmistry@google.com authored
After this CL is in users will be able to skip dependency checks and uploads for specific branches locally by running (using test2 as a branch name): git config branch.test2.skip-deps-uploads True To undo the skipping: git config --unset branch.test2.skip-deps-uploads To do the above commands globally (across all checkouts): git config --global branch.test2.skip-deps-uploads True git config --global --unset branch.test2.skip-deps-uploads BUG=chromium:504832 Review URL: https://codereview.chromium.org/1210903005 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295953 0039d316-1c4b-4281-b951-d872f2087c98
-
- 07 Jul, 2015 1 commit
-
-
sergiyb@chromium.org authored
This is needed to ensure that it resolves to a correct URL on Gitiles. R=maruel@chromium.org, smut@google.com Review URL: https://codereview.chromium.org/1225713002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295932 0039d316-1c4b-4281-b951-d872f2087c98
-
- 02 Jul, 2015 1 commit
-
-
agable@chromium.org authored
This both ensures that 'git auto-svn' has been properly run, and also that the Blink checkout is appropriately 'unmanaged'. R=dpranke@chromium.org, mmoss@chromium.org BUG=289742 Review URL: https://codereview.chromium.org/1186053007 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295916 0039d316-1c4b-4281-b951-d872f2087c98
-
- 01 Jul, 2015 2 commits
-
-
iannucci@chromium.org authored
* make RunTest's multiprocessing.Pool in the constructor of InputApi to avoid getting tripped up by chdir manipulation. * Don't do the split cyclic-import check when the invoker of the Pylint presubmit checks explicitly sends cyclic import check parameters via extra_args * fix pseudobug where ownership of the files variable was unclear, and pass all arguments on stdin (instead of mix of CLI + stdin). * fix bug in pylint which caused it to manipulate sys.path before spawning its subprocesses, which caused multiprocessing to fail on windows. * Note: This may carry a slight semantic change. Before, pylint would add all .py files' directories to sys.path while checking any of them. Now in parallel mode, pylint will only add the path of the single file to sys.path. This behavior actually mirrors Python's own behavior, so the check should be more-correct than before (and should cut down on pylint import scanning time with very large sys.path's). * If someone encounters an issue with this, please note that the GetPylint check also includes an extra_paths_list which is expressly for this purpose. R=dpranke@chromium.org, kbr@chromium.org, maruel@chromium.org BUG=501012 Review URL: https://codereview.chromium.org/1208743002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295908 0039d316-1c4b-4281-b951-d872f2087c98
-
sergiyb@chromium.org authored
The activate_end method is used in infra/bootstrap/build_deps.py, which doesn't pass the value for this parameter. R=pgervais@chromium.org BUG=503067 Review URL: https://codereview.chromium.org/1213113002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295893 0039d316-1c4b-4281-b951-d872f2087c98
-
- 30 Jun, 2015 3 commits
-
-
boliu@chromium.org authored
Revert of Add support for tar.gz archive files to download from download_from_google_storage (patchset #8 id:140001 of https://codereview.chromium.org/807463005/) Reason for revert: This conflicts with (and duplicates?) the -z option below and has broken one of the chrome android downstream bots. Safer to revert than trying to fix Original issue's description: > Add support for tar.gz archive files to download from download_from_google_storage > > Also, add support for directly setting the public read flag on uploaded files. > > The support for tar.gz allows the uploaded bundle to be a single tar.gz file instead of a lot of individual files using the directory support already in. The benefit here is that it is much easier to update the dependency. Simply clean out the existing files, copy in the new ones, create a tar.gz file, with the same name as the directory + 'tar.gz'. If the directory name and file name does not match up we will not clean up existing artifacts on download (i.e., there can be left over files after extracting). > > I am doing this because I am moving a bunch of the dart dependencies to gcs, and a lot of our dependencies is much easier to manage with this in. If you don't like this, I can simply wrap the download script in another python script and do the logic there, but this may be handy for other people as well. > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295872 TBR=hinoka@google.com,hinoka@chromium.org,azarchs@chromium.org,ricow@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1209033006 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295883 0039d316-1c4b-4281-b951-d872f2087c98
-
akuegel@chromium.org authored
All CQ supported projects already have git mirrors. We don't want to support svn checkouts anymore. BUG=503847 Review URL: https://codereview.chromium.org/1213363002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295882 0039d316-1c4b-4281-b951-d872f2087c98
-
ricow@google.com authored
Also, add support for directly setting the public read flag on uploaded files. The support for tar.gz allows the uploaded bundle to be a single tar.gz file instead of a lot of individual files using the directory support already in. The benefit here is that it is much easier to update the dependency. Simply clean out the existing files, copy in the new ones, create a tar.gz file, with the same name as the directory + 'tar.gz'. If the directory name and file name does not match up we will not clean up existing artifacts on download (i.e., there can be left over files after extracting). I am doing this because I am moving a bunch of the dart dependencies to gcs, and a lot of our dependencies is much easier to manage with this in. If you don't like this, I can simply wrap the download script in another python script and do the logic there, but this may be handy for other people as well. Review URL: https://codereview.chromium.org/807463005 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295872 0039d316-1c4b-4281-b951-d872f2087c98
-
- 29 Jun, 2015 2 commits
-
-
pkasting@chromium.org authored
BUG=none TEST=update_depot_tools actually works in msysgit Review URL: https://codereview.chromium.org/1208053003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295866 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
See the bug for how these were built. The linux binaries were built by thestig@chromium.org. The windows binary was built by scottmg@chromium.org. The mac binary was built by thakis@chromium.org BUG=505508 TBR=maruel@chromium.org Review URL: https://codereview.chromium.org/1221683003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295863 0039d316-1c4b-4281-b951-d872f2087c98
-
- 26 Jun, 2015 1 commit
-
-
sergiyb@chromium.org authored
R=pgervais@chromium.org Review URL: https://codereview.chromium.org/1211843003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295850 0039d316-1c4b-4281-b951-d872f2087c98
-
- 25 Jun, 2015 3 commits
-
-
sergiyb@chromium.org authored
R=pgervais@chromium.org BUG=503067 Review URL: https://codereview.chromium.org/1195423002. git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295843 0039d316-1c4b-4281-b951-d872f2087c98
-
sergiyb@chromium.org authored
Original CL: https://chromiumcodereview.appspot.com/1200843003/ R=pgervais@chromium.org BUG=503067 TEST=tested on Mac, Windows and Linux bots Review URL: https://codereview.chromium.org/1205873002. git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295842 0039d316-1c4b-4281-b951-d872f2087c98
-
rmistry@google.com authored
In https://codereview.chromium.org/1149653002/ we had decided to mark closed CLs are dependencies as well, but I forgot to update the printed out message. BUG=502255 Review URL: https://codereview.chromium.org/1204963005 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295831 0039d316-1c4b-4281-b951-d872f2087c98
-
- 24 Jun, 2015 4 commits
-
-
sergiyb@chromium.org authored
R=akuegel@chromium.org, pgervais@chromium.org BUG=472612, 503068 Review URL: https://codereview.chromium.org/1200863002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295818 0039d316-1c4b-4281-b951-d872f2087c98
-
raphael.kubo.da.costa@intel.com authored
It is not clear why it was skipped in r293502, but it was problematic before that as it can be seen from CL 802403003. The reason for the different results (and likely the reason why the test was skipped) is that the handling of the %(upstream:track) and %(upstream:trackhort) formatting tags was broken in git itself until version 2.3.0. This was fixed in git commit b6160d95, and the fix shows that the test expectations in testGetBranchesInfo() were actually wrong in one of the cases. Fix the expectations and make sure we only use %(upstream:track) in the test when a suitable git version is present. R=pgervais@chromium.org,iannucci@chromium.org Review URL: https://codereview.chromium.org/1195933003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295814 0039d316-1c4b-4281-b951-d872f2087c98
-
akuegel@chromium.org authored
Revert of Added virtualenv for depot_tools (patchset #10 id:180001 of https://chromiumcodereview.appspot.com/1200843003/) Reason for revert: Doesn't work, virtualenv is missing in depot_tools checkout. Original issue's description: > Added virtualenv for depot_tools > > R=pgervais@chromium.org > BUG=503067 > TEST=tested on Mac, Windows and Linux bots > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=295811 TBR=pgervais@chromium.org,sergiyb@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=503067 Review URL: https://codereview.chromium.org/1202843005. git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295813 0039d316-1c4b-4281-b951-d872f2087c98
-
sergiyb@chromium.org authored
R=pgervais@chromium.org BUG=503067 TEST=tested on Mac, Windows and Linux bots Review URL: https://codereview.chromium.org/1200843003. git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295811 0039d316-1c4b-4281-b951-d872f2087c98
-
- 23 Jun, 2015 5 commits
-
-
thakis@chromium.org authored
It still early-exits on non-Windows, so no visible change yet. BUG=495204 Review URL: https://codereview.chromium.org/1181943003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295807 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
Hashes for both the 2013 and 2015 toolchain don't change for me locally with this change, looks like there are no hidden or system files in the toolchain. (I tried with the "you are a googler" flow.) No intended behavior change. BUG=495204 Review URL: https://codereview.chromium.org/1200113004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295804 0039d316-1c4b-4281-b951-d872f2087c98
-
rmistry@google.com authored
Context is in the internal chrome-infra thread here: https://groups.google.com/a/google.com/d/msg/chrome-infra/dNQGjNoP-Dg/XDymPAwOCXkJ NOPRESUBMIT=true BUG=chromium:480453 Review URL: https://codereview.chromium.org/1194063003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295800 0039d316-1c4b-4281-b951-d872f2087c98
-
rmistry@google.com authored
Here is an explanation of the changes in each module: * git_cl.py - IF a local branch is being tracked AND a CL has been uploaded there THEN use the CL's issue number and latest patchset as a dependency. * upload.py - Uploads the patchset dependency, if it exists, to Rietveld (Rietveld will be able to parse this when https://codereview.chromium.org/1155513002/ lands). * rietveld.py - Adds utility methods to get patchset dependencies from the new Rietveld endpoint (the endpoint will exist when https://codereview.chromium.org/1155513002/ lands). * apply_issue.py - If CL3 depends on CL2 which in turn depends on CL1 then apply_issue will gather a list of all issues and patchsets to apply (Eg: [CL1:PS1, CL2:PS1, CL3:PS2]). apply_issue will then loop over the list applying each dependency. Note: The apply_issue.py diff looks much worse than it is. Please see my comment in https://codereview.chromium.org/1149653002/diff/260001/apply_issue.py#oldcode169 Tested end-to-end using a test Git repository (https://skia.googlesource.com/skiabot-test/) and the following CLs created in my test Rietveld instance: * https://skia-codereview-staging.appspot.com/931002 ('Branch1 CL') * https://skia-codereview-staging.appspot.com/5001001 ('Branch2 CL') * https://skia-codereview-staging.appspot.com/9881001 ('Branch3 CL') * https://skia-codereview-staging.appspot.com/3951001 ('Branch3.1 CL') Opt into the new UI and observe the new 'Depends on Patchset' and 'Dependent Patchsets' sections in the above CLs. Design doc is here: https://docs.google.com/document/d/1KZGFKZpOPvco81sYVRCzwlnjGctup71RAzY0MSb0ntc/edit#heading=h.6r6lt4tsvssw BUG=502255 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295778 Review URL: https://codereview.chromium.org/1149653002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295799 0039d316-1c4b-4281-b951-d872f2087c98
-
iannucci@chromium.org authored
R=thakis@chromium.org BUG=503462 Review URL: https://codereview.chromium.org/1193333012 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295795 0039d316-1c4b-4281-b951-d872f2087c98
-
- 22 Jun, 2015 3 commits
-
-
smut@google.com authored
This flag allows the user to specify a file which contains a JSON list of dicts to set for the "changes" property when scheduling the build. BUG=493885 Review URL: https://codereview.chromium.org/1199963004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295788 0039d316-1c4b-4281-b951-d872f2087c98
-
rmistry@google.com authored
Revert of [depot_tools] Find, upload and apply patchset dependencies (patchset #17 id:360001 of https://codereview.chromium.org/1149653002/) Reason for revert: Ran into a crash during the bot_update step here: https://uberchromegw.corp.google.com/i/internal.infra.try/builders/infra-internal-presubmit/builds/62 Original issue's description: > Find, upload and apply patchset dependencies. > > Here is an explanation of the changes in each module: > > * git_cl.py - > IF a local branch is being tracked AND a CL has been uploaded there THEN use the CL's issue number and latest patchset as a dependency. > > * upload.py - > Uploads the patchset dependency, if it exists, to Rietveld (Rietveld will be able to parse this when https://codereview.chromium.org/1155513002/ lands). > > * rietveld.py - > Adds utility methods to get patchset dependencies from the new Rietveld endpoint (the endpoint will exist when https://codereview.chromium.org/1155513002/ lands). > > * apply_issue.py - > If CL3 depends on CL2 which in turn depends on CL1 then apply_issue will gather a list of all issues and patchsets to apply (Eg: [CL1:PS1, CL2:PS1, CL3:PS2]). > apply_issue will then loop over the list applying each dependency. > Note: The apply_issue.py diff looks much worse than it is. Please see my comment in > https://codereview.chromium.org/1149653002/diff/260001/apply_issue.py#oldcode169 > > > Tested end-to-end using a test Git repository (https://skia.googlesource.com/skiabot-test/) and the following CLs created in my test Rietveld instance: > * https://skia-codereview-staging.appspot.com/931002 ('Branch1 CL') > * https://skia-codereview-staging.appspot.com/5001001 ('Branch2 CL') > * https://skia-codereview-staging.appspot.com/9881001 ('Branch3 CL') > * https://skia-codereview-staging.appspot.com/3951001 ('Branch3.1 CL') > Opt into the new UI and observe the new 'Depends on Patchset' and 'Dependent Patchsets' sections in the above CLs. > > > Design doc is here: https://docs.google.com/document/d/1KZGFKZpOPvco81sYVRCzwlnjGctup71RAzY0MSb0ntc/edit#heading=h.6r6lt4tsvssw > > BUG=502255 > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295778 TBR=agable@chromium.org,jrobbins@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=502255 Review URL: https://codereview.chromium.org/1200773003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295782 0039d316-1c4b-4281-b951-d872f2087c98
-
rmistry@google.com authored
Motivation: The conversation in https://docs.google.com/document/d/1KZGFKZpOPvco81sYVRCzwlnjGctup71RAzY0MSb0ntc/edit?disco=AAAAAXU60E8 BUG=502257 Review URL: https://codereview.chromium.org/1191473002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295779 0039d316-1c4b-4281-b951-d872f2087c98
-