- 23 May, 2017 1 commit
-
-
Paweł Hajdan, Jr authored
This feature appears unused, and removing it will simplify the codebase. Bug: 661382 Change-Id: I545befb2c592eea53c54552018ce2d3dda7670f5 Reviewed-on: https://chromium-review.googlesource.com/509693 Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org>
-
- 18 May, 2017 1 commit
-
-
Paweł Hajdan, Jr authored
This is based on https://codereview.chromium.org/2474543002/ Bug: 661382 Change-Id: I191ec16e0ce69a782979ae7d59b108747429ab78 Reviewed-on: https://chromium-review.googlesource.com/505067 Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
Michael Moss <mmoss@chromium.org>
-
- 18 Apr, 2017 3 commits
-
-
Aaron Gable authored
Gerrit sometimes returns a full response json object at the same time as returning a non-200 status code. This refactor makes it easier for calling code to request access to that object and handle error cases on its own. The original version of this commit had a bug where ReadHttpResponse properly set the default value for accept_statuses, but all calls which came through ReadHttpJsonResponse were setting None instead. Bug: 710028 Change-Id: I8cee435d8acd487fb777b3fd69b5e48e19d2e5a3 Reviewed-on: https://chromium-review.googlesource.com/481060Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org>
-
Aaron Gable authored
This reverts commit 6d7ab1bf. Reason for revert: Stacktrace: File "/s/depot_tools/gerrit_util.py", line 816, in GetAccountDetails return ReadHttpJsonResponse(conn) File "/s/depot_tools/gerrit_util.py", line 376, in ReadHttpJsonResponse fh = ReadHttpResponse(conn, accept_statuses) File "/s/depot_tools/gerrit_util.py", line 365, in ReadHttpResponse if response.status not in accept_statuses: TypeError: argument of type 'NoneType' is not iterable Original change's description: > Refactor ReadHttpResponse to be error-friendlier > > Gerrit sometimes returns a full response json object at > the same time as returning a non-200 status code. This > refactor makes it easier for calling code to request > access to that object and handle error cases on its own. > > Bug: 710028 > Change-Id: Id1017d580d2fb843d5ca6287efcfed8775c52cd6 > Reviewed-on: https://chromium-review.googlesource.com/479450 > Commit-Queue: Aaron Gable <agable@chromium.org> > Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> > TBR=agable@chromium.org,tandrii@chromium.org,chromium-reviews@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: Ia9d9ce835e207a32e7cc8ee35c0cf40c823c7b78 Reviewed-on: https://chromium-review.googlesource.com/481059Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org>
-
Aaron Gable authored
Gerrit sometimes returns a full response json object at the same time as returning a non-200 status code. This refactor makes it easier for calling code to request access to that object and handle error cases on its own. Bug: 710028 Change-Id: Id1017d580d2fb843d5ca6287efcfed8775c52cd6 Reviewed-on: https://chromium-review.googlesource.com/479450 Commit-Queue: Aaron Gable <agable@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org>
-
- 16 Dec, 2016 1 commit
-
-
Quinten Yearsley authored
This affects a bunch of files, but only changes comments, and shouldn't make any difference to behavior. The purpose is to slightly improve readability of pylint disable comments. Change-Id: Ic6cd0f8de792b31d91c6125f6da2616450b30f11 Reviewed-on: https://chromium-review.googlesource.com/420412Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
-
- 04 Nov, 2016 1 commit
-
-
iannucci authored
R=dnj@chromium.org, martiniss@chromium.org BUG=662277 Review-Url: https://codereview.chromium.org/2471133006
-
- 16 Aug, 2016 2 commits
-
-
tobiasjs authored
This allows users to specify additional local presubmit tests that do not need to exist as locally maintained changes to PRESUBMIT.py files. BUG= Review-Url: https://codereview.chromium.org/2232203002
-
iannucci authored
Unfortunately there's a bunch of other broken stuff, but it's something :/ R=agable@chromium.org, thakis@chromium.org BUG=607344 Review-Url: https://codereview.chromium.org/2244023003
-
- 14 Jul, 2016 1 commit
-
-
mbjorge authored
If an OWNERS file used the file: directive with a relative file path, but was using a root other than '/' (e.g. '/path/to/my/real/root'), then the include resolver would incorrectly leave a leading '/' on the include path. When os_path.join was then called, the leading '/' meant the path was treated as an absolute path and the join did not behave as expected. Review-Url: https://codereview.chromium.org/2148683003
-
- 17 Jun, 2016 1 commit
-
-
mgiuca authored
Review-Url: https://codereview.chromium.org/2075923003
-
- 16 Jun, 2016 1 commit
-
-
vapier authored
Review-Url: https://codereview.chromium.org/2076613002
-
- 09 May, 2016 1 commit
-
-
iannucci@chromium.org authored
This was breaking presubmit because the linked gae_ts_mon subdir was absent. R=andybons@chromium.org, dsansome@chromium.org, dnj@chromium.org BUG=608490 Review-Url: https://codereview.chromium.org/1959193002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300511 0039d316-1c4b-4281-b951-d872f2087c98
-
- 21 Mar, 2016 1 commit
-
-
tandrii@chromium.org authored
R=szager@chromium.org,sergiyb@chromium.org BUG=579160 Review URL: https://codereview.chromium.org/1820923002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299408 0039d316-1c4b-4281-b951-d872f2087c98
-
- 28 Jan, 2016 1 commit
-
-
mgiuca@chromium.org authored
This fixes the test being dependent on the system time, and undefined behaviour resulting from negative timestamps in positive-offset timezones. BUG=581895 Review URL: https://codereview.chromium.org/1640973002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298438 0039d316-1c4b-4281-b951-d872f2087c98
-
- 05 Jun, 2015 1 commit
-
-
akuegel@chromium.org authored
After changing this to '%f%' instead of just '%' this doesn't work anymore. It should be '%f%%' instead. BUG= TBR=iannucci@chromium.org Review URL: https://codereview.chromium.org/1156023008 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295539 0039d316-1c4b-4281-b951-d872f2087c98
-
- 01 Jun, 2015 1 commit
-
-
akuegel@chromium.org authored
This is needed to run the presubmit commit checks. Tested this CL by running git cl presubmit locally. BUG=420910 Review URL: https://codereview.chromium.org/1156923006 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295472 0039d316-1c4b-4281-b951-d872f2087c98
-
- 26 May, 2015 1 commit
-
-
maruel@chromium.org authored
Subversion usage is going away, tests get the kick first. R=iannucci@chromium.org BUG=475320 Review URL: https://codereview.chromium.org/1158043003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295411 0039d316-1c4b-4281-b951-d872f2087c98
-
- 22 May, 2015 1 commit
-
-
akuegel@chromium.org authored
BUG=487172 Review URL: https://codereview.chromium.org/1150663002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295375 0039d316-1c4b-4281-b951-d872f2087c98
-
- 30 Apr, 2015 1 commit
-
-
estaab@chromium.org authored
Change depot_tools presubmit to use infra rietveld from head. Also disable newly added backends by specifying app.yaml explicitly. BUG=481568 Review URL: https://codereview.chromium.org/1110403003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295099 0039d316-1c4b-4281-b951-d872f2087c98
-
- 16 Apr, 2015 1 commit
-
-
peter@chromium.org authored
This CL implements support for file: include lines in OWNERS files, both as top-level directives and as per-file directives. The paths can be either relative or absolute. Examples of lines in OWNERS files: file:test/OWNERS (relative, top-level) file://content/OWNERS (absolute, top-level) per-file mock_impl.h=file:test/OWNERS (relative, per-file) per-file mock_impl.h=file://content/OWNERS (absolute, per-file) A whole series of tests to cover this feature have been added to owners_unittest.py as well. BUG=119396, 147633 Review URL: https://codereview.chromium.org/1085993004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@294854 0039d316-1c4b-4281-b951-d872f2087c98
-
- 09 Apr, 2015 1 commit
-
-
sbc@chromium.org authored
Error out of the current tree is dirty (previously the dirty content would be incorporated silently into the newly squashed branch!). Review URL: https://codereview.chromium.org/1064933004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@294744 0039d316-1c4b-4281-b951-d872f2087c98
-
- 17 Feb, 2015 1 commit
-
-
primiano@chromium.org authored
Reland crrev.com/743083002, which was reverted in crrev.com/796053002 due to some test flakiness, probably related with an old version of Git on the bots. Relanding now that the infra has been updated to Trusty (plus adding some de-flake precautions). Original CL Description: Make gclient ready for the Blink (DEPS to main project) transition This CL makes gclient understand correctly whether a git project is being moved from DEPS to an upper project and vice-versa. The driving use case for this is the upcoming Blink merge, where third_party/Webkit will be removed from DEPS (and .gitignore) and will become part of the main project. At present state, gclient leaves the .git folder around when a project is removed from DEPS, and that causes many problems. Furthermore this CL solves the performance problem of bisecting across the merge point. The subproject's (Blink) .git/ folder is moved to a backup location (in the main checkout root) and is restored when moving backwards, avoiding a re-fetch when bisecting across the merge point. BUG=431469 Review URL: https://codereview.chromium.org/910913003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@294082 0039d316-1c4b-4281-b951-d872f2087c98
-
- 11 Dec, 2014 2 commits
-
-
primiano@chromium.org authored
Revert of Make gclient ready for the Blink (DEPS to main project) transition (patchset #6 id:180001 of https://codereview.chromium.org/743083002/) Reason for revert: The test intoruced is flake (see crrev.com/753543006/). Need to look into that with more patience as it reproduces only on precise. Original issue's description: > Make gclient ready for the Blink (DEPS to main project) transition > > This CL makes gclient understand correctly whether a git project is > being moved from DEPS to an upper project and vice-versa. > The driving use case for this is the upcoming Blink merge, where > third_party/Webkit will be removed from DEPS (and .gitignore) and will > become part of the main project. > > At present state, gclient leaves the .git folder around when a project > is removed from DEPS, and that causes many problems. > > Furthermore this CL solves the performance problem of bisecting across > the merge point. The subproject's (Blink) .git/ folder is moved to a > backup location (in the main checkout root) and is restored when moving > backwards, avoiding a re-fetch when bisecting across the merge point. > > BUG=431469 > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=293329 TBR=iannucci@chromium.org,maruel@chromium.org,jochen@chromium.org NOTREECHECKS=true NOTRY=true BUG=431469 Review URL: https://codereview.chromium.org/796053002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293352 0039d316-1c4b-4281-b951-d872f2087c98
-
sbc@chromium.org authored
I ran into several failures running the presubmit checks on my Ubuntu/Trusty laptop and it looks like a some of the tests were broken by recent versions of svn and git. Review URL: https://codereview.chromium.org/795723003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293341 0039d316-1c4b-4281-b951-d872f2087c98
-
- 10 Dec, 2014 1 commit
-
-
primiano@chromium.org authored
This CL makes gclient understand correctly whether a git project is being moved from DEPS to an upper project and vice-versa. The driving use case for this is the upcoming Blink merge, where third_party/Webkit will be removed from DEPS (and .gitignore) and will become part of the main project. At present state, gclient leaves the .git folder around when a project is removed from DEPS, and that causes many problems. Furthermore this CL solves the performance problem of bisecting across the merge point. The subproject's (Blink) .git/ folder is moved to a backup location (in the main checkout root) and is restored when moving backwards, avoiding a re-fetch when bisecting across the merge point. BUG=431469 Review URL: https://codereview.chromium.org/743083002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293329 0039d316-1c4b-4281-b951-d872f2087c98
-
- 02 Jun, 2014 1 commit
-
-
r.c.ladan@gmail.com authored
Invoke the bash shell via /usr/bin/env so that these scripts run on operating systems without /bin/bash too. TEST=run "git cl owners" on FreeBSD BUG= Review URL: https://codereview.chromium.org/197213008 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@274320 0039d316-1c4b-4281-b951-d872f2087c98
-
- 08 May, 2014 1 commit
-
-
iannucci@chromium.org authored
Passes through git-fetch's output instead of buffering it. R=djacques@chromium.org TBR=agable@chromium.org BUG=366375 Review URL: https://codereview.chromium.org/264423002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@269080 0039d316-1c4b-4281-b951-d872f2087c98
-
- 24 Apr, 2014 1 commit
-
-
maruel@chromium.org authored
This makes this file even easier to read and python 2.6 support is not needed anymore. R=iannucci@chromium.org BUG= Review URL: https://codereview.chromium.org/238233002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@265799 0039d316-1c4b-4281-b951-d872f2087c98
-
- 09 Apr, 2014 1 commit
-
-
borenet@google.com authored
BUG=skia:1638 Review URL: https://codereview.chromium.org/189913020 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@262761 0039d316-1c4b-4281-b951-d872f2087c98
-
- 26 Mar, 2014 1 commit
-
-
iannucci@chromium.org authored
git-rebase-update - ensure all branches are up to date git-new-branch - create branches git-rename-branch - rename a branch while preserving parentage relationships git-reparent-branch - change the parent of a branch, including rebasing it correctly onto that new parent. git-squash-branch - collapse a branch into a single commit git-upstream-diff - show the diff between the current branch and it's upstream branch git-mark-merge-base - explicitly set what you want the above tools to consider the merge-base for the current branch. R=agable@chromium.org, hinoka@chromium.org, stip@chromium.org, szager@chromium.org BUG=261738 Review URL: https://codereview.chromium.org/184253003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@259520 0039d316-1c4b-4281-b951-d872f2087c98
-
- 18 Mar, 2014 1 commit
-
-
szager@chromium.org authored
BUG= R=iannucci@chromium.org Review URL: https://codereview.chromium.org/198723010 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@257541 0039d316-1c4b-4281-b951-d872f2087c98
-
- 13 Mar, 2014 2 commits
-
-
szager@chromium.org authored
BUG= Review URL: https://codereview.chromium.org/199553002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@256925 0039d316-1c4b-4281-b951-d872f2087c98
-
stip@chromium.org authored
depot_tools PRESUBMIT.py and tools/build PRESUBMIT.py both run on cq.golo. If broken dev_appserver.py instances are left around, they will conflict with master ports. BUG=351926 Review URL: https://codereview.chromium.org/197073007 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@256721 0039d316-1c4b-4281-b951-d872f2087c98
-
- 12 Mar, 2014 2 commits
-
-
iannucci@chromium.org authored
git-map: Show your local repo's history in a pseudo-graphical format from the command line. git-map-branches: Show the topology of all of your branches, and their upstream relationships. git-nav-upstream: Navigate (checkout) to the upstream branch of the current branch. git-nav-downstream: Navigate (checkout) to a downstream branch of the current branch. If there's more than one downstream branch, then present a menu to select which one you want. R=agable@chromium.org, hinoka@chromium.org, stip@chromium.org, szager@chromium.org BUG= Review URL: https://codereview.chromium.org/184113002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@256384 0039d316-1c4b-4281-b951-d872f2087c98
-
szager@chromium.org authored
This is an emergency patch to avoid picking up the upcoming 2.9-rc0 version of gerrit, which requires java 7 and will break the chromeos bots. BUG=346369 R=davidjames@chromium.org Review URL: https://codereview.chromium.org/196063003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@256378 0039d316-1c4b-4281-b951-d872f2087c98
-
- 10 Mar, 2014 2 commits
-
-
thakis@chromium.org authored
Revert of Another attempt: gclient: delete mismatching checkouts (https://codereview.chromium.org/183283003/) Reason for revert: Broke `gclient sync` for me, failing with: Error: 1> Can't update/checkout /Volumes/MacintoshHD2/src/chrome-git/src if an unversioned directory is present. Delete the directory and try again. For someone else, it broke it with: % gclient sync ________ unmanaged solution; skipping src Error: Command svn info --xml returned non-zero exit status 1 in /Users/pawliger/chromium/src/. <?xml version="1.0" encoding="UTF-8"?> <info> svn: E155007: '/Users/pawliger/chromium/src' is not a working copy Original issue's description: > Another attempt: gclient: delete mismatching checkouts > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=255930 TBR=iannucci@chromium.org,szager@chromium.org,maruel@chromium.org,mmoss@chromium.org,borenet@google.com NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/192323006 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@256005 0039d316-1c4b-4281-b951-d872f2087c98
-
borenet@google.com authored
Review URL: https://codereview.chromium.org/183283003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@255930 0039d316-1c4b-4281-b951-d872f2087c98
-
- 19 Feb, 2014 2 commits
-
-
davidjames@chromium.org authored
This reverts commit cdd96909, which broke gerrit_unittest.py within the chroot, which has Java 6. Original-Review URL: https://codereview.chromium.org/164023005 TBR=szager BUG=344786 TEST=Run the unit tests before and after. Confirm this CL fixes them. Review URL: https://codereview.chromium.org/170423003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@251976 0039d316-1c4b-4281-b951-d872f2087c98
-
dborowitz@google.com authored
These may be named git-snapshot-VERSION.war, where VERSION is the long format defined in git-describe(1). In particular, this may include a number of commits after the given tag name; treat more commits since the tag as a higher version number. This is arguably not always strictly correct due to non-linear history, but the maintainers expect the total number of such snapshot versions to be low, and can remove old snapshot versions that don't sort correctly. Slightly de-obfuscate some of the variable names and logic while we're at it. R=szager@chromium.org BUG= Review URL: https://codereview.chromium.org/164023005 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@251888 0039d316-1c4b-4281-b951-d872f2087c98
-