1. 23 May, 2017 1 commit
  2. 18 May, 2017 1 commit
  3. 18 Apr, 2017 3 commits
    • Aaron Gable's avatar
      Reland "Refactor ReadHttpResponse to be error-friendlier" · 19ee16c8
      Aaron Gable authored
      Gerrit sometimes returns a full response json object at
      the same time as returning a non-200 status code. This
      refactor makes it easier for calling code to request
      access to that object and handle error cases on its own.
      
      The original version of this commit had a bug where
      ReadHttpResponse properly set the default value for
      accept_statuses, but all calls which came through
      ReadHttpJsonResponse were setting None instead.
      
      Bug: 710028
      Change-Id: I8cee435d8acd487fb777b3fd69b5e48e19d2e5a3
      Reviewed-on: https://chromium-review.googlesource.com/481060Reviewed-by: 's avatarRobbie Iannucci <iannucci@chromium.org>
      Reviewed-by: 's avatarAndrii Shyshkalov <tandrii@chromium.org>
      Commit-Queue: Aaron Gable <agable@chromium.org>
      19ee16c8
    • Aaron Gable's avatar
      Revert "Refactor ReadHttpResponse to be error-friendlier" · 382674be
      Aaron Gable authored
      This reverts commit 6d7ab1bf.
      
      Reason for revert: Stacktrace:
       File "/s/depot_tools/gerrit_util.py", line 816, in GetAccountDetails
         return ReadHttpJsonResponse(conn)
       File "/s/depot_tools/gerrit_util.py", line 376, in ReadHttpJsonResponse
         fh = ReadHttpResponse(conn, accept_statuses)
       File "/s/depot_tools/gerrit_util.py", line 365, in ReadHttpResponse
         if response.status not in accept_statuses:
      TypeError: argument of type 'NoneType' is not iterable
      
      Original change's description:
      > Refactor ReadHttpResponse to be error-friendlier
      > 
      > Gerrit sometimes returns a full response json object at
      > the same time as returning a non-200 status code. This
      > refactor makes it easier for calling code to request
      > access to that object and handle error cases on its own.
      > 
      > Bug: 710028
      > Change-Id: Id1017d580d2fb843d5ca6287efcfed8775c52cd6
      > Reviewed-on: https://chromium-review.googlesource.com/479450
      > Commit-Queue: Aaron Gable <agable@chromium.org>
      > Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
      > 
      
      TBR=agable@chromium.org,tandrii@chromium.org,chromium-reviews@chromium.org
      NOPRESUBMIT=true
      NOTREECHECKS=true
      NOTRY=true
      
      Change-Id: Ia9d9ce835e207a32e7cc8ee35c0cf40c823c7b78
      Reviewed-on: https://chromium-review.googlesource.com/481059Reviewed-by: 's avatarAaron Gable <agable@chromium.org>
      Commit-Queue: Aaron Gable <agable@chromium.org>
      382674be
    • Aaron Gable's avatar
      Refactor ReadHttpResponse to be error-friendlier · 6d7ab1bf
      Aaron Gable authored
      Gerrit sometimes returns a full response json object at
      the same time as returning a non-200 status code. This
      refactor makes it easier for calling code to request
      access to that object and handle error cases on its own.
      
      Bug: 710028
      Change-Id: Id1017d580d2fb843d5ca6287efcfed8775c52cd6
      Reviewed-on: https://chromium-review.googlesource.com/479450
      Commit-Queue: Aaron Gable <agable@chromium.org>
      Reviewed-by: 's avatarAndrii Shyshkalov <tandrii@chromium.org>
      6d7ab1bf
  4. 16 Dec, 2016 1 commit
  5. 04 Nov, 2016 1 commit
  6. 16 Aug, 2016 2 commits
  7. 14 Jul, 2016 1 commit
  8. 17 Jun, 2016 1 commit
  9. 16 Jun, 2016 1 commit
  10. 09 May, 2016 1 commit
  11. 21 Mar, 2016 1 commit
  12. 28 Jan, 2016 1 commit
  13. 05 Jun, 2015 1 commit
  14. 01 Jun, 2015 1 commit
  15. 26 May, 2015 1 commit
  16. 22 May, 2015 1 commit
  17. 30 Apr, 2015 1 commit
  18. 16 Apr, 2015 1 commit
  19. 09 Apr, 2015 1 commit
  20. 17 Feb, 2015 1 commit
    • primiano@chromium.org's avatar
      Reland "Make gclient ready for the Blink (DEPS to main project)" · 1c127389
      primiano@chromium.org authored
      Reland crrev.com/743083002, which was reverted in crrev.com/796053002
      due to some test flakiness, probably related with an old version of Git on
      the bots. Relanding now that the infra has been updated to Trusty (plus
      adding some de-flake precautions).
      
      Original CL Description:
      Make gclient ready for the Blink (DEPS to main project) transition
      
      This CL makes gclient understand correctly whether a git project is
      being moved from DEPS to an upper project and vice-versa.
      The driving use case for this is the upcoming Blink merge, where
      third_party/Webkit will be removed from DEPS (and .gitignore) and will
      become part of the main project.
      
      At present state, gclient leaves the .git folder around when a project
      is removed from DEPS, and that causes many problems.
      
      Furthermore this CL solves the performance problem of bisecting across
      the merge point. The subproject's (Blink) .git/ folder is moved to a
      backup location (in the main checkout root) and is restored when moving
      backwards, avoiding a re-fetch when bisecting across the merge point.
      
      BUG=431469
      
      Review URL: https://codereview.chromium.org/910913003
      
      git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@294082 0039d316-1c4b-4281-b951-d872f2087c98
      1c127389
  21. 11 Dec, 2014 2 commits
  22. 10 Dec, 2014 1 commit
    • primiano@chromium.org's avatar
      Make gclient ready for the Blink (DEPS to main project) transition · fcf03763
      primiano@chromium.org authored
      This CL makes gclient understand correctly whether a git project is
      being moved from DEPS to an upper project and vice-versa.
      The driving use case for this is the upcoming Blink merge, where
      third_party/Webkit will be removed from DEPS (and .gitignore) and will 
      become part of the main project.
      
      At present state, gclient leaves the .git folder around when a project
      is removed from DEPS, and that causes many problems. 
      
      Furthermore this CL solves the performance problem of bisecting across
      the merge point. The subproject's (Blink) .git/ folder is moved to a
      backup location (in the main checkout root) and is restored when moving
      backwards, avoiding a re-fetch when bisecting across the merge point. 
      
      BUG=431469
      
      Review URL: https://codereview.chromium.org/743083002
      
      git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293329 0039d316-1c4b-4281-b951-d872f2087c98
      fcf03763
  23. 02 Jun, 2014 1 commit
  24. 08 May, 2014 1 commit
  25. 24 Apr, 2014 1 commit
  26. 09 Apr, 2014 1 commit
  27. 26 Mar, 2014 1 commit
  28. 18 Mar, 2014 1 commit
  29. 13 Mar, 2014 2 commits
  30. 12 Mar, 2014 2 commits
  31. 10 Mar, 2014 2 commits
  32. 19 Feb, 2014 2 commits