Skip to content

C
Chromium_Depot_tools
Switch branch/tag
  1. 25 Dec, 2012 1 commit
  3. 20 Dec, 2012 3 commits
  5. 19 Dec, 2012 5 commits
  7. 18 Dec, 2012 2 commits
    • dpranke@chromium.org's avatar
      Rework the owner-suggesting algorithm. · 1a54c22b
      dpranke@chromium.org authored 
      It turns out that we were weighting all possible owners equally,
and picking the last one out of the list. Given the way we traversed
owners files, and given that we got rid of the "set noparent"s, this
meant that we were always suggesting Ben for just about everything.

This change implements a much smarter algorithm that attempts to balance
number of reviewers and closeness to the files under review. The unit
tests added show specific examples and explanations for why things are
chosen the way they are.

R=maruel@chromium.org
BUG=76727


Review URL: https://chromiumcodereview.appspot.com/11567052

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@173784 0039d316-1c4b-4281-b951-d872f2087c98
      1a54c22b
    • kjellander@chromium.org's avatar
      Move parsing of TRYSERVER_* so options.root is not overwritten · e6ce537f
      kjellander@chromium.org authored 
      Since the helper function for the parsing of the TRYSERVER_* variables relies on them being unset (i.e. value is None) in order to apply the settings from codereview.settings, this parsing must take place before the code that figures out the root path (since that sets the options.root value if it's not set). 
Otherwise the TRYSERVER_ROOT setting will never be set, even if configured in codereview.settings, essentially making it useless.

This has probably not been discovered previously since almost all Chrome projects use src as the root dir. In WebRTC and some other projects we use 'trunk' usually, which is giving us trouble in our own try server  setups (where we have to use 'src' because many other scripts have that root dir hardcoded).

I am not sure if there is a case for another project where this change may have any negative effect. Please let me know if theres's any investigation needed that I can assist with.

BUG=none
TEST=submitting try job to local try master with a codereview.settings file with TRYSERVER_ROOT set.

Review URL: https://chromiumcodereview.appspot.com/11574007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@173694 0039d316-1c4b-4281-b951-d872f2087c98
      e6ce537f
  9. 17 Dec, 2012 1 commit
  11. 14 Dec, 2012 1 commit
  13. 13 Dec, 2012 1 commit
  15. 11 Dec, 2012 3 commits
  17. 10 Dec, 2012 2 commits
  19. 06 Dec, 2012 1 commit
  21. 05 Dec, 2012 3 commits
  23. 03 Dec, 2012 1 commit
  25. 30 Nov, 2012 1 commit
  27. 28 Nov, 2012 5 commits
  29. 27 Nov, 2012 1 commit
  31. 26 Nov, 2012 3 commits
  33. 19 Nov, 2012 1 commit
  35. 15 Nov, 2012 1 commit
  37. 13 Nov, 2012 2 commits
  39. 09 Nov, 2012 2 commits