- 12 Jul, 2017 2 commits
-
-
Dan Jacques authored
Re-land of bf144679. Enable bundled Python CIPD packages in bleeding-edge mode. This replaces the ZIP unpacking approach used before, and introduces validation and management through the CIPD tool. The bleeding edge version will only install if a sentinel file is present in the "depot_tools" root; otherwise, default behavior will continue. This method adds a upgrade and downgrade path to/from ZIP and CIPD installations. This is done by rewriting the "win_tools.bat" process: 1) Ensure that a bootstrap Python is present. 2) Use it to run "win_tools.py", which has the functionality of "git_bootstrap.py" plus Python installation. 3) Run "win_tools.py" with appropriate flags. Some tricks were employed to handle cases where there is an already-running Python instance that uses the current Python installation and executable. This happens on bots because the system uses the same "depot_tools" checkout at multiple launch layers. To this end, we use the "python.bat" as the "current Python" authority and refrain from cleaning up old Python directories if their "python.exe" binaries are currently in use. We change the Git bleeding edge file to share the same sentinel file as Python, ".bleeding_edge". The new Python should have the same facilities as the original Python bundle. BUG=chromium:740171 TEST=local Change-Id: I51ba6415c60b95c2aaba94b6e21bd9b3fc82f35d Reviewed-on: https://chromium-review.googlesource.com/568524Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
-
Andrii Shyshkalov authored
This reverts commit bf144679. Reason for revert: broke win bots http://o/410053 Original change's description: > [win_tools] Use bundled Python CIPD packages. > > Enable bundled Python CIPD packages in bleeding-edge mode. This > replaces the ZIP unpacking approach used before, and introduces > validation and management through the CIPD tool. The bleeding edge > version will only install if a sentinel file is present in the > "depot_tools" root; otherwise, default behavior will continue. > > This method adds a upgrade and downgrade path to/from ZIP and > CIPD installations. This is done by rewriting the "win_tools.bat" > process: > > 1) Ensure that a bootstrap Python is present. > 2) Use it to run "win_tools.py", which has the functionality of > "git_bootstrap.py" plus Python installation. > 3) Run "win_tools.py" with appropriate flags. > > Some tricks were employed to handle cases where there is an > already-running Python instance that uses the current Python > installation and executable. This happens on bots because the > system uses the same "depot_tools" checkout at multiple launch > layers. To this end, we use the "python.bat" as the "current Python" > authority and refrain from cleaning up old Python directories if their > "python.exe" binaries are currently in use. > > We change the Git bleeding edge file to share the same > sentinel file as Python, ".bleeding_edge". > > The new Python should have the same facilities as the original Python > bundle. > > BUG=chromium:740171 > TEST=local > > Change-Id: I1b3b7d31d47d1a37a9dba9114d31681bec558736 > Reviewed-on: https://chromium-review.googlesource.com/563036 > Commit-Queue: Daniel Jacques <dnj@chromium.org> > Reviewed-by: Robbie Iannucci <iannucci@chromium.org> TBR=iannucci@chromium.org,dnj@chromium.org Change-Id: I84574a01bbad6596912e4aaa34f019d24720b638 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:740171 Reviewed-on: https://chromium-review.googlesource.com/567009Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
- 11 Jul, 2017 1 commit
-
-
Dan Jacques authored
Enable bundled Python CIPD packages in bleeding-edge mode. This replaces the ZIP unpacking approach used before, and introduces validation and management through the CIPD tool. The bleeding edge version will only install if a sentinel file is present in the "depot_tools" root; otherwise, default behavior will continue. This method adds a upgrade and downgrade path to/from ZIP and CIPD installations. This is done by rewriting the "win_tools.bat" process: 1) Ensure that a bootstrap Python is present. 2) Use it to run "win_tools.py", which has the functionality of "git_bootstrap.py" plus Python installation. 3) Run "win_tools.py" with appropriate flags. Some tricks were employed to handle cases where there is an already-running Python instance that uses the current Python installation and executable. This happens on bots because the system uses the same "depot_tools" checkout at multiple launch layers. To this end, we use the "python.bat" as the "current Python" authority and refrain from cleaning up old Python directories if their "python.exe" binaries are currently in use. We change the Git bleeding edge file to share the same sentinel file as Python, ".bleeding_edge". The new Python should have the same facilities as the original Python bundle. BUG=chromium:740171 TEST=local Change-Id: I1b3b7d31d47d1a37a9dba9114d31681bec558736 Reviewed-on: https://chromium-review.googlesource.com/563036 Commit-Queue: Daniel Jacques <dnj@chromium.org> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org>
-
- 27 May, 2016 1 commit
-
-
iannucci@chromium.org authored
Manual land of https://chromiumcodereview.appspot.com/2009173002/ due to CQ lineending issues. AUTHOR=techtonik@gmail.com R=phajdan.jr@chromium.org, techtonik@gmail.com, dpranke@chromium.org BUG= Review URL: https://codereview.chromium.org/2015673002 . git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300668 0039d316-1c4b-4281-b951-d872f2087c98
-
- 29 Mar, 2016 1 commit
-
-
iannucci@chromium.org authored
R=dnj@chromium.org, mmoss@chromium.org, vadimsh@chromium.org BUG=595883 Review URL: https://codereview.chromium.org/1827403003 . git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299520 0039d316-1c4b-4281-b951-d872f2087c98
-