Commits · 8c4faee3fa2bd4153a538228a59d0f8aa460e16a · Linshizhi / Chromium_Depot_tools

03 Nov, 2016 2 commits

Roll recipe dependencies (trivial). · 8c4faee3

recipe-roller authored Nov 03, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/6b5af03500f8ab57a2905d11af2690de990961bd Remove unused --bootstrap-script option. (iannucci@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2469863007

8c4faee3

Roll recipe dependencies (nontrivial). · e0b205e8

recipe-roller authored Nov 03, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

Please review the expectation changes, and LGTM as normal. The recipe roller
will *NOT* CQ the change itself, so you must CQ the change manually.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/2c474706779466f2e18e83a632f6d6debf63787f Fix issue overriding bug properties.test_api.tryserver for Gerrit. (tandrii@chromium.org)

R=tandrii@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2473883003

e0b205e8

02 Nov, 2016 3 commits

Roll recipe dependencies (trivial). · 27b7a139

recipe-roller authored Nov 02, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/2ecaa8b5944f016f6bda5cbe93ec6f54e8ead4fb Delete tryserver_gerrit and its old properties. (tandrii@chromium.org)
  https://crrev.com/fabbc26432e0ba2e5492e01640722eb4641519c9 Add exit status proto (martiniss@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2472853002

27b7a139

Recipes: Stop using tryserver_gerrit in depot_tools. · 9701c7c1

tandrii authored Nov 02, 2016

Only changes how test properties are given, no change in functionality.
Should enable recipe roll of https://codereview.chromium.org/2464673002.

R=martiniss@chromium.org,machenbach@chromium.org
BUG=chromium:645616

Review-Url: https://codereview.chromium.org/2468373002

9701c7c1

Remove --bootstrap-script parameter from recipes.py · 1158a545
iannucci authored Nov 02, 2016
```
R=martiniss@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2465613002
```
1158a545

01 Nov, 2016 1 commit
- git-cl-land: print url of final commit location · 32978d96
  agable authored Nov 01, 2016
```
BUG=661187

Review-Url: https://codereview.chromium.org/2466953003
```
  32978d96
31 Oct, 2016 2 commits

Make bot_update on win more resilient · 86fe47d1

katthomas authored Oct 31, 2016

Sometimes Windows has trouble deleting files. This can cause problems
when lockfiles are left in .git directories.

R=agable@google.com
BUG=659178

Review-Url: https://codereview.chromium.org/2454463002

86fe47d1

depot_tools: Remove DoGetTrySlaves, GetTrySlavesExecuter, GetPreferredTrySlaves · 136b49ff

qyearsley authored Oct 31, 2016

Note: This CL originally just removed a deprecated use of Remove use of DoGetTrySlaves, suggested in http://crrev.com/2442153002, then was expanded to remove DoGetTrySlaves, GetPreferredTrySlaves and GetTrySlavesExecuter since these are all deprecated and unused.

BUG=660453

Review-Url: https://codereview.chromium.org/2453823002

136b49ff

28 Oct, 2016 3 commits

Log error message if os.rename fails · b7c80888

katthomas authored Oct 28, 2016

R=agable@google.com
BUG=659178

Review-Url: https://codereview.chromium.org/2448983004

b7c80888

git cl try: Simplify _get_bucket_map. · dd49f94c

qyearsley authored Oct 28, 2016

Assuming that assuming bots are always just builder names, and they're never specified along with tests in git cl --bot options, then some logic used for git cl try can be removed.

Review-Url: https://codereview.chromium.org/2448193006

dd49f94c

Remove apply_gerrit_ref from bot_update recipe API · d918da64
borenet authored Oct 28, 2016
```
BUG=skia:5588

Review-Url: https://codereview.chromium.org/2453663004
```
d918da64

27 Oct, 2016 1 commit

Roll recipe dependencies (trivial). · 03832ffc

recipe-roller authored Oct 27, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/799034e5ee1634cf2d88b0a666e0d8ca934cd895 Remove --bootstrap-script parameter from recipes.py. (iannucci@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2460683003

03832ffc

26 Oct, 2016 4 commits

Revert of Call status before reset in gclient sync. (patchset #2 id:20001 of... · b655dbda

justincohen authored Oct 26, 2016

Revert of Call status before reset in gclient sync. (patchset #2 id:20001 of https://codereview.chromium.org/2447813003/ )

Reason for revert:
https://codereview.chromium.org/2444403003/ makes this pretty redundant.  Reverting this.

Original issue's description:
> Call status before reset in gclient sync.
>
> Calling status before reset will ensure files that have no been changed do not
> get deleted by reset --hard.
>
> BUG=642711
>
> Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/d74a7b4c14512d95cb46204bb7a70ba5666b5eb7

TBR=sdefresne@chromium.org,maruel@chromium.org,dpranke@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=642711

Review-Url: https://codereview.chromium.org/2453083002

b655dbda

git cl try: support multiple bots from different masters without specifying master. · 123a468d

qyearsley authored Oct 26, 2016

It might be good to make this change after the refactoring CL http://crrev.com/2442153002.

BUG=640740

Review-Url: https://codereview.chromium.org/2439293002

123a468d

git cl try: Remove --name option, stop sending "reason" property. · 5eb0519b

qyearsley authored Oct 26, 2016

When triggering the build, there's a field called "reason",
which is currently populated by default with the user's
branch name.

I have a feeling that this is optional and could be completely
omitted.

Andrii notes that if users want to send a "reason" string,
they could send invoke git cl try with the argument -p reason="<reason>".

PSA on infra-dev:
https://groups.google.com/a/chromium.org/d/msg/infra-announce/PXkM1WinTYY/w2IvN5B4AwAJ

BUG=659552

Review-Url: https://codereview.chromium.org/2428383010

5eb0519b

Call status before reset in gclient sync. · d74a7b4c

justincohen authored Oct 26, 2016

Calling status before reset will ensure files that have no been changed do not
get deleted by reset --hard.

BUG=642711

Review-Url: https://codereview.chromium.org/2447813003

d74a7b4c

25 Oct, 2016 4 commits

Correctly guard file_list modification in gclient update · c3937b91
agable authored Oct 25, 2016
```
TBR=smut@chromium.org
BUG=658959

Review-Url: https://codereview.chromium.org/2448993003
```
c3937b91
Continue to the next file after a conflict in apply_patch. · 2f3f137d
skobes authored Oct 25, 2016
```
BUG=658915

Review-Url: https://codereview.chromium.org/2446013002
```
2f3f137d

bot_update: understand new Gerrit patch properties. · 51a7b096

tandrii authored Oct 25, 2016

This change is backwards compatible, so no expectation changes expected
in downstream rolls.

Depends on https://codereview.chromium.org/2442173003 recipe_engine
change.

BUG=645616
R=martiniss@chromium.org,machenbach@chromium.org

Review-Url: https://codereview.chromium.org/2439373002

51a7b096

Roll recipe dependencies (trivial). · c1a668d8

recipe-roller authored Oct 25, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/24a5bf068cee997aec0c60df51ca81bfa5ac5416 Add cleaned up Gerrit props to properties.test_api.tryserver. (tandrii@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2446133002

c1a668d8

24 Oct, 2016 8 commits

Remove SVN support from checkout.py · c972d189

agable authored Oct 24, 2016

R=hinoka@chromium.org
BUG=475320

Review-Url: https://codereview.chromium.org/2398603003

c972d189

Clean up gclient sync's construction of the set of modified files · 1a8439a7
agable authored Oct 24, 2016
```
R=iannucci@chromium.org
BUG=643346

Review-Url: https://codereview.chromium.org/2425253003
```
1a8439a7

Remove unnecessary rev_str variable from gclient_scm · 83faed04

agable authored Oct 24, 2016

Some initial cleanup before larger refactorings.

R=iannucci@chromium.org
BUG=643346

Review-Url: https://codereview.chromium.org/2430523004

83faed04

Remove SVN support from apply_issue · 037edb82

agable authored Oct 24, 2016

R=iannucci@chromium.org
BUG=475320

Review-Url: https://codereview.chromium.org/2394963003

037edb82

Refactoring: Extract helper functions from CMDtry in git_cl.py. · 1fdfcb63

qyearsley authored Oct 24, 2016

The purpose of this change is to prepare for modifying git cl try
so that builders on multiple masters can be triggered in one invocation
(http://crbug.com/640740).

This should not affect behavior; this CL makes several non-essential
changes to formatting and comments.

Review-Url: https://codereview.chromium.org/2442153002

1fdfcb63

git_cl: fix GetPreferredTryMasters() feature · 70d11c37

nodir authored Oct 24, 2016

It was broken in https://chromiumcodereview.appspot.com/2419113002

R=borenet@chromium.org
BUG=658317

Review-Url: https://codereview.chromium.org/2442393002

70d11c37

Roll recipe dependencies (trivial). · 66cdab51

recipe-roller authored Oct 24, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/19b97eb65b25648c4101c279e30f2aa9d7754844 Refactor expectations of properties recipe_module. (tandrii@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2448453003

66cdab51

Make git cl patch work with binary files. · 6468b906
skobes authored Oct 24, 2016
```
BUG=557512

Review-Url: https://codereview.chromium.org/2445543002
```
6468b906

23 Oct, 2016 2 commits

Print failure reason when git cl try can't trigger jobs on a CL. · 99e2cdf4
qyearsley authored Oct 23, 2016
```
This is a very little fix.

Review-Url: https://codereview.chromium.org/2441213002
```
99e2cdf4

Automatically CC folks listed in CC= lines. · d975b30c

bradnelson authored Oct 23, 2016

Detect CC=<users> lines the way we detect R= and TBR=.
Add these as CC'ed users for rietveld and gerrit.

R=iannucci@chromium.org,hinoka@chromium.org,dnj@chromium.org

Review-Url: https://codereview.chromium.org/2433323004

d975b30c

20 Oct, 2016 1 commit

Remove SVN support from gclient_utils and gclient_scm · 41e3a6c5

agable authored Oct 20, 2016

This removes SVN support (most notably the SVNWrapper class, and the git-svn
logic in GitWrapper.GetUsableRev) from gclient_scm. It also removes some
references to SVN from comments in gclient_utils.

R=maruel@chromium.org
BUG=641588

Review-Url: https://chromiumcodereview.appspot.com/2393773003

41e3a6c5

19 Oct, 2016 6 commits

Change path to internal-try rietveld credentials · bc0b4c6e

hinoka authored Oct 19, 2016

To match where it ended up being located.

BUG=642150

Review-Url: https://chromiumcodereview.appspot.com/2436853002

bc0b4c6e

Roll recipe dependencies (trivial). · d501e8ac

recipe-roller authored Oct 19, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/6e11fcc25f244f962bf750349a805bb3261977ff Remove debugging print. (iannucci@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://chromiumcodereview.appspot.com/2433213002

d501e8ac

Roll recipe dependencies (trivial). · 16b03c73

recipe-roller authored Oct 19, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/9d854c6e7ce9ed004ef0854d0d2c3c5aabcca66f Add Swarming magic environment variables to ENV_WHITELIST (borenet@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://chromiumcodereview.appspot.com/2436773002

16b03c73

Add -B/--bucket flag to git-cl try · 6c0efe60
borenet authored Oct 19, 2016
```
BUG=

Review-Url: https://chromiumcodereview.appspot.com/2419113002
```
6c0efe60
git cl: refactor direct usage of time.sleep and time.time. · 2a16b95e
tandrii authored Oct 19, 2016
```
R=machenbach@chromium.org

Review-Url: https://chromiumcodereview.appspot.com/2433813004
```
2a16b95e
Automatically map urls to their raw appengine forms · 6ff1fc0e
Aaron Gable authored Oct 19, 2016
```
BUG=657216
R=dnj@chromium.org

Review URL: https://codereview.chromium.org/2431893002 .
```
6ff1fc0e

18 Oct, 2016 3 commits

Revert "git_cl: Allow server overriding." · 78de30e1
Dan Jacques authored Oct 18, 2016
```
This reverts commit a8fb3a28.
```
78de30e1

git_cl: Allow server overriding. · a8fb3a28

Dan Jacques authored Oct 18, 2016

BUG=chromium:657064
TEST=local
  - Ran "git cl status" during outage with override, works.

R=tandrii@chromium.org

Review URL: https://chromiumcodereview-hr.appspot.com/2425673005 .

a8fb3a28

Fix typo in --manually_grab_svn_rev deprecated flag. · 69b1be10

sdefresne authored Oct 18, 2016

Chrome on iOS downstream bot still use that flag and they cannot
recover as the flag has been misspelt when resurrected.

TBR=agable@chromium.org
TBR=dnj@chromium.org
BUG=656865

Review-Url: https://codereview.chromium.org/2428893002

69b1be10