- 20 Jan, 2021 1 commit
-
-
Edward Lesmes authored
This is a reland of 968b1fe7 Original change's description: > [git-cl] Use owners client when processing --[tb]r-owners. > > Change-Id: Id094bce2aa731359cd8af16f10ce79ae7e02bd85 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2572809 > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> > Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> > Reviewed-by: Josip Sokcevic <sokcevic@google.com> Change-Id: I9f93d755b10517c5296f7095f735ec2295be34e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2632840 Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Josip Sokcevic <sokcevic@google.com> Reviewed-by:
Josip Sokcevic <sokcevic@google.com>
-
- 19 Jan, 2021 5 commits
-
-
Edward Lesmes authored
This feature will not be supported when using Gerrit Code-Owners plugin. Change-Id: I7ad0d5bf004ba39818e57fc00e40592a44d1d11f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2638140 Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Gavin Mak <gavinmak@google.com> Reviewed-by:
Gavin Mak <gavinmak@google.com>
-
Edward Lesmes authored
New API was updated to properly support '*' as owner. Change-Id: If14144f83484731fd5534c03cb9fde4b18f49fe9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2628703 Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
-
Andrii Shyshkalov authored
<ExceptionObj>.message worked in py2, but not in py3. R=ehmaldonado@google.com Change-Id: I1f1302d453e9142b59de4ccab0298367bffde295 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2631495 Auto-Submit: Andrii Shyshkalov <tandrii@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org>
-
Takuto Ikuta authored
This removes dependency to httplib2 by using urllib. https://docs.python.org/3/library/http.client.html#httpresponse-objects Use six for both py2/py3 unittest. Bug: b/177465438 Change-Id: I48383559842615f97abea45b55ca0acf4d7c8bd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2629087 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@google.com> Reviewed-by:
Fumitoshi Ukai <ukai@google.com> Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
-
Takuto Ikuta authored
This is for comments in https://crrev.com/c/2629087/11/autoninja and https://crrev.com/c/2629087/11/autoninja.bat Change-Id: I2edafaee7916b7c826af7a7f8f0150a541c8d098 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2631396Reviewed-by:
-
- 15 Jan, 2021 4 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/2030661a4ff2a6b64b0651f2c44aabed8c71223f 2030661 (yuanzhi@google.com) [resultdb] Add option to include new invocation using rdb. More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: If1e8fed40c1fe3e464a382cf594dddfb3e0af76b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2632976Reviewed-by:
Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
Edward Lesmes authored
Bug: 1166467 Change-Id: Ib6c32b11ca2892841cad477cee61edef38a0ed62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2628702 Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Gavin Mak <gavinmak@google.com> Reviewed-by:
-
Yoshisato Yanagisawa authored
This reverts commit b7ddc5a0. Reason for revert: This broke the builder where depot_tools is not in PATH. https://logs.chromium.org/logs/infra-internal/buildbucket/cr-buildbucket.appspot.com/8858077852309878080/+/u/build/stdout Original change's description: > Check whether goma is running when it is enabled > > One of the mistakes one can make when running ninja is having goma > enabled (use_goma=true in args.gn) but not having goma running. This can > lead to ~1,000 failed compile steps, which is messy. > > This change teaches autoninja.py to check whether goma is running. If > not then it tells autoninja to just print a warning message. The > check costs roughly 30 ms which seems reasonable. > > In fact, because this change also switches away from vpython (necessary > to use python3 to use subprocess.run) it actually runs about 600 ms > _faster_ than before this change. > > If build acceleration is requested through use_rbe then no checking for > whether the service is running is done. That could be added in the > future. > > autoninja.py could auto-start goma but that is error prone and has > limited additional value. > > This was tested on Linux, OSX, and Windows. > > Bug: 868590, b/174673874 > Change-Id: Ie773e574878471e5136b9b82d52f86af3d848318 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2627014 > Commit-Queue: Bruce Dawson <brucedawson@chromium.org> > Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@google.com> TBR=yyanagisawa@google.com,dpranke@google.com,brucedawson@chromium.org,sanfin@chromium.org,infra-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I57a6c73ea853259f3d1ec7ad0ce51e495acc96db No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 868590 Bug: b/174673874 Bug: 1167064 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2632018Reviewed-by:
-
Yoshisato Yanagisawa authored
This reverts commit 2241db8a. Reason for revert: Cannot merge https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2632018 due to conflict. Original change's description: > Avoid capture_output to support Python 3.6 > > autoninja.py uses subprocess.run which requires Python 3 and used > capture_output which requires Python 3.6. One user reported this as an > issue and it turns out that it is easy to avoid by using subprocess.NULL > which then means that Python versions back to 3.3 are supported. > > Bug: 868590, b/174673874 > Change-Id: Ife5e186d9c54747d35ff989dc2afadba5b9a57f5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2630525 > Auto-Submit: Bruce Dawson <brucedawson@chromium.org> > Reviewed-by: Justin Cohen <justincohen@chromium.org> > Commit-Queue: Bruce Dawson <brucedawson@chromium.org> TBR=justincohen@chromium.org,brucedawson@chromium.org,infra-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I5131a43eeb9410a6b45920d409a392a2df9d9af0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 868590 Bug: b/174673874 Bug: 1167064 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2632022Reviewed-by:
-
- 14 Jan, 2021 7 commits
-
-
Josip Sokcevic authored
Currently, gclient sync assumes the default branch is master, and it doesn't work at all if such branch doesn't exist. This change queries local git copy to get remote HEAD. If local git version is not available, it queries remote git server using ls-remote. This change requires git version 2.28 (depot_tools comes with 2.29). R=ehmaldonado@chromium.org Bug: 1156318 Change-Id: Id348e0f1004093f395139e8f4d62adb66b94ca9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2628359 Commit-Queue: Josip Sokcevic <sokcevic@google.com> Reviewed-by:
-
Bruce Dawson authored
autoninja.py uses subprocess.run which requires Python 3 and used capture_output which requires Python 3.6. One user reported this as an issue and it turns out that it is easy to avoid by using subprocess.NULL which then means that Python versions back to 3.3 are supported. Bug: 868590, b/174673874 Change-Id: Ife5e186d9c54747d35ff989dc2afadba5b9a57f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2630525 Auto-Submit: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
-
Bruce Dawson authored
One of the mistakes one can make when running ninja is having goma enabled (use_goma=true in args.gn) but not having goma running. This can lead to ~1,000 failed compile steps, which is messy. This change teaches autoninja.py to check whether goma is running. If not then it tells autoninja to just print a warning message. The check costs roughly 30 ms which seems reasonable. In fact, because this change also switches away from vpython (necessary to use python3 to use subprocess.run) it actually runs about 600 ms _faster_ than before this change. If build acceleration is requested through use_rbe then no checking for whether the service is running is done. That could be added in the future. autoninja.py could auto-start goma but that is error prone and has limited additional value. This was tested on Linux, OSX, and Windows. Bug: 868590, b/174673874 Change-Id: Ie773e574878471e5136b9b82d52f86af3d848318 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2627014 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
-
Takuto Ikuta authored
I'll update to python3 separately. Bug: b/177465438 Change-Id: Id204789f2d0854a796e5408597700d90dc8cd191 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2626863Reviewed-by:
-
Ben Pastene authored
This reverts commit 64d94dea. Reason for revert: tentative revert for https://crbug.com/1166467 Original change's description: > presubmit: Use new API to check for owners approval > > It also allows us to improve unit tests. > > Change-Id: I356a2fddcbcc5af0e628f79ede1ba277008f5cde > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2612222 > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> > Reviewed-by: Josip Sokcevic <sokcevic@google.com> > Reviewed-by: Gavin Mak <gavinmak@google.com> > Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> TBR=ehmaldonado@chromium.org,gavinmak@google.com,infra-scoped@luci-project-accounts.iam.gserviceaccount.com,sokcevic@google.com Bug: 1166467 Change-Id: I1df97f8fdbc56942fdcc7bafffed517e24a9481d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2628574Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/3effff55e74af70a8eb875fedc28feb82e36a458 3effff5 (chanli@chromium.org) [resultdb] get invocation ids from invocation names More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I4e63f95aeef91180a5f571f6c47a3e713d3d540a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2628614Reviewed-by:
-
Edward Lesmes authored
It also allows us to improve unit tests. Change-Id: I356a2fddcbcc5af0e628f79ede1ba277008f5cde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2612222 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
-
- 13 Jan, 2021 5 commits
-
-
Mike Frysinger authored
Change-Id: Ia6388b624382c3b2db55c3cca5abacae7793e177 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2626049Reviewed-by:
Michael Mortensen <mmortensen@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/ae1e4dda6c91b7cb860554627904419f97febad1 ae1e4dd (olivernewman@google.com) [file] Don't add JSON log to read_proto steps More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I4e5b0124151790a404ab57a6140f848162ef7ccc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2627329Reviewed-by:
-
Scott Lee authored
To deploy the changes of the following CLs - https://crrev.com/c/2617742 - https://crrev.com/c/2594641 Bug: 1155298 Bug: 1141153 Change-Id: Ia09f1817285d9c3db38b7d7684b714e02f38b5b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2625979Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Scott Lee <ddoman@chromium.org>
-
James Zern authored
w/chromium-review.googlesource.com Change-Id: I8f024d68a3b89ae530fc1ce2806b9b12b83ba7b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2585050Reviewed-by:
-
Mandy Chen authored
Some of the owners.py code does not change file path to use the slash separator, causing owners check to crash on Windows. This CL fixes it. Change-Id: I6e06a235dbb563ea45691f19b03d826b23184b2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2626090Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Mandy Chen <mandy.chen@microsoft.com>
-
- 12 Jan, 2021 5 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/b9d95cda0b959f6935e8330db85ab3ee76c01684 b9d95cd (chanli@chromium.org) [swarming] use get() when getting invocation More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I00d44a695cb5bc771ab5c42b57c4b64518268a2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2625399Reviewed-by:
-
Edward Lesmes authored
So that presubmit API can use it to check owners approval. Change-Id: Ie26c8a83de02b750fd92b4f419fe4d55809e6dbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2621745Reviewed-by:
-
Edward Lesmes authored
When used as part of presubmit's input_api, we only expose OwnersClient and not global constants, so move constants inside OwnersClient. Change-Id: I8983c5edadafeebff62838d9cd4a19fdce908159 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2621744 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
-
Gavin Mak authored
Running gclient validate or gclient flatten outside of gclient root results in an unhelpful AttributeError stacktrace. This change adds an error message that lets the user know the client is not confugred. Bug: 732733 Change-Id: I33b1a08aa394145e238a4939bfd995ec33a8df17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2624351Reviewed-by:
-
Yoshisato Yanagisawa authored
Bug: b/174281084 Change-Id: Id248e306cb8e11974fc0846b22b33831fc04a76d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2622010 Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Commit-Queue: Fumitoshi Ukai <ukai@google.com> Auto-Submit: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Reviewed-by:
-
- 11 Jan, 2021 4 commits
-
-
Edward Lesmes authored
This makes it easier to test, e.g. we can mock DepotToolsClient.BatchListOwners without having to mock DepotToolsClient first (to avoid initialization). Change-Id: I9c24ef28ba7a82cd1498e863cc1b4bc825a579d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2616900Reviewed-by:
-
Yuanjun Huang authored
To release the new Led which uses RBE-CAS. infra/infra change log: https://chromium.googlesource.com/infra/infra/+log/657015d..d86f553/ luci-go change log: https://chromium.googlesource.com/infra/luci/luci-go/+log/71ccb73..5c64c54 Bug:1145959 Change-Id: Ic55890c21a527bb482c902a28fdbc0c2d6e08c62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2623107Reviewed-by:
Andrii Shyshkalov <tandrii@google.com> Commit-Queue: Yuanjun Huang <yuanjunh@google.com>
-
Chan Li authored
To Include changes: - https://chromium-review.googlesource.com/c/infra/infra/+/2601378 - https://chromium-review.googlesource.com/c/infra/infra/+/2614222 Bug: 1103287 Change-Id: If6fa29bc7cce08f74baa00b2034371e20f46d0e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2617502Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Commit-Queue: Chan Li <chanli@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/d0bbd7d86166132343652b1729a9c45f9631f9b4 d0bbd7d (akashmukherjee@google.com) [Provenance] Add single file hash calculation to file module. More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I7d458989a208b22cb01a85d6619e278aa7e0eea0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2622857Reviewed-by:
-
- 09 Jan, 2021 1 commit
-
-
Edward Lesmes authored
This is a reland of 276bab4c Fixed to include author on the list of reviewers. Original change's description: > presubmit: Don't print comments for missing reviewers. > > Don't print owners comments when suggesting missing reviewers, > as this won't be supported when using Gerrit API. > > Change-Id: I644b2f87b58a3c9ece3aa7d107100f3501bd3071 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2607675 > Commit-Queue: Josip Sokcevic <sokcevic@google.com> > Reviewed-by: Gavin Mak <gavinmak@google.com> > Reviewed-by: Josip Sokcevic <sokcevic@google.com> > Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Change-Id: I6dfb2087022ad87595e6cabc50d42a8bdf6311b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2615918 Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
-
- 08 Jan, 2021 3 commits
-
-
Edward Lesmes authored
Reland of [1]. Original CL contained some changes to --[tb]r-owners which are not included in this CL because those changes were reverted on [2]. - Remove GetChangeApprovalStatus and GetFilesApprovalStatus. - Make host, project and branch part of GerritClient. - Rename ListOwnersForFile to ListOwners. [1] https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2587268 [2] https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2611219 Change-Id: Ife2051b8be0460d1c6bc4fbe4e3b0a571d12dafb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2616130 Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
-
Josip Sokcevic authored
R=ehmaldonado@chromium.org Bug: 1136986 Change-Id: I012f0d29589460b8cc7809c9c011811dff476a02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2616898Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/900b191fea68d1c0869204ec58ed0710fbacd283 900b191 (qyearsley@chromium.org) tricium: Remove hard limit on num comments in recipe module More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I150fcf8f926c70af80ed35dd02885f9ff2938fd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2616899Reviewed-by:
-
- 07 Jan, 2021 5 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/a0af0123ab934330280360700d919c074caffa95 a0af012 (sokcevic@google.com) Use inclusive parameter names in PRESUBMIT More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I6316b4cb33c794f7b63db9a3a089d23fd252def8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2615859Reviewed-by:
-
Garrett Beaty authored
When set_output_commit is True and the repo associated with the got_revision property does not use commit positions, buiders whose gclient config uses RevisionFallbackChain for that repo will raise an exception when attempting set the output commit because a string is expected for the revision value, not a RevisionFallbackChain object. This changes the set_output_commit code to resolve the revision so that the output commit can be set in those cases. Bug: 1159749, 1141886 Change-Id: Iddf1d49871028d9500eefb0eed07e36ce7e6b0d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2612223 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
-
Stephen Martinis authored
This reverts commit 968b1fe7. Reason for revert: Appears to be breaking git cl upload for the recipe autoroller with https://logs.chromium.org/logs/infra-internal/buildbucket/cr-buildbucket.appspot.com/8858802226988308224/+/steps/infra/0/steps/git_cl_upload/0/stdout. Original change's description: > [git-cl] Use owners client when processing --[tb]r-owners. > > Change-Id: Id094bce2aa731359cd8af16f10ce79ae7e02bd85 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2572809 > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> > Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> > Reviewed-by: Josip Sokcevic <sokcevic@google.com> TBR=ehmaldonado@chromium.org,apolito@google.com,infra-scoped@luci-project-accounts.iam.gserviceaccount.com,sokcevic@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Id561a059eaf1419cbda52b7c0c6a45b5c6f2bd1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2611219Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
-
Edward Lesmes authored
This reverts commit 9c7f6c25. Reason for revert: Not working https://logs.chromium.org/logs/infra-internal/buildbucket/cr-buildbucket.appspot.com/8858807889610091152/+/steps/franky/0/steps/git_cl_upload/0/stdout Original change's description: > [owners] Refactor OwnersClient. > > - Remove GetChangeApprovalStatus and GetFilesApprovalStatus. > - Make host, project and branch part of GerritClient. > - Rename ListOwnersForFile to ListOwners. > > Change-Id: I1f610a64f0217ce54e5ce4a210026535adc1c2e5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2587268 > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> > Reviewed-by: Gavin Mak <gavinmak@google.com> TBR=ehmaldonado@chromium.org,gavinmak@google.com,infra-scoped@luci-project-accounts.iam.gserviceaccount.com,sokcevic@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I4928df90856526210a4fd4d104e6cc96aa005bc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2613925 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
-
Edward Lesmes authored
This reverts commit 276bab4c. Reason for revert: Possible cause of crbug.com/1163731 Original change's description: > presubmit: Don't print comments for missing reviewers. > > Don't print owners comments when suggesting missing reviewers, > as this won't be supported when using Gerrit API. > > Change-Id: I644b2f87b58a3c9ece3aa7d107100f3501bd3071 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2607675 > Commit-Queue: Josip Sokcevic <sokcevic@google.com> > Reviewed-by: Gavin Mak <gavinmak@google.com> > Reviewed-by: Josip Sokcevic <sokcevic@google.com> > Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> TBR=ehmaldonado@chromium.org,gavinmak@google.com,infra-scoped@luci-project-accounts.iam.gserviceaccount.com,sokcevic@google.com Bug: 1163731 Change-Id: I0b3d0f352e5483e754f6b790f70a9278df4eb3e2 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2613924Reviewed-by:
-
