Skip to content

C
Chromium_Depot_tools
Switch branch/tag
  1. 02 Feb, 2021 3 commits
    • Takuto Ikuta's avatar
      Roll out new goma client binary VERSION=213 · 8bb35133
      Takuto Ikuta authored 
      Bug: b/178747003
Change-Id: I2dff72f688ea67228dc691e94cc17e419cfc8f21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2666652Reviewed-by: 's avatarFumitoshi Ukai <ukai@google.com>
Reviewed-by: 's avatarYoshisato Yanagisawa <yyanagisawa@google.com>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
      8bb35133
    • Takuto Ikuta's avatar
      Revert "win toolchain: Prepare downloader for windows sdk dir switch" · 98cc028b
      Takuto Ikuta authored 
      This reverts commit e72789f5.

Reason for revert: 
This broke goma builder.

Original change's description:
> win toolchain: Prepare downloader for windows sdk dir switch
>
> crrev.com/c/2655836 tries to move the Windows SDK from
> "win_sdk" to "Windows Kits/10".
>
> get_toolchain_if_necessary.py (in depot_tools) saves the path to the SDK to
> third_party/depot_tools/win_toolchain/data.json which then gets copied
> by a script in the chromium repo to build/win_toolchain.json.
> For the SDK move to work, chromium's pinned depot_tools
> must write the new SDK path when rolling in the new toolchain package.
> This change makes depot_tools handle win packages that have the
> windows sdk either win "win_sdk" or in "Windows Kits\10".
>
> The plan is:
>
> 1. Land this change, which can handle both path styles
> 2. Wait for depot_tools in chromium to update
> 3. Then roll to a win toolchain package with the new layout
>
> In a few years, when we no longer need the old layout,
> we can remove this detection code again and assume the new layout.
>
> Bug: 1173176
> Change-Id: Iaefc5c16685d3dbfff87a3e50a7b20b457366e44
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2666429
> Commit-Queue: Nico Weber <thakis@chromium.org>
> Auto-Submit: Nico Weber <thakis@chromium.org>
> Reviewed-by: Bruce Dawson <brucedawson@chromium.org>

TBR=thakis@chromium.org,brucedawson@chromium.org,infra-scoped@luci-project-accounts.iam.gserviceaccount.com

Change-Id: I8d133f4fa199f81978f5245bdb2155c62bc9cc88
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1173176
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2666651Reviewed-by: 's avatarTakuto Ikuta <tikuta@chromium.org>
      98cc028b
    • Nico Weber's avatar
      win toolchain: Prepare downloader for windows sdk dir switch · e72789f5
      Nico Weber authored 
      crrev.com/c/2655836 tries to move the Windows SDK from
"win_sdk" to "Windows Kits/10".

get_toolchain_if_necessary.py (in depot_tools) saves the path to the SDK to
third_party/depot_tools/win_toolchain/data.json which then gets copied
by a script in the chromium repo to build/win_toolchain.json.
For the SDK move to work, chromium's pinned depot_tools
must write the new SDK path when rolling in the new toolchain package.
This change makes depot_tools handle win packages that have the
windows sdk either win "win_sdk" or in "Windows Kits\10".

The plan is:

1. Land this change, which can handle both path styles
2. Wait for depot_tools in chromium to update
3. Then roll to a win toolchain package with the new layout

In a few years, when we no longer need the old layout,
we can remove this detection code again and assume the new layout.

Bug: 1173176
Change-Id: Iaefc5c16685d3dbfff87a3e50a7b20b457366e44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2666429
Commit-Queue: Nico Weber <thakis@chromium.org>
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: 's avatarBruce Dawson <brucedawson@chromium.org>
      e72789f5
  3. 01 Feb, 2021 4 commits
  5. 30 Jan, 2021 1 commit
  7. 29 Jan, 2021 7 commits
  9. 28 Jan, 2021 4 commits
  11. 27 Jan, 2021 5 commits
  13. 26 Jan, 2021 6 commits
  15. 25 Jan, 2021 5 commits
  17. 22 Jan, 2021 3 commits
  19. 21 Jan, 2021 2 commits