- 09 Sep, 2011 2 commits
-
-
maruel@chromium.org authored
stderr is not redirected by default. stdout is not allowed. Both were oversight. Do not override stdin=None in case the user would response to stderr output for example. Increase test coverage. R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/7860041 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100456 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
TBR=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/7860038 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100393 0039d316-1c4b-4281-b951-d872f2087c98
-
- 08 Sep, 2011 2 commits
-
-
maruel@chromium.org authored
TBR=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/7787008 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100270 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
Remove reference to shutil while at it. R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/7851001 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100182 0039d316-1c4b-4281-b951-d872f2087c98
-
- 26 Apr, 2011 1 commit
-
-
maruel@chromium.org authored
When the tree is not versionned, svn can return <info></info>. R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/6899052 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@83020 0039d316-1c4b-4281-b951-d872f2087c98
-
- 07 Apr, 2011 3 commits
-
-
maruel@chromium.org authored
Reapply r80770 "Switch from xml.dom.minidom to xml.etree". TBR=dpranke@chromium.org BUG= TEST= git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80785 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
Throws exceptions on mac. R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/6811020 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80771 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
The reason of this change (beside deleting 30 lines) is to fix pylint on Mac. For an unknown reason, it was dying here trying to process the minidom import. R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/6799021 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80770 0039d316-1c4b-4281-b951-d872f2087c98
-
- 06 Apr, 2011 1 commit
-
-
maruel@chromium.org authored
Also fix a few issues found along the way. Tests had regressed a lot. Add a lot of tweaks to make most test pass. R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/6792060 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80618 0039d316-1c4b-4281-b951-d872f2087c98
-
- 05 Apr, 2011 1 commit
-
-
maruel@chromium.org authored
TBR=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/6792050 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80452 0039d316-1c4b-4281-b951-d872f2087c98
-
- 04 Apr, 2011 1 commit
-
-
maruel@chromium.org authored
Make sure every site that catches gclient_utils.Error also catch subprocess2.CalledProcessError. BUG= TEST= Review URL: http://codereview.chromium.org/6691034 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80339 0039d316-1c4b-4281-b951-d872f2087c98
-
- 24 Mar, 2011 1 commit
-
-
maruel@chromium.org authored
Generate a fake diff instance of crashing. R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/6721030 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@79290 0039d316-1c4b-4281-b951-d872f2087c98
-
- 18 Mar, 2011 2 commits
-
-
bauerb@chromium.org authored
BUG=none TEST=manual Review URL: http://codereview.chromium.org/6598068 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@78741 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
Split presubmit_support.Main() in two to make it simpler. Handle better the case with unversioned files and add a unit test. R=dpranke@chromium.org Review URL: http://codereview.chromium.org/6674059 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@78700 0039d316-1c4b-4281-b951-d872f2087c98
-
- 15 Mar, 2011 1 commit
-
-
maruel@chromium.org authored
Revert the order back to deleting then svn revert'ing, which is safer than the reverse. Document a bit better the behavior. R=dpranke@chromium.org BUG=none TEST=commit queue should die less often Review URL: http://codereview.chromium.org/6681032 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@78224 0039d316-1c4b-4281-b951-d872f2087c98
-
- 09 Mar, 2011 1 commit
-
-
maruel@chromium.org authored
Improve test to make sure svn status comes out clean. TEST=improved unit tests and scm.SVN.Revert() should now do the right thing BUG=none Review URL: http://codereview.chromium.org/6650011 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@77391 0039d316-1c4b-4281-b951-d872f2087c98
-
- 03 Mar, 2011 1 commit
-
-
maruel@chromium.org authored
Add a unit test to catch potential regressions. Remove an old test new code broke. TEST=unit tests BUG=none Review URL: http://codereview.chromium.org/6613025 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@76805 0039d316-1c4b-4281-b951-d872f2087c98
-
- 01 Mar, 2011 1 commit
-
-
bauerb@chromium.org authored
The svn branch heuristic does roughly the same thing git-svn does: We first iterate backwards over the history to find the svn URL (like svn://svn.chromium.org/chrome/trunk/src). Then we go through all defined svn-remote section looking for one where the URL is the root of the svn URL (svn://svn.chromium.org/chrome in that case), and the fetch spec looks like "trunk/src:remotes/origin/trunk". If the base URL + left part (trunk/src) is the full URL, the right part (remotes/origin/trunk) is the git ref that is updated when we do a `git svn fetch`! This works for git-svn branches that fetch from trunk as well as milestone branches. BUG=none TEST=none Review URL: http://codereview.chromium.org/6597004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@76364 0039d316-1c4b-4281-b951-d872f2087c98
-
- 24 Feb, 2011 2 commits
-
-
maruel@chromium.org authored
from the same repository. TEST=added regression test. BUG=none Review URL: http://codereview.chromium.org/6578029 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@75937 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
To reproduce, svn delete a file, then svn merge -c -N the file to revive it. Also fix a unit test that was broken for a while. TEST=none BUG=none Review URL: http://codereview.chromium.org/6576005 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@75835 0039d316-1c4b-4281-b951-d872f2087c98
-
- 08 Feb, 2011 1 commit
-
-
maruel@chromium.org authored
There is 2 changes while moving the code: - Making externals handling an option. - Not trapping EnvironmentError. This code will be reused by the commit queue. TEST=unit tests BUG=none Review URL: http://codereview.chromium.org/6250177 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@74181 0039d316-1c4b-4281-b951-d872f2087c98
-
- 26 Oct, 2010 2 commits
-
-
maruel@chromium.org authored
TEST=none BUG=none Review URL: http://codereview.chromium.org/4157002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@63886 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
TBR=jochen BUG= TEST= Review URL: http://codereview.chromium.org/4132002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@63832 0039d316-1c4b-4281-b951-d872f2087c98
-
- 20 Sep, 2010 1 commit
-
-
maruel@chromium.org authored
TEST=none BUG=none Review URL: http://codereview.chromium.org/3446014 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@59944 0039d316-1c4b-4281-b951-d872f2087c98
-
- 09 Sep, 2010 2 commits
-
-
maruel@chromium.org authored
Simplify GIT.Capture() code to always redirect stderr by default and always throw an exception on failure. Make gclient_scm_test silent. Replace raise Exception() with raise gclient_utils.Error(). BUG=54084 TEST=none Review URL: http://codereview.chromium.org/3353018 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@58936 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
Added try/except to the places where errors are tolerated. Renamed scm.SVN.CaptureBaseRevision to CaptureRevision and removed CaptureHeadRevision. BUG=54084 TEST=none Review URL: http://codereview.chromium.org/3307016 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@58932 0039d316-1c4b-4281-b951-d872f2087c98
-
- 03 Sep, 2010 1 commit
-
-
cbentzel@chromium.org authored
This starts at 5 seconds (used to be 15) and goes up to ~60 seconds on the tenth round. BUG=None TEST=None Review URL: http://codereview.chromium.org/3326004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@58488 0039d316-1c4b-4281-b951-d872f2087c98
-
- 01 Sep, 2010 2 commits
-
-
maruel@chromium.org authored
BUG=54084 TEST=unit tests Review URL: http://codereview.chromium.org/3338003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@58214 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
Simplify code by removing fail_status Rename print_messages to always Simplify the doc. Review URL: http://codereview.chromium.org/3104036 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@58201 0039d316-1c4b-4281-b951-d872f2087c98
-
- 25 Aug, 2010 1 commit
-
-
maruel@chromium.org authored
This way the function is much more similar to subprocess.call(). Further changes will be done, to be able to convert all the function, to be able to parallelize output without corrupting it. Used pylint to verify call graph correctness, causing some other unrelated changes. TEST=unit tests BUG=none Review URL: http://codereview.chromium.org/3117039 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@57369 0039d316-1c4b-4281-b951-d872f2087c98
-
- 23 Aug, 2010 2 commits
-
-
maruel@chromium.org authored
It will eventually replace 'print_messages' and be used to annotate printed lines when using --jobs. Review URL: http://codereview.chromium.org/3174020 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@57092 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
Original Description: Remove code duplication and improve style. Create a Popen function to reduce code duplication. Use RemoveDirectory where relevant. Make drover slightly more posix friendly. Review URL: http://codereview.chromium.org/3199011 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@57083 0039d316-1c4b-4281-b951-d872f2087c98
-
- 20 Aug, 2010 2 commits
-
-
maruel@chromium.org authored
This reverts commit 850ee065. git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@56894 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
Create a Popen function to reduce code duplication. Use RemoveDirectory where relevant. Make drover slightly more posix friendly. Review URL: http://codereview.chromium.org/3126020 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@56893 0039d316-1c4b-4281-b951-d872f2087c98
-
- 19 Aug, 2010 1 commit
-
-
maruel@chromium.org authored
svn's client uses a different error format for HTTP 502 and I didn't recall how the string was formatted. Luckily enough googlecode fails often enough it wasn't long for me to reproduce the issue. :) TBR=bradnelson Review URL: http://codereview.chromium.org/3143030 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@56675 0039d316-1c4b-4281-b951-d872f2087c98
-
- 18 Aug, 2010 1 commit
-
-
maruel@chromium.org authored
BUG=chromium-os:5305 TEST=gclient sync should be much more resistent Review URL: http://codereview.chromium.org/3132021 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@56565 0039d316-1c4b-4281-b951-d872f2087c98
-
- 16 Aug, 2010 1 commit
-
-
maruel@chromium.org authored
This is towards cleaning up the mess with 'options' in gclient_scm.py. Review URL: http://codereview.chromium.org/3106014 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@56213 0039d316-1c4b-4281-b951-d872f2087c98
-
- 06 Aug, 2010 1 commit
-
-
maruel@chromium.org authored
Review URL: http://codereview.chromium.org/3007040 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@55225 0039d316-1c4b-4281-b951-d872f2087c98
-
- 29 Jun, 2010 1 commit
-
-
gavinp@google.com authored
Right now if you svn cp or svn mv before uploading to rietveld, there's no description in the patch at all of what was done; so you get a diff, but it's for who knows what revision of what prior file to some current version. For code reviews this kinda works (you ask the guy what it was), but for trying to apply patches (ala git patch) this fails badly. This patch tries to add some metadata to the start of a rietveld patch that describes these changes: both to a human (who can read them) and to a potential clever future git-cl (which I'll do next). The metadata looks like this after checking out a test repo, and svn cp -r 1 foo nitz; svn cp bar quux; echo be good>>quux ### BEGIN SVN COPY METADATA #$ svn cp -r 1 foo nitz ### WARNING: note non-trunk copy #$ cp bar quux ### END SVN COPY METADATA Index: nitz Index: quux =================================================================== --- quux (revision 0) +++ quux (working copy) @@ -1,2 +1,3 @@ hi mom hi sister +be good I did a test, and this looks like it works in svn 1.4.4 as well. BUG=none TEST=none Review URL: http://codereview.chromium.org/2824035 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@51121 0039d316-1c4b-4281-b951-d872f2087c98
-
- 18 Jun, 2010 1 commit
-
-
maruel@chromium.org authored
TBR=bradnelson Review URL: http://codereview.chromium.org/2850014 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@50232 0039d316-1c4b-4281-b951-d872f2087c98
-