Commits · 88f9c40e0ccefb491790888a703c857b0c3ec6d1 · Linshizhi / Chromium_Depot_tools

22 Mar, 2018 5 commits

gclient eval: Expand vars while parsing DEPS files · 88f9c40e

Edward Lesmes authored Mar 22, 2018

Introduce a Parse function that takes care of expanding vars while parsing
the DEPS file.

It wraps Exec and exec calls, and supports deferring the expansion until
later, so gclient flatten gets access to the unexpanded version.

Bug: 821199
Change-Id: I943b021cc4474c9cda67b3816b841dd8ada3f5b2
Reviewed-on: https://chromium-review.googlesource.com/973749
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>

88f9c40e

Trigger recipe roll to pick up . · e8703543

Robert Iannucci authored Mar 22, 2018

To make sure that the following CL actually rolls into downstream recipes:
https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/961865

TBR=nodir@chromium.org, vadimsh@chromium.org

Bug: 821669
Change-Id: Ia530a619e355291a15d849e09c449fc82e31534b
Reviewed-on: https://chromium-review.googlesource.com/976558Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

e8703543

[presubmit_support] Prevent depot_tools' virtualenv from leaking into other repos. · 5025893c

Robert Iannucci authored Mar 19, 2018

Currently in LUCI `git cl` is invoked on chromium_presubmit using vpython. This
means that it operates under the depot_tools .vpython environment (which is
blank).

Some features in presubmit_support allow invocation of python subprocesses, and
previously they would use `sys.executable` (especially on windows, but
occasionally on non-windows as well).

In non-vpython environments, this just picks up the system python and whatever
modules happen to be installed there. Some python unittests work around this on
non-windows systems by having a shebang line which explicitly invokes vpython.

This CL changes presubmit_support so that invocations of 'python', or executions
of '.py' scripts will always end up invoking vpython. In the best case, this will
pick up the invoked scripts' vpython environment. In the worst case, this will
invoke the script under an empty vpython environment (aka "stock python").

R=dpranke@chromium.org, jbudorick@chromium.org, tandrii@chromium.org, tikuta@chromium.org

Bug: 821669
Change-Id: I5d2d5dfd0364022d56833c2c8af4983553a29c7a
Reviewed-on: https://chromium-review.googlesource.com/961865Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

5025893c

gclient sync: Add support to apply gerrit refs. · c621b21a

Edward Lesmes authored Mar 22, 2018

Mimics bot_update's functionality to apply gerrit refs in gclient
via --gerrit-ref flags.
When the patch fails to apply, gclient sync will return exit code 2.

The idea is to move this logic from bot_update to gclient sync to
deal when patches for projects like ANGLE are tried on Chromium bots.
This way the patch is applied before recursively parsing and syncing
ANGLE’s DEPS.chromium file, which doesn't currently happen.

Bug: 643346

Change-Id: I7e2018b3c393a5ac9852b8c3611f906977eeeb18
Reviewed-on: https://chromium-review.googlesource.com/961605Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

c621b21a

Revert "Add debugging info when gclient deletes an old DEPS entry." · 869a2857

Lei Zhang authored Mar 22, 2018

This reverts commit 33bf4953.

Reason for revert: Done debugging.

Original change's description:
> Add debugging info when gclient deletes an old DEPS entry.
> 
> To help figure out why it decided to do so.
> 
> BUG=823586
> 
> Change-Id: I93d7c9f7af6145ee0ebd9f5ad4483f27925e84d6
> Reviewed-on: https://chromium-review.googlesource.com/970082
> Commit-Queue: Lei Zhang <thestig@chromium.org>
> Reviewed-by: Aaron Gable <agable@chromium.org>

TBR=thestig@chromium.org,agable@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 823586
Change-Id: I476cbe423b849582f8684426653f0c08062e89e9
Reviewed-on: https://chromium-review.googlesource.com/974458Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

869a2857

21 Mar, 2018 5 commits

gclient eval: Get rid of global_scope, local_scope and functions other than Var. · 9f531298

Edward Lesmes authored Mar 21, 2018

Since we only support Var, and Var only does one thing, we hard code that
into the parser. Then, we don't need global_scope.

local_scope hasn't been needed for a while.

Bug: 760633
Change-Id: I21b171a8b71e7dcaf8e29c780ca88b9f46f368e8
Reviewed-on: https://chromium-review.googlesource.com/972611Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

9f531298

bot_update: don't repack, don't gc in main repo of builder's checkout. · b3065fb6

Andrii Shyshkalov authored Mar 21, 2018

The main purpose is to avoid running slow and useless operation in
chromium/src checkouts. Ideally, this should be done in every DEPS-ed
repo, too, but that requires substantially more changes in gclient.
Thus, this CL provides biggest bang for the buck.

Example led build: https://ci.chromium.org/swarming/task/3c62efb31ed3a910?server=chromium-swarm.appspot.com

R=hinoka@chromium.org

Bug: 822437
Change-Id: I347d85e5cb5158b77969a755b67ca2289fb39d40
Reviewed-on: https://chromium-review.googlesource.com/973900
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Ryan Tseng <hinoka@chromium.org>

b3065fb6

Add progress indicator that prints a dot on nearly each RPCs request · a68d82cb

Sergiy Byelozyorov authored Mar 21, 2018

R=tandrii@chromium.org

Change-Id: Id4fa494c8225c8edefecba064445504065581478
Reviewed-on: https://chromium-review.googlesource.com/966564
Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>

a68d82cb

Add ability to filter issues precisely by comment publication date · 1b7d56d2

Sergiy Byelozyorov authored Mar 21, 2018

This also parallelises get_changes, get_issues and get_reviews.

R=tandrii@chromium.org

Change-Id: I8ebc69fc6e59637ec576057abf1d9068a340b71a
Reviewed-on: https://chromium-review.googlesource.com/966563
Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

1b7d56d2

presubmit_unittest.py: use LUCI for the optional GPU tests on Mac · ba51bb3c

Corentin Wallez authored Mar 20, 2018

BUG=chromium:815092

Change-Id: I3eeb6332be4a2cd8b8d1be6b57859895458a5067
Reviewed-on: https://chromium-review.googlesource.com/971349Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>

ba51bb3c

20 Mar, 2018 4 commits

Reland "gclient: Add commands to edit dependencies and variables in DEPS" · 6f64a052

Edward Lesmes authored Mar 20, 2018

This is a reland of 7f4c905f

Original change's description:
> gclient: Add commands to edit dependencies and variables in DEPS
> 
> Adds 'gclient setvar' and 'gclient setdep' commands to edit variables
> and dependencies in a DEPS file.
> 
> Bug: 760633
> Change-Id: I6c0712cc079dbbbaee6541b7eda71f4b4813b77b
> Reviewed-on: https://chromium-review.googlesource.com/950405
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
> Reviewed-by: Aaron Gable <agable@chromium.org>

Bug: 760633
Change-Id: Ia46c74d02e5cc3b67517dfa248f597cb3d98ef3d
Reviewed-on: https://chromium-review.googlesource.com/969457
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>

6f64a052

[gclient] Use a single CIPD root for an entire gclient checkout. · d3ba72bb

John Budorick authored Mar 20, 2018

gclient previously used a CIPD root per DEPS file. This didn't work
in cases in which a DEPS file wanted to specify a CIPD package outside
of its directory hierarchy, though, as is the case with buildspecs.

Bug: 755920
Change-Id: I0d6c3db567f17f9171c0feaaf9ed6bc64db22757
Reviewed-on: https://chromium-review.googlesource.com/955933
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
Reviewed-by: Michael Moss <mmoss@chromium.org>

d3ba72bb

Add debugging info when gclient deletes an old DEPS entry. · 33bf4953

Lei Zhang authored Mar 20, 2018

To help figure out why it decided to do so.

BUG=823586

Change-Id: I93d7c9f7af6145ee0ebd9f5ad4483f27925e84d6
Reviewed-on: https://chromium-review.googlesource.com/970082
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>

33bf4953

Remove nested ifs in GClientSmokeBase.splitBlock(). · 083471af

Lei Zhang authored Mar 20, 2018

This helps make it slightly easier to understand.

Change-Id: Iaf68409374be67e03d5708b409c1ad9229c68b1d
Reviewed-on: https://chromium-review.googlesource.com/970161Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

083471af

19 Mar, 2018 2 commits

Revert "gclient: Add commands to edit dependencies and variables in DEPS" · 0b89935a

Edward Lesmes authored Mar 19, 2018

This reverts commit 7f4c905f.

Reason for revert:
When running "gclient sync" on a V8 checkout, it says:

  File "/work/chrome/depot_tools/gclient.py", line 995, in run
   self.ParseDepsFile()
 File "/work/chrome/depot_tools/gclient.py", line 874, in ParseDepsFile
   self._postprocess_deps(deps, rel_prefix), use_relative_paths)
 File "/work/chrome/depot_tools/gclient.py", line 660, in _postprocess_deps
   dval['condition'], self.condition)
TypeError: '_NodeDict' object does not support item assignment

on the recursive descent into third_party/android_tools/DEPS. Any chance that's related to https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/950405 ?

Original change's description:
> gclient: Add commands to edit dependencies and variables in DEPS
> 
> Adds 'gclient setvar' and 'gclient setdep' commands to edit variables
> and dependencies in a DEPS file.
> 
> Bug: 760633
> Change-Id: I6c0712cc079dbbbaee6541b7eda71f4b4813b77b
> Reviewed-on: https://chromium-review.googlesource.com/950405
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
> Reviewed-by: Aaron Gable <agable@chromium.org>

TBR=agable@chromium.org,ehmaldonado@chromium.org

Change-Id: If58f6b15d31b19fc53294f1e41d26b4e684a2cf9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 760633
Reviewed-on: https://chromium-review.googlesource.com/969165Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

0b89935a

gclient: Add commands to edit dependencies and variables in DEPS · 7f4c905f

Edward Lesmes authored Mar 19, 2018

Adds 'gclient setvar' and 'gclient setdep' commands to edit variables
and dependencies in a DEPS file.

Bug: 760633
Change-Id: I6c0712cc079dbbbaee6541b7eda71f4b4813b77b
Reviewed-on: https://chromium-review.googlesource.com/950405
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>

7f4c905f

16 Mar, 2018 1 commit

Add option for printing changes grouped by issue · 544b7446

Sergiy Byelozyorov authored Mar 16, 2018

This also adds support for V8 project on issue tracker.

R=tandrii@chromium.org

Change-Id: Ie90ae664573d36030267b639e8a55bc349cad872
Reviewed-on: https://chromium-review.googlesource.com/966623
Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

544b7446

14 Mar, 2018 4 commits

presubmit_unittest.py: use LUCI for the optional GPU tests on Linux · a3a80b69

Corentin Wallez authored Mar 14, 2018

TBR=maruel@chromium.org

BUG=chromium:815092

Change-Id: I2d9e63000cbe48fea636a3d0f6fd69f040495697
Reviewed-on: https://chromium-review.googlesource.com/962994Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>

a3a80b69

[led] Bump to support CIPD Recipes. · 1c9c0034

Robert Iannucci authored Mar 14, 2018

TBR=tandrii@chromium.org

Bug: 811974
Change-Id: I1ace75471dfbe2798c7c848f76d6607b34ff1033
Reviewed-on: https://chromium-review.googlesource.com/962082
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

1c9c0034

[git_cl] Remove rietveld CMDland implementation. · 2e73d438

Robert Iannucci authored Mar 14, 2018

R=agable@chromium.org, tandrii@chromium.org

Change-Id: I2bfed54a9a1bde3335340e5949eac313c3fdda32
Reviewed-on: https://chromium-review.googlesource.com/961970
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

2e73d438

[bot_update] Remove support for rietveld patches. · 456b0d64

Robert Iannucci authored Mar 14, 2018

R=agable@chromium.org, tandrii@chromium.org

Recipe-Nontrivial-Roll: build
Recipe-Nontrivial-Roll: infra
Change-Id: I518335e7b8fdce316b5566caccd3c4c7c2ae741a
Reviewed-on: https://chromium-review.googlesource.com/960161
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

456b0d64

13 Mar, 2018 2 commits

Roll recipe dependencies (trivial). · 06493714

recipe-roller authored Mar 13, 2018

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/d17fa9994d031c525a5a732218667d41b827c8ec Use more common term in recipe-api docu (machenbach@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Idef0e59985a9500e49b5a313be021f1bb88a1be4
Reviewed-on: https://chromium-review.googlesource.com/961082
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>

06493714

Roll recipe dependencies (trivial). · 68de9f34

recipe-roller authored Mar 13, 2018

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/5c6e39ec6dee4d110839f61767a361979ae13dda [bundle] Copy file data instead of symlinks. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I92193f0989929c7d75c4bbb09c2ed1706d008a46
Reviewed-on: https://chromium-review.googlesource.com/959695
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>

68de9f34

12 Mar, 2018 2 commits

[bot_update] Remove rietveld recipe_module. · f4c2703a

Robert Iannucci authored Mar 10, 2018

R=agable@chromium.org, tandrii@chromium.org

Recipe-Nontrivial-Roll: build
Change-Id: Ic4c2dc7a50d389f18f3e0c1de332cb1a0ab376a9
Reviewed-on: https://chromium-review.googlesource.com/957834
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>

f4c2703a

[bot_update] Remove use_site_config_creds. · 3a8b0908

Robert Iannucci authored Mar 10, 2018

This method hasn't been supported for a long time now (and besides, its
only for Rietveld).

R=agable@chromium.org, tandrii@chromium.org

Recipe-Manual-Change: infra
Change-Id: Ie6e63834dca67962db29f2cb407950ed85db55a7
Reviewed-on: https://chromium-review.googlesource.com/957832Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

3a8b0908

08 Mar, 2018 1 commit

Roll recipe dependencies (trivial). · 44048672

recipe-roller authored Mar 08, 2018

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/ee2763eca5218a9257efb06bef385622f0fc8561 Add builder_id property to BuildBucketApi (kjharland@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I969a55f5f633d343690ea4255af82ce77df76f73
Reviewed-on: https://chromium-review.googlesource.com/956423
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>

44048672

07 Mar, 2018 2 commits

gclient: Give priority to URL over paths when specifying revisions. · 53014653

Edward Lesmes authored Mar 07, 2018

e.g. when specifying both '--revision src@<something>' and
'--revision <src_gerrit_repo>@<some_gerrit_ref>', gclient will sync to
'<some_gerrit_ref>' instead of '<something>'.

This is useful when specifying which gerrit change to patch, which
should take priority over other revision specifications.

Bug: chromium:643346
Change-Id: Ibc21ede355b56e4da966f38f144ce6f6f1743403
Reviewed-on: https://chromium-review.googlesource.com/949981
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>

53014653

gclient revinfo: Add an option to output a JSON file. · c2960246

Edward Lesmes authored Mar 07, 2018

Add a --output-json flag to gclient revinfo so is easier for other
programs to process its output.

Bug: None
Change-Id: Ic120e7a279f3ed537ead624ab9bfd1f141485487
Reviewed-on: https://chromium-review.googlesource.com/952206
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>

c2960246

06 Mar, 2018 4 commits

git-cl: respect http.cookieFile for finding gitcookies · 8797cab3

Aaron Gable authored Mar 06, 2018

This allows people to configure their gitcookies file to be
whereever they want. As long as it actually exists and has
credentials in it, we'll accept it, just like git itself.

Change-Id: I4aa4806ddca0e61b28b003b0d3bc486407c13ab4
Reviewed-on: https://chromium-review.googlesource.com/951917Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>

8797cab3

Update git_hyper_blame_test for git 2.16 · ccd62f4e

Aaron Gable authored Mar 06, 2018

Change-Id: I9e45c55d1a57a7c275d0524af60c8f644717eb25
Reviewed-on: https://chromium-review.googlesource.com/952076
Commit-Queue: Aaron Gable <agable@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

ccd62f4e

Roll recipe dependencies (trivial). · 64f2fabf

recipe-roller authored Mar 06, 2018

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/5906d3e7a321c743d49f29a995040c41cc08ec24 [recipe_modules][time] Add ms_since_epoch method (kjharland@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ifabc93da366e23f18f8ab1d12ff0bbfcecb2bbbb
Reviewed-on: https://chromium-review.googlesource.com/952302Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

64f2fabf

gclient revinfo: Add options to filter by path or url. · daa76d2f

Edward Lesmes authored Mar 06, 2018

Add --path and --url options to show only the dependencies that match
one of the given paths or URLs.

Bug: None
Change-Id: I12c205545b7ce54b56abcd62f9bf1db229b4fd77
Reviewed-on: https://chromium-review.googlesource.com/951963Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

daa76d2f

03 Mar, 2018 1 commit

Roll recipe dependencies (trivial). · 462839ea

recipe-roller authored Mar 03, 2018

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/b10224f3b916ec7aac1e6edbfc0fefa9635d15df Reserve pipe in step names. (nodir@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I7f12d43fa7660186e78eb2cd1c9c9d3b05438171
Reviewed-on: https://chromium-review.googlesource.com/947622Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

462839ea

28 Feb, 2018 1 commit

[cipd] Bump cipd version to ae28364c740acff97ae118adcb2808b6cb5129c5. · d0de9616

Robert Iannucci authored Feb 28, 2018

This allows the cipd client to process refs with slashes in them.

Also it is compiled with cgo on OSX, which should help with DNS
resolution errors that happen on some machines.

R=vadimsh@chromium.org

Bug: 811974, 803673
Change-Id: If298db5cfe0e10e3734deb4215bf82b95ff5e09e
Reviewed-on: https://chromium-review.googlesource.com/940521
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>

d0de9616

27 Feb, 2018 3 commits

Update windows git to 2.16.2 · 9cb8fad0

Jao-ke Chin-Lee authored Feb 27, 2018

Bug: 811681
Change-Id: I2ef7238baececcf87643cba78d72622922ad881c
Reviewed-on: https://chromium-review.googlesource.com/939991Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org>

9cb8fad0

Update windows bleeding-edge git to 2.16.2 · 53a62911

Aaron Gable authored Feb 27, 2018

Bug: 811681
Change-Id: Id7b276274ba6e2e52fba9a19e6c15d5fd972c178
Reviewed-on: https://chromium-review.googlesource.com/919530
Commit-Queue: Aaron Gable <agable@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

53a62911

Gerrit: Enable overriding step_test_data · 9b4d0c77

Michael Achenbach authored Feb 27, 2018

Bug: v8:7419
Change-Id: I49ad9358b9487b76503c3c1f4d6838aa0dd42736
Reviewed-on: https://chromium-review.googlesource.com/938969Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>

9b4d0c77

26 Feb, 2018 1 commit

[cipd] Support cipd dependencies hooked under same directory · 6f83031f

Shenghua Zhang authored Feb 26, 2018

When hooks multiple cipd packages under same directory, gclient would
pop up error that same directory name appears multiple times in deps
section. This CL overrides verify_validity for CipdDependency to
support multiple packages hooked in same directory.

Bug:812386
Change-Id: Ia4f1fe0e3c8481c9b06c1d22b6e98d98e1e4c309
Reviewed-on: https://chromium-review.googlesource.com/920686
Commit-Queue: Shenghua Zhang <shenghuazhang@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>

6f83031f

23 Feb, 2018 1 commit

[cipd] Match version to vars value supporting in gclient.py · f438ff74

Shenghua Zhang authored Feb 23, 2018

For now 'version' of packages only support string like 'version:27.0.5'.
It is helpful to support version to match vars value, e.g.
Var('tool_version'), especially useful when version numbers could be
modified via api. This change won't affect versions with string format.

Change-Id: I40b389b528f04712798b08f1455869cab2ec54c9
Reviewed-on: https://chromium-review.googlesource.com/935666Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Shenghua Zhang <shenghuazhang@chromium.org>

f438ff74

22 Feb, 2018 1 commit

git cl try: support custom --category. · f9648b5c

Andrii Shyshkalov authored Feb 22, 2018

Over last two weeks of running tryjobs on CLs of others, I found
this very useful. This CL also simplifies code.

R=agable@chromium.org

Change-Id: I5c7ce0d311b1ca024b92227dbec54e5197205c62
Reviewed-on: https://chromium-review.googlesource.com/930742Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

f9648b5c