- 05 Oct, 2018 6 commits
-
-
Robert Iannucci authored
This should allow better integration with buildbucket named cache support. Since this was already parameterized it shouldn't actually break anything; previously the directory would be deleted on every run, now it will still be deleted on every run (but we can add a buildbucket named cache entry for it to preserve it). R=tandrii@chromium.org, vadimsh@chromium.org Bug: 877775 Change-Id: I1184fb59a3ed18bfda5fcb288903201b01527096 Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: infra Reviewed-on: https://chromium-review.googlesource.com/c/1263861 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
Vadim Shtayura <vadimsh@chromium.org>
-
Edward Lemur authored
It has been True by default for a while, and there is no need to override it. Bug: 891917 Change-Id: I2598a2230b0ea38a647a533757331c541b871971 Reviewed-on: https://chromium-review.googlesource.com/c/1260057Reviewed-by:
-
Eric Boren authored
Bug: skia:8394 Change-Id: I928eaec8459a5905360ce760c6361e4554852b44 Reviewed-on: https://chromium-review.googlesource.com/c/1261796Reviewed-by:
-
Ryan Tseng authored
Picks up https://chromium-review.googlesource.com/c/1260068 Bug: 891925 Change-Id: If2df9ea7ce2d1bcbaca8533935f6e6d30dcd8810 Reviewed-on: https://chromium-review.googlesource.com/c/1263015Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/840950f4bfb6469b4ff72ae4e54ab5c0f5e71116 [cipd] Fix typo in pkg-deploy method. (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I5525b0182f7d6395cf66186fba4058dfc0d61496 Reviewed-on: https://chromium-review.googlesource.com/c/1263596 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by:
Recipe Roller <recipe-roller@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/9f1afcb08b95a9c2cbae653dd320cd84d62287ff raw_io: pipe placeholder name through for input placeholders. (jbudorick@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I5038f06949f8865afb59e614736923ba29547085 Reviewed-on: https://chromium-review.googlesource.com/c/1263595Reviewed-by:
-
- 04 Oct, 2018 3 commits
-
-
Edward Lemur authored
Bug: 882611 Change-Id: I72646544a164f557ea7d53e0ce0f16d663618a98 Reviewed-on: https://chromium-review.googlesource.com/c/1255446Reviewed-by:
-
Asanka Herath authored
Revision 51049267 removed git-crup which orphaned git-crsync whose only purpose in life is to invoke git-crup. Change-Id: Ic8594150692106d8c6326004adea8ce2977f221d Reviewed-on: https://chromium-review.googlesource.com/c/1262117Reviewed-by:
-
Vadim Shtayura authored
This CL basically replaces "skip if is_gce" with "skip if default auth method is not gitcookies". This presumable makes 'git cl' work on LUCI in a consistent manner. Before, it worked only if the LUCI bot happened to also be GCE bot. R=tandrii@chromium.org BUG=891755 Change-Id: I2caa219a4082438a5e026e728bfb62f46a0c80fd Reviewed-on: https://chromium-review.googlesource.com/c/1260053 Commit-Queue: Vadim Shtayura <vadimsh@chromium.org> Reviewed-by:
-
- 03 Oct, 2018 4 commits
-
-
Oleh Prypin authored
Bug: chromium:836566 Change-Id: I752633cd0f5334b4592e1a1f1d4506bf89c7716d Reviewed-on: https://chromium-review.googlesource.com/1257841Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Oleh Prypin <oprypin@google.com>
-
Aiden Benner authored
Parses git diff for changed python files in a method similar to clang-diff and feeds the resulting line ranges into yapf. Also sets the default style to the yapf file included in depot tools by searching parent directories of each changed file to find a yapf style config (.style.yapf). If none is found the default style file will be the chromium .style.yapf included in depot tools. Note: Even if line ranges are specified, yapf will fix indentation issues for the entire file. This is intended see https://github.com/google/yapf/issues/499 This may cause some issues if git cl format is run on a file with lots of indentation issues or on a file or when run on a third_party file that is formatted with pep8 and does not include a .style.yapf and may make many more changes then the user expects. Still undecided on whether this should be turned on by default but if not I think the non --full support is a positive change anyways. Bug:846432 Change-Id: Ib85797f4a8e1021870901ff465ec10f7e70deb87 Reviewed-on: https://chromium-review.googlesource.com/1249642 Commit-Queue: Aiden Benner <abenner@google.com> Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org>
-
Bruce Dawson authored
Nina supports -C out/Default and -Cout/Default to specify the build directory so autoninja should also. This change adds that support. Bug: 890744 Change-Id: I5e824242ed4b333ac99f1ee9a649ffcfa03a812e Reviewed-on: https://chromium-review.googlesource.com/c/1257586Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
-
Robert Iannucci authored
R=tandrii@chromium.org, vadimsh@chromium.org Change-Id: I1f235cf959e92e4430cff7dcd0d292db1721319d Reviewed-on: https://chromium-review.googlesource.com/c/1257585Reviewed-by:
-
- 02 Oct, 2018 1 commit
-
-
Dirk Pranke authored
bradleynelson is no longer active in depot_tools. agable@ is unavailable for the rest of 2018. Change-Id: Idf5be1db84b8f6857f9edd7ed16c56d4c89f81ef Reviewed-on: https://chromium-review.googlesource.com/1256170Reviewed-by:
-
- 27 Sep, 2018 4 commits
-
-
Adrienne Walker authored
Also, sort all the gerrit instances by url for clarity. Change-Id: I89aea98f75de33e8673c929fb07df3b686ea6c15 Reviewed-on: https://chromium-review.googlesource.com/1228659 Commit-Queue: enne <enne@chromium.org> Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/7d52a83204be2083edfc82042b13769846db9dff Update the recipes user guide to use post_process. (gbeaty@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I61abce116cb3d914f057cdf33eb55579a82b49d2 Reviewed-on: https://chromium-review.googlesource.com/1249641Reviewed-by:
-
Andrii Shyshkalov authored
R=smut@google.com Bug: 881860 Change-Id: I59c337384891f02dbd2cc776318803ac556843ca Reviewed-on: https://chromium-review.googlesource.com/1247584Reviewed-by:
smut <smut@google.com> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/dc1bf00db5252bb54dd09745865c3160778a882d Fix cmd error in StepCommandContains check (aluo@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ic85a74dbbbf78b069d29b26154e9321c96b36cea Reviewed-on: https://chromium-review.googlesource.com/1247821Reviewed-by:
-
- 26 Sep, 2018 1 commit
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/65fffecb2f6a041d71107292b1453a92ab1127fc Add post_process functions for asserting on a step's command. (gbeaty@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ie68b5d385f6455604d95d89d0b1686e91969c0b2 Reviewed-on: https://chromium-review.googlesource.com/1247041Reviewed-by:
-
- 25 Sep, 2018 3 commits
-
-
Andrii Shyshkalov authored
This removes 1 RPC when tbr-ing second or later patchset. Since tests cover TBR only in first upload, there are no test changes. Since adding test is real PITA here, keep them as is. R=ehmaldonado Change-Id: I90801b06727ce2131a703d6cd6c24ffad798bc8a Reviewed-on: https://chromium-review.googlesource.com/1242212Reviewed-by:
-
Andrii Shyshkalov authored
R=ehmaldonado Change-Id: Ie5522283e84bdec9d98e236577eaad568816519b Reviewed-on: https://chromium-review.googlesource.com/1242211Reviewed-by:
-
Andrii Shyshkalov authored
This will cycle through known gerrit mirrors for chromium-review host if Gerrit HTTP RPC results in 404 after successful initial git push refs/for/refs/... Tested locally by intentionally using wrong change number (2000000): $ PATH=`pwd`:$PATH git cl upload --bypass-hooks ... remote: Processing changes: refs: 1, new: 1, done remote: SUCCESS remote: New Changes: remote: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1227440 * [new branch] ea9aea5faa85b4b289b7add4bc6f4d5dd6a01caf -> refs/for/refs/heads/master%wip,m=Initial_upload,hashtag=git-cl WARNING:root:404 NotFound error occurred while querying POST https://chromium-review.googlesource.com/a/changes/chromium%2Ftools%2Fdepot_tools~2000000/revisions/current/review: Not Found WARNING:root:404 NotFound error occurred while querying POST https://ap1-mirror-chromium-review.googlesource.com/a/changes/chromium%2Ftools%2Fdepot_tools~2000000/revisions/current/review: Not Found WARNING:root:404 NotFound error occurred while querying POST https://us1-mirror-chromium-review.googlesource.com/a/changes/chromium%2Ftools%2Fdepot_tools~2000000/revisions/current/review: Not Found ^C Bug: 881860 Change-Id: Iac7dbe4e35052007650a7a2646a394caed6bd400 Reviewed-on: https://chromium-review.googlesource.com/1227441 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
-
- 24 Sep, 2018 5 commits
-
-
Robert Iannucci authored
TBR=tandrii@chromium.org, vadimsh@chromium.org Bug: 875089 Change-Id: Ia48c7c67df8bdbd9bc0573406bd9f56f6cfe5d49 Reviewed-on: https://chromium-review.googlesource.com/1241677Reviewed-by:
-
Gabriel Charette authored
This reverts https://chromium-review.googlesource.com/1173069 It breaks my_activity.py on Windows. R=iannucci@chromium.org, rrangel@chromium.org Bug: 888641 Change-Id: I353489e52155d40e48e63819dc3016cf7dd59277 Reviewed-on: https://chromium-review.googlesource.com/1241133Reviewed-by:
-
Andy Perelson authored
This reverts commit ea4301e5. We now have many reponse headers, stopping contributions until and unless we are asked for more as part of debugging git cl upload issues. R=tandrii@chromium.org Bug: 881860 Change-Id: Ic3524aa93f146cebd882efe30b2e3f110cf74838 Reviewed-on: https://chromium-review.googlesource.com/1241613Reviewed-by:
-
Sergiy Byelozyorov authored
R=ehmaldonado@chromium.org, machenbach@chromium.org Bug: 878303 Change-Id: Ic387bbdc9e8ee4b27b17505ca53e8873e20e4cda Reviewed-on: https://chromium-review.googlesource.com/1238571Reviewed-by:
-
Andrii Shyshkalov authored
--completed-issues lists only monorail issues which are owned by the user and have status Fixed|Verified. R=sergiyb@chromium.org Change-Id: I42737bb6ef81ffa463eedee209a2993f68b57d3a Reviewed-on: https://chromium-review.googlesource.com/1227445 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org>
-
- 21 Sep, 2018 3 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/da81755358cf32a496ed8a9eddf6ec6d4f0efd18 post_process: Add StepCommandContains check. (jbudorick@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I8e3f14556e0ae66b3c5f6698be601e5b8930cad4 Reviewed-on: https://chromium-review.googlesource.com/1239096 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/ad0e2563a79f19f916cf2939811a2019dec16386 Improve local execution of recipes (martiniss@google.com) https://crrev.com/d5fd7cc14d7f0a82d1358617f1ec94c4417ec85e [buildbucket] Split try_build/ci_build (nodir@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I47055f996a36b2b9b39de7142d062b9c59be429d Reviewed-on: https://chromium-review.googlesource.com/1239095 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by:
-
Nodir Turakulov authored
This reverts commit 7e301cff. Reason for revert: internal builds failed, e.g. bugdroid Original change's description: > [gclient] Use canonical URLs in solutions > > Strip ".git" suffix from all solution URLs. > > Recipe-Nontrivial-Roll: build > Recipe-Nontrivial-Roll: build_limited_scripts_slave > Recipe-Nontrivial-Roll: infra > Recipe-Nontrivial-Roll: release_scripts > Bug: 877161 > Change-Id: I0cb9cc512fdd9cc5e53ade6bc1d725dc84f7563d > Reviewed-on: https://chromium-review.googlesource.com/1237332 > Reviewed-by: Stephen Martinis <martiniss@chromium.org> > Commit-Queue: Nodir Turakulov <nodir@chromium.org> TBR=nodir@chromium.org,tandrii@chromium.org,martiniss@chromium.org,jbudorick@chromium.org Change-Id: Ie24e10844ceb89071c9e665f2aa7dde9f9bf6e6c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 877161 Reviewed-on: https://chromium-review.googlesource.com/1237423Reviewed-by:
-
- 20 Sep, 2018 7 commits
-
-
Nodir Turakulov authored
Strip ".git" suffix from all solution URLs. Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: build_limited_scripts_slave Recipe-Nontrivial-Roll: infra Recipe-Nontrivial-Roll: release_scripts Bug: 877161 Change-Id: I0cb9cc512fdd9cc5e53ade6bc1d725dc84f7563d Reviewed-on: https://chromium-review.googlesource.com/1237332Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Nodir Turakulov <nodir@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/66dfa7cca67be5376d6cb54b462e9ccd832e4f01 [buildbucket] Add gitiles_commit shortcut (nodir@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Icc8a9462ec44431c60f71a22f6ecc4d82aaa1e26 Reviewed-on: https://chromium-review.googlesource.com/1236897Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/39df254c20b7052fed669e3319036b20f96e75e3 [buildbucket] Fix typo. (nodir@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I566c81d35832b76a43e9bd54838bb6f95a0d8bad Reviewed-on: https://chromium-review.googlesource.com/1236896Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/673743d3e861ad9c6d9a8cc71088f4be7d01a1bb [buildbucket] add builder_name (nodir@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I8aa6eb66e991d5ec5ec556a3fa3b6ea43648fc40 Reviewed-on: https://chromium-review.googlesource.com/1236895Reviewed-by:
-
Dirk Pranke authored
Hopefully this will also actually speed up downloads like it claims it will :). Bug: 875100 Change-Id: I712df6272135b1fa3b1f32095916b18128644718 Reviewed-on: https://chromium-review.googlesource.com/1179078Reviewed-by:
-
Sidney San Martín authored
These can just be from not having a network connection. Bug: 887540 Change-Id: Ie025cc278a4633d688bfb34544ecaaacb2df1bad Reviewed-on: https://chromium-review.googlesource.com/1236893 Auto-Submit: Sidney San Martín <sdy@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/4232dd9f1c5aa35874d70634ae86f1cc4720bc6a Add documentation for placeholders. (erikchen@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ie2747491eef99bf0227d484be71a54203b02c794 Reviewed-on: https://chromium-review.googlesource.com/1236894Reviewed-by:
-
- 19 Sep, 2018 3 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/ec1f045f324fd25c985a60cdcddb913f82da0490 Add AnnotationContains post processing step (erikchen@chromium.org) https://crrev.com/702c6847b3cc129007d58f1ba864b009e820c11e [buildbucket] Populate created_by from legacy property (nodir@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ifb26c38e87c3789fce58fba5c8a5d0553be6bba3 Reviewed-on: https://chromium-review.googlesource.com/1234978Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/ecba3385f199e9f9aecf783d7ce8d87c23775640 [buildbucket] Add bucket_v1 property (nodir@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I8ed25d6f14e9526c4157a23c9a656c2be612a063 Reviewed-on: https://chromium-review.googlesource.com/1234977 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by:
-
Nodir Turakulov authored
It was superseded by repo_path_map. Bug: 694348 Change-Id: If6b4790290bf2573f2a9367334decf064d382f52 Reviewed-on: https://chromium-review.googlesource.com/1232875 Commit-Queue: Nodir Turakulov <nodir@chromium.org> Auto-Submit: Nodir Turakulov <nodir@chromium.org> Reviewed-by:
-
