Commits · 801b5ddb145f189f301bc824a6b1ac9c109d480e · Linshizhi / Chromium_Depot_tools

16 Nov, 2018 3 commits

[DevTools] Add a fetch config for the inspector_protocol. · 801b5ddb

Johannes Henkel authored Nov 16, 2018

This will facilitate a more standalone development process.
We don't have a DEPS file there yet, but I'm planning
to add a simple one, which for starters will
have gunit. I'll model this mostly after breakpad.
I've tested this fetch config and it appears to work great:

$ mkdir testfetch
$ cd testfetch
$ fetch inspector_protocol

After this there's an src directory in testfetch which
has our sources.

Change-Id: I482d65b3d8e50e9e5a98c4affc7b487a5bd6df53
Reviewed-on: https://chromium-review.googlesource.com/c/1340502
Commit-Queue: Johannes Henkel <johannes@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>

801b5ddb

[led] Update led to latest version. · 6343daaa

Robert Iannucci authored Nov 16, 2018

Fixes issue with bogus secret bytes being included when running
`led get-build`. The server would return "<REDACTED>".encode("base64"),
and led would pass this along to the task, which would fail to decode
it as a proto.

R=nodir@chromium.org, vadimsh@chromium.org

Change-Id: Ie8b33a2dc1f05ddb163465d72ea461f9e6833363
Reviewed-on: https://chromium-review.googlesource.com/c/1340504
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>

6343daaa

[gclient] Make getdep and setdep to provide builtin vars · 5705acab

Eric Boren authored Nov 16, 2018

Bug: 906114
Change-Id: I069cc21343911f7fdb3c91ecbd8fcba53fc8099f
Reviewed-on: https://chromium-review.googlesource.com/c/1340461Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Eric Boren <borenet@chromium.org>

5705acab

15 Nov, 2018 5 commits

[cipd] Roll cipd to allow long paths on Windows · 8ada4d52

Robert Iannucci authored Nov 15, 2018

R=vadimsh@chromium.org

Change-Id: Ibd55035fe62ae710cdce448ec489bf7af06925fd
Reviewed-on: https://chromium-review.googlesource.com/c/1337522
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

8ada4d52

metrics: Spell out PII. · 59127a5d

Edward Lemur authored Nov 15, 2018

Use "personally identifiable information" instead of "PII"
on metrics.README.md.

Tbr: tandrii@chromium.org
Bug: None
Change-Id: I5294ab3ddfbc9e6705085a68751a477073cea052
Reviewed-on: https://chromium-review.googlesource.com/c/1337515Reviewed-by: Alan Bram <flyboy@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

59127a5d

autoninja: fix shellcheck warnings · 91de1109

Yoshisato Yanagisawa authored Nov 15, 2018

Change-Id: Ic7ca117435de34400fdd117741d0b321339f8cfd
Reviewed-on: https://chromium-review.googlesource.com/c/1325250
Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>

91de1109

autoninja: quote the arguments when needed. · 43a35d29

Yoshisato Yanagisawa authored Nov 15, 2018

On Windows, without quote, whole return value would be treated as
a command, and the execution would fail.
On Linux and Mac, without quote, if depot_tools is settled under
directories with ' ', command execution would fail because paths are
separated in a wrong way.

To make such a return value work on Linux and Mac, the shell script
started to use eval.

Bug: 902930
Change-Id: I9bb74585294af565988c0b844b6b113a5c685530
Reviewed-on: https://chromium-review.googlesource.com/c/1325249Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org>

43a35d29

autoninja: support -j100 and -tclean. · f66e5510

Yoshisato Yanagisawa authored Nov 15, 2018

Since ninja uses getopt_long to parse the argument, we need to suppose
-j100 and -tclean.
Please see ReadFlags function in:
https://github.com/ninja-build/ninja/blob/master/src/ninja.cc

Change-Id: If61f05e66be546a591549f6f153cce994c972309
Reviewed-on: https://chromium-review.googlesource.com/c/1335428Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>

f66e5510

12 Nov, 2018 2 commits

Roll recipe dependencies (trivial). · ef71a5f0

recipe-roller authored Nov 12, 2018

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/3ec591502d7760fb3d2d64b63d51e6993b5beca6 [doc/user_guide] Add a bit more about recipes.py (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ibf90ca4157cbe0eee09bdc54eef09855b05b2557
Reviewed-on: https://chromium-review.googlesource.com/c/1332567Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

ef71a5f0

[led] Roll led to pick up new kitchen CLI args. · 332c9ff5

Robert Iannucci authored Nov 12, 2018

R=bpastene@chromium.org, nodir@chromium.org

Bug: 904478
Change-Id: I087c4e5a3a88339869573f214e6f415dd54f82aa
Reviewed-on: https://chromium-review.googlesource.com/c/1332027
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>

332c9ff5

10 Nov, 2018 2 commits

Roll recipe dependencies (trivial). · ddbeac1c

recipe-roller authored Nov 10, 2018

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/8bda99d5e0cd3e2cf8b863d1c77152dbbd0fc23e [doc/user_guide.md] Initial structure for rewrite of user_guide.md. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I338d530089d2b5e90ccdbec2a423ac398c8b1fd7
Reviewed-on: https://chromium-review.googlesource.com/c/1330187
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>

ddbeac1c

[led] Roll to pick up new kitchen CLI flags and set CallUpdateBuild=false. · 768c3afe

Robert Iannucci authored Nov 10, 2018

R=nodir@chromium.org

Change-Id: I37a0647ad9358a9e9b88f25b737385556428ebcd
Reviewed-on: https://chromium-review.googlesource.com/c/1329997
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>

768c3afe

09 Nov, 2018 5 commits

Roll recipe dependencies (trivial). · af0ede1e

recipe-roller authored Nov 09, 2018

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/519790719eb481c3c7282d76da6010dc0f5418c7 Add ability to mock git ref (sergiyb@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I200ce62c30b96523912701c723ab88d3f772d61d
Reviewed-on: https://chromium-review.googlesource.com/c/1330183Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

af0ede1e

Fix crash were CL has no reviewers · 171c0745

Mohamed Heikal authored Nov 09, 2018

Currently git cl owners tries to fetch the current reviewers of a CL
from gerrit. However, this fails with a KeyError when there are no
reviewers currently. This cl fixes that bug.

Bug: 895722
Change-Id: I78a998ee234d207523aa2cef4b5058ba7cfecbc2
Reviewed-on: https://chromium-review.googlesource.com/c/1330122
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>

171c0745

Add the opt-in/out commands to metrics notice · e28390cc

Peter Boström authored Nov 09, 2018

Mentioning these commands make it easier for folks to get rid of the
large notice.

Bug: None
Change-Id: I85dd0e1ec0d33999af46f9e20b95bea05bd40a1e
Reviewed-on: https://chromium-review.googlesource.com/c/1330181
Auto-Submit: Peter Boström <pbos@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

e28390cc

[cipd] Bump CIPD client and vpython versions. · 6edb632f

Vadim Shtayura authored Nov 09, 2018

The most notable change is in how the integrity of the tag cache file is
checked. Once deployed, existing tag cache files will be considered invalid and
wiped.

The only observable side effect is the following line in the log:
"can't deserialize tag cache - no sha256 is recorded in the file"

R=tandrii@chromium.org, iannucci@chromium.org

Change-Id: I7ea300a4e7ad8be0c1d42ae561c5202420d2db62
Reviewed-on: https://chromium-review.googlesource.com/c/1327823Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>

6edb632f

Add autoninja* to .gitattributes. · 98c0fdb9

Yoshisato Yanagisawa authored Nov 09, 2018

Bug: b/77176746
Change-Id: I8f027daa6f867d61f0a9124a6d22c512bf91f219
Reviewed-on: https://chromium-review.googlesource.com/c/1325267Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org>

98c0fdb9

08 Nov, 2018 6 commits

Roll recipe dependencies (trivial). · 93cd73d9

recipe-roller authored Nov 08, 2018

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/a5a5b1ee65266762db9839ed8ac32eb325c53dca Remove old run code (martiniss@google.com)
  https://crrev.com/0c993cb828b335e2fc0528c149f8060c35ebf0ac Revert "Remove old run code" (martiniss@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I7fbab5d8255120016278cde25eefcbe6bb6f2f67
Reviewed-on: https://chromium-review.googlesource.com/c/1327627Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

93cd73d9

Allow gsutil recipe_module calls to not always be infra_steps. · 9340ca09

Ben Pastene authored Nov 08, 2018

I'm writing a recipe that makes heavy use of gsutil's ls and cat, and
some of the calls are expected to fail. So this allows the user to make
those that fail do so as normal steps.

R=iannucci, tandrii

Bug: 866062
Change-Id: I4c9cdcb77c00afd4ab8fefd146f22fa94fcc37d7
Reviewed-on: https://chromium-review.googlesource.com/c/1325332Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>

9340ca09

Revert "Roll recipe dependencies (trivial)." · 1d2946bb

Stephen Martinis authored Nov 08, 2018

This reverts commit fc810ab2.

Reason for revert: Broke everything

Original change's description:
> Roll recipe dependencies (trivial).
> 
> This is an automated CL created by the recipe roller. This CL rolls recipe
> changes from upstream projects (e.g. depot_tools) into downstream projects
> (e.g. tools/build).
> 
> 
> More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
> recipe_engine:
>   https://crrev.com/a5a5b1ee65266762db9839ed8ac32eb325c53dca Remove old run code (martiniss@google.com)
> 
> 
> TBR=iannucci@chromium.org
> 
> Recipe-Tryjob-Bypass-Reason: Autoroller
> Bugdroid-Send-Email: False
> Change-Id: Ieac443303891c032ddec11b24004774595cd954a
> Reviewed-on: https://chromium-review.googlesource.com/c/1327623
> Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

TBR=iannucci@chromium.org,recipe-roller@chromium.org

Change-Id: Iad38bee7bc5dcb0d342f5a3b1a072c458a8257d6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/1327505Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>

1d2946bb

Roll recipe dependencies (trivial). · fc810ab2

recipe-roller authored Nov 08, 2018

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/a5a5b1ee65266762db9839ed8ac32eb325c53dca Remove old run code (martiniss@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ieac443303891c032ddec11b24004774595cd954a
Reviewed-on: https://chromium-review.googlesource.com/c/1327623Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

fc810ab2

git-cl: Print git push stdout. · edcefdcf

Edward Lemur authored Nov 08, 2018

Tbr: tandrii@chromium.org
Bug: 881860
Change-Id: I17dd5c3b6e3fc6da126487b03ea4fc5aa06c2898
Reviewed-on: https://chromium-review.googlesource.com/c/1326561Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

edcefdcf

git cl status: Force description encoding to utf-8 to avoid throwing · cf6df902

Dan Beam authored Nov 08, 2018

Example error: https://gist.github.com/danbeam/3c6b1f98b5d4a921a583a6f070ed0bf0

R=dpranke@chromium.org
BUG=none

Change-Id: Ib3406ce04782b08b1761506b494b96a827fa4a84
Reviewed-on: https://chromium-review.googlesource.com/c/1299615
Commit-Queue: Dan Beam <dbeam@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>

cf6df902

07 Nov, 2018 6 commits

Quote the full path to ninja.exe. · 75fa8552

Allen Bauer authored Nov 07, 2018

Bug: 902930
Change-Id: I5f160cd2ff7a9da603b029c894c84db1c5ed8374
Reviewed-on: https://chromium-review.googlesource.com/c/1324650Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Allen Bauer <kylixrd@chromium.org>

75fa8552

git-cl: Stop logging response headers on 404 Gerrit RPC status. · 49c8eafc

Edward Lemur authored Nov 07, 2018

Bug: 881860
Change-Id: I96a1e8f3ed9fe032307b49d7a130d512e050369e
Reviewed-on: https://chromium-review.googlesource.com/c/1306013Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

49c8eafc

Roll recipe dependencies (trivial). · 421605af

recipe-roller authored Nov 07, 2018

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/5d8bfa9fef017493107749f2af885ba5e6b805f7 Add ability to override buildnumber via buildbucket module's test API (sergiyb@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I5eebd5b44c729ebc4e1488d6c0ef498b25edf3d4
Reviewed-on: https://chromium-review.googlesource.com/c/1323869Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

421605af

Fix unhelpful error when gn.py run in wrong directory. · 4d2d5b4b

Lowell Manners authored Nov 07, 2018

Before this change, when running gn.py outside of
the checkout, the error was:
AttributeError: 'NoneType' object has no attribute 'endswith'

R=scottmg@chromium.org
Bug: gn:14

Change-Id: I4f2f83b2a861bd6f9436c16c2c422fe18fab8f2a
Reviewed-on: https://chromium-review.googlesource.com/c/1299023Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Lowell Manners <lowell@google.com>

4d2d5b4b

autoninja: use ninja in the autoninja.py directory · 4b49707c

Yoshisato Yanagisawa authored Nov 07, 2018

When people execute autoninja, I believe people would expect ninja
in the autoninja directory would be used.  However, the original code
find ninja from PATH, and ninja in other directory could be used.
People usually do not notice this because having depot_tools in
PATH is recommended for Chromium developers.  However, in some
environments, an old version ninja is pre-installed, and unexpected
version ninja could be used upon PATH environment.

Also, in most of bots, depot_tools directory is not included in PATH.
Autoninja execution would fail there because the system cannot find
ninja.

Bug: b/77176746
Change-Id: Iad8bd952dc1e34a9d303fd5b493c555156369a17
Reviewed-on: https://chromium-review.googlesource.com/c/1319489Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Fumitoshi Ukai <ukai@chromium.org>
Reviewed-by: Shinya Kawanaka <shinyak@chromium.org>
Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Auto-Submit: Yoshisato Yanagisawa <yyanagisawa@chromium.org>

4b49707c

Add android_internal fetch spec. · 52a091f4

John Budorick authored Nov 07, 2018

Bug: 856278
Change-Id: I9aa7cd933a54ba675bdeadb7888d0205a080ea62
Reviewed-on: https://chromium-review.googlesource.com/c/1315470Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>

52a091f4

05 Nov, 2018 3 commits

Roll recipe dependencies (trivial). · 6d6e0a80

recipe-roller authored Nov 05, 2018

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/c00f13df3e9b3c9bbd191ace36502341f1f2cc52 [isolated] Add ability to add an array of files. (joshuaseaton@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I1da91c43f113b1536e744e0f93714dfaadd8b43c
Reviewed-on: https://chromium-review.googlesource.com/c/1318494Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

6d6e0a80

Roll recipe dependencies (trivial). · 8b0f609c

recipe-roller authored Nov 05, 2018

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/0aa0d59a984e8a2fbc99205ea3de860416bc5107 [isolated] Update path to isolated binary (joshuaseaton@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I074d077d42c3637eb6f69f5841bbe26778da13ce
Reviewed-on: https://chromium-review.googlesource.com/c/1318492Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

8b0f609c

Roll recipe dependencies (trivial). · 459aaba0

recipe-roller authored Nov 05, 2018

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/834ac61e122d54c0409b2789490f7b5d5684aea2 [cipd] Permit unicode cipd tags (joshuaseaton@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ice67d5f088116fbfcde1c312325cae2c776deb27
Reviewed-on: https://chromium-review.googlesource.com/c/1318491Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

459aaba0

03 Nov, 2018 3 commits

Roll recipe dependencies (trivial). · 7e0b0c49

recipe-roller authored Nov 03, 2018

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/001848147e74b8f8e63e32dc8bed9ff16e11820f [isolated] Upstream fuchsia's isolated recipe module (joshuaseaton@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Iad829cba40508e05be2a351474f35ceb6f3c48fd
Reviewed-on: https://chromium-review.googlesource.com/c/1316907Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

7e0b0c49

git-cl: Add tests for metrics collection. · 01f4a4ff

Edward Lemur authored Nov 03, 2018

Bug: 897394
Change-Id: I07959e870fef4e6a6b8e6e7c974397d3306460c1
Reviewed-on: https://chromium-review.googlesource.com/c/1315839
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

01f4a4ff

Add CELab gclient config · a98da076

Mathieu Binette authored Nov 03, 2018

Change-Id: I97fc6e677cdbab0e2bd74b5b04a74badbd1b0b1e
Reviewed-on: https://chromium-review.googlesource.com/c/1313232
Commit-Queue: Mathieu Binette <mbinette@google.com>
Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

a98da076

01 Nov, 2018 5 commits

git-cl: Report git push information to metrics collection. · fec80c41

Edward Lemur authored Nov 01, 2018

Bug: 897394
Change-Id: I52a31bb4840b5de89b96545a3e7544c6708f148f
Reviewed-on: https://chromium-review.googlesource.com/c/1312240Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

fec80c41

gclient: Make built-in vars available for expansion. · 8f8a50d0

Edward Lemur authored Nov 01, 2018

Make it possible to refer to built-in variables without having to declare
then in DEPS files.

Bug: None
Change-Id: I5403963052463befc074f29750de56cce13927ce
Reviewed-on: https://chromium-review.googlesource.com/c/1312234Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

8f8a50d0

Add brucedawson to OWNERS of autoninja file · 5ee6b6e6

Takuto Ikuta authored Nov 01, 2018

Change-Id: I6923bced3700434a15756fa33f713cf4521b9041
Reviewed-on: https://chromium-review.googlesource.com/c/1312416Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>

5ee6b6e6

owners.py: Use os.path.split to handle file separators correctly · 24bca4e7

Daniel Cheng authored Nov 01, 2018

The script gets confused on Windows, because the path delimieter is \,
not /.

Bug: 899724
Change-Id: Id907aceb4f7bb6fcc0460245890b9e4716054ff9
Reviewed-on: https://chromium-review.googlesource.com/c/1308897Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>

24bca4e7

recipe_modules/depot_tools: export autoninja_path · a870c969

Yoshisato Yanagisawa authored Nov 01, 2018

Make autoninja path also available via depot_tools recipe module,
and make autoninja used where it is needed.

Bug: b/77176746
Change-Id: I8553cb3fb32f98e2e3ff420c255461b7e7da7df6
Reviewed-on: https://chromium-review.googlesource.com/c/1293112Reviewed-by: Fumitoshi Ukai <ukai@chromium.org>
Reviewed-by: Shinya Kawanaka <shinyak@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org>

a870c969