Commits · 7c62ed63ace59cbdfda4a26c6a24ca0c668e9ef3 · Linshizhi / Chromium_Depot_tools

28 Nov, 2019 3 commits

properly detect msys_nt as windows in the ninja script · 7c62ed63

Samuel Attard authored Nov 28, 2019

Some versions of bash for windows report their uname -s as "MSYS_NT-10.0-{VERSION}",
this updates the wrapper script to handle them.

Change-Id: I5916324fc93d86d71f97ae3ad8497a5bb11a350c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1941341
Auto-Submit: Samuel Attard <samuel.r.attard@gmail.com>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>

7c62ed63

Save .git_cl_description_backup in the working dir · ff24962c

Henrique Ferreiro authored Nov 28, 2019

Avoid cluttering the home directory by saving the CL description in
the project's working directory.

Bug: None
Change-Id: I42c78d03cd239e7c0453867f21fe4be57086722e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1925627
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

ff24962c

bb: ask BB server to respond in JSONPB, which is much faster. · 1bfe890b

Andrii Shyshkalov authored Nov 28, 2019

But still send requests in binary.
More info in https://crrev.com/c/1941150.

All changes:
  https://chromium.googlesource.com/infra/infra.git/+log/bdbeaf7..5231ced

R=smut

Bug: 1028915, 1028420, 1028915
Change-Id: I97deb81a53db3294cab797e7bb6c1dcf5712ff14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1941042
Commit-Queue: Andrii Shyshkalov <tandrii@google.com>
Commit-Queue: smut <smut@google.com>
Auto-Submit: Andrii Shyshkalov <tandrii@google.com>
Reviewed-by: smut <smut@google.com>

1bfe890b

27 Nov, 2019 5 commits

[recipe_modules/osx_sdk] Better default XCode versions depending on host OS. · f31cb801

Robert Iannucci authored Nov 27, 2019

This uses the macOS<->XCode mapping from wikipedia to set the default XCode
version to the highest supported XCode version supported by the current
host OS.

R=justincohen@google.com, tandrii@chromium.org

Bug: 1026340
Recipe-Nontrivial-Roll: build
Recipe-Nontrivial-Roll: infra
Recipe-Nontrivial-Roll: build_limited_scripts_slave
Change-Id: I524d08f81a7778404c60a64b1100b4386a2ed79a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1938022Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

f31cb801

Revert "Release new bb tool @ 1b9c7d3e8bacc3100d0f81c96825756e6f48a293." · 34267f83

Andrii Shyshkalov authored Nov 27, 2019

This reverts commit b00449ac.

Reason for revert: new version is buggy when serializing properties.

Original change's description:
> Release new bb tool @ 1b9c7d3e8bacc3100d0f81c96825756e6f48a293.
> 
> Git log https://chromium.googlesource.com/infra/infra.git/+log/bdbeaf7..1b9c7d3e8
> 
> R=smut
> 
> Bug: 1028420
> Change-Id: Id1730f84b96a5ac9ecc62c2e04251b7a5ae238f9
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1938548
> Reviewed-by: smut <smut@google.com>
> Commit-Queue: smut <smut@google.com>
> Auto-Submit: Andrii Shyshkalov <tandrii@google.com>

TBR=smut@google.com,tandrii@google.com

Change-Id: I468dece3818a95a2f7313ef0dfbea8fc4d8f126b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1028420
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1938550Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Commit-Queue: Andrii Shyshkalov <tandrii@google.com>

34267f83

Release new bb tool @ 1b9c7d3e8bacc3100d0f81c96825756e6f48a293. · b00449ac

Andrii Shyshkalov authored Nov 27, 2019

Git log https://chromium.googlesource.com/infra/infra.git/+log/bdbeaf7..1b9c7d3e8

R=smut

Bug: 1028420
Change-Id: Id1730f84b96a5ac9ecc62c2e04251b7a5ae238f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1938548Reviewed-by: smut <smut@google.com>
Commit-Queue: smut <smut@google.com>
Auto-Submit: Andrii Shyshkalov <tandrii@google.com>

b00449ac

Roll recipe dependencies (trivial). · 9a5941ed

recipe-roller authored Nov 27, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/c48c77264fea1fbe3bdc8352451a91b3dd529c96 [platform] Add mac_release method. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib78b2cc88349f9d3f18b25d08b2890ce2151388b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1938407Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

9a5941ed

Roll recipe dependencies (trivial). · 341d41ba

recipe-roller authored Nov 27, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/9aa46f0fd476ce9bba0380209e52ae48b88222a1 [resultdb] Add resultdb protos (nodir@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib3274bfd43107f8e433ff79c5151d16e4701f56d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1938251Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

341d41ba

26 Nov, 2019 3 commits

git-hyper-blame: Fix unicode handling. · 5e94b80c

Edward Lemur authored Nov 26, 2019

git hyper_blame might use a subprocess' stdin for its stdout,
which is opened to accept byte input.
The text must be encoded before printing to stdout to avoid
unicode errors.

Bug: 1028709
Change-Id: If2a270a7f3f69a818d367616f6732245de364db9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1937500Reviewed-by: Andy Perelson <ajp@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

5e94b80c

Roll recipe dependencies (trivial). · 5604ce9f

recipe-roller authored Nov 26, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/1b8cdb3fb0283ac8f93a7ca517b278b1ace51353 [recipe_modules/context] Simplify context implementation. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ie8113fe7be7be45ed5f572c426d209291006b68f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1937495Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

5604ce9f

Roll recipe dependencies (trivial). · 74e43a9f

recipe-roller authored Nov 26, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/e3103d1197e1d8511966713535b19c72b7ec7bfb [recipe_modules/cipd] Add option to override CIPD cache. (iannucci@chromium.org)
  https://crrev.com/1ae0516e8e33e289a9b52280c500ffddb0542979 Update luci-go protos (nodir@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Iae21a62c7f434539538412b4e658dcfa4b9c7119
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1935159Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

74e43a9f

25 Nov, 2019 4 commits

depot_tools: Make gsutil compatible with python3. · 83aafc97

Edward Lemur authored Nov 25, 2019

Bug: 1026371
Change-Id: Iddef64ac2d3a9f97fdb0540a048dfb9dc5679b5c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1925407
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

83aafc97

depot_tools: Add ehmaldonado@google.com to OWNERS. · 5504dc64

Edward Lemur authored Nov 25, 2019

Change-Id: Ib9c48e979b87aaddd39ace259b7ef1b9de567081
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1930055
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Anthony Polito <apolito@google.com>
Reviewed-by: Anthony Polito <apolito@google.com>

5504dc64

depot_tools: Run roll_dep tests on Python 3. · 9ea51a5b

Edward Lemur authored Nov 25, 2019

Bug: 1009816
Change-Id: I2fac9f03b6dd275563375d8ac4d1e71b5188e468
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1925325Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

9ea51a5b

depot_tools: Use system's python for vpython. · 0ab6a9f6

Edward Lemur authored Nov 25, 2019

Using bootstrapped vpython causes problems like [1] when used on
platforms it was not compiled for (e.g. Fedora).

[1] https://chromium-review.googlesource.com/c/infra/infra/+/1929031

Change-Id: I4e62cd1a4e13eee58143695f54ecf80d3473a862
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1930181Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

0ab6a9f6

23 Nov, 2019 2 commits

my_activity: allow to exclude some servers · 80012971

Vadim Bendebury authored Nov 23, 2019

Not all my_activity.py users have accounts on all servers the utility
queries. This results in access errors reported when the utility is
ran.

Also, many users never upload patches on some servers even though the
account is there, there is no point in querying those servers.

This patch allows to pass in a list of servers to exclude from the
list of queried servers.

BUG=none
TEST=invoked the utility as follows:

  $ my_activity.py --skip_servers \
    pdfium-review.googlesource.com,skia-review.googlesource.com

  observed that the 'ERROR:root:Access Errors:' messages are not
  generated any more.

Change-Id: I7d676e45ee99d883a153b58acb778a2e2d5ed74a
Signed-off-by: Vadim Bendebury <vbendeb@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1487342Reviewed-by: Aaron Gable <agable@chromium.org>

80012971

Roll recipe dependencies (trivial). · 556c0a2e

recipe-roller authored Nov 23, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/dcbdf913dcecac13e14af5928a070f369b729c60 [swarming] Don't use null user/tags in test data (olivernewman@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Iffebe95b12ff0fba1d595822feedd959a5ac00fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1931726Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

556c0a2e

22 Nov, 2019 1 commit

Roll recipe dependencies (trivial). · 9dabaedf

recipe-roller authored Nov 22, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/fb9043505a8386e9ea7b9ff12bad0aeaaf41d929 [recipes-py] Provide the ability to supply reason when cancel a build (yiwzhang@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ie07c36de453e8c0c7b86b7307279595050108744
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1931456Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

9dabaedf

21 Nov, 2019 4 commits

git_cache: don't lose options in upload_bootstrap. · c50b0963

Andrii Shyshkalov authored Nov 21, 2019

I noticed that chromium/src archive grew 2x from 7.3GiB in August
to 15+ GiB now. Turns out --aggressive-gc had no effect.

R=iannucci

Change-Id: I6a27f67f5a4dd2101ac1622221106e094af4688a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1928583
Auto-Submit: Andrii Shyshkalov <tandrii@google.com>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

c50b0963

gclient: Assert invokations of gclient succeed when running smoketests. · 65f6b45d

Edward Lemur authored Nov 21, 2019

Bug: 1024683
Change-Id: I01245d34ad1fa1142ce726c80bf5b61567bafe35
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1925038Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

65f6b45d

depot_tools: Run watchlists tests on Python 3 · 589d4563

Edward Lemur authored Nov 21, 2019

Bug: 1002209
Change-Id: I64aecc5e06be13237b73ae568a1beae046ba4962
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1925324Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

589d4563

depot_tools: Run auth, cipd_bootstrap, git_number tests on python3. · 2e2f5875

Edward Lemur authored Nov 21, 2019

Bug: 1009809
Change-Id: Ia02460a24f4ac048bd7f0072e70856f9ee22a997
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1925314
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

2e2f5875

20 Nov, 2019 2 commits

Roll recipe dependencies (trivial). · bea1635c

recipe-roller authored Nov 20, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/2a3717d7299123f93cc91c42c8a492838e8ec03b Stop accepting None in with_user or with_tags (garymm@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I5bd45ad0ee45864202ccee417023840f99d4df35
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1926570Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

bea1635c

roll out new goma client binary · 50696684

Fumitoshi Ukai authored Nov 20, 2019

https://chromium.googlesource.com/infra/goma/client/+/f6867ba895ff67bd3604cbf3dd66bc657eaa3cc0

BUG=1026184

Change-Id: I150df7d3eb8ce000e161bd1b5a0b8532a74a4e8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1925945
Auto-Submit: Fumitoshi Ukai <ukai@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@google.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

50696684

19 Nov, 2019 4 commits

Roll recipe dependencies (trivial). · 639872c8

recipe-roller authored Nov 19, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/8143132bb9539bb3ab7ba8dc222941c6a0a2f51f [buildbucket] Expose DEFAULT_FIELDS (olivernewman@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I32048fb9fd66835427448d32f961fb77dea73b9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1925317Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

639872c8

gclient: Make smoke tests use local dir instead of git daemon. · e9024d00

Edward Lemur authored Nov 19, 2019

Running gclient_smoketests times out on windows when using git daemon,
so use a local directory as remote instead.

Bug: 1024683
Change-Id: I6ca506d74de463d914317f176eefbe74996298c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1879723
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Anthony Polito <apolito@google.com>

e9024d00

Reland "depot_tools: Ensure Python is bootstrapped before reading python3_bin_reldir.txt" · 6ec8b51b

John Budorick authored Nov 19, 2019

This reverts commit b2bfd55f.

Reason for revert: not responsible for crbug.com/1025659

Original change's description:
> Revert "depot_tools: Ensure Python is bootstrapped before reading python3_bin_reldir.txt"
> 
> This reverts commit bf26b167.
> 
> Reason for revert: spec revert for https://bugs.chromium.org/p/chromium/issues/detail?id=1025659
> 
> Original change's description:
> > depot_tools: Ensure Python is bootstrapped before reading python3_bin_reldir.txt
> > 
> > Bug: 1017812
> > Change-Id: I7013e5445ff5917fab813a54fed416d9770d2684
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1913269
> > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
> > Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> 
> TBR=dpranke@chromium.org,ehmaldonado@chromium.org,apolito@google.com
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: 1017812
> Change-Id: I8e10894a2e835c20ece7d555c21f6ce1f76528a5
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1922949
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Commit-Queue: John Budorick <jbudorick@chromium.org>

Bug: 1017812
Change-Id: I251c6b1a3e3a7b9ac9d21dabe745466c668a8246
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1924494Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

6ec8b51b

Revert "depot_tools: Ensure Python is bootstrapped before reading python3_bin_reldir.txt" · b2bfd55f

John Budorick authored Nov 19, 2019

This reverts commit bf26b167.

Reason for revert: spec revert for https://bugs.chromium.org/p/chromium/issues/detail?id=1025659

Original change's description:
> depot_tools: Ensure Python is bootstrapped before reading python3_bin_reldir.txt
> 
> Bug: 1017812
> Change-Id: I7013e5445ff5917fab813a54fed416d9770d2684
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1913269
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>

TBR=dpranke@chromium.org,ehmaldonado@chromium.org,apolito@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1017812
Change-Id: I8e10894a2e835c20ece7d555c21f6ce1f76528a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1922949Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>

b2bfd55f

18 Nov, 2019 1 commit

Roll recipe dependencies (trivial). · 35a67a57

recipe-roller authored Nov 18, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/7c426bbd1c09baf26a19be775d10b7ff332fa139 Remove BOGUS_FIELDS (guterman@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I5e872e9dec9044f02fe6bc309fbfef5f35d3a27a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1922947Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

35a67a57

15 Nov, 2019 5 commits

gclient: Support setting local directories as dependency URLs. · 1f392b83

Edward Lemur authored Nov 15, 2019

Using git daemon for smoke tests times out on Windows.
This CL adds support for local directory URLs to gclient so we can tests
using local directories as remotes instead.

Bug: 1024683
Change-Id: I6dcefa6eb0a93713cf46ea1e4c6b29311ad37565
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1915416Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

1f392b83

presubmit: Print executed command along with test name. · 7cf9438c

Edward Lemur authored Nov 15, 2019

Useful when runnig the same test both on Python 2 and Python 3.

Change-Id: I6074e4cbd64318985cf438a2d491182b7b9ccc7b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1913259Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

7cf9438c

depot_tools: Ensure Python is bootstrapped before reading python3_bin_reldir.txt · bf26b167

Edward Lemur authored Nov 15, 2019

Bug: 1017812
Change-Id: I7013e5445ff5917fab813a54fed416d9770d2684
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1913269
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>

bf26b167

Changed "gclient sync -D" logic to compare against the expected DEPS version · bb457349

Anthony Polito authored Nov 15, 2019

Also add a better warning if 'gclient sync -D' fails due to a modified file.
I've tested this code via deleting a DEP and running gclient sync -D.

Bug: 981149
Change-Id: I97035ac238d163ccb1684c3ee423c223ed0f6299
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1891830Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Anthony Polito <apolito@google.com>

bb457349

Fix CMDUploadTestCase in presubmit · 46689b09

Anthony Polito authored Nov 15, 2019

Bug: 1025293
Change-Id: I41ca2fba3855ecad3036e94a3bdc39b399c1a276
Recipe-Nontrivial-Roll: build_limited_scripts_slave
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1918609
Commit-Queue: Anthony Polito <apolito@google.com>
Auto-Submit: Anthony Polito <apolito@google.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

46689b09

14 Nov, 2019 5 commits

Reland "Fetch the input commit ref when both ref and id are specified." · 90c88f09

Garrett Beaty authored Nov 14, 2019

This is a reland of 72a245e4

The "git checkout master --detach" operation has been modified to run in the solution
directory.

Original change's description:
> Fetch the input commit ref when both ref and id are specified.
>
> This causes --refs refs/head/master to be added to bot_update calls when
> the input build message contains a commit id and the refs/head/master
> ref. This is an effective no-op.
>
> When bot_update clones a git repository, it results in HEAD referring to
> master in contrast to the non-clone case which results in a detached
> HEAD. This prevents fetching refs/heads/master, so detach the HEAD after
> cloning.
>
> Bug: 922150
> Change-Id: I357a78305020218e9f5d350832a706b8f2b27967
> Recipe-Nontrivial-Roll: build
> Recipe-Nontrivial-Roll: build_limited_scripts_slave
> Recipe-Nontrivial-Roll: infra
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1900735
> Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

Bug: 922150
Change-Id: I7dc6ebed2dcbd880ff4d515f7e9fc6428ff24099
Recipe-Nontrivial-Roll: build
Recipe-Nontrivial-Roll: build_limited_scripts_slave
Recipe-Nontrivial-Roll: infra
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1910260Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Garrett Beaty <gbeaty@chromium.org>

90c88f09

depot_tools: Execute tests using bot's vpython instead of depot_tools' vpython · 336e51f6

Edward Lemur authored Nov 14, 2019

On Windows, scripts on the current directory take precedence over PATH, so
that when testing depot_tools on Windows, calling `vpython.bat` will
execute the copy of vpython of the depot_tools under test instead of the
one in the bot.
As a workaround, we run the tests from the parent directory instead.

Change-Id: I5187943b6cf7499d50b3f1a2ec906a5e8fd84835
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1910448Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

336e51f6

Revert git cache diagnostic tracing. · 3da78c4b

John Budorick authored Nov 14, 2019

This reverts commit ebba8d75.
This reverts commit fcde3ba0.
This reverts commit fd843fa4.

Bug: 1019824
Change-Id: I14ad2d4f620ac316421f1c3d168b66176af2d26e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1917496
Auto-Submit: John Budorick <jbudorick@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>

3da78c4b

Roll recipe dependencies (trivial). · e6e5db55

recipe-roller authored Nov 14, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/838fce779fcaec9469266d6bca9ec753eebd7414 Accept None in with_user and with_tags (garymm@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I81329b109e171b59a59ee26d0c9697865f53b1de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1915417Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

e6e5db55

Randomize results of git cl owners · 37740e2b

Bruce Dawson authored Nov 14, 2019

git cl owners orders owners by score with alphabetization being the tie
breaker. This leads to some owners being suggested far more often than
others.

Adding a tiny amount of randomization to the scoring leads to an even
distribution of equally qualified reviewers. Less qualified reviewers
will still be sorted into distinct buckets - the randomness is too small
to do anything except break ties.

The tests were updated so that they can tolerate the randomness, but
only for breaking ties.

Bug: 1024083
Change-Id: If7d39d1b3bbd980b80b46ab3f62c65215309bdc8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1913642
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Anthony Polito <apolito@google.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

37740e2b

13 Nov, 2019 1 commit

Roll recipe dependencies (trivial). · 088977a7

recipe-roller authored Nov 13, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/9ab6dcc77364de001bb752e5d1fb42e1dd256371 isolated: update client (tikuta@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ie95f7e8b84f9d110065847594744b449eddcfe91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1913387Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

088977a7