- 06 May, 2019 1 commit
-
-
Raul Tambre authored
Ran "2to3 -w -n -f print ./" and manually added imports. Ran "^\s*print " and "\s+print " to find batch/shell scripts, comments and the like with embedded code, and updated them manually. Also manually added imports to files, which used print as a function, but were missing the import. The scripts still work with Python 2. There are no intended behaviour changes. Bug: 942522 Change-Id: Id777e4d4df4adcdfdab1b18bde89f235ef491b9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1595684Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Auto-Submit: Raul Tambre <raul@tambre.ee>
-
- 11 Sep, 2017 1 commit
-
-
Daniel Cheng authored
No more trying to remember format differences between my_activity.py and my_reviews.py. Change-Id: Iaac34529899a78aef3bd2e0742e674c8754f8afb Reviewed-on: https://chromium-review.googlesource.com/655420Reviewed-by: Aaron Gable <agable@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org>
-
- 16 Dec, 2016 1 commit
-
-
Quinten Yearsley authored
This affects a bunch of files, but only changes comments, and shouldn't make any difference to behavior. The purpose is to slightly improve readability of pylint disable comments. Change-Id: Ic6cd0f8de792b31d91c6125f6da2616450b30f11 Reviewed-on: https://chromium-review.googlesource.com/420412Reviewed-by: Aaron Gable <agable@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
-
- 09 Apr, 2015 1 commit
-
-
vadimsh@chromium.org authored
It is done in preparation for switching to OAuth2 as default (and only) authentication method. Having all auth options handled by the same code makes it easier to gradually add OAuth2 support. As part of this, some options that would no longer work with OAuth2 (and that are not being used from anywhere now, as far as I can tell) are removed: * Passing account password for authentication via command line. * Overriding 'Host' header when making requests to Rietveld (won't work with SSL anyway). * --account_type option (seems to be ClientLogin specific). R=maruel@chromium.org BUG=356813 Review URL: https://codereview.chromium.org/1075723002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@294746 0039d316-1c4b-4281-b951-d872f2087c98
-
- 26 Feb, 2015 1 commit
-
-
sbc@chromium.org authored
Handle KeyboardInterrupt gracefully rather the printing a backtrace. Most users of these tools don't expect a backtrace when then hit Ctrl-C. Also, fix a few other inconsistencies found in the python startup code of these different scripts: - always call main function 'main' (rather than 'Main') - always return 0 from main function - if main takes args never include argv[0] Review URL: https://codereview.chromium.org/955993006 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@294250 0039d316-1c4b-4281-b951-d872f2087c98
-
- 11 Dec, 2014 1 commit
-
-
sbc@chromium.org authored
Also, fix assertion that fires if all the reviews are on the same day (first_day == last_day) Also, don't print backtrace if no arguments at all are specified. Review URL: https://codereview.chromium.org/797523002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293351 0039d316-1c4b-4281-b951-d872f2087c98
-
- 11 Mar, 2014 1 commit
-
-
thestig@chromium.org authored
Review URL: https://codereview.chromium.org/194753007 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@256292 0039d316-1c4b-4281-b951-d872f2087c98
-
- 17 Jul, 2013 1 commit
-
-
thestig@chromium.org authored
Review URL: https://chromiumcodereview.appspot.com/19460002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@211880 0039d316-1c4b-4281-b951-d872f2087c98
-
- 03 Jun, 2013 1 commit
-
-
maruel@chromium.org authored
.search() may return results in unexpected order. Manually sort the entries otherwise first_day and last_day could be inversed, leading to negative number of days. R=iannucci@chromium.org BUG= Review URL: https://chromiumcodereview.appspot.com/16003003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@203792 0039d316-1c4b-4281-b951-d872f2087c98
-
- 21 Mar, 2012 1 commit
-
-
maruel@chromium.org authored
R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/9764009 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@127856 0039d316-1c4b-4281-b951-d872f2087c98
-
- 30 Nov, 2011 1 commit
-
-
maruel@chromium.org authored
Also, increase the wait for socket binding to 0.2 seconds because OSX10.6 is broken _and_ slow. R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/8749005 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@112277 0039d316-1c4b-4281-b951-d872f2087c98
-
- 25 Sep, 2011 1 commit
-
-
maruel@chromium.org authored
I heard some people like to review their changes themselves. :) TBR=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/8045007 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@102670 0039d316-1c4b-4281-b951-d872f2087c98
-
- 23 Sep, 2011 1 commit
-
-
maruel@chromium.org authored
R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/8034001 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@102578 0039d316-1c4b-4281-b951-d872f2087c98
-
- 22 Sep, 2011 6 commits
-
-
maruel@chromium.org authored
TBR=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/7966018 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@102354 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
Enforce a reviewer, when $EMAIL_ADDRESS is not set BUG= TEST= Review URL: http://codereview.chromium.org/7988012 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@102340 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
It's now live on codereview.appspot, codereview.chromium and the internal instance so it's far more easier to get review stats now. R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/7989013 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@102331 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
Add more doc. R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/7991002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@102328 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
Output details to stderr to make it redirect-friendly. Silence upload.py. R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/7979034 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@102277 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
TBR=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/7982048 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@102219 0039d316-1c4b-4281-b951-d872f2087c98
-
- 21 Sep, 2011 1 commit
-
-
maruel@chromium.org authored
Add search interface for rietveld. R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/7977030 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@102191 0039d316-1c4b-4281-b951-d872f2087c98
-