Commits · 76988a8c5288791cf677d5cc20f35d44276e943a · Linshizhi / Chromium_Depot_tools

15 Oct, 2018 1 commit

git cl: compute reviewers and ccs before pushing change to Gerrit. · 76988a8c

Andrii Shyshkalov authored Oct 15, 2018

R=ehmaldonado

Bug: 877717
Change-Id: Iccfba594369d8c726fd9b077d3ac18046757e4a2
Reviewed-on: https://chromium-review.googlesource.com/c/1242845
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

76988a8c

13 Oct, 2018 1 commit

git cl: bring label setting closer to git push in Gerrit case. · dd788444

Andrii Shyshkalov authored Oct 13, 2018

R=ehmaldonado

Bug: 877717
Change-Id: I81e574068687576cc44e41ba00ba650de8aae31b
Reviewed-on: https://chromium-review.googlesource.com/c/1242844Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

dd788444

12 Oct, 2018 1 commit

git cl upload: also explicitly use eu1 mirror for retries. · 94faf328

Andrii Shyshkalov authored Oct 12, 2018

R=ehmaldonado

Bug: 881860
Change-Id: Ia02905a8b71486d771a691c31114d692e62a369f
Reviewed-on: https://chromium-review.googlesource.com/c/1277796Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

94faf328

11 Oct, 2018 2 commits

Roll recipe dependencies (trivial). · 066e1107

recipe-roller authored Oct 11, 2018

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/dffa0b83f071c910d625955d6bb61335696e3a08 Add UUID recipe module (smut@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: If0a3cdcf3cf05894b71f73aa15121bdf353193af
Reviewed-on: https://chromium-review.googlesource.com/c/1278325
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>

066e1107

git-cl: Make request to upload logs more visible. · 47faa068

Edward Lemur authored Oct 11, 2018

Print the message asking the user to upload gerrit logs for git-cl upload
failures after the exception.

Also, initialize the error logger only for git-cl upload, so that the
headers are not overwritten unless git-cl upload is executed again.

Bug: 881860
Change-Id: I8e63432eecca5253e56096e3ad0218eec4058e12
Reviewed-on: https://chromium-review.googlesource.com/c/1277426
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

47faa068

10 Oct, 2018 2 commits

[git recipe_module] Add tags flag for fetch · 2fddb956

Ryan Tseng authored Oct 10, 2018

Some projects that use the git module (eg flutter) require tags.

Bug:  870558
Change-Id: Idae50ef5c8a092e5f0109b6c14c562268a2ad236
Reviewed-on: https://chromium-review.googlesource.com/c/1274245Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>
Commit-Queue: Ryan Tseng <hinoka@chromium.org>

2fddb956

git-cl: Print response headers on 404 Gerrit RPC status. · 83bd7f4c

Edward Lemur authored Oct 10, 2018

And ask the user to report the printed headers to the bug.

Bug: 881860
Change-Id: I0a6cc0d90b4a721f72cd7eee4cba59934facbb1e
Reviewed-on: https://chromium-review.googlesource.com/c/1266837
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

83bd7f4c

09 Oct, 2018 2 commits

Update yapf version 0.22 -> 0.24 · db1e69ef

Aiden Benner authored Oct 09, 2018

0.24 has just been uploaded see bug.

Bug: 890349
Change-Id: Ice1e0c54d3fb60c0da5fde14aafae20c3ac449ce
Reviewed-on: https://chromium-review.googlesource.com/c/1261756Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Aiden Benner <abenner@google.com>

db1e69ef

[led] Roll led to correctly pick swarming host from buildbucket. · dce74762

Robert Iannucci authored Oct 09, 2018

TBR=tandrii@chromium.org, vadimsh@chromium.org

Change-Id: Ie976820701359bb4976d251b3de4f1077d2357ac
Reviewed-on: https://chromium-review.googlesource.com/c/1271304
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

dce74762

05 Oct, 2018 7 commits

Roll recipe dependencies (trivial). · 71e3be7a

recipe-roller authored Oct 05, 2018

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/acbe9e3142610d958181460254565ef27ad47dc0 [StepPresentation] Remove all logs from memory during finalization. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id65a77df9f8508f57a28aa77433b141b1a691c9f
Reviewed-on: https://chromium-review.googlesource.com/c/1264996Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

71e3be7a

[windows_sdk] Default to cache/windows_sdk. · 85af4533

Robert Iannucci authored Oct 05, 2018

This should allow better integration with buildbucket named cache
support. Since this was already parameterized it shouldn't actually
break anything; previously the directory would be deleted on every run,
now it will still be deleted on every run (but we can add a buildbucket
named cache entry for it to preserve it).

R=tandrii@chromium.org, vadimsh@chromium.org

Bug: 877775
Change-Id: I1184fb59a3ed18bfda5fcb288903201b01527096
Recipe-Nontrivial-Roll: build
Recipe-Nontrivial-Roll: infra
Reviewed-on: https://chromium-review.googlesource.com/c/1263861
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>

85af4533

bot_update: Don't use apply_patch_on_gclient. · 0c3bd490

Edward Lemur authored Oct 05, 2018

It has been True by default for a while, and there is no need to override it.

Bug: 891917
Change-Id: I2598a2230b0ea38a647a533757331c541b871971
Reviewed-on: https://chromium-review.googlesource.com/c/1260057Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

0c3bd490

Reland gerrit_util: Support OAuth2 bearer tokens in CookieAuthenticator · 2fb63102

Eric Boren authored Oct 05, 2018

Bug: skia:8394
Change-Id: I928eaec8459a5905360ce760c6361e4554852b44
Reviewed-on: https://chromium-review.googlesource.com/c/1261796Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Eric Boren <borenet@chromium.org>

2fb63102

[led] Roll led to fix broken Milo annotation stream. · f98905e8

Ryan Tseng authored Oct 05, 2018

Picks up https://chromium-review.googlesource.com/c/1260068

Bug: 891925
Change-Id: If2df9ea7ce2d1bcbaca8533935f6e6d30dcd8810
Reviewed-on: https://chromium-review.googlesource.com/c/1263015Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

f98905e8

Roll recipe dependencies (trivial). · d1d4dc8e

recipe-roller authored Oct 05, 2018

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/840950f4bfb6469b4ff72ae4e54ab5c0f5e71116 [cipd] Fix typo in pkg-deploy method. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I5525b0182f7d6395cf66186fba4058dfc0d61496
Reviewed-on: https://chromium-review.googlesource.com/c/1263596
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>

d1d4dc8e

Roll recipe dependencies (trivial). · 8e9443f5

recipe-roller authored Oct 05, 2018

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/9f1afcb08b95a9c2cbae653dd320cd84d62287ff raw_io: pipe placeholder name through for input placeholders. (jbudorick@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I5038f06949f8865afb59e614736923ba29547085
Reviewed-on: https://chromium-review.googlesource.com/c/1263595Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

8e9443f5

04 Oct, 2018 3 commits

gclient: Sync CIPD deps before running hooks. · 5b1fa949

Edward Lemur authored Oct 04, 2018

Bug: 882611
Change-Id: I72646544a164f557ea7d53e0ce0f16d663618a98
Reviewed-on: https://chromium-review.googlesource.com/c/1255446Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

5b1fa949

Remove git-crsync · e8f574a2

Asanka Herath authored Oct 04, 2018

Revision 51049267 removed git-crup which
orphaned git-crsync whose only purpose in life is to invoke git-crup.

Change-Id: Ic8594150692106d8c6326004adea8ce2977f221d
Reviewed-on: https://chromium-review.googlesource.com/c/1262117Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Asanka Herath <asanka@chromium.org>

e8f574a2

[git_cl] Don't check .gitcookies when running on LUCI. · b250ec16

Vadim Shtayura authored Oct 04, 2018

This CL basically replaces "skip if is_gce" with "skip if default auth method
is not gitcookies".

This presumable makes 'git cl' work on LUCI in a consistent manner. Before, it
worked only if the LUCI bot happened to also be GCE bot.

R=tandrii@chromium.org
BUG=891755

Change-Id: I2caa219a4082438a5e026e728bfb62f46a0c80fd
Reviewed-on: https://chromium-review.googlesource.com/c/1260053
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

b250ec16

03 Oct, 2018 4 commits

gclient setdep doesn't need to update_depot_tools · 684313d6

Oleh Prypin authored Oct 03, 2018

Bug: chromium:836566
Change-Id: I752633cd0f5334b4592e1a1f1d4506bf89c7716d
Reviewed-on: https://chromium-review.googlesource.com/1257841Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Oleh Prypin <oprypin@google.com>

684313d6

Add non --full support to python git cl format · c08566e6

Aiden Benner authored Oct 03, 2018

Parses git diff for changed python files in a method similar to
clang-diff and feeds the resulting line ranges into yapf.

Also sets the default style to the yapf file included in depot tools
by searching parent directories of each changed file to find a yapf
style config (.style.yapf). If none is found the default style
file will be the chromium .style.yapf included in depot tools.

Note: Even if line ranges are specified, yapf will fix indentation
issues for the entire file.
This is intended see https://github.com/google/yapf/issues/499
This may cause some issues if git cl format is run on a file
with lots of indentation issues or on a file or when run on a
third_party file that is formatted with pep8 and does not include
a .style.yapf and may make many more changes then the user expects.

Still undecided on whether this should be turned on by default but
if not I think the non --full support is a positive change anyways.

Bug:846432
Change-Id: Ib85797f4a8e1021870901ff465ec10f7e70deb87
Reviewed-on: https://chromium-review.googlesource.com/1249642
Commit-Queue: Aiden Benner <abenner@google.com>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>

c08566e6

Support omitting the space after -C · 6af3aa85

Bruce Dawson authored Oct 03, 2018

Nina supports -C out/Default and -Cout/Default to specify the build
directory so autoninja should also. This change adds that support.

Bug: 890744
Change-Id: I5e824242ed4b333ac99f1ee9a649ffcfa03a812e
Reviewed-on: https://chromium-review.googlesource.com/c/1257586Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>

6af3aa85

[led] Roll led to add gerritcodereview scope to edit-cr-cl · 22300e1f

Robert Iannucci authored Oct 03, 2018

R=tandrii@chromium.org, vadimsh@chromium.org

Change-Id: I1f235cf959e92e4430cff7dcd0d292db1721319d
Reviewed-on: https://chromium-review.googlesource.com/c/1257585Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

22300e1f

02 Oct, 2018 1 commit

Remove agable, bradleynelson from //OWNERS. · 0daedf77

Dirk Pranke authored Oct 02, 2018

bradleynelson is no longer active in depot_tools. agable@ is
unavailable for the rest of 2018.

Change-Id: Idf5be1db84b8f6857f9edd7ed16c56d4c89f81ef
Reviewed-on: https://chromium-review.googlesource.com/1256170Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>

0daedf77

27 Sep, 2018 4 commits

Add skia reviews to my_activity · 95d4c855

Adrienne Walker authored Sep 27, 2018

Also, sort all the gerrit instances by url for clarity.

Change-Id: I89aea98f75de33e8673c929fb07df3b686ea6c15
Reviewed-on: https://chromium-review.googlesource.com/1228659
Commit-Queue: enne <enne@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

95d4c855

Roll recipe dependencies (trivial). · cf257cec

recipe-roller authored Sep 27, 2018

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/7d52a83204be2083edfc82042b13769846db9dff Update the recipes user guide to use post_process. (gbeaty@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I61abce116cb3d914f057cdf33eb55579a82b49d2
Reviewed-on: https://chromium-review.googlesource.com/1249641Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

cf257cec

git cl: save description before doing any RPCs during upload. · d9fdc1f5

Andrii Shyshkalov authored Sep 27, 2018

R=smut@google.com

Bug: 881860
Change-Id: I59c337384891f02dbd2cc776318803ac556843ca
Reviewed-on: https://chromium-review.googlesource.com/1247584Reviewed-by: smut <smut@google.com>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

d9fdc1f5

Roll recipe dependencies (trivial). · f221bac5

recipe-roller authored Sep 27, 2018

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/dc1bf00db5252bb54dd09745865c3160778a882d Fix cmd error in StepCommandContains check (aluo@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ic85a74dbbbf78b069d29b26154e9321c96b36cea
Reviewed-on: https://chromium-review.googlesource.com/1247821Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

f221bac5

26 Sep, 2018 1 commit

Roll recipe dependencies (trivial). · c8b28b92

recipe-roller authored Sep 26, 2018

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/65fffecb2f6a041d71107292b1453a92ab1127fc Add post_process functions for asserting on a step's command. (gbeaty@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ie68b5d385f6455604d95d89d0b1686e91969c0b2
Reviewed-on: https://chromium-review.googlesource.com/1247041Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

c8b28b92

25 Sep, 2018 3 commits

git cl: cache also LABELS data on a change. · c4a7356a

Andrii Shyshkalov authored Sep 25, 2018

This removes 1 RPC when tbr-ing second or later patchset.

Since tests cover TBR only in first upload, there are
no test changes. Since adding test is real PITA here,
keep them as is.

R=ehmaldonado

Change-Id: I90801b06727ce2131a703d6cd6c24ffad798bc8a
Reviewed-on: https://chromium-review.googlesource.com/1242212Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

c4a7356a

git cl: delete old support code for Git Numberer with Rietveld. · 8e643693

Andrii Shyshkalov authored Sep 25, 2018

R=ehmaldonado

Change-Id: Ie5522283e84bdec9d98e236577eaad568816519b
Reviewed-on: https://chromium-review.googlesource.com/1242211Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

8e643693

git cl: use explicit Gerrit mirrors on 404s during upload. · d4c86735

Andrii Shyshkalov authored Sep 25, 2018

This will cycle through known gerrit mirrors for chromium-review host
if Gerrit HTTP RPC results in 404 after successful initial
git push refs/for/refs/...

Tested locally by intentionally using wrong change number (2000000):

    $ PATH=`pwd`:$PATH git cl upload --bypass-hooks
        ...
        remote: Processing changes: refs: 1, new: 1, done
        remote: SUCCESS
        remote: New Changes:
        remote:   https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1227440

                * [new branch]        ea9aea5faa85b4b289b7add4bc6f4d5dd6a01caf -> refs/for/refs/heads/master%wip,m=Initial_upload,hashtag=git-cl

        WARNING:root:404 NotFound error occurred while querying POST https://chromium-review.googlesource.com/a/changes/chromium%2Ftools%2Fdepot_tools~2000000/revisions/current/review: Not Found
        WARNING:root:404 NotFound error occurred while querying POST https://ap1-mirror-chromium-review.googlesource.com/a/changes/chromium%2Ftools%2Fdepot_tools~2000000/revisions/current/review: Not Found
        WARNING:root:404 NotFound error occurred while querying POST https://us1-mirror-chromium-review.googlesource.com/a/changes/chromium%2Ftools%2Fdepot_tools~2000000/revisions/current/review: Not Found

        ^C

Bug: 881860
Change-Id: Iac7dbe4e35052007650a7a2646a394caed6bd400
Reviewed-on: https://chromium-review.googlesource.com/1227441
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

d4c86735

24 Sep, 2018 5 commits

[led] Roll led to fix missing expiration_secs issue. · 64b61330

Robert Iannucci authored Sep 24, 2018

TBR=tandrii@chromium.org, vadimsh@chromium.org

Bug: 875089
Change-Id: Ia48c7c67df8bdbd9bc0573406bd9f56f6cfe5d49
Reviewed-on: https://chromium-review.googlesource.com/1241677Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

64b61330

Revert "my_activity: Add review.coreboot.org as a source" · 482d615b

Gabriel Charette authored Sep 24, 2018

This reverts https://chromium-review.googlesource.com/1173069

It breaks my_activity.py on Windows.

R=iannucci@chromium.org, rrangel@chromium.org

Bug: 888641
Change-Id: I353489e52155d40e48e63819dc3016cf7dd59277
Reviewed-on: https://chromium-review.googlesource.com/1241133Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>

482d615b

Revert "git cl upload: print response headers on 404 Gerrit RPC status." · a06cd091

Andy Perelson authored Sep 24, 2018

This reverts commit ea4301e5. We now have many
reponse headers, stopping contributions until and unless we are asked for more
as part of debugging git cl upload issues.

R=tandrii@chromium.org

Bug: 881860
Change-Id: Ic3524aa93f146cebd882efe30b2e3f110cf74838
Reviewed-on: https://chromium-review.googlesource.com/1241613Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Andy Perelson <ajp@chromium.org>

a06cd091

Implement --no-autocc flag for Gerrit · aaf2cc09

Sergiy Byelozyorov authored Sep 24, 2018

R=ehmaldonado@chromium.org, machenbach@chromium.org

Bug: 878303
Change-Id: Ic387bbdc9e8ee4b27b17505ca53e8873e20e4cda
Reviewed-on: https://chromium-review.googlesource.com/1238571Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org>

aaf2cc09

my_activity: add --completed-issues option. · 8bdc1b8a

Andrii Shyshkalov authored Sep 24, 2018

--completed-issues lists only monorail issues which are owned by the
user and have status Fixed|Verified.

R=sergiyb@chromium.org

Change-Id: I42737bb6ef81ffa463eedee209a2993f68b57d3a
Reviewed-on: https://chromium-review.googlesource.com/1227445
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>

8bdc1b8a

21 Sep, 2018 3 commits

Roll recipe dependencies (trivial). · baf09271

recipe-roller authored Sep 21, 2018

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/da81755358cf32a496ed8a9eddf6ec6d4f0efd18 post_process: Add StepCommandContains check. (jbudorick@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I8e3f14556e0ae66b3c5f6698be601e5b8930cad4
Reviewed-on: https://chromium-review.googlesource.com/1239096
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>

baf09271

Roll recipe dependencies (trivial). · 0dc1fa04

recipe-roller authored Sep 21, 2018

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/ad0e2563a79f19f916cf2939811a2019dec16386 Improve local execution of recipes (martiniss@google.com)
  https://crrev.com/d5fd7cc14d7f0a82d1358617f1ec94c4417ec85e [buildbucket] Split try_build/ci_build (nodir@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I47055f996a36b2b9b39de7142d062b9c59be429d
Reviewed-on: https://chromium-review.googlesource.com/1239095
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>

0dc1fa04

Revert "[gclient] Use canonical URLs in solutions" · 92df4e63

Nodir Turakulov authored Sep 21, 2018

This reverts commit 7e301cff.

Reason for revert: internal builds failed, e.g. bugdroid

Original change's description:
> [gclient] Use canonical URLs in solutions
> 
> Strip ".git" suffix from all solution URLs.
> 
> Recipe-Nontrivial-Roll: build
> Recipe-Nontrivial-Roll: build_limited_scripts_slave
> Recipe-Nontrivial-Roll: infra
> Recipe-Nontrivial-Roll: release_scripts
> Bug: 877161
> Change-Id: I0cb9cc512fdd9cc5e53ade6bc1d725dc84f7563d
> Reviewed-on: https://chromium-review.googlesource.com/1237332
> Reviewed-by: Stephen Martinis <martiniss@chromium.org>
> Commit-Queue: Nodir Turakulov <nodir@chromium.org>

TBR=nodir@chromium.org,tandrii@chromium.org,martiniss@chromium.org,jbudorick@chromium.org

Change-Id: Ie24e10844ceb89071c9e665f2aa7dde9f9bf6e6c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 877161
Reviewed-on: https://chromium-review.googlesource.com/1237423Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

92df4e63