- 08 Apr, 2018 1 commit
-
-
Michael Moss authored
This fixes an issue where cumulative conditions would fail to evaluate if the recursed DEP (or custom_var overrides) didn't happen to redeclare all the variables used by the parent conditions. TBR=dpranke@google.com, ehmaldonado@google.com Bug: 825063 Change-Id: Icb53f04928f914dfacc2c3035d01be103d9f8247 Reviewed-on: https://chromium-review.googlesource.com/1000836 Commit-Queue: Michael Moss <mmoss@chromium.org> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by: Michael Moss <mmoss@chromium.org>
-
- 31 Mar, 2018 1 commit
-
-
Michael Moss authored
This is useful for processing purely "local" DEPS files, with a command-line like: gclient revinfo --output-json /tmp/out \ --spec 'solutions=[{"name": ".", "deps_file": "myDEPS", "url": None}]' This is specifically to fix the "revinfo --output-json" case, but it also cleans up some errors in the 'flattening' test cases. Note that None values already work when using 'revinfo' with stdout output, it's just the json output that complains. BUG=825063 Change-Id: If5f69ba51cb9d0aa0f2b48a2f9b4ed8706b4c738 Reviewed-on: https://chromium-review.googlesource.com/989022 Commit-Queue: Michael Moss <mmoss@chromium.org> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by: Aaron Gable <agable@chromium.org>
-
- 22 Mar, 2018 1 commit
-
-
Edward Lesmes authored
Mimics bot_update's functionality to apply gerrit refs in gclient via --gerrit-ref flags. When the patch fails to apply, gclient sync will return exit code 2. The idea is to move this logic from bot_update to gclient sync to deal when patches for projects like ANGLE are tried on Chromium bots. This way the patch is applied before recursively parsing and syncing ANGLE’s DEPS.chromium file, which doesn't currently happen. Bug: 643346 Change-Id: I7e2018b3c393a5ac9852b8c3611f906977eeeb18 Reviewed-on: https://chromium-review.googlesource.com/961605Reviewed-by: Aaron Gable <agable@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
- 20 Feb, 2018 1 commit
-
-
John Budorick authored
Bug: 813460 Change-Id: Ie52a20dcdf5cb60ab47b787dcfa05aa8a712a727 Reviewed-on: https://chromium-review.googlesource.com/926709Reviewed-by: Michael Moss <mmoss@chromium.org> Reviewed-by: Aaron Gable <agable@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org>
-
- 12 Feb, 2018 1 commit
-
-
Matt Giuca authored
Previously, if you used custom metadata keys in a test commit (like GitRepo.AUTHOR_NAME), they would also be treated as filenames, and fail because they aren't strings. (This wasn't a problem because it isn't currently used in any tests.) Bug: 808941 Change-Id: Id7c4fa5822741925beba591ea587bd8ebbf2e478 Reviewed-on: https://chromium-review.googlesource.com/901122Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
-
- 06 Feb, 2018 1 commit
-
-
Michael Moss authored
BUG=783607 R=agable@google.com, dpranke@google.com Change-Id: I6989203a9e560930cc53254c566275a30d3bead3 Reviewed-on: https://chromium-review.googlesource.com/902168Reviewed-by: Aaron Gable <agable@chromium.org> Commit-Queue: Michael Moss <mmoss@chromium.org>
-
- 12 Oct, 2017 1 commit
-
-
Dirk Pranke authored
Previously, gclient would attempt to write an args file after a dependency was checked out, but before any sub-dependencies had been checked out. If the args file path pointed at something inside a sub-dependency, this wouldn't work, because the directory might not yet exist. This most obviously happened for buildspec clobber builds. The fix is to wait until after the sub-dependencies have been checked out to write the file. R=phajdan.jr@chromium.org, mmoss@chromium.org BUG=773933 Change-Id: I0cf4564204f7dabd9f843dc7904db7050fcc0d23 Reviewed-on: https://chromium-review.googlesource.com/714644Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org>
-
- 02 Oct, 2017 2 commits
-
-
Paweł Hajdan, Jr authored
Bug: 570091 Change-Id: I195f5f798d9869f385437db4e0bc5f4c5d4853ae Reviewed-on: https://chromium-review.googlesource.com/687496 Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
-
Paweł Hajdan, Jr authored
Bug: 661382 Change-Id: I0e74273a5e00b4f3cf1d5c22ce0944dc2fa6f31e Reviewed-on: https://chromium-review.googlesource.com/692934Reviewed-by: Michael Moss <mmoss@chromium.org> Reviewed-by: Aaron Gable <agable@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-
- 29 Sep, 2017 1 commit
-
-
Aaron Gable authored
R=tandrii@chromium.org Bug: 770019 Change-Id: I55d74d67281bd3f79cfd5ba9f57eea082359573e Reviewed-on: https://chromium-review.googlesource.com/693034 Commit-Queue: Aaron Gable <agable@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
-
- 26 Sep, 2017 1 commit
-
-
Paweł Hajdan, Jr authored
This helps make sure they have proper types (e.g. True instead of "True" for booleans). Also see https://chromium-review.googlesource.com/c/chromium/src/+/681854 for context. Bug: 756688, 570091 Change-Id: I1e4d26df724e8e94cc3daba361191856f80a1b2c Reviewed-on: https://chromium-review.googlesource.com/681705Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-
- 07 Sep, 2017 1 commit
-
-
Paweł Hajdan, Jr authored
Bug: 624178 Change-Id: I7ffbf58441e8762630c3beec642108bcc671aae6 Reviewed-on: https://chromium-review.googlesource.com/647848Reviewed-by: Aaron Gable <agable@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-
- 18 Aug, 2017 1 commit
-
-
Paweł Hajdan, Jr authored
We need to pass OS info to recursively called _flatten_dep. Regular deps entries in OS-specific DEPS file recursed into need to be marked as OS-specific in the flattened file. Bug: 570091 Change-Id: If3055b84143d8a52d10d8753113893b5054b4d07 Reviewed-on: https://chromium-review.googlesource.com/621046Reviewed-by: Michael Moss <mmoss@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-
- 17 Aug, 2017 1 commit
-
-
Paweł Hajdan, Jr authored
Bug: 570091 Change-Id: I773b74b042233efa2a525f5f47e920468b7fea4a Reviewed-on: https://chromium-review.googlesource.com/618930Reviewed-by: Michael Moss <mmoss@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-
- 10 Aug, 2017 2 commits
-
-
Paweł Hajdan, Jr authored
This is the same change as in https://chromium-review.googlesource.com/c/586594 applied to _DepsOsToLines. Bug: 570091 Change-Id: I06a4dc3a9b6dbb001a15b1d7b88fef12cf6c6aaa Reviewed-on: https://chromium-review.googlesource.com/609980Reviewed-by: Emma Söderberg <emso@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-
Paweł Hajdan, Jr authored
Bug: 570091 Change-Id: I8e67d617c2738459634aabbffd22135ee5d27cc4 Reviewed-on: https://chromium-review.googlesource.com/609065Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-
- 09 Aug, 2017 1 commit
-
-
Paweł Hajdan, Jr authored
This finally makes the code structure seem right as well: there's just one method (_flatten_dep), with a simpler control flow. Also added a regression test. Bug: 570091 Change-Id: I22ac7a3af0429a7ffd874b4b1715c0f6c72e0006 Reviewed-on: https://chromium-review.googlesource.com/608241Reviewed-by: Michael Moss <mmoss@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-
- 03 Aug, 2017 1 commit
-
-
Paweł Hajdan, Jr authored
Nice side-effect of this change is simplifying the code. Also added regression test coverage. Bug: 570091 Change-Id: I470e9efc319632f997b02d210483988c17a7d3c8 Reviewed-on: https://chromium-review.googlesource.com/600369Reviewed-by: Michael Moss <mmoss@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-
- 27 Jul, 2017 1 commit
-
-
Paweł Hajdan, Jr authored
This is an exact reland of https://chromium-review.googlesource.com/583617 . One of the main use cases is making it clear which revision hashes need to be changed together. The way it's usually done is one variable referenced several times. With this CL, we preserve the references from original DEPS, as opposed to evaluating them and losing some info. This CL actually makes Var() emit a variable placeholder instead of its value, and adds support for these placeholders to gclient. One of possible next steps might be to deprecate Var(). Bug: 570091, 748486 Change-Id: Id47e3771b7163149a4cd427b84f84ece52772f34 Reviewed-on: https://chromium-review.googlesource.com/586594Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: William Hesse <whesse@google.com> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-
- 25 Jul, 2017 2 commits
-
-
Paweł Hajdan Jr authored
This reverts commit e79ddeaa. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=748486 Original change's description: > gclient flatten: preserve variable placeholders > > One of the main use cases is making it clear which revision hashes > need to be changed together. The way it's usually done is one variable > referenced several times. With this CL, we preserve the references > from original DEPS, as opposed to evaluating them and losing some info. > > This CL actually makes Var() emit a variable placeholder > instead of its value, and adds support for these placeholders > to gclient. > > One of possible next steps might be to deprecate Var(). > > Bug: 570091 > Change-Id: I9b13a691b5203cc284c33a59438720e31c9ebf7a > Reviewed-on: https://chromium-review.googlesource.com/583617 > Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> TBR=phajdan.jr@chromium.org,dpranke@chromium.org Change-Id: If9c52ebfa78aba8041ce797ff842d09952d0e2ce No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 570091, 748486 Reviewed-on: https://chromium-review.googlesource.com/584907Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-
Paweł Hajdan, Jr authored
One of the main use cases is making it clear which revision hashes need to be changed together. The way it's usually done is one variable referenced several times. With this CL, we preserve the references from original DEPS, as opposed to evaluating them and losing some info. This CL actually makes Var() emit a variable placeholder instead of its value, and adds support for these placeholders to gclient. One of possible next steps might be to deprecate Var(). Bug: 570091 Change-Id: I9b13a691b5203cc284c33a59438720e31c9ebf7a Reviewed-on: https://chromium-review.googlesource.com/583617 Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
-
- 24 Jul, 2017 1 commit
-
-
Paweł Hajdan, Jr authored
Added a regression test. Simplified some logic - if we don't add os-specific deps and hooks to |dependencies|, we don't need to keep separate original values. Bug: 570091 Change-Id: I5bdd0b6a66df6b3a2b99d0ad9c6e54ee7114f09b Reviewed-on: https://chromium-review.googlesource.com/581687 Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Reviewed-by: Michael Moss <mmoss@chromium.org>
-
- 06 Jul, 2017 1 commit
-
-
Paweł Hajdan, Jr authored
Bug: 570091 Change-Id: I4fac33ca683ff2011fa7307d5175592f3d9e258e Reviewed-on: https://chromium-review.googlesource.com/560171Reviewed-by: Michael Moss <mmoss@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-
- 03 Jul, 2017 1 commit
-
-
Paweł Hajdan, Jr authored
Bug: 570091 Change-Id: I96417d462efb3b0476ee17d42ac5f19d8c4f99c3 Reviewed-on: https://chromium-review.googlesource.com/558352Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-
- 27 Jun, 2017 1 commit
-
-
Paweł Hajdan, Jr authored
Bug: 570091 Change-Id: Ia7f81a81d7df75004c5f8b7560dfd50a14f4cddd Reviewed-on: https://chromium-review.googlesource.com/549355 Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by: Michael Moss <mmoss@chromium.org>
-
- 23 Jun, 2017 1 commit
-
-
Paweł Hajdan, Jr authored
Bug: 570091 Change-Id: I5a489f9f9cbc5384b720685264aa918573234cf5 Reviewed-on: https://chromium-review.googlesource.com/544965Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-
- 21 Jun, 2017 3 commits
-
-
Paweł Hajdan, Jr authored
This is a reland of https://chromium-review.googlesource.com/c/541280/ with a fix for https://bugs.chromium.org/p/chromium/issues/detail?id=735418 (patchset 1 is original patch, patchset 2 has the fix). Keep deps_os entries in dependencies, just with should_process set to False for entries not applicable to target OS list. This way gclient flatten has proper access to dependencies e.g. to evaluate recursedeps referring to deps_os entries other than active OS. Allow but ignore deps_os overriding a value with None, since that does not fit the new model. There's no correctness harm in not checking out a repo. Allow "overrides" setting given dependency to the same value. This seems fairly common, especially for mac/ios and unix/android, even in chromium/src. Bug: 570091, 735418 Change-Id: I6eba0e4be202212eb86cb959c18f2b2f0c1452b9 Reviewed-on: https://chromium-review.googlesource.com/543076 Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
-
Andrii Shyshkalov authored
This reverts commit 529d6a4e. Reason for revert: broke developers and CI/Try checkouts. Bug: 735418 Original change's description: > gclient: include deps_os entries in dependencies > > Keep deps_os entries in dependencies, just with should_process set to False > for entries not applicable to target OS list. > > This way gclient flatten has proper access to dependencies e.g. to evaluate > recursedeps referring to deps_os entries other than active OS. > > Allow but ignore deps_os overriding a value with None, since that does not > fit the new model. There's no correctness harm in not checking out a repo. > > Allow "overrides" setting given dependency to the same value. This seems > fairly common, especially for mac/ios and unix/android, even in chromium/src. > > Bug: 570091 > Change-Id: I2037a1ecc5fd2da6b5f73061548b81fc79ba2e72 > Reviewed-on: https://chromium-review.googlesource.com/541280 > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> TBR=phajdan.jr@chromium.org,dpranke@chromium.org Change-Id: Iaa0c39865908a5b25c15dda54ba61c0e76abcbea No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 570091 Reviewed-on: https://chromium-review.googlesource.com/543138Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
Paweł Hajdan, Jr authored
Keep deps_os entries in dependencies, just with should_process set to False for entries not applicable to target OS list. This way gclient flatten has proper access to dependencies e.g. to evaluate recursedeps referring to deps_os entries other than active OS. Allow but ignore deps_os overriding a value with None, since that does not fit the new model. There's no correctness harm in not checking out a repo. Allow "overrides" setting given dependency to the same value. This seems fairly common, especially for mac/ios and unix/android, even in chromium/src. Bug: 570091 Change-Id: I2037a1ecc5fd2da6b5f73061548b81fc79ba2e72 Reviewed-on: https://chromium-review.googlesource.com/541280Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-
- 13 Jun, 2017 1 commit
-
-
Paweł Hajdan, Jr authored
Bug: 570091 Change-Id: I2b68e8e8a0e28b28b9aab79833578cdf59392b98 Reviewed-on: https://chromium-review.googlesource.com/531185Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-
- 07 Jun, 2017 1 commit
-
-
Paweł Hajdan, Jr authored
Bug: 570091 Change-Id: I5c7cf00722c47a2063a8635822c0bb270a26b524 Reviewed-on: https://chromium-review.googlesource.com/527632 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
-
- 06 Jun, 2017 2 commits
-
-
Paweł Hajdan, Jr authored
Bug: 570091 Change-Id: Ib2b966b5bc967de11a295b1636c1901faabea55f Reviewed-on: https://chromium-review.googlesource.com/525540 Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
-
Paweł Hajdan, Jr authored
Bug: 570091 Change-Id: Id95be31767d302c5eb9f7de96d31e32cc4dec1a4 Reviewed-on: https://chromium-review.googlesource.com/524492Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-
- 29 May, 2017 2 commits
-
-
Paweł Hajdan, Jr authored
This is a follow-up after https://chromium-review.googlesource.com/c/517049/ Bug: 727334, 570091 Change-Id: I49f9ad07f1b79cba547d88e93b2d2064c33e1f4b Reviewed-on: https://chromium-review.googlesource.com/518125Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-
Paweł Hajdan, Jr authored
Bug: 570091 Change-Id: Ib3296a201bdcbd4ec350ee0e98112a89e388fd61 Reviewed-on: https://chromium-review.googlesource.com/517049Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-
- 23 May, 2017 3 commits
-
-
Paweł Hajdan, Jr authored
Original CL: https://chromium-review.googlesource.com/509693 This feature appears unused, and removing it will simplify the codebase. Bug: 661382 Change-Id: I0d83b537b57d0b9ca65c7101d13e0ad6c1642a29 Reviewed-on: https://chromium-review.googlesource.com/512842Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-
Andrii Shyshkalov authored
This reverts commit bf72b593. Reason for revert: maybe caused outage. Original change's description: > gclient: remove support for From() > > This feature appears unused, and removing it will simplify the codebase. > > Bug: 661382 > Change-Id: I545befb2c592eea53c54552018ce2d3dda7670f5 > Reviewed-on: https://chromium-review.googlesource.com/509693 > Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > TBR=phajdan.jr@chromium.org,dpranke@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Bug: 661382 Change-Id: I4db9554a0a3a64a3a69908560b6da2a9963518f2 Reviewed-on: https://chromium-review.googlesource.com/512343Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
Paweł Hajdan, Jr authored
This feature appears unused, and removing it will simplify the codebase. Bug: 661382 Change-Id: I545befb2c592eea53c54552018ce2d3dda7670f5 Reviewed-on: https://chromium-review.googlesource.com/509693 Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
-
- 18 May, 2017 1 commit
-
-
Paweł Hajdan, Jr authored
This is based on https://codereview.chromium.org/2474543002/ Bug: 661382 Change-Id: I191ec16e0ce69a782979ae7d59b108747429ab78 Reviewed-on: https://chromium-review.googlesource.com/505067 Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Michael Moss <mmoss@chromium.org>
-
- 18 Apr, 2017 1 commit
-
-
Aaron Gable authored
Gerrit sometimes returns a full response json object at the same time as returning a non-200 status code. This refactor makes it easier for calling code to request access to that object and handle error cases on its own. The original version of this commit had a bug where ReadHttpResponse properly set the default value for accept_statuses, but all calls which came through ReadHttpJsonResponse were setting None instead. Bug: 710028 Change-Id: I8cee435d8acd487fb777b3fd69b5e48e19d2e5a3 Reviewed-on: https://chromium-review.googlesource.com/481060Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org>
-