1. 08 Apr, 2018 1 commit
  2. 31 Mar, 2018 1 commit
  3. 22 Mar, 2018 1 commit
    • Edward Lesmes's avatar
      gclient sync: Add support to apply gerrit refs. · c621b21a
      Edward Lesmes authored
      Mimics bot_update's functionality to apply gerrit refs in gclient
      via --gerrit-ref flags.
      When the patch fails to apply, gclient sync will return exit code 2.
      
      The idea is to move this logic from bot_update to gclient sync to
      deal when patches for projects like ANGLE are tried on Chromium bots.
      This way the patch is applied before recursively parsing and syncing
      ANGLE’s DEPS.chromium file, which doesn't currently happen.
      
      Bug: 643346
      
      Change-Id: I7e2018b3c393a5ac9852b8c3611f906977eeeb18
      Reviewed-on: https://chromium-review.googlesource.com/961605Reviewed-by: 's avatarAaron Gable <agable@chromium.org>
      Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
      c621b21a
  4. 20 Feb, 2018 1 commit
  5. 12 Feb, 2018 1 commit
  6. 06 Feb, 2018 1 commit
  7. 12 Oct, 2017 1 commit
    • Dirk Pranke's avatar
      Do not write gclient_gn_args_file too early. · 9f20d020
      Dirk Pranke authored
      Previously, gclient would attempt to write an args file after
      a dependency was checked out, but before any sub-dependencies
      had been checked out. If the args file path pointed at something
      inside a sub-dependency, this wouldn't work, because the directory
      might not yet exist. This most obviously happened for buildspec
      clobber builds.
      
      The fix is to wait until after the sub-dependencies have been
      checked out to write the file.
      
      R=phajdan.jr@chromium.org, mmoss@chromium.org
      BUG=773933
      
      Change-Id: I0cf4564204f7dabd9f843dc7904db7050fcc0d23
      Reviewed-on: https://chromium-review.googlesource.com/714644Reviewed-by: 's avatarPaweł Hajdan Jr. <phajdan.jr@chromium.org>
      Commit-Queue: Dirk Pranke <dpranke@chromium.org>
      9f20d020
  8. 02 Oct, 2017 2 commits
  9. 29 Sep, 2017 1 commit
  10. 26 Sep, 2017 1 commit
  11. 07 Sep, 2017 1 commit
  12. 18 Aug, 2017 1 commit
  13. 17 Aug, 2017 1 commit
  14. 10 Aug, 2017 2 commits
  15. 09 Aug, 2017 1 commit
  16. 03 Aug, 2017 1 commit
  17. 27 Jul, 2017 1 commit
  18. 25 Jul, 2017 2 commits
    • Paweł Hajdan Jr's avatar
      Revert "gclient flatten: preserve variable placeholders" · 393ba066
      Paweł Hajdan Jr authored
      This reverts commit e79ddeaa.
      
      Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=748486
      
      Original change's description:
      > gclient flatten: preserve variable placeholders
      > 
      > One of the main use cases is making it clear which revision hashes
      > need to be changed together. The way it's usually done is one variable
      > referenced several times. With this CL, we preserve the references
      > from original DEPS, as opposed to evaluating them and losing some info.
      > 
      > This CL actually makes Var() emit a variable placeholder
      > instead of its value, and adds support for these placeholders
      > to gclient.
      > 
      > One of possible next steps might be to deprecate Var().
      > 
      > Bug: 570091
      > Change-Id: I9b13a691b5203cc284c33a59438720e31c9ebf7a
      > Reviewed-on: https://chromium-review.googlesource.com/583617
      > Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
      > Reviewed-by: Dirk Pranke <dpranke@chromium.org>
      
      TBR=phajdan.jr@chromium.org,dpranke@chromium.org
      
      Change-Id: If9c52ebfa78aba8041ce797ff842d09952d0e2ce
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: 570091, 748486
      Reviewed-on: https://chromium-review.googlesource.com/584907Reviewed-by: 's avatarPaweł Hajdan Jr. <phajdan.jr@chromium.org>
      Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
      393ba066
    • Paweł Hajdan, Jr's avatar
      gclient flatten: preserve variable placeholders · e79ddeaa
      Paweł Hajdan, Jr authored
      One of the main use cases is making it clear which revision hashes
      need to be changed together. The way it's usually done is one variable
      referenced several times. With this CL, we preserve the references
      from original DEPS, as opposed to evaluating them and losing some info.
      
      This CL actually makes Var() emit a variable placeholder
      instead of its value, and adds support for these placeholders
      to gclient.
      
      One of possible next steps might be to deprecate Var().
      
      Bug: 570091
      Change-Id: I9b13a691b5203cc284c33a59438720e31c9ebf7a
      Reviewed-on: https://chromium-review.googlesource.com/583617
      Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
      Reviewed-by: 's avatarDirk Pranke <dpranke@chromium.org>
      e79ddeaa
  19. 24 Jul, 2017 1 commit
  20. 06 Jul, 2017 1 commit
  21. 03 Jul, 2017 1 commit
  22. 27 Jun, 2017 1 commit
  23. 23 Jun, 2017 1 commit
  24. 21 Jun, 2017 3 commits
    • Paweł Hajdan, Jr's avatar
      gclient: include deps_os entries in dependencies (reland #1) · fd0057e4
      Paweł Hajdan, Jr authored
      This is a reland of https://chromium-review.googlesource.com/c/541280/
      with a fix for https://bugs.chromium.org/p/chromium/issues/detail?id=735418
      (patchset 1 is original patch, patchset 2 has the fix).
      
      Keep deps_os entries in dependencies, just with should_process set to False
      for entries not applicable to target OS list.
      
      This way gclient flatten has proper access to dependencies e.g. to evaluate
      recursedeps referring to deps_os entries other than active OS.
      
      Allow but ignore deps_os overriding a value with None, since that does not
      fit the new model. There's no correctness harm in not checking out a repo.
      
      Allow "overrides" setting given dependency to the same value. This seems
      fairly common, especially for mac/ios and unix/android, even in chromium/src.
      
      Bug: 570091, 735418
      Change-Id: I6eba0e4be202212eb86cb959c18f2b2f0c1452b9
      Reviewed-on: https://chromium-review.googlesource.com/543076
      Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
      Reviewed-by: 's avatarAndrii Shyshkalov <tandrii@chromium.org>
      fd0057e4
    • Andrii Shyshkalov's avatar
      Revert "gclient: include deps_os entries in dependencies" · 806b7018
      Andrii Shyshkalov authored
      This reverts commit 529d6a4e.
      
      Reason for revert: broke developers and CI/Try checkouts.
      
      Bug: 735418
      
      Original change's description:
      > gclient: include deps_os entries in dependencies
      > 
      > Keep deps_os entries in dependencies, just with should_process set to False
      > for entries not applicable to target OS list.
      > 
      > This way gclient flatten has proper access to dependencies e.g. to evaluate
      > recursedeps referring to deps_os entries other than active OS.
      > 
      > Allow but ignore deps_os overriding a value with None, since that does not
      > fit the new model. There's no correctness harm in not checking out a repo.
      > 
      > Allow "overrides" setting given dependency to the same value. This seems
      > fairly common, especially for mac/ios and unix/android, even in chromium/src.
      > 
      > Bug: 570091
      > Change-Id: I2037a1ecc5fd2da6b5f73061548b81fc79ba2e72
      > Reviewed-on: https://chromium-review.googlesource.com/541280
      > Reviewed-by: Dirk Pranke <dpranke@chromium.org>
      > Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
      
      TBR=phajdan.jr@chromium.org,dpranke@chromium.org
      
      Change-Id: Iaa0c39865908a5b25c15dda54ba61c0e76abcbea
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: 570091
      Reviewed-on: https://chromium-review.googlesource.com/543138Reviewed-by: 's avatarAndrii Shyshkalov <tandrii@chromium.org>
      Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
      806b7018
    • Paweł Hajdan, Jr's avatar
      gclient: include deps_os entries in dependencies · 529d6a4e
      Paweł Hajdan, Jr authored
      Keep deps_os entries in dependencies, just with should_process set to False
      for entries not applicable to target OS list.
      
      This way gclient flatten has proper access to dependencies e.g. to evaluate
      recursedeps referring to deps_os entries other than active OS.
      
      Allow but ignore deps_os overriding a value with None, since that does not
      fit the new model. There's no correctness harm in not checking out a repo.
      
      Allow "overrides" setting given dependency to the same value. This seems
      fairly common, especially for mac/ios and unix/android, even in chromium/src.
      
      Bug: 570091
      Change-Id: I2037a1ecc5fd2da6b5f73061548b81fc79ba2e72
      Reviewed-on: https://chromium-review.googlesource.com/541280Reviewed-by: 's avatarDirk Pranke <dpranke@chromium.org>
      Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
      529d6a4e
  25. 13 Jun, 2017 1 commit
  26. 07 Jun, 2017 1 commit
  27. 06 Jun, 2017 2 commits
  28. 29 May, 2017 2 commits
  29. 23 May, 2017 3 commits
  30. 18 May, 2017 1 commit
  31. 18 Apr, 2017 1 commit