This version of upload.py is slightly less annoying, it won't cancel out if no
patchset title is provided and disable colors all the time.

R=cmp@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/9233057

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@121826 0039d316-1c4b-4281-b951-d872f2087c98

also, use http download instead of scp,
because scp won't work well on Windows.

BUG=chromium:113153
Review URL: https://chromiumcodereview.appspot.com/9369023

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@121820 0039d316-1c4b-4281-b951-d872f2087c98

Should be no functional change.
Necessary for a follow-up change I'm making.

Review URL: http://codereview.chromium.org/9385017

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@121590 0039d316-1c4b-4281-b951-d872f2087c98

Everyone at this point should have been migrated to the new format.

Review URL: http://codereview.chromium.org/9385010

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@121509 0039d316-1c4b-4281-b951-d872f2087c98

Prints the bots a tryjob would use if sent out.
(Does not send out the job.)

Review URL: http://codereview.chromium.org/9348068

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@121409 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/9264044

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@120586 0039d316-1c4b-4281-b951-d872f2087c98

If we quote as --receive-pack="git receive-pack --reviewer=foo@example.com",
git will try to run "git receive-pack --reviewer=foo@example.com" command
and failed like this

Gerrit Code Review: git receive-pack --reviewer=foo@example.com: not found
fatal: The remote end hung up unexpectedly
Command "git push --receive-pack="git receive-pack --reviewer=foo@example.com" origin HEAD:refs/for/master" failed.

Review URL: http://codereview.chromium.org/9325018

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@120337 0039d316-1c4b-4281-b951-d872f2087c98

For some reason, on Mac setup_tools won't create the installation directory if
it doesn't exist, while it appears to do so on Linux and Windows.

BUG=
TEST=


Review URL: http://codereview.chromium.org/9323030

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@120331 0039d316-1c4b-4281-b951-d872f2087c98

This is the bare beginnings of Gerrit support for (non-repo) depot_tools,
based on Roland's work.
Differnt from http://codereview.chromium.org/8826015/
 it read codereview.settings and if it has GERRTI_HOST and GERRIT_PORT,
 then "git cl config" configured it for gerrit.
   installs hooks/commit-msg
   git config gerrit.host $GERRIT_HOST
   git config gerrit.port $GERRIT_PORT

 if it has gerrit.host config, "git cl upload" will upload a change
 to gerrit as
   "git push --receive-pack=... origin master"
 it scans description and extract reviewers from R= line.

Review URL: http://codereview.chromium.org/9264065

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@120276 0039d316-1c4b-4281-b951-d872f2087c98

This CL introduces package_management.py, a module for managing third-party Python packages in a site directory within depot_tools. A future CL will integrate this with depot_tools, causing the packages to be downloaded and installed on first run after that CL lands. Once in place presubmit_canned_checks will be extended to make use of the locally installed version of pylint.

BUG=
TEST=


Review URL: http://codereview.chromium.org/8965033

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@120225 0039d316-1c4b-4281-b951-d872f2087c98

Upstream cpplint.py r79 ("Convert windows path seperators to unix like while doing IncludeWhatYouUse.")

Review URL: http://codereview.chromium.org/9159036

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@119713 0039d316-1c4b-4281-b951-d872f2087c98

this forces license headers, no line-end whitespace, etc.

Also update the default license header regex to allow concluding */ on the final line.

Review URL: http://codereview.chromium.org/9109001

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@119448 0039d316-1c4b-4281-b951-d872f2087c98

TBR=ben
Review URL: https://chromiumcodereview.appspot.com/9298002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@119353 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/9113091

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@119290 0039d316-1c4b-4281-b951-d872f2087c98

R=cmp@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/9234038

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@119264 0039d316-1c4b-4281-b951-d872f2087c98

It also removes the need of manually creating a subject argument.

Other related changes in this CL:
- Reenable the prompt for patchset title in gcl. I'm not sure why it was disabled.
- Remove git cl upload --desc_from_logs flag. --force is already meaningful.

R=cmp@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/9193023

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@119066 0039d316-1c4b-4281-b951-d872f2087c98

R=cmp@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/9212062

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@119064 0039d316-1c4b-4281-b951-d872f2087c98

It speeds up significantly these tests.

R=cmp@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/9283041

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@118912 0039d316-1c4b-4281-b951-d872f2087c98

R=cmp@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/9222016

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@118711 0039d316-1c4b-4281-b951-d872f2087c98

Built by running `./ninja && strip ninja` on
a (64bit) 10.6 Mac and on a 64bit linux box.
TBR=evan
Review URL: https://chromiumcodereview.appspot.com/9262002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@118205 0039d316-1c4b-4281-b951-d872f2087c98

TBR=thakis@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/9251005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@118017 0039d316-1c4b-4281-b951-d872f2087c98

BUG=108515

Review URL: http://codereview.chromium.org/9255001

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@118008 0039d316-1c4b-4281-b951-d872f2087c98

I found out that some devs thought that -f just skipped the prompt, but it did
in fact also skip the presubmit checks.
Make -f do what it should, no prompt and just return if the presubmit check
failed.

R=cmp@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/9240009

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@117918 0039d316-1c4b-4281-b951-d872f2087c98

This required fixing the adhoc mock to be more versatile.

TBR=cmp@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/9178019

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@117896 0039d316-1c4b-4281-b951-d872f2087c98

Enable it for git-cl and gcl.

R=nsylvain@chromium.org
BUG=107838
TEST=New connections go through https://


Review URL: http://codereview.chromium.org/9214004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@117857 0039d316-1c4b-4281-b951-d872f2087c98

So any modification to the defaults is coded at only one place.

TBR=nsylvain@chromium.org
BUG=107838
TEST=


Review URL: http://codereview.chromium.org/9214002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@117853 0039d316-1c4b-4281-b951-d872f2087c98

R=cmp@chromium.org
BUG=25940
TEST=


Review URL: http://codereview.chromium.org/9211013

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@117851 0039d316-1c4b-4281-b951-d872f2087c98

R=cmp@chromium.org
BUG=25940
TEST=


Review URL: http://codereview.chromium.org/9112039

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@117850 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/9214014

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@117754 0039d316-1c4b-4281-b951-d872f2087c98

The shell script currently just assumes Linux, but can be
fixed to run the Mac binary when appropriate.

Review URL: http://codereview.chromium.org/9212017

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@117723 0039d316-1c4b-4281-b951-d872f2087c98

When a file contains a single line of text, svn diff will generate an odd hunk
header. Modify the hunk parsing code to accept this format.

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/9147056

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@117143 0039d316-1c4b-4281-b951-d872f2087c98

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/9172003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@117133 0039d316-1c4b-4281-b951-d872f2087c98

Fix RAW.NEW_NOT_NULL parsing to detect correctly it's a new file.

Add proper Hunk parsing to fix these 2 bugs.

R=dpranke@chromium.org
BUG=109715
TEST=CQ'ing a patch generated with svn that delete files is applied properly, e.g. the file is deleted and not simple 0-length.


Review URL: http://codereview.chromium.org/9167015

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@117084 0039d316-1c4b-4281-b951-d872f2087c98

I'm not sure why it hasn't triggered before.

TBR=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/9172002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@117054 0039d316-1c4b-4281-b951-d872f2087c98

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/9127026

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@117040 0039d316-1c4b-4281-b951-d872f2087c98

I don't want to receive them even in the case of a direct call to SendStack().

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/9145001

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@117039 0039d316-1c4b-4281-b951-d872f2087c98

It appears to have been broken in http://crrev.com/104148

BUG=102205

Review URL: http://codereview.chromium.org/9108030

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@116723 0039d316-1c4b-4281-b951-d872f2087c98

svn info --xml will return
<entry (...) revision="Resource is not under version control."> for
new files, causing an exception in the parsing code.

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/9110010

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@116522 0039d316-1c4b-4281-b951-d872f2087c98

As a n0oB to Chrome, I sometimes deleted uploaded CLs on codereview.chromium.org
after looking at them and deciding they were unsuitable for review. I
would then later git cl upload and get a confusing stacktrace about a
404. This change lets the user know why the error happened, and how to
resolve it.

I decided not to auto-scrub the old issue on the client side, because
the 404 might be spurious (server misconfiguration, bug in my code, etc.).
Safer to make the user explicitly run the command.

Review URL: http://codereview.chromium.org/9091009

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@116360 0039d316-1c4b-4281-b951-d872f2087c98

The purpose of this is so that cros can roll out repo updates at our
own pace (including testing), rather than being at the mercy of android
project rolling something out that may break our setup.

BUG=chromium-os:24413

Review URL: http://codereview.chromium.org/9021045

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@115533 0039d316-1c4b-4281-b951-d872f2087c98