- 12 Feb, 2018 1 commit
-
-
Matt Giuca authored
Previously, if you used custom metadata keys in a test commit (like GitRepo.AUTHOR_NAME), they would also be treated as filenames, and fail because they aren't strings. (This wasn't a problem because it isn't currently used in any tests.) Bug: 808941 Change-Id: Id7c4fa5822741925beba591ea587bd8ebbf2e478 Reviewed-on: https://chromium-review.googlesource.com/901122Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
-
- 09 Feb, 2018 3 commits
-
-
Aaron Gable authored
The purpose of this CL is to remove confusion around whether or not git-cl support the similarity flags when talking to Gerrit. It does not. However, because Rietveld support has not been fully ripped out of git-cl, this change does modify some of the Rietveld-specific code to remove similarity support from everywhere. Bug: 800902 Change-Id: I8703ed60d6889c7a36400b8a9f8f26de4669020a Reviewed-on: https://chromium-review.googlesource.com/912389Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org>
-
Bruce Dawson authored
post_build_ninja_summary.py analyzes the .ninja_log file in an output directory to summarize build performance. It lists the most expensive build steps, and build-step types, printing both their elapsed time and, more importantly, their "weighted" time which is a measure of their contribution to the total build time. For each time segment within the build the running build steps accumulate weighted time that is proportional to the elapsed time divided by the number of tasks running. If a thousand compilation steps are running in parallel then they will each be "charged" for 1/1,000th of the elapsed time. If a single link step is running alone then it is charged with all of the elapsed time. Bug: chromium:787983 Change-Id: Id5aea715f798a16415dd0365a27f0051202668e5 Reviewed-on: https://chromium-review.googlesource.com/871988Reviewed-by: Dirk Pranke <dpranke@chromium.org> Reviewed-by: Erik Staab <estaab@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
-
Torne (Richard Coles) authored
After the initial gclient sync, "fetch --no-history" was adding a fetchspec to the config for the main repository that causes all tags to be downloaded in future. This means that after fetching a repository with no history, the very next git pull (or other remote update operation) will download all the tags, including all the history referred to by those tags, leaving you with an almost-complete checkout of the top-level repository that takes up much more space. Fix this by skipping the "git config" command that requests the tags when using no-history. Change-Id: Ia31baa6a90df014ebc1e8c2ed6e05de3ad27d415 Reviewed-on: https://chromium-review.googlesource.com/909653Reviewed-by: Aaron Gable <agable@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org>
-
- 08 Feb, 2018 4 commits
-
-
Vadim Shtayura authored
No code changes, just rebuilt with 1.9.4 that includes potential fix for deadlocks on Windows. R=iannucci@chromium.org BUG=810072 Change-Id: Ic39de760657e86abb5667b6fd9d200e74b140aeb Reviewed-on: https://chromium-review.googlesource.com/909725Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
-
Tom Anderson authored
Also, some lines went over 80chars, so I ran 'yapf --style chromium' which formatted some unrelated things. BUG=905285 R=dpranke Change-Id: Iee5f46d88a6e9782612cc4f9e5a2cb72d62ab6af Reviewed-on: https://chromium-review.googlesource.com/907736 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
-
Robert Iannucci authored
This only includes the change to remove all VIRTUALENV envvars when vpython preps environments. See https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/907929 R=dnj@chromium.org, vadimsh@chromium.org Bug: 808434 Change-Id: I2f6f1b2cec342997081322884b9dde06557a0c60 Reviewed-on: https://chromium-review.googlesource.com/908058 Commit-Queue: Nodir Turakulov <nodir@chromium.org> Reviewed-by: Daniel Jacques <dnj@chromium.org> Reviewed-by: Nodir Turakulov <nodir@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/0584da0c3d052d75bba9cd4108b307f43852024a [luci-auth] Make service_account module use luci-auth (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I96e7cad4e152e7625fc15f09fa4b2290dc52c302 Reviewed-on: https://chromium-review.googlesource.com/907233Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
-
- 07 Feb, 2018 8 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/baa8aadd3db91c4870bcc82c1091f25944dfdc96 scheduler recipe_module: remove deprecated method. (tandrii@chromium.org) https://crrev.com/745f389a0d8fe49cc34f96704e5ad3dc0df406ec Don't block on OWNERS approval of README.recipes.md. (tandrii@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I8ab818dbebce2c51f00752059e1e754fc8950bcb Reviewed-on: https://chromium-review.googlesource.com/907131 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
-
Edward Lemur authored
Bug: 728298 Change-Id: If813ff41b1668a2cab6c26b65e424fbe574e629c Reviewed-on: https://chromium-review.googlesource.com/899086 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by: Aaron Gable <agable@chromium.org>
-
Robert Iannucci authored
This is already rolled to all buildbot machines; was waiting to roll vpython in depot_tools last, but it appears that their builds may actually depend on the version here. f88d8d9aa [buildbucket] cancel swarming tasks when deleting builds 0c7d29eb5 Roll recipe dependencies (trivial). 58cd44f90 Roll luci-go. b3dbb75ba Roll recipe dependencies (trivial). 57743d010 Revert "Remove temporary code used to add https to hosts" 4592a0a20 [buildbucket] refactor task cancelation 76f45a19b Roll recipe dependencies (trivial). b2fb6be8e [som] Fix some FE unit tests. 57f45c589 [som] Update RELNOTES.md c7bc0b942 Roll recipe dependencies (trivial). f91ebe64a SoM: Add autosuggested labels back. b2de6ae83 [Findit] Translate test failure to event schema 52adb6e67 Roll recipe dependencies (trivial). efa035c1d [Monorail] Follow-up fix for presubmit browser compat fix bf5820217 [prpc,luci-auth] Set builds to use static linking. 959f0f9bc SoM: Update ChOpsUI version. 91e92e1e6 Roll luci-go. ebc1baca9 Roll recipe dependencies (trivial). 47b35eab2 In set review request, use patch set number 886cc525e [buildbucket] no kitchen output file => Infra failure d73861ca3 [Predator] Increase soft memory for uma sampling profiler. cd84bd1c5 [buildbucket] refactor build_run_result loading 011e82c92 [Monorail] Fix two issues introduced by presubmit Safari/IE fix a004798d1 [luci-migration] Surface Infra Failures information. 3a20d2ded Roll recipe dependencies (trivial). 7d82e1b8b Roll recipe dependencies (trivial). a2eb2e90f [Findit] Flake Analyzer - Run more try jobs. 9a3bd613e Roll recipe dependencies (trivial). 42f912526 Roll recipe dependencies (trivial). 66acb1cd1 Update path in example input in GitFileIsolator test 18b65029f Add a note to the GitRef comment in Tricium AnalyzeRequest 78bd9ceaf [Tricium] Proofread and reformat comments 11d51e0f0 Remove temporary code used to add https to hosts b6876f848 Fix two minor spelling issues in isolate.go 9aeb8d71f Roll recipe dependencies (trivial). fffcbaf25 Roll recipe dependencies (trivial). 2d91b6863 [Findit] Instrument bug filing to use CustomFields instead of labels 5a87eb159 Roll luci-go and luci/gae. 37175a98c Roll recipe dependencies (trivial). 965cb361b Revert "Use git.exe and python.exe from %PATH% on Windows" 3ca5b0adb Roll luci-go DEPS 0ae3fcdc2 [test-results] Parse build_id form parameters from uploads. dd5056295 Roll recipe dependencies (trivial). 896ada564 Roll recipe dependencies (trivial). 71ed7ee94 [som] Add monitoring metrics for alert *groups* 549b91906 Make submodules respect 'condition' for inclusion. f39b717ce Roll recipe dependencies (trivial). 19eb6271e Roll recipe dependencies (trivial). 75aa8fc6a [Findit] Move swarming related logic only for flake analyzer to a separate module. 6429566ed [Findit] Translate models to BQ schema for test flake & compile failure 8d1731533 Roll recipe dependencies (trivial). 7c8adc760 Roll recipe dependencies (trivial). a1844f202 [Monorail] Refine the order that we peel off autolinking trailing delimeters. 5409e9f46 Roll recipe dependencies (trivial). c69c8d781 bot_setup: do not initialize swarming client on multibots 66388a79d Roll recipe dependencies (trivial). 61163aa41 Roll recipe dependencies (trivial). 4c5009d2a Roll recipe dependencies (trivial). 03f5cac69 Use system python for preallocated Swarming bots. 3d0fe245d Roll recipe dependencies (trivial). 0c35aa4a3 [Findit] miscellaneous bug fixes 1cb856336 Roll recipe dependencies (trivial). f1e5e0076 [doc] Document permissions for cross-project joins bb4241f99 [Monorail] Fix typo in SQL declarations. b8e22ed36 Roll recipe dependencies (trivial). 7f8d1f1ab [buildbucket] make timing metrics cumulative 1d7d9ffa0 Roll recipe dependencies (trivial). 6afb9a8c8 Roll recipe dependencies (trivial). bd4151e59 Roll recipe dependencies (trivial). d450c3faf Roll recipe dependencies (trivial). 783bc9322 Roll recipe dependencies (trivial). f2770a571 Roll recipe dependencies (trivial). e9b8e600b Roll recipe dependencies (trivial). 03db6cde2 [Findit] move all gtest specific logic to services/gtest.py c4884b963 Use GCE service account when fetching Swarming bot code. a4f61f59e Roll recipe dependencies (trivial). 1ebe658ce Gen some ssh keys on cros container startup. 382263cf8 Roll recipe dependencies (trivial). 26b8b693e Point swarm*-c7 to chrome-swarming.appspot.com d0b138cd0 [Predator] Strip parentheses in function name when matching with crash_state. b35020f73 Allow force-version and migrate-to to accept versions greater than 9 2f0a1df32 Roll recipe dependencies (trivial). 5c77e779e Roll recipe dependencies (trivial). 6cb457523 [Monorail] Add instructions for running one unit test 64291222f Roll recipe dependencies (trivial). e50870d52 [Monorail] Fix presubmit JS incompatibility 7d8342ee3 Roll luci-go DEPS. afaeeb0fc [Tricium] Include notify: NONE when posting to Gerrit a2985c216 [Findit] Refactoring BigQuery schema for analysis events f8272181b [Monorail] Make autocomplete dropdown accessible for ChromeVox users. d31763ca4 [Findit] Add bigquery helper that interacts with BQ REST API d4dc0c29a mac_toolchain: add support for legacy Xcode 8.* a304231ca Roll recipe dependencies (trivial). 6ec369965 Roll recipe dependencies (trivial). 4d60ec8f8 Roll recipe dependencies (trivial). 07e3fd5ed Roll recipe dependencies (trivial). 390212979 [Findit] Move gtest related logic to gtest.py (1/2) d5e83d77d Roll recipe dependencies (trivial). 5df250555 Generalize android_docker image building for CrOS as well. ed978bda5 [buildbucket] use swarming's timestamps a14f4bfb9 Roll recipe dependencies (trivial). 68f043ea7 Roll recipe dependencies (trivial). a926b8f75 [Monorail] Autolink text in bigger issues. 63a39573b [som] Update RELNOTES.md 3ae74f454 Roll recipe dependencies (trivial). 4d5af48ff Roll recipe dependencies (trivial). 9d0c9b8b3 Roll recipe dependencies (trivial). cd4db1329 Add approval_id to FieldDef table. 3ad142a2c [som] Increase client RPC timeouts to 1 minute eaaa18b94 Roll recipe dependencies (trivial). 09b3ab3ff Roll recipe dependencies (trivial). 64bcfd437 Roll recipe dependencies (trivial). 2faa1f2ac Roll recipe dependencies (trivial). 2e0feb96a Roll recipe dependencies (trivial). 86e40f0c0 Bootstrap gn with clang 9c305f17f [Findit] Ignore IntelliJ project files 17bd7606d [bbroll] Fix other link :) 94c06b37a Add IssueSnapshot table SQL schema and join tables b0f8ad63f [Findit] Flake Analyzer - New DetermineApproximatePassRatePipeline 89dfd42af Roll recipe dependencies (trivial). 00ac3227d Roll recipe dependencies (trivial). aab58f01d Roll recipe dependencies (trivial). c643aedfe [bbroll] Fix canary links. 52f211da7 Monorail: Allow specifying one label in an email address for ticket alerts. dd7df86a2 [bq events] Update docs with comments about SoM and test-results tables. TBR=vadimsh@chromium.org Bug: 808434 Change-Id: Id16a8758257ad0c531b0a590e923b3b4d3442397 Reviewed-on: https://chromium-review.googlesource.com/905830Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/3bc7426647d70d8ba58b895becc276ac3518917c scheduler recipe module: use classes instead of raw dicts. (tandrii@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I40e68ea96f302536e281d6f0462dd8cea52a8ff4 Reviewed-on: https://chromium-review.googlesource.com/905601 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
-
Tom Anderson authored
BUG=807986 R=dpranke Change-Id: I6b7e94d489a228c5dde23a9b6c7d6f58ce73b180 Reviewed-on: https://chromium-review.googlesource.com/905285Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/b80999e32c0692d0ab2fe00722c2550f8b74c0ac raw_io: fix to use splitlines for add_output_log (tikuta@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ia4b2f1c2d20e4e8f511cc12cc8fca9391382a42e Reviewed-on: https://chromium-review.googlesource.com/905593Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
-
Andrii Shyshkalov authored
This reverts commit fa573785. Reason for revert: broke CQ on branches. Example: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/chromium_presubmit/28220 Original change's description: > bot_update: allow rebasing the patch onto an older revision. > > When applying a rebase, we normally go from an older base commit to a newer one. > > A ---- B ---- C ---- D -origin/master > \ > E -branch > > In this case, `git rebase D` would certainly work as expected. However, > writing `git rebase B` would NOT get us to the following state: > > A ---- B ---- C ---- D -origin/master > \ > E' -branch > > In fact, it would have no effect. > > This article http://matthew-brett.github.io/pydagogue/rebase_without_tears.html > explains the general invocation as > > `git rebase --onto <graft-point> <exclude-from> <include-from>` > > If you don’t specify --onto, <graft-point> defaults to <exclude-from> > > So what's happening is, by writing `git rebase B` we're rebasing onto B, > excluding commits that are in B. Commit C is not "in" B so it is kept and we're > back to the starting point. > > So I suggest to change the invocation to `git rebase --onto B origin/master`, > which rebases onto B, excluding commits that are in origin/master. This works > more generally and allows rebasing "backwards". > > Bug: None > Change-Id: I68e4d805811530b585550bc75099354fef4e9c15 > Reviewed-on: https://chromium-review.googlesource.com/904004 > Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> > Commit-Queue: Oleh Prypin <oprypin@chromium.org> TBR=iannucci@chromium.org,tandrii@chromium.org,oprypin@chromium.org Change-Id: I7243641d84428bf4504ee798bf31ad0afbfd4865 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://chromium-review.googlesource.com/905862 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
-
Robert Iannucci authored
R=tandrii@chromium.org, vadimsh@chromium.org Bug: 809645 Change-Id: I21ad49fa03630955eca6ecd531445bc4acf0c0c6 Reviewed-on: https://chromium-review.googlesource.com/905822Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
-
- 06 Feb, 2018 7 commits
-
-
Robert Iannucci authored
This will be used when running infrastructure code locally (e.g. recipes) to correctly interact with LUCI service APIs (such as luci-scheduler.appspot.com). It is also generically useful to explore and interact with LUCI service APIs on the command line (for debugging/scripting). R=tandrii@chromium.org, vadimsh@chromium.org Bug: 808677 Change-Id: I41cfd4cc7e2d245d3a5d2be83f9879f92a8d1bca Reviewed-on: https://chromium-review.googlesource.com/905457 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
-
Andrii Shyshkalov authored
Goal: reduce number of git fetches from remote to the minimum possible. Minimum possible is either: * 0 if desired revision is pinned (!= HEAD) and already exists in cache * 1 if desired revision is HEAD * >= 2 if revision is pinned but we talk temporarily out-of-date git server not yet having it. This CL achieves the above. No fetch: https://ci.chromium.org/swarming/task/39dad20230c84110?server=chromium-swarm.appspot.com bot_update takes <1min, but it used to take at least 2. The steps are now like this: ... ===Running git cat-file -e 33bf8a94dcd5e0abbdf83e4afaed24b5180e3eb2=== In directory: /b/swarming/w/ir/cache/git/chromium.googlesource.com-chromium-src ===Succeeded in 0.0 mins=== ===Running /b/swarming/w/ir/cipd_bin_packages/bin/python -u /b/swarming/w/ir/recipe-checkout-dir/depot_tools/git_cache.py exists --quiet --cache-dir /b/swarming/w/ir/cache/git https://chromium.googlesource.com/chromium/src.git=== In directory: /b/swarming/w/ir/cache/builder/linux /b/swarming/w/ir/cache/git/chromium.googlesource.com-chromium-src ===Succeeded in 0.0 mins=== ===Running git remote set-url origin /b/swarming/w/ir/cache/git/chromium.googlesource.com-chromium-src=== In directory: /b/swarming/w/ir/cache/builder/linux/src ===Succeeded in 0.0 mins=== ===Running git fetch origin=== In directory: /b/swarming/w/ir/cache/builder/linux/src From /b/swarming/w/ir/cache/git/chromium.googlesource.com-chromium-src 003eedbfee47..5210107a20e8 master -> origin/master ===Succeeded in 0.0 mins=== ===Running git checkout --force 33bf8a94dcd5e0abbdf83e4afaed24b5180e3eb2=== ... Fetch & success: https://ci.chromium.org/swarming/task/39db022b874ffd10?server=chromium-swarm.appspot.com Fetch & retry because missing rev: https://ci.chromium.org/swarming/task/39db04ce8b4b8910?server=chromium-swarm.appspot.com Fetch because rev=HEAD: https://ci.chromium.org/swarming/task/39db0c0dd5ab5d10?server=chromium-swarm.appspot.com This has already been adopted in gclient. Bug: Change-Id: Id99892b62719fdf3f7e6e59058986d1500384f8d Reviewed-on: https://chromium-review.googlesource.com/771591 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>
-
Tom Anderson authored
This CL adds target_cpu and target_cpu_only variables. The logic is: * If target_cpu is defined in .gclient, use it. Otherwise, initialize it as an empty list. * If not target_cpu_only, add the host arch to the list too. detect_host_arch.py is copied directly from the Chromium repo. BUG=807986 R=dpranke Change-Id: I27621cbc81ad6a844648525863b92ffdd3b1d03a Reviewed-on: https://chromium-review.googlesource.com/902441 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
-
Oleh Prypin authored
When applying a rebase, we normally go from an older base commit to a newer one. A ---- B ---- C ---- D -origin/master \ E -branch In this case, `git rebase D` would certainly work as expected. However, writing `git rebase B` would NOT get us to the following state: A ---- B ---- C ---- D -origin/master \ E' -branch In fact, it would have no effect. This article http://matthew-brett.github.io/pydagogue/rebase_without_tears.html explains the general invocation as > `git rebase --onto <graft-point> <exclude-from> <include-from>` > If you don’t specify --onto, <graft-point> defaults to <exclude-from> So what's happening is, by writing `git rebase B` we're rebasing onto B, excluding commits that are in B. Commit C is not "in" B so it is kept and we're back to the starting point. So I suggest to change the invocation to `git rebase --onto B origin/master`, which rebases onto B, excluding commits that are in origin/master. This works more generally and allows rebasing "backwards". Bug: None Change-Id: I68e4d805811530b585550bc75099354fef4e9c15 Reviewed-on: https://chromium-review.googlesource.com/904004Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Oleh Prypin <oprypin@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/a262d9709414e7270ee617510bd720b19e229779 raw_io: add add_output_log option (tikuta@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Icac945216219b5cb33bff914bc6f312595c5c6bc Reviewed-on: https://chromium-review.googlesource.com/905482 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
-
Michael Moss authored
BUG=783607 R=agable@google.com, dpranke@google.com Change-Id: I6989203a9e560930cc53254c566275a30d3bead3 Reviewed-on: https://chromium-review.googlesource.com/902168Reviewed-by: Aaron Gable <agable@chromium.org> Commit-Queue: Michael Moss <mmoss@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/8f09f5f2571c4ec5b22269eb44e53742dfae29fb Add sleep to the time recipe module (mknyszek@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I1889cd049d05e3e400b5e3ccbac4b73273791ce7 Reviewed-on: https://chromium-review.googlesource.com/903282Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
-
- 05 Feb, 2018 1 commit
-
-
John Budorick authored
TBR=agable@chromium.org Bug: 789809 Change-Id: I4ede72a3584b23d01063e5cfa20401c921762b50 Reviewed-on: https://chromium-review.googlesource.com/900664Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org>
-
- 02 Feb, 2018 3 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/c9374582f3cbe9b1e54eaa851b891de56b7b7aa9 Add scheduler recipe module with EmitTrigger RPC support only. (tandrii@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ibddefab48c94b9c034068cbe24b86dd46c85dc19 Reviewed-on: https://chromium-review.googlesource.com/900189 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
-
Aaron Gable authored
R=maruel Change-Id: I0a5a18d598632bc77a8c70a21c8b3c4c2223d543 Reviewed-on: https://chromium-review.googlesource.com/899682Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org>
-
Michael Achenbach authored
The first call to gsutil causes a network call and makes the download script slow also in the most optimal cases. This CL refactors the download script and moves the first gsutil call after checking locally if sha1s match. 1) This turns the input acquisition into a generator and buffers the files and sha1s in a list before multithreading. 2) This sequentially checks the sha1s and files and bails out early if all match. In Chrome-land, we usually call this script with only one file. There are some cases with around 4. This could also be parallelized if the need arises. 3) The initial gsutil check, which ensures gsutil is updated, is moved right in front of the multithreaded downloads. The performance of one call to download_from_google_storage for an existing 500MB file is 2.3s before this CL and 1.2s after (most of the remaining time left is spent for making sha1sum). Example for full gclient runhooks (when everything is up-to-date): Chromium: 32s before, 12s after V8: 12s before, 3s after Bug: 776311 Change-Id: Ia7715a6af84b1b336455ea88494d399bdb050317 Reviewed-on: https://chromium-review.googlesource.com/897562 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by: Ryan Tseng <hinoka@chromium.org>
-
- 01 Feb, 2018 5 commits
-
-
Sergey Berezin authored
Relevant commits: d4dc0c29a mac_toolchain: add support for legacy Xcode 8.* BUG=797051 TBR=vadimsh@chromium.org Change-Id: I79a77a03b332d7f4bfbe8208928d67194dfc1854 Reviewed-on: https://chromium-review.googlesource.com/897685Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org> Commit-Queue: Sergey Berezin <sergeyberezin@chromium.org>
-
Lei Zhang authored
This is needed for run_presubmit.py to work. BUG=pdfium:971 Change-Id: Ib598fbfd6eab3c0b7628301eb3bd54c548a4885e Reviewed-on: https://chromium-review.googlesource.com/898039Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org>
-
Michael Moss authored
This has been supported in gclient, and used in DEPS, since https://crrev.com/c/687496. R=dpranke@google.com, iannucci@google.com Bug: 570091,807318 Change-Id: I59935625e3bae6010a371ad7bb1413e177a09176 Reviewed-on: https://chromium-review.googlesource.com/896835Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Michael Moss <mmoss@chromium.org>
-
Michael Moss authored
Flattening currently ignores custom_vars, but it looks like that was just an attempt to avoid including all the runtime-calculated values (e.g. the host OS) in the flattened output, and not because there's any real issue with supporting explicit overrides. This is useful for changing default values in the flattened buildspecs (e.g. to enable internal checkouts by default). R=dpranke@google.com, iannucci@google.com Bug: 570091,807318 Change-Id: I6d743f33cf7e3e202d5e68d21657f74f0e4c001b Reviewed-on: https://chromium-review.googlesource.com/895927Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Michael Moss <mmoss@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/d047343541342f1e360ba98704216a717f23a1af [buildbucket] add build_id property (nodir@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I0cb3812b1e86d12aaa9dd4101adb40a392b9e99c Reviewed-on: https://chromium-review.googlesource.com/896842Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
-
- 31 Jan, 2018 2 commits
-
-
Robert Iannucci authored
R=nodir@chromium.org Bug: 801960,804174 Change-Id: I9f87db6be2d9470384d364591b5d5ff3b5a7b3d9 Reviewed-on: https://chromium-review.googlesource.com/894893Reviewed-by: Nodir Turakulov <nodir@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
-
Edward Lemur authored
This will allow us to show the progress when cloning a new repo when running commands like gclient sync. R=agable@chromium.org Bug: 722686 Change-Id: I268cba343ea4c3c024292c9341d5009aa112b184 Reviewed-on: https://chromium-review.googlesource.com/890524 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by: Aaron Gable <agable@chromium.org>
-
- 29 Jan, 2018 2 commits
-
-
Benjamin Pastene authored
This is necessary for https://chromium-review.googlesource.com/c/chromium/src/+/882196. Bug: 776987 Change-Id: Iec0a960a7d80f3ddbc0252073e30abc5a243f06c Reviewed-on: https://chromium-review.googlesource.com/882318Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Benjamin Pastene <bpastene@chromium.org>
-
Edward Lemur authored
Add an option to not store stdout when running commands unless it's needed. R=agable@chromium.org Bug: 722686 Change-Id: I402c83767097d53e588ba3e8bca89291712a572f Reviewed-on: https://chromium-review.googlesource.com/888584Reviewed-by: Aaron Gable <agable@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
- 27 Jan, 2018 2 commits
-
-
Nicolas Boichat authored
Bug: Change-Id: I382ed2fe8544583005e7bfa4479600a90b646ca7 Reviewed-on: https://chromium-review.googlesource.com/888118Reviewed-by: Aaron Gable <agable@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Nicolas Boichat <drinkcat@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/e0a35d1c979628a0c8f5f3cf233ea727c7ee2ef5 Add support for unquote to url recipe module (mknyszek@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Id8603a0484747885f2c0bb11c61ca224948391a7 Reviewed-on: https://chromium-review.googlesource.com/889941 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
-
- 26 Jan, 2018 2 commits
-
-
John Budorick authored
Change-Id: I46d3bc00a7d66f8754a3b9a535d5d9817166b777 Reviewed-on: https://chromium-review.googlesource.com/889416Reviewed-by: Aaron Gable <agable@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org>
-
Aaron Gable authored
I don't know of any use-case where someone would want to use git-cl-patch to pull a (e.g.) chromium change into their (e.g.) v8 checkout. Bug: 803918 Change-Id: Id53f1cc3ab97e623d0098bb366a573b18b54e91a Reviewed-on: https://chromium-review.googlesource.com/876930Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org>
-