Skip to content

C
Chromium_Depot_tools
Switch branch/tag
  1. 10 Jun, 2022 2 commits
    • recipe-roller's avatar
      Roll recipe dependencies (trivial). · 6fbb7442
      recipe-roller authored 
      This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8811716339900330657

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/dfb53acac971bed26ea89cbeeedd748de5ca7938
  dfb53ac (jkusuma@google.com)
      Update resultdb recipe module to support gcs uri.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I873e31a9bd0d955f7f04b11305874c6f083840e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3699409
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
      6fbb7442
    • Bruce Dawson's avatar
      Report when vpython (Python 2) is run during presubmits · f2b0421f
      Bruce Dawson authored 
      While all Chromium PRESUBMIT.py scripts have been running on Python 2
for a long time they continue to invoke child scripts under Python 2.
Part of the reason for slow progress on this transition is that it is
not easy to tell that this is happening, and most developers probably
assume that Python 3 presubmits implies a lack of Python 2.

This change adds a warning when it detects Python 2 scripts being run.
Typical output (edited for clarity) looks like this:

  git cl presubmit --files "chrome/updater/tools/*;ppapi/generators/*"
...
  Python 2 scripts were run during Python 3 presubmits. Please ask ??? if help is needed in preventing this.
   "depot_tools\pylint-1.5" --args-on-stdin from chrome\updater\tools \
   "depot_tools\pylint-1.5" --args-on-stdin from chrome\updater\tools \
   idl_tests.py from ppapi\generators

If Python 2 scripts launch child scripts, especially if they use
sys.executable, then they will not be reported. However this is a good
thing because it means that the report focuses on the top-level scripts
that drive Python 2 usage.

This change works by modifying vpython.bat to write invocation
information to a text file. The data in this text file is picked up by
presubmit_support.py when it finishes running a set of presubmits.

Bug: 1313804
Change-Id: Ic632b38eae07eca2e02e94358305cc9c998818e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3699002Reviewed-by: 's avatarGavin Mak <gavinmak@google.com>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
      f2b0421f
  3. 09 Jun, 2022 4 commits
  5. 08 Jun, 2022 7 commits
  7. 07 Jun, 2022 6 commits
  9. 04 Jun, 2022 1 commit
    • Bruce Dawson's avatar
      Print full path and upgrade details in PyLint warning · 89b222db
      Bruce Dawson authored 
      A run of "git cl presubmit --all" shows that PyLint 1.5 is being run
from nine locations, however the deprecation warnings don't say where.
This makes it difficult to file bugs or fix the remaining instances.
This changes the message to list the path to the presubmit that is
running PyLint 1.5.

This also adds instructions on how to change to version 2.7.

Before:

  pylint-1.5 is deprecated, please switch to 2.7 before 2022-07-11

After (with word wrapping):

  pylint-1.5 is being run on ...src\tools\find_runtime_symbols
  and is deprecated, please switch to 2.7 before 2022-07-11 (add
  version='2.7' to RunPylint call)

Change-Id: Iece2cb904f5d26ad66e3ab78f7ce7aef1878bfd1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3688839Reviewed-by: 's avatarJosip Sokcevic <sokcevic@google.com>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
      89b222db
  11. 03 Jun, 2022 5 commits
  13. 02 Jun, 2022 5 commits
  15. 01 Jun, 2022 7 commits
  17. 31 May, 2022 3 commits